git://git.webkit.org / WebKit-https.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: efda034) | patch
Can't add followup comment to a previous comment
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2012 21:11:01 +0000 (21:11 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2012 21:11:01 +0000 (21:11 +0000)
commit67f1616234636ece69b69cff91ac0dccabbab09f
tree6879df010dca8c99642e702aa7422fac29ebfa67tree | snapshot
parentefda034ed857dfb3e83525b9bebce29894b1304ccommit | diff
Can't add followup comment to a previous comment
https://bugs.webkit.org/show_bug.cgi?id=104025

Reviewed by Adam Barth.

If we side-by-sidify a shared diff line, and then apply
a previous comment, we would incorrectly put the comment
on the Line instead of the LineContainer.

Also, get rid of global next_line_id to simplify testing.

* code-review-test.html:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@136556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Websites/bugs.webkit.org/ChangeLog diff | blob | history
Websites/bugs.webkit.org/code-review-test.html diff | blob | history
Websites/bugs.webkit.org/code-review.js diff | blob | history
Mirror of the WebKit open source project from svn.webkit.org.