LayoutTests:
authorjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2006 06:38:22 +0000 (06:38 +0000)
committerjusting <justing@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2006 06:38:22 +0000 (06:38 +0000)
commit6603df0e7643df32e48e48e2c902112dfe0d0c04
treeaad9162de5468d798931dca1f59669b9bd7875bb
parent5140f8b2d1e5c0ae81c0ed776f520efbeb5256c4
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
        REGRESSION: selectionRect includes next/previous replaced elements
        <rdar://problems/4402375&4474871&4474871>

        * editing/selection/4402375-expected.checksum: Added.
        * editing/selection/4402375-expected.png: Added.
        * editing/selection/4402375-expected.txt: Added.
        * editing/selection/4402375.html: Added.
        Turned on dumpSelectionRect for these tests:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/replaced-boundaries-1.html:
        * editing/selection/replaced-boundaries-2-expected.checksum:
        * editing/selection/replaced-boundaries-2-expected.png:
        * editing/selection/replaced-boundaries-2.html:
        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * editing/selection/replaced-boundaries-3.html:
        * editing/selection/image-before-linebreak-expected.checksum: Added.
        * editing/selection/image-before-linebreak-expected.png: Added.
        * editing/selection/image-before-linebreak-expected.txt: Added.
        * editing/selection/image-before-linebreak.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
        REGRESSION: selectionRect includes next/previous replaced elements
        Also fixes: <rdar://problems/4402375&4474871&4474871>

        In the case where a selection starts at the end or ends at the start
        of o, o->selectionState() != SelectionNone, but o isn't really selected.
        Constraining the selection with upstream and downstream eliminates these
        types of endpoints, but constraining endpoints that occur at the
        start or end of a paragraph creates positions inside containers - some
        of which the selection painting code isn't equipped to handle.

        * dom/Document.cpp:
        (WebCore::Document::updateSelection):
        * rendering/render_replaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        (WebCore::RenderReplaced::selectionRect):
        (WebCore::RenderReplaced::setSelectionState):
        (WebCore::RenderWidget::setSelectionState):

WebKitTools:

        Reviewed by darin

        <rdar://problem/4402375>
        REGRESSION (417.8-TOT): selectionRect sometimes includes adjacent images

        Added an option to draw the selectionRect.

        * DumpRenderTree/DumpRenderTree.m:
        (dump):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpSelectionRect]):
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
23 files changed:
LayoutTests/ChangeLog
LayoutTests/editing/selection/4402375-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/4402375-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/4402375-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/4402375.html [new file with mode: 0644]
LayoutTests/editing/selection/image-before-linebreak-expected.checksum [new file with mode: 0644]
LayoutTests/editing/selection/image-before-linebreak-expected.png [new file with mode: 0644]
LayoutTests/editing/selection/image-before-linebreak-expected.txt [new file with mode: 0644]
LayoutTests/editing/selection/image-before-linebreak.html [new file with mode: 0644]
LayoutTests/editing/selection/replaced-boundaries-1-expected.checksum
LayoutTests/editing/selection/replaced-boundaries-1-expected.png
LayoutTests/editing/selection/replaced-boundaries-1.html
LayoutTests/editing/selection/replaced-boundaries-2-expected.checksum
LayoutTests/editing/selection/replaced-boundaries-2-expected.png
LayoutTests/editing/selection/replaced-boundaries-2.html
LayoutTests/editing/selection/replaced-boundaries-3-expected.checksum
LayoutTests/editing/selection/replaced-boundaries-3-expected.png
LayoutTests/editing/selection/replaced-boundaries-3.html
WebCore/ChangeLog
WebCore/dom/Document.cpp
WebCore/rendering/render_replaced.cpp
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/DumpRenderTree.m