Remove webkit prefix from CSS columns.
https://bugs.webkit.org/show_bug.cgi?id=137132.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-31
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Import tests for basic multi-column properties settings. They are approved by W3C and
pass the WebKit testing. More tests need to be imported when they are approved.
* css: Added.
* css/multicol: Added.
* css/multicol/multicol-basic-001-expected.html: Added.
* css/multicol/multicol-basic-001.html: Added.
* css/multicol/multicol-basic-002-expected.html: Added.
* css/multicol/multicol-basic-002.html: Added.
* css/multicol/multicol-basic-003-expected.html: Added.
* css/multicol/multicol-basic-003.html: Added.
* css/multicol/multicol-basic-004-expected.html: Added.
* css/multicol/multicol-basic-004.html: Added.
Source/WebCore:
CSS columns properties are ready for un-prefixing. There are still a couple
that we haven't implemented, such as the ones starting with "break-", so we're
just going to do the ones starting with "column-". The list of column un-
prefixed properties in this change set is:
- column-count
- column-fill
- column-gap
- column-progression
- column-rule
- column-rule-color
- column-rule-style
- column-rule-width
- column-span
- column-width
- columns
Tests: fast/multicol/column-box-alignment-rtl.html
fast/multicol/multicol-aliases.html
imported/w3c/css/multicol/multicol-basic-001.html
imported/w3c/css/multicol/multicol-basic-002.html
imported/w3c/css/multicol/multicol-basic-003.html
imported/w3c/css/multicol/multicol-basic-004.html
Add new un-prefixed column properties and make the -webkit* ones be aliases
to the new ones.
* css/CSSPropertyNames.in:
Use the new enums CSSPropertyColumn* instead of the prefixed ones.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isColorPropertyID):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
* css/StylePropertyShorthand.cpp:
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
* css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::paintColumnRules):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorIncludingFallback):
LayoutTests:
Ensure the CSS un-prefixed column properties are behaving the same way as the
prefixed ones. The CSS prefixed column properties are still supported by making
them aliases of the un-prefixed ones. Also port some of the W3C and Mozilla
tests for css column properties tests.
Change to the un-prefixed column names to be compared with the return of CSSStyleDeclaration.item().
And change the expected names to be the un-prefixed ones also.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
Change to the un-prefixed column names and compare them with the return of object.style.cssText().
* fast/css/remove-shorthand-expected.txt:
Test for the effect of the rtl settings on column flow; it is ported from Mozilla.
* fast/multicol/column-box-alignment-rtl-expected.html: Added.
* fast/multicol/column-box-alignment-rtl.html: Added.
Ensure the prefixed and the un-prefixed column properties are behaving exactly the same.
* fast/multicol/multicol-aliases-expected.html: Added.
* fast/multicol/multicol-aliases.html: Added.
Change to the un-prefixed column names to be compared with the return of CSSStyleDeclaration.item().
* svg/css/getComputedStyle-basic-expected.txt:
Remove the use of the un-prefixed columns property since it seems unrelated to the test.
* svg/custom/svg-fonts-in-html.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc