Source/WebCore: [EFL]Background Style of element not visible because of default...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Sep 2013 06:42:36 +0000 (06:42 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 Sep 2013 06:42:36 +0000 (06:42 +0000)
commit63fc05a123cc759d6c146b40999bd9580649e4d9
treec43bcd35f6528d43977344bc157b769ff2287fbf
parentcbb9fbc59861e196445fa623794c2935e7c28153
Source/WebCore: [EFL]Background Style of element not visible because of  default theme style
https://bugs.webkit.org/show_bug.cgi?id=117405

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.

When select element is styled with css background property(color/image) the styling
gets hidden by Combo box non transparent image. This patch handle the
case and transparent images are used when select image is styled. So
now background-color and background-image are visible across the Combo box

The code is added to support css styling of other theme control,
Basically an extra signal is emitted to edje which change the state
of edje object whenever the control is styled.

Covered by existing test case, updated the test expected image.

* platform/efl/DefaultTheme/CMakeLists.txt:
* platform/efl/DefaultTheme/widget/combo/combo.edc:
* platform/efl/DefaultTheme/widget/combo/combo_focus_button_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_focus_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_hover_button_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_hover_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_normal_button_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_normal_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_press_button_transparent.png: Added.
* platform/efl/DefaultTheme/widget/combo/combo_press_transparent.png: Added.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::isControlStyled):
(WebCore::RenderThemeEfl::paintThemePart):
* platform/efl/RenderThemeEfl.h:

LayoutTests: [EFL] Background Style of element not visible because of default theme style
https://bugs.webkit.org/show_bug.cgi?id=117405

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.

Updating expected image oputput of pixel test reflecting the
background image visible over combo box.

* platform/efl/fast/forms/menulist-narrow-width-expected.png:
* platform/efl/fast/forms/menulist-restrict-line-height-expected.png:
* platform/efl/fast/forms/menulist-style-color-expected.png:
* platform/efl/fast/forms/select-background-none-expected.png:
* platform/efl/fast/forms/select-style-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@155674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
19 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/efl/fast/forms/menulist-narrow-width-expected.png
LayoutTests/platform/efl/fast/forms/menulist-restrict-line-height-expected.png
LayoutTests/platform/efl/fast/forms/menulist-style-color-expected.png
LayoutTests/platform/efl/fast/forms/select-background-none-expected.png
LayoutTests/platform/efl/fast/forms/select-style-expected.png
Source/WebCore/ChangeLog
Source/WebCore/platform/efl/DefaultTheme/CMakeLists.txt
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo.edc
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_focus_button_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_focus_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_hover_button_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_hover_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_normal_button_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_normal_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_press_button_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/DefaultTheme/widget/combo/combo_press_transparent.png [new file with mode: 0644]
Source/WebCore/platform/efl/RenderThemeEfl.cpp
Source/WebCore/platform/efl/RenderThemeEfl.h