Source/WebCore: Refined the heuristic introduced to fix <rdar://problem/10002140...
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Sep 2011 00:14:17 +0000 (00:14 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Sep 2011 00:14:17 +0000 (00:14 +0000)
commit5f02286d59fcca7f244750ac436191c49497cbb1
tree5e9ae6705db1a0485bfa5a7149331053316fd5c0
parent00d0060b7822812f44bcb546d4e9d53e1fb77095
Source/WebCore: Refined the heuristic introduced to fix <rdar://problem/10002140> Text gets clipped in
multi-column layouts when overflow:auto is used.
https://bugs.webkit.org/show_bug.cgi?id=67212

Reviewed by Dave Hyatt.

Test: fast/multicol/overflow-across-columns-percent-height.html

* rendering/RenderBox.cpp:
(WebCore::percentageLogicalHeightIsResolvable): Added. This follows logic similar to the one
in computePercentageLogicalHeight() to determine whether percentage values for height properties
are resolved or treated as "auto".
(WebCore::RenderBox::hasUnsplittableScrollingOverflow): If min-height or max-height are specified
as a percentage but actually resolve to "auto", don’t let that prevent splitting.

LayoutTests: Additional test for <rdar://problem/10002140> Text gets clipped in
multi-column layouts when overflow:auto is used.
https://bugs.webkit.org/show_bug.cgi?id=67212

Reviewed by Dave Hyatt.

* fast/multicol/overflow-across-columns-percent-height.html: Added.
* platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.png: Added.
* platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/multicol/overflow-across-columns-percent-height.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBox.cpp