REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jul 2014 04:51:13 +0000 (04:51 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jul 2014 04:51:13 +0000 (04:51 +0000)
commit5bd4d489ff3d495ef4096c5dded6e6c02bd2a1fe
tree3d30bf16f5a7fcc9db7ff225fb0f6806d696a54c
parent4274509e4aa0d752764417dd00bcc58c5a26621f
REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel
https://bugs.webkit.org/show_bug.cgi?id=135278

Reviewed by Tim Horton.

The bug was caused by editorUIUpdateTimerFired calling respondToChangedSelection only if the selection was
triggered by dictation instead of only if it was NOT triggered by dictation.

Prior to r164401, AlternativeTextController::respondToMarkerAtEndOfWord exited early when SetSelectionOptions
had DictationTriggered set. r164401 intended to move this check to editorUIUpdateTimerFired to avoid passing
options around but the boolean condition was erroneously flipped.

Fixed the bug by negating the condition in editorUIUpdateTimerFired.

No new tests for now since autocorrection panel cannot be tested automatically. (We should really automate this!)

* editing/Editor.cpp:
(WebCore::Editor::editorUIUpdateTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@171580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/editing/Editor.cpp