Incorrect rendering for flex boxes with percentage height in a table cell
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Feb 2013 01:22:43 +0000 (01:22 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Feb 2013 01:22:43 +0000 (01:22 +0000)
commit5aa20aa5c724aa00b50849e04eb157332e89c287
treeddd6b74cafc732df0562224e3dcfcb04ee92eb17
parent9dc06be01362fb555b53f882673c6afce5d46eed
Incorrect rendering for flex boxes with percentage height in a table cell
https://bugs.webkit.org/show_bug.cgi?id=110389

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

Source/WebCore:

Tests: css3/flexbox/flex-percentage-height-in-table-standards-mode.html
       css3/flexbox/flex-percentage-height-in-table.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
Always update the logical height of the flex box, not just when it is
auto. If necessary, the later updateLogicalHeight() call will adjust
it.

LayoutTests:

* css3/flexbox/flex-percentage-height-in-table-expected.html: Added.
* css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html: Added.
* css3/flexbox/flex-percentage-height-in-table-standards-mode.html: Added.
* css3/flexbox/flex-percentage-height-in-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/css3/flexbox/flex-percentage-height-in-table-expected.html [new file with mode: 0644]
LayoutTests/css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html [new file with mode: 0644]
LayoutTests/css3/flexbox/flex-percentage-height-in-table-standards-mode.html [new file with mode: 0644]
LayoutTests/css3/flexbox/flex-percentage-height-in-table.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderFlexibleBox.cpp