<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned...
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 12 Nov 2011 22:13:00 +0000 (22:13 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 12 Nov 2011 22:13:00 +0000 (22:13 +0000)
commit55aed2d1036d06cd597ecd5cf5fa960994c90cfd
treee1b401354087799a27a79f667153a00e074f7cd6
parent3ac72cf51368867cd5d6a08034def58a409354eb
<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm
Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm