WebCore:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 May 2005 17:20:36 +0000 (17:20 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 May 2005 17:20:36 +0000 (17:20 +0000)
commit53e96eb473a0af5a64af3d134c639566f936165a
treeed276eae9c2b5d6102002bc23255d96e5d4fbbe2
parentabbe0363be012f957950e3deda6a1cd9787282ed
WebCore:

        Reviewed by Kevin.

        - WebCore part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable

        * kwq/KWQKHTMLSettings.h:
        (KHTMLSettings::textAreasAreResizable):
        new getter
        (KHTMLSettings::setTextAreasAreResizable):
        new setter

        * kwq/KWQTextArea.h:
        * kwq/KWQTextArea.mm:
        eliminated ALLOW_RESIZING_TEXT_AREAS #define in favor of using runtime setting
        (-[KWQTextArea isResizableByUser]):
        get value from settings, and cache it in KWQTextArea instance
        (-[KWQTextAreaTextView _enclosingTextArea]):
        new convenience method, extracted from _trackResizeFromMouseDown:
        (-[KWQTextAreaTextView _trackResizeFromMouseDown:]):
        now uses extracted method

        (-[KWQTextAreaTextView drawRect:]):
        now checks isResizableByUser
        (-[KWQTextAreaTextView mouseDown:]):
        ditto

        * kwq/WebCoreSettings.h:
        * kwq/WebCoreSettings.mm:
        (-[WebCoreSettings setTextAreasAreResizable:]):
        new setter
        (-[WebCoreSettings textAreasAreResizable]):
        new getter

WebKit:

        Reviewed by Kevin.

        - WebKit part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable

        * WebView.subproj/WebPreferencesPrivate.h:
        added private-for-now getter and setter for new preference
        * WebView.subproj/WebPreferenceKeysPrivate.h:
        added private preference key controlling whether textareas are resizable
        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]):
        initial value of new preference is NO, so other clients' behavior doesn't change
        (-[WebPreferences textAreasAreResizable]):
        new getter
        (-[WebPreferences setTextAreasAreResizable:]):
        new setter

        * WebView.subproj/WebView.m:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):
        update this new setting in WebCore

        * English.lproj/StringsNotToBeLocalized.txt:
        updated for these changes

WebBrowser:

        Reviewed by Kevin.

        - added debug menu item to toggle resizable textareas

        * Debug/DebugUtilities.m:
        (-[DebugUtilities createDebugMenu]):
        add "Allow Resizing Text Areas" item and separator
        (-[BrowserDocument toggleAllowResizingTextAreas:]):
        toggle WebPreferences setting
        (-[BrowserDocument validate_toggleAllowResizingTextAreas:]):
        sync checkmark with setting

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
12 files changed:
WebCore/ChangeLog-2005-08-23
WebCore/kwq/KWQKHTMLSettings.h
WebCore/kwq/KWQTextArea.h
WebCore/kwq/KWQTextArea.mm
WebCore/kwq/WebCoreSettings.h
WebCore/kwq/WebCoreSettings.mm
WebKit/ChangeLog
WebKit/English.lproj/StringsNotToBeLocalized.txt
WebKit/WebView.subproj/WebPreferenceKeysPrivate.h
WebKit/WebView.subproj/WebPreferences.m
WebKit/WebView.subproj/WebPreferencesPrivate.h
WebKit/WebView.subproj/WebView.m