Source/WebCore: Appearance of compound transform animations under apps linked on...
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Nov 2011 19:18:19 +0000 (19:18 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Nov 2011 19:18:19 +0000 (19:18 +0000)
commit51dc0cdd3f9061de833cfe5c7530d45ba1664cbb
treed7c286e5b391e6dce647ab95734e7f21e3492f16
parentdf3cafa4e702f20c27e5bc920307c5a947170230
Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641
and
<rdar://problem/10314267>

Reviewed by Dean Jackson.

GraphicsLayerCA contains a "linked on or after" check to account for a bug in
Core Animation on SnowLeopard and earlier, which is that CA would apply the list
of animations in reverse order.

Our previous fix was incorrect, because it only adjusted the 'additive' property
of the animation list based on ordering, rather than flipping the entire list.
This change reverses the list of animations before giving them to CA, which fixes
the bug.

Test: animations/additive-transform-animations.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Reviewed by Dean Jackson.

Pixel test for a hardware-animated tranform, where order of operations matters.

* animations/additive-transform-animations-expected.png: Added.
* animations/additive-transform-animations.html: Added.
* platform/mac/animations/additive-transform-animations-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/animations/additive-transform-animations-expected.png [new file with mode: 0644]
LayoutTests/animations/additive-transform-animations.html [new file with mode: 0644]
LayoutTests/platform/mac/animations/additive-transform-animations-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h