Lots of build warnings from Source/ThirdParty/openvr
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 4 Feb 2018 08:17:17 +0000 (08:17 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 4 Feb 2018 08:17:17 +0000 (08:17 +0000)
commit506b6d7e1c694308fbd7f77f040f935fd38abcb9
tree2f718cd8e4a8bb1628e0f2719b1234b3e8b0e27d
parent6909278fa48f1f1194d5c7a62d5e3837e2e693a0
Lots of build warnings from Source/ThirdParty/openvr
https://bugs.webkit.org/show_bug.cgi?id=182117

Reviewed by Michael Catanzaro.

Suppress OpenVR compiler warnings by listing -Wno-unknown-pragmas,
-Wno-unused-parameter and -Wno-unused-variable options among the
libopenvr_api.so CXX flags.

CMake configuration warning about default project variables for the
openvr_api project is avoided by removing the openvr_api project and
instead setting the OPENVR_SOURCE_DIR to the path of the OpenVR
source directory under Source/ThirdParty/.

Another compiler warning is removed by fixing the return condition in
the Path_WriteBinaryFile() function to perform an equality comparison
instead of an assignment. This has already been fixed upstream.

All changes to the OpenVR code are reflected in the separately-managed
patch files kept in the patches/ directory.

* openvr/README.webkit:
* openvr/patches/Path_WriteBinaryFile-fix-return-condition.patch: Added.
* openvr/patches/cmake-build.patch:
* openvr/src/CMakeLists.txt:
* openvr/src/vrcommon/pathtools_public.cpp:
(Path_WriteBinaryFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/ThirdParty/ChangeLog
Source/ThirdParty/openvr/README.webkit
Source/ThirdParty/openvr/patches/Path_WriteBinaryFile-fix-return-condition.patch [new file with mode: 0644]
Source/ThirdParty/openvr/patches/cmake-build.patch
Source/ThirdParty/openvr/src/CMakeLists.txt
Source/ThirdParty/openvr/src/vrcommon/pathtools_public.cpp