WebCore:
authorsullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Feb 2004 16:51:58 +0000 (16:51 +0000)
committersullivan <sullivan@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Feb 2004 16:51:58 +0000 (16:51 +0000)
commit4e24dd056eca3d731700785c9cc02f8e6817d84f
tree83c46f8ddc71a4f0d501f943c67d87a72c5b505e
parentff78f104a0d717f72a4ca2a767b4004210d667fc
WebCore:

        WebCore part of fix for <rdar://problem/3546370>: add a way to tab to menus,
        checkmarks, and buttons without turning on Full Keyboard Acceess

        Reviewed by Ken.

        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::tabsToAllControls):
        now checks for option-tab like tabsToLinks
        (KWQKHTMLPart::partForWidget):
        new method, extracted from bridgeForWidget
        (KWQKHTMLPart::bridgeForWidget):
        now calls extracted method

        * kwq/KWQButton.mm:
        (-[KWQButton canBecomeKeyView]):
        overridden to handle our rules about full keyboard access, different
        than NSView's rules
        * kwq/KWQComboBox.mm:
        (-[KWQPopUpButton canBecomeKeyView]):
        ditto
        * kwq/KWQListBox.mm:
        (-[KWQTableView canBecomeKeyView]):
        ditto

WebKit:

        WebKit part of fix for <rdar://problem/3546370>: add a way to tab to menus,
        checkmarks, and buttons without turning on Full Keyboard Acceess

        Reviewed by Ken.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]):
        turn on WebCoreKeyboardAccessFull bit whenever we turn on
        WebCoreKeyboardAccessTabsToLinks bit

WebBrowser:

        - WebBrowser part of fix for <rdar://problem/3546370>: add a way to tab to menus,
          checkmarks, and buttons without turning on Full Keyboard Acceess
        - fixed <rdar://problem/3566996>: "Highlight each item" choice in Preferences
          should use a checkbox and have different wording

        Reviewed by Ken.

        * Preferences.subproj/AdvancedPreferences.h:
        * Preferences.subproj/AdvancedPreferences.m:
        (systemIsInFullKeyboardAccessMode):
        new function, reads the state of the Full Keyboard Access setting
        (-[AdvancedPreferences updateTabToAllViews]):
        set checkbox instead of matrix; new wording for fine print; renamed method
        (-[AdvancedPreferences keyboardUIModeDidChange:]):
        notification callback; call updateTabToAllViews
        (-[AdvancedPreferences toggleTabToAll:]):
        new method, replaces takeTabToLinksSettingFrom:
        (-[AdvancedPreferences initializeFromDefaults]):
        call renamed method
        (-[AdvancedPreferences moduleWillBeRemoved]):
        stop observing notification for Full Keyboard Access mode change
        (-[AdvancedPreferences moduleWasInstalled]):
        start observing notification for Full Keyboard Access mode change

        * Preferences.subproj/English.lproj/AdvancedPreferences.nib:
        replace radio buttons with checkbox; rejigger positions

        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        Updated for these changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog-2005-08-23
WebCore/kwq/KWQButton.mm
WebCore/kwq/KWQComboBox.mm
WebCore/kwq/KWQKHTMLPart.h
WebCore/kwq/KWQKHTMLPart.mm
WebCore/kwq/KWQListBox.mm
WebKit/ChangeLog
WebKit/WebCoreSupport.subproj/WebBridge.m