WebCore:
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Apr 2009 23:09:14 +0000 (23:09 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Apr 2009 23:09:14 +0000 (23:09 +0000)
commit4670d48fb957132c12178188012f5282fac74ee9
treeef02b861dc4bd186d8a22953e14435aa7c9cc9bc
parent66dfb543ddc6e19b24b14e2322e5c3c0e577e638
WebCore:

2009-04-07  David Hyatt  <hyatt@apple.com>

        Reviewed by Adam Roben

        Fix ScrollView's algorithm that determines whether or not to show scrollbars.  There was a bug
        with the method mainly because RenderView will size itself to the viewport's size, making it
        impossible to really know the document's "true" size.

        In order to solve this problem ScrollView now has a minimumContentsSize method.  This method
        returns the document size excluding the RenderView from the calculation.  This width/height
        is now cached on RenderView in m_docWidth/m_docHeight member variables.

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameView::adjustPageHeight):
        (WebCore::FrameView::minimumContentsSize):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::updateScrollbars):
        * platform/ScrollView.h:
        (WebCore::ScrollView::minimumContentsSize):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::layout):
        (WebCore::RenderView::calcDocHeight):
        (WebCore::RenderView::calcDocWidth):
        * rendering/RenderView.h:
        (WebCore::RenderView::docWidth):
        (WebCore::RenderView::docHeight):

WebKit/mac:

2009-04-07  David Hyatt  <hyatt@apple.com>

        Reviewed by Adam Roben

        Mac portion of fix to make DumpRenderTree always produce accurate scrollbar results.  Change
        updateScrollers to call minimumContentsSize when a WebHTMLView is inside the WebDynamicScrollbarsView.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):

LayoutTests:

2009-04-07  David Hyatt  <hyatt@apple.com>

        Reviewed by Adam Roben

        Land updated layout test results now that DRT is doing the right thing
        with scrollbar results.

        * platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
        * platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
        * platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
        * platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
        * platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
        * platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
        * platform/mac/fast/block/float/013-expected.checksum:
        * platform/mac/fast/block/float/013-expected.png:
        * platform/mac/fast/block/float/013-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
20 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum
LayoutTests/platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png
LayoutTests/platform/mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt
LayoutTests/platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum
LayoutTests/platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.png
LayoutTests/platform/mac/css2.1/t0803-c5505-mrgn-02-c-expected.txt
LayoutTests/platform/mac/fast/block/float/013-expected.checksum
LayoutTests/platform/mac/fast/block/float/013-expected.png
LayoutTests/platform/mac/fast/block/float/013-expected.txt
WebCore/ChangeLog
WebCore/WebCore.base.exp
WebCore/page/FrameView.cpp
WebCore/page/FrameView.h
WebCore/platform/ScrollView.cpp
WebCore/platform/ScrollView.h
WebCore/rendering/RenderView.cpp
WebCore/rendering/RenderView.h
WebKit/mac/ChangeLog
WebKit/mac/WebView/WebDynamicScrollBarsView.m