2006-09-27 Eric Seidel <eric@eseidel.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Sep 2006 23:48:09 +0000 (23:48 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 27 Sep 2006 23:48:09 +0000 (23:48 +0000)
commit44e8f7804ed32a53d3d80a7f67b31c42b9e66d52
tree33fd4715860f90dab3d32ad0092746c356db4ee9
parent524809fe66683df828cf1d1c7b0f70bbd746b3e2
2006-09-27  Eric Seidel  <eric@eseidel.com>

        Reviewed by mitz.

        paths with no fill specified default to black but do not recieve paint-related mouse events
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
        The default fill was being applied at the wrong place in the rendering chain, causing this problem.

        Test: svg/custom/hover-default-fill.svg

        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
        * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::isFilled): remove null check
        (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
        (WebCore::KSVGPainterFactory::isStroked): remove null check
        (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
        * ksvg2/svg/SVGPaint.cpp:
        (WebCore::SVGPaint::defaultFill): added.
        (WebCore::SVGPaint::defaultStroke): added.
        * ksvg2/svg/SVGPaint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/svg/custom/hover-default-fill-expected.checksum [new file with mode: 0644]
LayoutTests/svg/custom/hover-default-fill-expected.png [new file with mode: 0644]
LayoutTests/svg/custom/hover-default-fill-expected.txt [new file with mode: 0644]
LayoutTests/svg/custom/hover-default-fill.svg [new file with mode: 0644]
WebCore/ChangeLog
WebCore/kcanvas/RenderPath.cpp
WebCore/ksvg2/css/SVGRenderStyle.h
WebCore/ksvg2/misc/KCanvasRenderingStyle.cpp
WebCore/ksvg2/svg/SVGPaint.cpp
WebCore/ksvg2/svg/SVGPaint.h