WebCore: Change the V8 and JSC SQLStatementErrorCallback to interpret
authordumi@chromium.org <dumi@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Feb 2010 20:52:07 +0000 (20:52 +0000)
committerdumi@chromium.org <dumi@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Feb 2010 20:52:07 +0000 (20:52 +0000)
commit41867f238109052ef916a305c49a6133484da298
treee268896c3e320f696450bbe617875ff337235675
parent0603fdf03a3a87d8cb64d0aa011def56d36e70d6
WebCore: Change the V8 and JSC SQLStatementErrorCallback to interpret
'undefined' return values as 'true', as required by the spec.

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35048

* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallbackHelper):
(WebCore::invokeCallback):
(WebCore::invokeCallbackTreatUndefinedAsTrue):
* bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: 'undefined' return values from statement error callbacks are not
treated as 'true'. Fix the tests that did not use this
assumption.

Reviewed by NOBODY Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35048

* storage/database-lock-after-reload.html:
* storage/private-browsing-readonly.html:
* storage/statement-error-callback.html:
* storage/statement-error-callback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/storage/database-lock-after-reload.html
LayoutTests/storage/private-browsing-readonly.html
LayoutTests/storage/statement-error-callback-expected.txt
LayoutTests/storage/statement-error-callback.html
WebCore/ChangeLog
WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp
WebCore/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp
WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp
WebCore/bindings/v8/custom/V8CustomVoidCallback.h