Remove an unnecessary extra computeLogicalWidth() from line layout
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 2 Apr 2011 21:37:11 +0000 (21:37 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 2 Apr 2011 21:37:11 +0000 (21:37 +0000)
commit3450f0c17261e5da7fbd7013d25ca44ba4021213
treef9208667230df5459ee73554a519c9cc4e640a26
parentf2c4bd33042b4d1ce6f386b31457bc234626e3ba
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711

Reviewed by Dave Hyatt.

Source/WebCore:

Changes in behavior (MathML progression) covered by existing layout tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.

LayoutTests:

These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.

* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
21 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum
LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.png
LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt
LayoutTests/platform/mac/mathml/presentation/fractions-expected.checksum
LayoutTests/platform/mac/mathml/presentation/fractions-expected.png
LayoutTests/platform/mac/mathml/presentation/fractions-expected.txt
LayoutTests/platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum
LayoutTests/platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png
LayoutTests/platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt
LayoutTests/platform/mac/mathml/presentation/roots-expected.checksum
LayoutTests/platform/mac/mathml/presentation/roots-expected.png
LayoutTests/platform/mac/mathml/presentation/roots-expected.txt
LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.checksum
LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.png
LayoutTests/platform/mac/mathml/presentation/row-alignment-expected.txt
LayoutTests/platform/mac/mathml/presentation/subsup-expected.checksum
LayoutTests/platform/mac/mathml/presentation/subsup-expected.png
LayoutTests/platform/mac/mathml/presentation/subsup-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderBlockLineLayout.cpp