Remove SVGUseElement.instanceRoot and all tests that depend on it
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 30 Jan 2015 04:23:51 +0000 (04:23 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 30 Jan 2015 04:23:51 +0000 (04:23 +0000)
commit338584b1946684e2cacc94ee731c58e883a03f02
tree361371c5a81f59f1cd7417ee8ae741a352f4bf8e
parent05b498b8c49bd83cdcb5a5d76362d96874bdcb5f
Remove SVGUseElement.instanceRoot and all tests that depend on it
https://bugs.webkit.org/show_bug.cgi?id=141025

Reviewed by Anders Carlsson.

Source/WebCore:

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::instanceRoot): Deleted.
* svg/SVGUseElement.h: Removed instanceRoot.
* svg/SVGUseElement.idl: Ditto.

LayoutTests:

* platform/gtk/TestExpectations: Removed expected failure for now-removed test.
* platform/ios-simulator-wk2/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.

* platform/gtk/svg/custom/use-elementInstance-event-target-expected.png: Removed.
* platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/gtk/svg/custom/use-elementInstance-methods-expected.png: Removed.
* platform/gtk/svg/custom/use-elementInstance-methods-expected.txt: Removed.
* platform/ios-sim-deprecated/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/ios-sim-deprecated/svg/custom/use-elementInstance-methods-expected.txt: Removed.
* platform/ios-simulator/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/ios-simulator/svg/custom/use-elementInstance-methods-expected.txt: Removed.
* platform/mac-mountainlion/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/mac-mountainlion/svg/custom/use-elementInstance-methods-expected.txt: Removed.
* platform/mac/svg/custom/use-elementInstance-event-target-expected.png: Removed.
* platform/mac/svg/custom/use-elementInstance-event-target-expected.txt: Removed.
* platform/mac/svg/custom/use-elementInstance-methods-expected.png: Removed.
* platform/mac/svg/custom/use-elementInstance-methods-expected.txt: Removed.
* svg/custom/element-instance-held-by-js-crash-expected.txt: Removed.
* svg/custom/element-instance-held-by-js-crash.svg: Removed.
* svg/custom/resources/use-instanceRoot-event-bubbling.js: Find element by id instead
of using use.instanceRoot.correspondingElement.
* svg/custom/resources/use-instanceRoot-event-listeners.js: Removed.
* svg/custom/use-crash-using-children-before-destroy.svg: Removed a line of code that
got at the instanceRoot. It's possible this test no longer has value, and if so, then
we could later delete it, but it does no harm.
* svg/custom/use-elementInstance-event-target.svg: Removed.
* svg/custom/use-elementInstance-methods.svg: Removed.
* svg/custom/use-instanceRoot-as-event-target-expected.txt: Removed.
* svg/custom/use-instanceRoot-as-event-target.xhtml: Removed.
* svg/custom/use-instanceRoot-event-listener-liveness-expected.txt: Removed.
* svg/custom/use-instanceRoot-event-listener-liveness.xhtml: Removed.
* svg/custom/use-instanceRoot-event-listeners-expected.txt: Removed.
* svg/custom/use-instanceRoot-event-listeners.xhtml: Removed.
* svg/custom/use-instanceRoot-modifications.svg: Removed the part of this that involved
the instanceRoot property. It's possible this test now has reduced value, and if so, we
could later delete it but it does no harm.
* svg/custom/use-instanceRoot-with-use-removed.svg: Removed the use of instanceRoot
and correspondingUseElement. Not certain this remains a useful test. Also converted line
endings to LF instead of CRLF.
* svg/custom/use-listener-append-crash.html: Get elements by id instead of instanceRoot.
* svg/custom/use-modify-target-container.svg: Ditto.
* svg/custom/use-modify-target-symbol.svg: Ditto.
* svg/custom/use-on-use-with-child-expected.txt: Updated since we don't dump an instance
tree any more.
* svg/custom/use-on-use-with-child.svg: Removed the part about dumping the instance tree,
and added in the part about dragging to make sure it doesn't crash.
* svg/dom/use-transform.svg: Get element by id instead of instanceRoot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
43 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/svg/custom/use-elementInstance-event-target-expected.png [deleted file]
LayoutTests/platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt [deleted file]
LayoutTests/platform/gtk/svg/custom/use-elementInstance-methods-expected.png [deleted file]
LayoutTests/platform/gtk/svg/custom/use-elementInstance-methods-expected.txt [deleted file]
LayoutTests/platform/ios-sim-deprecated/svg/custom/use-elementInstance-event-target-expected.txt [deleted file]
LayoutTests/platform/ios-sim-deprecated/svg/custom/use-elementInstance-methods-expected.txt [deleted file]
LayoutTests/platform/ios-simulator-wk2/TestExpectations
LayoutTests/platform/ios-simulator/svg/custom/use-elementInstance-event-target-expected.txt [deleted file]
LayoutTests/platform/ios-simulator/svg/custom/use-elementInstance-methods-expected.txt [deleted file]
LayoutTests/platform/mac-mountainlion/svg/custom/use-elementInstance-event-target-expected.txt [deleted file]
LayoutTests/platform/mac-mountainlion/svg/custom/use-elementInstance-methods-expected.txt [deleted file]
LayoutTests/platform/mac/TestExpectations
LayoutTests/platform/mac/svg/custom/use-elementInstance-event-target-expected.png [deleted file]
LayoutTests/platform/mac/svg/custom/use-elementInstance-event-target-expected.txt [deleted file]
LayoutTests/platform/mac/svg/custom/use-elementInstance-methods-expected.png [deleted file]
LayoutTests/platform/mac/svg/custom/use-elementInstance-methods-expected.txt [deleted file]
LayoutTests/svg/custom/element-instance-held-by-js-crash-expected.txt [deleted file]
LayoutTests/svg/custom/element-instance-held-by-js-crash.svg [deleted file]
LayoutTests/svg/custom/resources/use-instanceRoot-event-bubbling.js
LayoutTests/svg/custom/resources/use-instanceRoot-event-listeners.js [deleted file]
LayoutTests/svg/custom/use-crash-using-children-before-destroy.svg
LayoutTests/svg/custom/use-elementInstance-event-target.svg [deleted file]
LayoutTests/svg/custom/use-elementInstance-methods.svg [deleted file]
LayoutTests/svg/custom/use-instanceRoot-as-event-target-expected.txt [deleted file]
LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml [deleted file]
LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness-expected.txt [deleted file]
LayoutTests/svg/custom/use-instanceRoot-event-listener-liveness.xhtml [deleted file]
LayoutTests/svg/custom/use-instanceRoot-event-listeners-expected.txt [deleted file]
LayoutTests/svg/custom/use-instanceRoot-event-listeners.xhtml [deleted file]
LayoutTests/svg/custom/use-instanceRoot-modifications.svg
LayoutTests/svg/custom/use-instanceRoot-with-use-removed.svg
LayoutTests/svg/custom/use-listener-append-crash.html
LayoutTests/svg/custom/use-modify-target-container.svg
LayoutTests/svg/custom/use-modify-target-symbol.svg
LayoutTests/svg/custom/use-on-use-with-child-expected.txt
LayoutTests/svg/custom/use-on-use-with-child.svg
LayoutTests/svg/dom/use-transform.svg
Source/WebCore/ChangeLog
Source/WebCore/svg/SVGUseElement.cpp
Source/WebCore/svg/SVGUseElement.h
Source/WebCore/svg/SVGUseElement.idl