LayoutTests:
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Oct 2006 01:02:49 +0000 (01:02 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 2 Oct 2006 01:02:49 +0000 (01:02 +0000)
commit333db7f4989c00a9fc6217c365c1fd81ff544359
tree5933783945493f72404e9bdc8ab6d37b939b9340
parentec02e202938e87d32886c57bbf3ee3648fb1b42b
LayoutTests:

        Added test for the viewource attribute, which applies to <frame> and
        <iframe> elements.

        * fast/frames/viewsource-attribute-expected.txt: Added.
        * fast/frames/viewsource-attribute.html: Added.

        * fast/frames/frameElement-widthheight.html: Removed stray character.

WebCore:

        Reviewed by Maciej.

        More frame/iframe merging.

        - Removed needWidgetUpdate and related code. needWidgetUpdate is always
        false, so this was dead code.
        - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
        than attach(), is the correct place for setInViewSourceMode, because
        openURL() is the function that creates our frame.
        - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
        code that did the same thing in other places.
        - Made FRAME's attach() method suffuciently generic so that IFRAME could
        call up to it, rather than skipping its superclass and calling up directly
        to ELEMENT.
        - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
        - Replaced ad hoc frame loading code in FRAME::attach() with call to
        openURL(), the designated frame loading function.

        Layout tests pass. I added a layout test for viewsource mode, since I
        broke it in the course of writing this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/frames/frameElement-widthheight.html
LayoutTests/fast/frames/viewsource-attribute-expected.txt [new file with mode: 0644]
LayoutTests/fast/frames/viewsource-attribute.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/html/HTMLFrameElement.cpp
WebCore/html/HTMLFrameElement.h
WebCore/html/HTMLIFrameElement.cpp
WebCore/html/HTMLIFrameElement.h