http/tests/security/xss-DENIED-xsl-document-redirect.xml fails with NetworkProcess
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 May 2014 22:03:33 +0000 (22:03 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 May 2014 22:03:33 +0000 (22:03 +0000)
commit2bbfc935b9a1d20d73ffc95082872b9a177ca4a3
treefd972926148f3c6b8b0eb5c62396024738664cf9
parent80477dfd734b4f6e7d0236b2e0f1c8fa7622bad1
http/tests/security/xss-DENIED-xsl-document-redirect.xml fails with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=132523

Reviewed by Alexey Proskuryakov.

Source/WebCore:
We should not manufacture a response in the event of an error during a
synchronous XHR. In addition, this test removes one place that is
sensitive to such a manufactured response.

Updates test expectations.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::platformLoadResourceSynchronously): Do not
manufacture a response
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::docLoaderFunc): Only use the response's URL if no error
occurred.

LayoutTests:
Two tests have been rebaselined, and re-enable test that now passes

* fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: The test describes
that success causes an ErrorHandler to run, but there was no ErrorHandler line in the
expected output. This now gets printed.
* http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Expecting logging
output on failed redirection
* platform/mac-wk2/TestExpectations: Re-enable test that now passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt
LayoutTests/platform/mac-wk2/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
Source/WebCore/platform/network/mac/ResourceHandleMac.mm
Source/WebCore/xml/XSLTProcessorLibxslt.cpp