2011-03-22 Dean Jackson <dino@apple.com>
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Mar 2011 23:52:01 +0000 (23:52 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Mar 2011 23:52:01 +0000 (23:52 +0000)
commit2b2d3af9d43bb7081b085171c8659b823865d318
tree602911c891fec237036357405e292db7c12cf0ef
parent1fd8c10c03df9030cdde0a0dbbb4a66008445583
2011-03-22  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=56242
        Interrupted accelerated animations/transitions were causing
        subsequent animations to not start (because they were stuck
        waiting for a response from the compositing layer). I renamed
        the instance variable that indicates whether or not to
        notify animations of start time, from m_waitingForStartTimeResponse
        to m_waitingForAsyncStartNotification, so that it makes more sense.
        The actual bug fix was changing the logic so that the flag is reset
        when the list of waiting animations becomes empty. I mistakenly committed
        the bad logic in r81613.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):
        - Always set paused time as we enter the paused state
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::endAnimationUpdate):
        (WebCore::AnimationControllerPrivate::receivedStartTimeResponse):
        (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
        (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
        - reset the waiting flag when the list is empty (rather than not empty)
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        * page/animation/AnimationControllerPrivate.h:
        - rename m_waitingForStartTimeResponse to m_waitingForAsyncStartNotification

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore/ChangeLog
Source/WebCore/page/animation/AnimationBase.cpp
Source/WebCore/page/animation/AnimationController.cpp
Source/WebCore/page/animation/AnimationControllerPrivate.h