Reviewed by Adam.
authorggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Oct 2006 21:17:28 +0000 (21:17 +0000)
committerggaren <ggaren@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Oct 2006 21:17:28 +0000 (21:17 +0000)
commit27de279fd0b0f4724228580043cd215c4c11d440
treefb86b171e968c39b174b8fbbe6b6ef017820186e
parentc358532b3259b48e16fc199b9562e8c49e619898
    Reviewed by Adam.

        - Fixed "FIXME: Violates Liskov Substitution principle."

        IFRAME was never a true subclass of FRAME, since they disagreed on a
        number of behaviors, which, confusingly, IFRAME just overrode and contradicted.

        The fix here is to factor out things common to IFRAME and FRAME into a
        common base class, HTMLFrameElementBase.

        I also changed some " *" to "* " and added #includes in files that implicitly
        assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/WebCore.vcproj/WebCore/WebCore.vcproj
WebCore/WebCore.xcodeproj/project.pbxproj
WebCore/bindings/js/kjs_html.cpp
WebCore/html/HTMLElementFactory.cpp
WebCore/html/HTMLFrameElement.cpp
WebCore/html/HTMLFrameElement.h
WebCore/html/HTMLFrameElementBase.cpp [new file with mode: 0644]
WebCore/html/HTMLFrameElementBase.h [new file with mode: 0644]
WebCore/html/HTMLIFrameElement.cpp
WebCore/html/HTMLIFrameElement.h