Reviewed by Hyatt
authorkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Apr 2004 20:43:50 +0000 (20:43 +0000)
committerkocienda <kocienda@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Apr 2004 20:43:50 +0000 (20:43 +0000)
commit26a1531791186a72e1c30b8d0554eb8ebcf3108a
tree8be8380dc84e8f873f02bcbeca3c9190e4e58c80
parentbc871a2545d4fb034b1bf5dd959af5c5c4cff37f
    Reviewed by Hyatt

        A small collection of fixups.

        * khtml/editing/htmlediting_impl.cpp:
        (DeleteSelectionCommandImpl::doApply): Do not shift ending selection downstream
        when at position zero of a BR. That's just wrong. Simplify code that does
        "onlyWhitespace" delete. No need to handle multiple characters here; we can
        only ever have one thanks to the delete-collapsible-whitespace code.
        (TypingCommandImpl::issueCommandForDeleteKey): Don't do anything if at the
        start of a root editable block. This is a no-op....not an opportunity to crash.
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::positionForRenderer): Return this renderer's element position
        if the passed-in renderer is nil. This helps to make clicking in empty blocks work.
        * khtml/rendering/render_container.cpp:
        (RenderContainer::positionForCoordinates): Fixed typo in comment.
        * khtml/xml/dom_position.cpp:
        (DOM::Position::equivalentLeafPosition): Do not attempt to find a leaf if the
        position's node does not have a renderer, if the renderer has no kids.
        * layout-tests/editing/deleting/delete-br-001-expected.txt: Update expected results for BR fix.
        * layout-tests/editing/deleting/delete-br-003-expected.txt: Ditto.
        * layout-tests/editing/deleting/delete-br-006-expected.txt: Ditto.
        * layout-tests/editing/deleting/delete-br-007.html: Added. New BR test.
        * layout-tests/editing/deleting/delete-br-007-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@6437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/editing/deleting/delete-br-001-expected.txt
LayoutTests/editing/deleting/delete-br-003-expected.txt
LayoutTests/editing/deleting/delete-br-006-expected.txt
LayoutTests/editing/deleting/delete-br-007-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-br-007.html [new file with mode: 0644]
WebCore/ChangeLog-2005-08-23
WebCore/khtml/editing/htmlediting_impl.cpp
WebCore/khtml/rendering/render_block.cpp
WebCore/khtml/rendering/render_container.cpp
WebCore/khtml/xml/dom_position.cpp