2006-01-29 Eric Seidel <eseidel@apple.com>
authoreseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 29 Jan 2006 14:40:15 +0000 (14:40 +0000)
committereseidel <eseidel@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 29 Jan 2006 14:40:15 +0000 (14:40 +0000)
commit26685b140464e969487173ea5748c361880db55a
tree7bb148637d7d8a73e5d72fa757f3791abc5165a6
parent4ed780a5e7a121137dc655b5045266425049b1fe
2006-01-29  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt & darin.

        There are a few small, but intertwined fixes in this patch:

        Remaining fixes for SVGTetris:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

        Testing blocked by: http://bugzilla.opendarwin.org/show_bug.cgi?id=6905

        Fix for CDF support:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

        Updated test: svg/custom/simpleCDF.xml

        Fix for filter updating:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6849

        Testing blocked by: http://bugzilla.opendarwin.org/show_bug.cgi?id=6904

        Also, as a side effect of 6849, fixed double-apply of filters, improving:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6713

        Results updated for most tests, pixel results improved for filter tests.

        * kcanvas/KCanvasFilters.cpp:
        (KCanvasFilter::filterBBoxForItemBBox): moved into baseclass
        * kcanvas/KCanvasFilters.h:
        * kcanvas/RenderSVGImage.cpp:
        (RenderSVGImage::paint): use relativeBBox
        (RenderSVGImage::relativeBBox): added
        (RenderSVGImage::imageChanged): added
        (RenderSVGImage::getAbsoluteRepaintRect): fixed
        * kcanvas/RenderSVGImage.h:
        (KSVG::RenderSVGImage::imageChanged): added.
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::applyFilter): use new baseclass method
        (KCanvasFEFloodQuartz::getCIFilter): fixed.
        * kcanvas/device/quartz/KCanvasItemQuartz.h:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::layout): update width/height
        (KCanvasItemQuartz::getAbsoluteRepaintRect): fixed.
        (KCanvasItemQuartz::requiresLayer): moved to .cpp
        (KCanvasItemQuartz::lineHeight): added.
        (KCanvasItemQuartz::baselinePosition): added.
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (KCanvasContainerQuartz::canHaveChildren): moved to .cpp
        (KCanvasContainerQuartz::requiresLayer): moved to .cpp
        (KCanvasContainerQuartz::lineHeight): added.
        (KCanvasContainerQuartz::baselinePosition): added.
        (KCanvasContainerQuartz::paint): fixed.
        (KCanvasContainerQuartz::viewportTransform): fixed.
        (KCanvasContainerQuartz::getAbsoluteRepaintRect): fixed.
        (KCanvasContainerQuartz::absoluteTransform): fixed.
        * rendering/render_object.cpp:
        (WebCore::RenderObject::absoluteTransform): fixed apply order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
78 files changed:
LayoutTests/ChangeLog
LayoutTests/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum
LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png
LayoutTests/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt
LayoutTests/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt
LayoutTests/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt
LayoutTests/svg/W3C-SVG-1.1/text-text-01-b-expected.txt
LayoutTests/svg/custom/filter-source-alpha-expected.txt
LayoutTests/svg/custom/image-with-transform-clip-filter-expected.checksum
LayoutTests/svg/custom/image-with-transform-clip-filter-expected.png
LayoutTests/svg/custom/image-with-transform-clip-filter-expected.txt
LayoutTests/svg/custom/junk-data-expected.checksum
LayoutTests/svg/custom/junk-data-expected.png
LayoutTests/svg/custom/junk-data-expected.txt
LayoutTests/svg/custom/missing-xlink-expected.checksum
LayoutTests/svg/custom/missing-xlink-expected.png
LayoutTests/svg/custom/missing-xlink-expected.txt
LayoutTests/svg/custom/simpleCDF-expected.checksum
LayoutTests/svg/custom/simpleCDF-expected.png
LayoutTests/svg/custom/simpleCDF-expected.txt
LayoutTests/svg/custom/text-filter-expected.checksum
LayoutTests/svg/custom/text-filter-expected.png
LayoutTests/svg/custom/text-filter-expected.txt
LayoutTests/svg/custom/text-image-opacity-expected.txt
WebCore/ChangeLog
WebCore/kcanvas/KCanvasFilters.cpp
WebCore/kcanvas/KCanvasFilters.h
WebCore/kcanvas/RenderSVGImage.cpp
WebCore/kcanvas/RenderSVGImage.h
WebCore/kcanvas/device/quartz/KCanvasFilterQuartz.h
WebCore/kcanvas/device/quartz/KCanvasFilterQuartz.mm
WebCore/kcanvas/device/quartz/KCanvasItemQuartz.h
WebCore/kcanvas/device/quartz/KCanvasItemQuartz.mm
WebCore/kcanvas/device/quartz/KCanvasResourcesQuartz.h
WebCore/kcanvas/device/quartz/KCanvasResourcesQuartz.mm
WebCore/ksvg2/svg/SVGFilterElementImpl.cpp
WebCore/rendering/render_object.cpp