WebCore:
authoroliver <oliver@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jun 2007 03:07:04 +0000 (03:07 +0000)
committeroliver <oliver@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jun 2007 03:07:04 +0000 (03:07 +0000)
commit235ef7a94039750e35f3d6f1dc80b443784c1b99
tree9214d12d2e6a646a1d2611769f6711e07221abb4
parentae200e849f5c9564abc3a07a1740d8b46927a0be
WebCore:

        Reviewed by Justin.

        Remove incorrect assertions.

        These assertions were made on the assumption that
        TSM would always call with a range that was contained
        by an editable region.

        TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
        event that is otherwise unrelated to editing, which may
        be outside the current editing region, triggering these
        assertions.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge convertToNSRange:]):

WebKit:

        Reviewed by Justin.

        Add checks to make sure we don't try to create, use
        or return invalid ranges to TSM when it calls us despite
        not currently being in an editable region.

        * WebView/WebHTMLView.mm:
        (isTextInput):
        (-[WebHTMLView textStorage]):
        (-[WebHTMLView firstRectForCharacterRange:]):
        (-[WebHTMLView selectedRange]):
        (-[WebHTMLView attributedSubstringFromRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebCore/ChangeLog
WebCore/page/mac/WebCoreFrameBridge.mm
WebKit/ChangeLog
WebKit/WebView/WebHTMLView.mm