Reviewed by Darin, Maciej.
authorharrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Apr 2005 22:39:33 +0000 (22:39 +0000)
committerharrison <harrison@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Apr 2005 22:39:33 +0000 (22:39 +0000)
commit1fec1cc948adf3070e9536aa4a37514ce89d60c4
treef54cf813bfa522f4492648287c4a3b7dfe304bf4
parent5de74028f890ee9e681772448c502a86999243ff
    Reviewed by Darin, Maciej.

        <rdar://problem/4075576> Deleting text in new message borks content

        Fixed by removing the methods that attempted to preserve the position.  The idea
        of preserving position is a very recent one, and turned out to not actually address
        the problem it was intended to fix (see below).  Further, is unclear how the position
        could be preserved in a form that could be properly used later on.   Therefore,
        removing the code to work like before is the preferred alternative for this software
        update.  I've written <rdar://problem/4099839> to cover the bug that position
        preservation was supposed to fix (but did not).  Added layout tests for
        both this bug and 4099839.  Also, updated existing tests with correct expected results
        (delete-at-paragraph-boundaries-003 and 004).

        * khtml/editing/htmlediting.cpp:
        (khtml::CompositeEditCommand::removeFullySelectedNode):
        (khtml::CompositeEditCommand::removeChildrenInRange):
        (khtml::DeleteSelectionCommand::handleGeneralDelete):
        * khtml/editing/htmlediting.h:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-007.html: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-008.html: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-009.html: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt: Added.
        * layout-tests/editing/deleting/delete-at-paragraph-boundaries-010.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
13 files changed:
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-007.html [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-008.html [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-009.html [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt [new file with mode: 0644]
LayoutTests/editing/deleting/delete-at-paragraph-boundaries-010.html [new file with mode: 0644]
WebCore/ChangeLog-2005-08-23
WebCore/khtml/editing/htmlediting.cpp
WebCore/khtml/editing/htmlediting.h