Convert media controls from DeprecatedFlexibleBox to FlexibleBox
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Feb 2013 01:39:18 +0000 (01:39 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 15 Feb 2013 01:39:18 +0000 (01:39 +0000)
commit11e5973629b4d29de49478146717f1fe51ee1ba5
tree9e72e105b798e567ba60682d9929edeecd39daf5
parent563a03979f2304cd9fcc548b8499c7e8643bc826
Convert media controls from DeprecatedFlexibleBox to FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109775

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-14
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests in media/.

* css/mediaControls.css:
* css/mediaControlsBlackBerry.css:
* css/mediaControlsChromium.css:
* css/mediaControlsChromiumAndroid.css:
* css/mediaControlsEfl.css:
* css/mediaControlsGtk.css:
* css/mediaControlsQt.css:
* css/mediaControlsQuickTime.css:
Automated search and replace of old flexbox CSS rules to new ones.
Minor tuning of the chromium rules.

* rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderMediaControlTimeDisplay::layout):
* rendering/RenderMediaControlElements.h:
Make media controls inherit from RenderFlexibleBox

LayoutTests:

Rebaselined lots of tests. There were two kinds of changes:
- Replaced the RenderDeprecatedFlexibleBox class name with
RenderFlexibleBox, and minor printing differences
- Slight positioning/size changes due to a different algorithm for
shrinking elements (old flexbox shrinks elements evenly, new flexbox
shrinks in proportion to the size of the flex item)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
158 files changed:
LayoutTests/ChangeLog
LayoutTests/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/chromium-android/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/chromium-android/fast/layers/video-layer-expected.txt
LayoutTests/platform/chromium-android/media/audio-controls-rendering-expected.txt
LayoutTests/platform/chromium-android/media/controls-after-reload-expected.txt
LayoutTests/platform/chromium-android/media/controls-strict-expected.txt
LayoutTests/platform/chromium-android/media/controls-styling-expected.txt
LayoutTests/platform/chromium-android/media/controls-styling-strict-expected.txt
LayoutTests/platform/chromium-android/media/controls-without-preload-expected.txt
LayoutTests/platform/chromium-android/media/media-controls-clone-expected.txt
LayoutTests/platform/chromium-android/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/chromium-android/media/video-controls-rendering-expected.txt
LayoutTests/platform/chromium-android/media/video-display-toggle-expected.txt
LayoutTests/platform/chromium-android/media/video-empty-source-expected.txt
LayoutTests/platform/chromium-android/media/video-no-audio-expected.txt
LayoutTests/platform/chromium-android/media/video-playing-and-pause-expected.txt
LayoutTests/platform/chromium-android/media/video-zoom-controls-expected.txt
LayoutTests/platform/chromium-linux/media/audio-repaint-expected.png
LayoutTests/platform/chromium-linux/media/controls-after-reload-expected.png
LayoutTests/platform/chromium-linux/media/controls-strict-expected.png
LayoutTests/platform/chromium-linux/media/controls-styling-expected.png
LayoutTests/platform/chromium-linux/media/controls-styling-strict-expected.png
LayoutTests/platform/chromium-linux/media/controls-without-preload-expected.png
LayoutTests/platform/chromium-linux/media/media-document-audio-repaint-expected.png
LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png
LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png
LayoutTests/platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt
LayoutTests/platform/chromium-linux/media/video-controls-rendering-expected.png
LayoutTests/platform/chromium-linux/media/video-display-toggle-expected.png
LayoutTests/platform/chromium-linux/media/video-playing-and-pause-expected.png
LayoutTests/platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/chromium-mac/fast/layers/video-layer-expected.txt
LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.txt
LayoutTests/platform/chromium-mac/media/audio-repaint-expected.txt
LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.txt
LayoutTests/platform/chromium-mac/media/controls-strict-expected.txt
LayoutTests/platform/chromium-mac/media/controls-styling-expected.txt
LayoutTests/platform/chromium-mac/media/controls-styling-strict-expected.txt
LayoutTests/platform/chromium-mac/media/controls-without-preload-expected.txt
LayoutTests/platform/chromium-mac/media/media-controls-clone-expected.txt
LayoutTests/platform/chromium-mac/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt
LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt
LayoutTests/platform/chromium-mac/media/video-controls-rendering-expected.txt
LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.txt
LayoutTests/platform/chromium-mac/media/video-empty-source-expected.txt
LayoutTests/platform/chromium-mac/media/video-no-audio-expected.txt
LayoutTests/platform/chromium-mac/media/video-playing-and-pause-expected.txt
LayoutTests/platform/chromium-mac/media/video-zoom-controls-expected.txt
LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/chromium-win/fast/layers/video-layer-expected.txt
LayoutTests/platform/chromium-win/media/audio-controls-rendering-expected.txt
LayoutTests/platform/chromium-win/media/audio-repaint-expected.txt
LayoutTests/platform/chromium-win/media/controls-after-reload-expected.txt
LayoutTests/platform/chromium-win/media/controls-strict-expected.txt
LayoutTests/platform/chromium-win/media/controls-styling-expected.txt
LayoutTests/platform/chromium-win/media/controls-styling-strict-expected.txt
LayoutTests/platform/chromium-win/media/controls-without-preload-expected.txt
LayoutTests/platform/chromium-win/media/media-controls-clone-expected.txt
LayoutTests/platform/chromium-win/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt
LayoutTests/platform/chromium-win/media/video-controls-rendering-expected.txt
LayoutTests/platform/chromium-win/media/video-display-toggle-expected.txt
LayoutTests/platform/chromium-win/media/video-empty-source-expected.txt
LayoutTests/platform/chromium-win/media/video-no-audio-expected.txt
LayoutTests/platform/chromium-win/media/video-playing-and-pause-expected.txt
LayoutTests/platform/chromium-win/media/video-zoom-controls-expected.txt
LayoutTests/platform/chromium-win/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/chromium/TestExpectations
LayoutTests/platform/efl/TestExpectations
LayoutTests/platform/efl/fast/layers/video-layer-expected.txt
LayoutTests/platform/efl/media/audio-controls-rendering-expected.txt
LayoutTests/platform/efl/media/audio-repaint-expected.txt
LayoutTests/platform/efl/media/controls-after-reload-expected.txt
LayoutTests/platform/efl/media/controls-strict-expected.txt
LayoutTests/platform/efl/media/controls-styling-expected.txt
LayoutTests/platform/efl/media/controls-styling-strict-expected.txt
LayoutTests/platform/efl/media/controls-without-preload-expected.txt
LayoutTests/platform/efl/media/media-controls-clone-expected.txt
LayoutTests/platform/efl/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/efl/media/video-controls-rendering-expected.txt
LayoutTests/platform/efl/media/video-display-toggle-expected.txt
LayoutTests/platform/efl/media/video-empty-source-expected.txt
LayoutTests/platform/efl/media/video-no-audio-expected.txt
LayoutTests/platform/efl/media/video-playing-and-pause-expected.txt
LayoutTests/platform/efl/media/video-zoom-controls-expected.txt
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/gtk/fast/layers/video-layer-expected.txt
LayoutTests/platform/gtk/media/audio-controls-rendering-expected.txt
LayoutTests/platform/gtk/media/audio-repaint-expected.txt
LayoutTests/platform/gtk/media/controls-after-reload-expected.txt
LayoutTests/platform/gtk/media/controls-strict-expected.txt
LayoutTests/platform/gtk/media/controls-styling-expected.txt
LayoutTests/platform/gtk/media/controls-styling-strict-expected.txt
LayoutTests/platform/gtk/media/controls-without-preload-expected.txt
LayoutTests/platform/gtk/media/media-controls-clone-expected.txt
LayoutTests/platform/gtk/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/gtk/media/video-controls-rendering-expected.txt
LayoutTests/platform/gtk/media/video-display-toggle-expected.txt
LayoutTests/platform/gtk/media/video-empty-source-expected.txt
LayoutTests/platform/gtk/media/video-no-audio-expected.txt
LayoutTests/platform/gtk/media/video-playing-and-pause-expected.txt
LayoutTests/platform/gtk/media/video-zoom-controls-expected.txt
LayoutTests/platform/mac-snowleopard/media/controls-strict-expected.txt
LayoutTests/platform/mac-snowleopard/media/controls-styling-expected.txt
LayoutTests/platform/mac-snowleopard/media/controls-without-preload-expected.txt
LayoutTests/platform/mac-snowleopard/media/video-controls-rendering-expected.txt
LayoutTests/platform/mac-snowleopard/media/video-display-toggle-expected.txt
LayoutTests/platform/mac-snowleopard/media/video-no-audio-expected.txt
LayoutTests/platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt
LayoutTests/platform/mac/fast/layers/video-layer-expected.txt
LayoutTests/platform/mac/media/audio-controls-rendering-expected.txt
LayoutTests/platform/mac/media/audio-repaint-expected.txt
LayoutTests/platform/mac/media/controls-after-reload-expected.txt
LayoutTests/platform/mac/media/controls-strict-expected.txt
LayoutTests/platform/mac/media/controls-styling-expected.txt
LayoutTests/platform/mac/media/controls-styling-strict-expected.txt
LayoutTests/platform/mac/media/controls-without-preload-expected.txt
LayoutTests/platform/mac/media/media-controls-clone-expected.txt
LayoutTests/platform/mac/media/video-controls-rendering-expected.txt
LayoutTests/platform/mac/media/video-display-toggle-expected.txt
LayoutTests/platform/mac/media/video-empty-source-expected.txt
LayoutTests/platform/mac/media/video-no-audio-expected.txt
LayoutTests/platform/mac/media/video-playing-and-pause-expected.txt
LayoutTests/platform/mac/media/video-zoom-controls-expected.txt
LayoutTests/platform/qt/TestExpectations
LayoutTests/platform/qt/media/audio-repaint-expected.txt
LayoutTests/platform/qt/media/controls-without-preload-expected.txt
LayoutTests/platform/qt/media/video-playing-and-pause-expected.txt
LayoutTests/platform/win-xp/fast/layers/video-layer-expected.txt
LayoutTests/platform/win-xp/media/audio-controls-rendering-expected.txt
LayoutTests/platform/win-xp/media/audio-repaint-expected.txt
LayoutTests/platform/win-xp/media/controls-after-reload-expected.txt
LayoutTests/platform/win-xp/media/controls-strict-expected.txt
LayoutTests/platform/win-xp/media/controls-styling-expected.txt
LayoutTests/platform/win-xp/media/controls-without-preload-expected.txt
LayoutTests/platform/win-xp/media/media-controls-clone-expected.txt
LayoutTests/platform/win-xp/media/media-document-audio-repaint-expected.txt
LayoutTests/platform/win-xp/media/video-controls-rendering-expected.txt
LayoutTests/platform/win-xp/media/video-display-toggle-expected.txt
LayoutTests/platform/win-xp/media/video-empty-source-expected.txt
LayoutTests/platform/win-xp/media/video-no-audio-expected.txt
LayoutTests/platform/win-xp/media/video-playing-and-pause-expected.txt
LayoutTests/platform/win/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/css/mediaControls.css
Source/WebCore/css/mediaControlsBlackBerry.css
Source/WebCore/css/mediaControlsChromium.css
Source/WebCore/css/mediaControlsChromiumAndroid.css
Source/WebCore/css/mediaControlsEfl.css
Source/WebCore/css/mediaControlsGtk.css
Source/WebCore/css/mediaControlsQt.css
Source/WebCore/css/mediaControlsQuickTime.css
Source/WebCore/rendering/RenderMediaControlElements.cpp
Source/WebCore/rendering/RenderMediaControlElements.h