WebCore:
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Jul 2008 03:43:36 +0000 (03:43 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Jul 2008 03:43:36 +0000 (03:43 +0000)
commit10c11a51e9a11aeec6e0e4c720bfc302f103c651
tree8d5bb24c58607d09313ecdda45a7bbe953ec00fb
parent74dec49dbda417a45dae7962002c3d088733c46f
WebCore:

2008-07-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/5997215> display: table-row-group
        for :before content causes a crash

        The actual bug fix here is to ddd the generated content container
        as a child before adding any of the generated content to the
        container. There are two correctness fixes as well that deal with
        style changes and correctly.

        This patch also makes Node::diff() a static function.

        * dom/Node.cpp:
        (WebCore::Node::diff):
        * dom/Node.h:
        (WebCore::Node::):
        (WebCore::Node::recalcStyle):
        * rendering/RenderContainer.cpp:
        (WebCore::findBeforeAfterParent):
        (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::recalcStyle):

LayoutTests:

2008-07-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dan Bernstein.

        Tests for <rdar://problem/5997215> display: table-row-group
        for :before content causes a crash

        * fast/css-generated-content/table-row-group-to-inline.html: Added.
        * fast/css-generated-content/table-row-group-with-before.html: Added.
        * fast/css-generated-content/table-row-with-before.html: Added.
        * fast/css-generated-content/table-with-before.html: Added.
        * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt: Added.
        * platform/mac/fast/css-generated-content/table-row-group-with-before-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-row-group-with-before-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt: Added.
        * platform/mac/fast/css-generated-content/table-row-with-before-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-row-with-before-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-row-with-before-expected.txt: Added.
        * platform/mac/fast/css-generated-content/table-with-before-expected.checksum: Added.
        * platform/mac/fast/css-generated-content/table-with-before-expected.png: Added.
        * platform/mac/fast/css-generated-content/table-with-before-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
22 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/css-generated-content/table-row-group-to-inline.html [new file with mode: 0644]
LayoutTests/fast/css-generated-content/table-row-group-with-before.html [new file with mode: 0644]
LayoutTests/fast/css-generated-content/table-row-with-before.html [new file with mode: 0644]
LayoutTests/fast/css-generated-content/table-with-before.html [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-row-with-before-expected.txt [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.checksum [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.png [new file with mode: 0644]
LayoutTests/platform/mac/fast/css-generated-content/table-with-before-expected.txt [new file with mode: 0644]
WebCore/ChangeLog
WebCore/dom/Node.cpp
WebCore/dom/Node.h
WebCore/rendering/RenderContainer.cpp
WebCore/svg/SVGUseElement.cpp