LayoutTests:
authorandersca <andersca@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Jul 2007 20:15:44 +0000 (20:15 +0000)
committerandersca <andersca@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 Jul 2007 20:15:44 +0000 (20:15 +0000)
commit0a9320b206c8bdca159654b0a71a875d745a180e
tree0d7a1d70155ab69257bbd713029b49c3d65bafff
parent84c118094c037ad3f47e56974364a41d8d464c05
LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5289718>
        http://bugs.webkit.org/show_bug.cgi?id=14437
        CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)

        Add test from Alexey Proskuryakov.

        * plugins/plugin-remove-subframe-expected.txt: Added.
        * plugins/plugin-remove-subframe.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/5289718>
        http://bugs.webkit.org/show_bug.cgi?id=14437
        CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)

        Based on a patch from Maxime Britto.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys
        its frame.

        (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
        ASSERT that this is only called on the main frame.

WebKit:

        Reviewed by Darin.

        * WebView/WebView.mm:
        (-[WebView stringByEvaluatingJavaScriptFromString:]):
        ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/plugins/plugin-remove-subframe-expected.txt [new file with mode: 0644]
LayoutTests/plugins/plugin-remove-subframe.html [new file with mode: 0644]
WebCore/ChangeLog
WebCore/page/mac/WebCoreFrameBridge.mm
WebKit/ChangeLog
WebKit/WebView/WebView.mm