Assertion failure in WebCore::BidiRun::BidiRun()
authorantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 May 2015 20:34:40 +0000 (20:34 +0000)
committerantti@apple.com <antti@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 20 May 2015 20:34:40 +0000 (20:34 +0000)
commit0711d3f4e557ddb91780fcbc0f9a85d577b28883
treee64884ff7eb80be884a0fbc52c5a63dee52fb236
parent6e571297d60b9d00cafbc1003c872b8033366ca1
Assertion failure in WebCore::BidiRun::BidiRun()
https://bugs.webkit.org/show_bug.cgi?id=145203
rdar://problem/20958973

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/text/text-combine-crash.html

* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):

    Renove !isCombined() check. RenderCombineText::combineText() doesn't
    do any work unless needed and text may become uncombined too.

* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):

    Same here.

LayoutTests:

* fast/text/text-combine-crash-expected.txt: Added.
* fast/text/text-combine-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@184653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/text/text-combine-crash-expected.txt [new file with mode: 0644]
LayoutTests/fast/text/text-combine-crash.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/line/BreakingContext.h
Source/WebCore/rendering/line/LineBreaker.cpp