Reviewed by Eric.
[WebKit-https.git] / WebKit / ChangeLog
index 4258375c858b73340996de526e1af93441374804..50b483e314c0c7300da5ce7075c9873129b7e88f 100644 (file)
@@ -1,3 +1,19 @@
+2006-03-27  Tim Omernick  <timo@apple.com>
+
+        Reviewed by Eric.
+
+        <rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed
+
+        * ChangeLog:
+        * Plugins/WebBaseNetscapePluginView.m:
+        (-[WebBaseNetscapePluginView dealloc]):
+        Instead of calling -stop, assert that the plugin is not running.  A plugin view cannot be deallocated
+        until it is removed from its window.  When a plugin view is removed from its window, it calls -stop
+        on itself.  Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the
+        assertion will help catch any edge cases.
+        (-[WebBaseNetscapePluginView finalize]):
+        ditto
+
 2006-03-27  Tim Omernick  <timo@apple.com>
 
         Reviewed by Eric.