Reviewed by Anders.
[WebKit-https.git] / WebCore / ChangeLog
index ecb5c5542df11939fa41446d8f8cbdfef52bc59d..7d57632fe9f0be35fbd2ee2d2d0bd9781e2eb492 100644 (file)
@@ -1,3 +1,26 @@
+2006-09-02  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Anders.
+
+        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10667
+          Password: Double-click should select-all to avoid exposing word boundaries
+
+        Test: fast/forms/password-doubleclick-selection.html
+
+        * editing/visible_units.cpp:
+        (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property, 
+         convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character
+         isn't treated as a punctuation boundary.
+        (WebCore::nextBoundary): ditto.
+        * editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's 
+          string instead of the node value.  This matches the base class implementation of handleTextNode.
+
+        Code cleanup.
+        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): 
+          Avoid unnecessary check for password field case if the smart replace condition is false.
+        * page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code.  Calls isSelectionInPasswordField now.
+        * rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.
+
 2006-09-01  David Hyatt  <hyatt@apple.com>
 
         Fix for 10682, refine the FOUC paint suppression logic so that it