Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after draggin...

[WebKit-https.git] / WebCore / ChangeLog

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index b301bf6f70c44a2c8784d5982085ce9ee605eab3..29ec7ccf703013d33401987d8ed745b25f973789 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,20 @@
+2008-01-08  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Adele and John.
+
+        Fix <rdar://problem/5652740> Crash occurs at WebCore::Widget::getView() after
+        dragging file into window that contains web page ( http://www.econocraft.com/flood_arch.htm )
+
+        We hit this crash if the page reloads between DragController::dragUpdated
+        and DragController::performDrag, meaning that m_document starts pointing to
+        a now viewless document.  This is picked up by an assertion in performDrag
+        which I have now replaced with an assignment given that the assertion is 
+        invalid -- it is possible for m_document to be changed between dragUpdated
+        performDrag
+
+        * page/DragController.cpp:
+        (WebCore::DragController::performDrag):
+
 2008-01-08  Alexey Proskuryakov  <ap@webkit.org>
 
         Reviewed by Darin.