Reviewed by Darin
[WebKit-https.git] / WebCore / ChangeLog-2005-08-23
index c397ad7..9633d22 100644 (file)
@@ -1,3 +1,53 @@
+2005-01-10  Ken Kocienda  <kocienda@apple.com>
+
+        Reviewed by Darin
+
+        Fix for this bug:
+        
+        <rdar://problem/3907005> Applying block styles to a line of text can unexpectedly affect other lines
+
+        * khtml/editing/htmlediting.cpp:
+        (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): New function which moves "paragraphs"
+        to their own blocks if needed so that a block style can be applied.
+        (khtml::CompositeEditCommand::isMailBlockquote): Moved this function to base class so it can be used more generally.
+        (khtml::ApplyStyleCommand::applyBlockStyle): Pass a node instead of a block to addBlockStyleIfNeeded().
+        (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Now accepts a node instead of a block for styling.
+        This function also now calls moveParagraphContentsToNewBlockIfNecessary() to make sure that only the current
+        paragraph is styled.
+        (khtml::SetNodeAttributeCommand::doUnapply): Should not assert on undo if old value of attribute was null.
+        Should remove attributue instead.
+        * khtml/editing/htmlediting.h: Touch function declarations accordingly.
+        * layout-tests/editing/style/create-block-for-style-001-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-001.html: Added.
+        * layout-tests/editing/style/create-block-for-style-002-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-002.html: Added.
+        * layout-tests/editing/style/create-block-for-style-003-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-003.html: Added.
+        * layout-tests/editing/style/create-block-for-style-004-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-004.html: Added.
+        * layout-tests/editing/style/create-block-for-style-005-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-005.html: Added.
+        * layout-tests/editing/style/create-block-for-style-006-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-006.html: Added.
+        * layout-tests/editing/style/create-block-for-style-007-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-007.html: Added.
+        * layout-tests/editing/style/create-block-for-style-008-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-008.html: Added.
+        * layout-tests/editing/style/create-block-for-style-009-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-009.html: Added.
+        * layout-tests/editing/style/create-block-for-style-010-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-010.html: Added.
+        * layout-tests/editing/style/create-block-for-style-011-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-011.html: Added.
+        * layout-tests/editing/style/create-block-for-style-012-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-012.html: Added.
+        * layout-tests/editing/style/create-block-for-style-013-expected.txt: Added.
+        * layout-tests/editing/style/create-block-for-style-013.html: Added.
+
+        Unrelated updates to these expected results.
+        * layout-tests/editing/inserting/insert-div-007-expected.txt
+        * layout-tests/editing/pasteboard/paste-text-013-expected.txt
+
 2005-01-10  Chris Blumenberg  <cblu@apple.com>
 
        Fixed: <rdar://problem/3936844> Mail: Messages with rich text do not print