Occasional thread-safety-related crashes on the ServicesController queue
[WebKit-https.git] / Source / WebKit2 / ChangeLog
index 171602d2960ff191a5697d14f802d8e2e2218888..eab77c85bcd92707945d48d2883ba7af673ee912 100644 (file)
@@ -1,3 +1,20 @@
+2014-08-28  Tim Horton  <timothy_horton@apple.com>
+
+        Occasional thread-safety-related crashes on the ServicesController queue
+        https://bugs.webkit.org/show_bug.cgi?id=136356
+        <rdar://problem/18045685>
+
+        Reviewed by Dan Bernstein.
+
+        * UIProcess/mac/ServicesController.mm:
+        (WebKit::hasCompatibleServicesForItems):
+        Added. Check directly with NSSharingService if we have any services for the given items.
+        We should eventually check Viewer and Editor services separately so the Web process can
+        be smarter about when it shows the overlay, but for now this maintains the existing behavior.
+
+        (WebKit::ServicesController::refreshExistingServices):
+        Make use of hasCompatibleServicesForItems instead of having NSSharingServicePicker construct NSMenus.
+
 2014-08-28  Tim Horton  <timothy_horton@apple.com>
 
         WebKit2 doesn't support viewer services that accept image attachments