If the action menu hit test times out, a menu with a single separator appears
[WebKit-https.git] / Source / WebKit2 / ChangeLog
index 09a331372955fbdc68fd8bbca437f41dd3157c51..e576b4ca1c0fa2d3bf002ac8c3ae77931b3d0ccd 100644 (file)
@@ -1,3 +1,20 @@
+2014-12-05  Tim Horton  <timothy_horton@apple.com>
+
+        If the action menu hit test times out, a menu with a single separator appears
+        https://bugs.webkit.org/show_bug.cgi?id=139320
+        <rdar://problem/19158331>
+
+        Reviewed by Beth Dakin.
+
+        * UIProcess/mac/WKActionMenuController.h:
+        * UIProcess/mac/WKActionMenuController.mm:
+        (-[WKActionMenuController menuNeedsUpdate:]):
+        (-[WKActionMenuController _defaultMenuItems]):
+        Add a new "TimedOut" state, which we get into if the sync wait for
+        didPerformActionMenuHitTest times out. In this case, we'll drop the
+        separator item and give up on the menu. This way, the menu will never
+        have just a single separator item at the end of menuNeedsUpdate:.
+
 2014-12-05  Mark Lam  <mark.lam@apple.com>
 
         Gardening: speculative build fix for GTK builds.
 2014-12-05  Mark Lam  <mark.lam@apple.com>
 
         Gardening: speculative build fix for GTK builds.