ITMLKit Inspector: Computed Style Box Model section throws exceptions
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
index 6c0ae38..b4d500d 100644 (file)
@@ -1,3 +1,19 @@
+2018-12-20  Joseph Pecoraro  <pecoraro@apple.com>
+
+        ITMLKit Inspector: Computed Style Box Model section throws exceptions
+        https://bugs.webkit.org/show_bug.cgi?id=192911
+        <rdar://problem/46861112>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/BoxModelDetailsSectionRow.js:
+        (WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
+        (WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
+        (WI.BoxModelDetailsSectionRow.prototype._updateMetrics):
+        ITMLKit doesn't always provide a display/position/width/height etc properties.
+        Protect against this, and just show an empty message in the box model section
+        if those properties do not exist.
+
 2018-12-20  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: UIString should take an optional key and description to aid localization