CSS Exclusions polygon shape arguments should be comma separated
[WebKit-https.git] / Source / WebCore / ChangeLog
index 2cbfd492ea9c8d415671aaff9b78328c9b2d0085..db3b9f1faeceb4d060a450d24a403209c3e2921a 100644 (file)
@@ -1,3 +1,41 @@
+2012-04-05  Hans Muller  <hmuller@adobe.com>
+
+        CSS Exclusions polygon shape arguments should be comma separated
+        https://bugs.webkit.org/show_bug.cgi?id=82368
+
+        Reviewed by Ryosuke Niwa.
+
+        Changed the CSS Parser to accept a conventional comma separated argument list for the
+        polygon exclusion shape. The syntax had used spaces to separate x,y coordinates, like:
+        polygon(10px,20px 30px,40px).  Now commas separate points: polygon(10px 20px, 30px 40px).
+        This change is per the draft exclusions spec, http://dev.w3.org/csswg/css3-exclusions.
+        Additional relevant information about CSS argument list syntax can be found
+        here: http://dev.w3.org/csswg/css3-values/#component-whitespace.
+
+        Factored comma recognition idiom in CSSParser.cpp into isComma() utility function.
+
+        The existing tests have been updated.
+
+        * css/CSSParser.cpp:
+        (WebCore::isComma)
+        (WebCore::CSSParser::parseFillPosition)
+        (WebCore::CSSParser::parseFillRepeat)
+        (WebCore::CSSParser::parseFillProperty)
+        (WebCore::CSSParser::parseCubicBezierTimingFunctionValue)
+        (WebCore::CSSParser::parseAnimationTimingFunction)
+        (WebCore::CSSParser::parseAnimationProperty)
+        (WebCore::CSSParser::parseExclusionShapePolygon)
+        (WebCore::CSSParser::parseDeprecatedGradient)
+        (WebCore::CSSParser::parseRadialGradient)
+        (WebCore::CSSParser::parseGradientColorStops)
+        (WebCore::CSSParser::parseImageSet)
+        (WebCore::filterInfoForName)
+        (WebCore::CSSParser::parseCustomFilter)
+        (WebCore::CSSParser::parseFontFeatureSettings)
+
+        * css/CSSWrapShapes.cpp:
+        (WebCore::CSSWrapShapePolygon::cssText):
+
 2012-04-05  Joshua Bell  <jsbell@chromium.org>
 
         IndexedDB: Support string.length in keyPaths