Implement RenderGrid::computeIntrinsicLogicalWidths
[WebKit-https.git] / Source / WebCore / ChangeLog
index ded7140247b3da1fa534bf4e602afa4498fc14c9..b16449b736743b6043e71bd0c2ae867665209fbc 100644 (file)
@@ -1,3 +1,24 @@
+2013-02-14  Ojan Vafai  <ojan@chromium.org>
+
+        Implement RenderGrid::computeIntrinsicLogicalWidths
+        https://bugs.webkit.org/show_bug.cgi?id=109881
+
+        Reviewed by Tony Chang.
+
+        For now this is not observable due to the FIXMEs for unimplemented bits
+        of computePreferredLogicalWidths. But, soon, I'll be removing the computePreferredLogicalWidths
+        override entirely and instead use RenderBlock's, which will also address the
+        RenderGrid FIXMEs.
+
+        * rendering/RenderGrid.cpp:
+        (WebCore::RenderGrid::computeIntrinsicLogicalWidths):
+        const_cast the usages of m_grid. Alternately, we could stack allocate it, but there's disagreement on
+        whether that's the right choice. See https://bugs.webkit.org/show_bug.cgi?id=109880.
+
+        (WebCore::RenderGrid::computePreferredLogicalWidths):
+        * rendering/RenderGrid.h:
+
+
 2013-02-15  Xueqing Huang  <huangxueqing@baidu.com>
 
         Flexbox should ignore firstLine pseudo element.