REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel
[WebKit-https.git] / Source / WebCore / ChangeLog
index 2c8e536b72109d0391af943908c339dcf69fc41b..a3682f39df7f43f93452d7e6ad7e77b3b897b179 100644 (file)
@@ -1,3 +1,24 @@
+2014-07-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel
+        https://bugs.webkit.org/show_bug.cgi?id=135278
+
+        Reviewed by Tim Horton.
+
+        The bug was caused by editorUIUpdateTimerFired calling respondToChangedSelection only if the selection was
+        triggered by dictation instead of only if it was NOT triggered by dictation.
+
+        Prior to r164401, AlternativeTextController::respondToMarkerAtEndOfWord exited early when SetSelectionOptions
+        had DictationTriggered set. r164401 intended to move this check to editorUIUpdateTimerFired to avoid passing
+        options around but the boolean condition was erroneously flipped.
+
+        Fixed the bug by negating the condition in editorUIUpdateTimerFired.
+
+        No new tests for now since autocorrection panel cannot be tested automatically. (We should really automate this!)
+
+        * editing/Editor.cpp:
+        (WebCore::Editor::editorUIUpdateTimerFired):
+
 2014-07-24  Pratik Solanki  <psolanki@apple.com>
 
         REGRESSION(r171526): [GTK] Massive crashes.
 2014-07-24  Pratik Solanki  <psolanki@apple.com>
 
         REGRESSION(r171526): [GTK] Massive crashes.