StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExecutable...
[WebKit-https.git] / Source / JavaScriptCore / ChangeLog
index 341e157..22f507a 100644 (file)
@@ -1,3 +1,21 @@
+2015-02-17  Filip Pizlo  <fpizlo@apple.com>
+
+        StackLayoutPhase should use CodeBlock::usesArguments rather than FunctionExecutable::usesArguments
+        https://bugs.webkit.org/show_bug.cgi?id=141721
+        rdar://problem/17198633
+
+        Reviewed by Michael Saboff.
+        
+        I've seen cases where the two are out of sync.  We know we can trust the CodeBlock::usesArguments because
+        we use it everywhere else.
+        
+        No test because I could never reproduce the crash.
+
+        * dfg/DFGGraph.h:
+        (JSC::DFG::Graph::usesArguments):
+        * dfg/DFGStackLayoutPhase.cpp:
+        (JSC::DFG::StackLayoutPhase::run):
+
 2015-02-16  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Improved Console Support for Bound Functions