bmalloc, WTF and JavaScriptCore parts of [Xcode] Update some build settings as recomm...
[WebKit-https.git] / Source / JavaScriptCore / ChangeLog
index 21f16cc..11d4f31 100644 (file)
@@ -1,3 +1,29 @@
+2018-10-03  Dan Bernstein  <mitz@apple.com>
+
+        JavaScriptCore part of [Xcode] Update some build settings as recommended by Xcode 10
+        https://bugs.webkit.org/show_bug.cgi?id=190250
+
+        Reviewed by Alex Christensen.
+
+        * API/tests/Regress141275.mm:
+        (-[JSTEvaluator _sourcePerform]): Addressed newly-enabled CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF
+          by making the self-retaining explicit.
+
+        * API/tests/testapi.cpp:
+        (testCAPIViaCpp): Addressed newly-enabled CLANG_WARN_UNREACHABLE_CODE by breaking out of the
+          loop instead of returning from the lambda.
+
+        * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_UNREACHABLE_CODE,
+          CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
+          CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
+
+        * JavaScriptCore.xcodeproj/project.pbxproj: Removed a duplicate reference to
+          UnlinkedFunctionExecutable.h, and let Xcode update the project file.
+
+        * assembler/MacroAssemblerPrinter.cpp:
+        (JSC::Printer::printAllRegisters): Addressed newly-enabled CLANG_WARN_COMMA by replacing
+          some commas with semicolons.
+
 2018-10-03  Mark Lam  <mark.lam@apple.com>
 
         Make string MaxLength for all WTF and JS strings consistently equal to INT_MAX.