2009-11-26 Adam Barth Reviewed by Eric Seidel. [bzt] Kill WebKitLandingScripts https://bugs.webkit.org/show_bug.cgi?id=31904 Step 3: Kill build_webkit. * Scripts/modules/buildsteps.py: * Scripts/modules/landingsequence.py: * Scripts/modules/webkitlandingscripts.py: 2009-11-26 Adam Barth Reviewed by Eric Seidel. [bzt] Kill WebKitLandingScripts https://bugs.webkit.org/show_bug.cgi?id=31904 Step 2: Kill ensure_builders_are_green. * Scripts/modules/buildsteps.py: * Scripts/modules/commands/download.py: * Scripts/modules/landingsequence.py: * Scripts/modules/webkitlandingscripts.py: 2009-11-26 Adam Barth Reviewed by Eric Seidel. [bzt] Kill WebKitLandingScripts https://bugs.webkit.org/show_bug.cgi?id=31904 Step 1: Kill prepare_clean_working_directory and run_webkit_tests. * Scripts/bugzilla-tool: * Scripts/modules/buildsteps.py: Added. * Scripts/modules/commands/download.py: * Scripts/modules/landingsequence.py: * Scripts/modules/webkitlandingscripts.py: 2009-11-26 Zoltan Horvath Reviewed by Adam Barth. Remove directory prefixes from linux commands SCM unittests can cause errors on some systems if we use absolute reference to the commands, so directory prefixes have been removed. * Scripts/modules/scm_unittest.py: 2009-11-21 Holger Hans Peter Freyther Reviewed by Kenneth Rohde Christiansen. Link DumpRenderTree to the Qt Ui Tools https://bugs.webkit.org/show_bug.cgi?id=31203 Implement QWebPage::createPlugin using the Qt Ui Tools to be able to create classes like QProgressBar from within the tags This is required for the new automatic test of Qt Plugins. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::createPlugin): * DumpRenderTree/qt/DumpRenderTree.h: * DumpRenderTree/qt/DumpRenderTree.pro: 2009-11-25 Yuzo Fujishima Reviewed by Eric Seidel. Update pywebsocket to 0.4.2 Update pywebsocket to 0.4.2 https://bugs.webkit.org/show_bug.cgi?id=31861 * pywebsocket/example/echo_client.py: * pywebsocket/example/echo_wsh.py: * pywebsocket/mod_pywebsocket/__init__.py: * pywebsocket/mod_pywebsocket/dispatch.py: * pywebsocket/mod_pywebsocket/msgutil.py: * pywebsocket/mod_pywebsocket/standalone.py: * pywebsocket/setup.py: * pywebsocket/test/test_dispatch.py: * pywebsocket/test/test_msgutil.py: 2009-11-25 Adam Barth Reviewed by Eric Seidel. Add unit test for mark-fixed https://bugs.webkit.org/show_bug.cgi?id=31896 * Scripts/modules/commands/commandtest.py: Added. * Scripts/modules/commands/queries_unittest.py: * Scripts/modules/commands/upload_unittest.py: Added. * Scripts/modules/mock_bugzillatool.py: * Scripts/run-webkit-unittests: 2009-11-25 Adam Barth Reviewed by Eric Seidel. bugzilla-tool should have a mark-fixed command https://bugs.webkit.org/show_bug.cgi?id=31853 Pretty simple stuff. * Scripts/modules/commands/upload.py: 2009-11-25 Eric Seidel Reviewed by Adam Barth. 'bugzilla-tool help' should only show common commands like how 'git help' does https://bugs.webkit.org/show_bug.cgi?id=31772 I also took this opportunity to make 'help' a real Command. Making 'help' a real command required adding Command.tool (which we've wanted to do for a while). * Scripts/bugzilla-tool: - change should_show_command_help to should_show_in_main_help * Scripts/modules/commands/download.py: - Mark commands as being shown in main help or not. - show_in_main_help = False is not required (default is false), but it seemed to make the commands more self-documenting. * Scripts/modules/commands/queries.py: ditto * Scripts/modules/commands/queues.py: ditto * Scripts/modules/commands/upload.py: ditto * Scripts/modules/multicommandtool.py: - Make Command hold a pointer to tool in self.tool. Most Command subclasses do not take advantage of this yet, but it was required for HelpCommand to be able to reach the tool from _help_epilog(). - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help - Move MultiCommandTool._help_epilog to Command._help_epilog - Move "help" logic into HelpCommand.execute() - Change should_show_command_help to should_show_in_main_help and add a default implementation. * Scripts/modules/multicommandtool_unittest.py: - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands' 2009-11-25 Brian Weinstein Reviewed by Dan Bernstein. Patch by Mark Rowe. The buildbots are failing on Windows because when they were upgraded to 4.0.4, Apple Application Support was not in their path. Add it to the path to fix the buildots. * Scripts/webkitdirs.pm: 2009-11-25 Csaba Osztrogonác Reviewed by David Kilzer. run-webkit-tests doesn't accept directories/files with --skipped=only parameter https://bugs.webkit.org/show_bug.cgi?id=31799 * Scripts/run-webkit-tests: Fixed. 2009-11-25 Zoltan Horvath Reviewed by Eric Seidel. Change run_command to give back stderr by default https://bugs.webkit.org/show_bug.cgi?id=31734 Change run_command to give back stderr by default. Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches. Change the related unittest call. * Scripts/modules/scm.py: * Scripts/modules/scm_unittest.py: 2009-11-25 Eric Seidel Reviewed by Adam Barth. Centralize required argument parsing in Command https://bugs.webkit.org/show_bug.cgi?id=31872 * Scripts/modules/commands/download.py: remove custom required arg message. * Scripts/modules/commands/upload.py: ditto. * Scripts/modules/multicommandtool.py: - Add _parse_required_arguments. - Pass program name off to OptionParser. - Add name() for access to tool name. - Add check_arguments_and_execute and make it return a return code. - Replace a couple uses of + with %. * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments 2009-11-25 Eric Seidel Reviewed by Adam Barth. Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. https://bugs.webkit.org/show_bug.cgi?id=31870 * Scripts/modules/commands/queries_unittest.py: Use the new class. * Scripts/modules/multicommandtool_unittest.py: Ditto. * Scripts/modules/outputcapture.py: Added. 2009-11-24 Dmitry Titov Reviewed by Eric Seidel. Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit https://bugs.webkit.org/show_bug.cgi?id=31444 * Scripts/build-webkit: 2009-11-24 Chris Marrin Reviewed by Simon Fraser. Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded https://bugs.webkit.org/show_bug.cgi?id=27314 Now the script allows the directories with these tests to be included on all platforms but Mac, where they behave the same as always. For all other platforms the tests need to be excluded using the Skipped files, which is currently done for all platforms (including win since we're not turned on yet) * Scripts/webkitdirs.pm: 2009-11-24 Eric Seidel Reviewed by Adam Barth. queries_unittest.py should test command output https://bugs.webkit.org/show_bug.cgi?id=31845 * Scripts/modules/commands/queries_unittest.py: - Capture stdout and stderr and compare with expected strings. 2009-11-24 Simon Fraser No Review. Fix spelling error ("depenedencies"). * Scripts/build-webkit: 2009-11-24 Mark Rowe Land the configuration that includes the two debug GTK Linux builders. * BuildSlaveSupport/build.webkit.org-config/config.json: 2009-11-24 David Kilzer bisect-builds broke after r50080 Reviewed by Dan Bernstein. * Scripts/bisect-builds: (mountAndRunNightly): Switched back to using backticks to run the hdiutil command since exec() will terminate the existing script, which is not what we want. Store the output of File::Spec->devnull() in a variable for use in the hdiutil detach commands. 2009-11-23 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. Include "config.h" to meet Coding Style Guidelines https://bugs.webkit.org/show_bug.cgi?id=31792 * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: * DumpRenderTree/qt/jsobjects.cpp: * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: 2009-11-23 Gustavo Noronha Silva Reviewed by Oliver Hunt. Implement new required function to pass test we used to pass. This change is required since r51294. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs): 2009-11-23 Jakub Wieczorek Reviewed by Kenneth Rohde Christiansen. [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs. https://bugs.webkit.org/show_bug.cgi?id=31775 LayoutTestController::dumpBackForwardList() should work with local URLs as well as with normal URLs (in http tests for instance). Currently it does not output the latter properly. Unskip a bunch of passing http/navigation tests. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::dumpHistoryItem): 2009-11-22 Chris Fleizach Reviewed by Oliver Hunt. ARIA: support aria-flowto https://bugs.webkit.org/show_bug.cgi?id=31762 * DumpRenderTree/AccessibilityUIElement.cpp: (ariaFlowToElementAtIndexCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaFlowToElementAtIndex): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::ariaFlowToElementAtIndex): 2009-11-22 Antonio Gomes Reviewed by Kenneth Christiansen. [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen https://bugs.webkit.org/show_bug.cgi?id=31638 Unfreeze WorkQueue after each test execution. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2009-11-22 Jakub Wieczorek Reviewed by Adam Barth. [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors for localhost and 127.0.0.1. https://bugs.webkit.org/show_bug.cgi?id=31783 Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::NetworkAccessManager::NetworkAccessManager): (WebCore::NetworkAccessManager::sslErrorsEncountered): (WebCore::WebPage::WebPage): * DumpRenderTree/qt/DumpRenderTree.h: 2009-11-22 Chris Evans Reviewed by Adam Barth. Disable access to file:/// directory listings https://bugs.webkit.org/show_bug.cgi?id=31329 Implemented setAllowUniversalAccessFromFileURLs to support testing of file URL security. * DumpRenderTree/LayoutTestController.cpp: (setAllowUniversalAccessFromFileURLsCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAllowUniversalAccessFromFileURLs): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAllowUniversalAccessFromFileURLs): 2009-11-22 Jakub Wieczorek Reviewed by Kenneth Rohde Christiansen. [Qt] Fix the timeout of fast/frames/frame-navigation.html https://bugs.webkit.org/show_bug.cgi?id=31638 The test is timeouting, because it uses the WorkQueue to load a document in one of the child frames and once the loading is finished, the DRT does not dump the tree. This is because it waits for the QWebFrame::loadFinished() signal from the main frame, while it should connect to QWebPage::loadFinished(). * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): 2009-11-21 Eric Seidel Reviewed by Adam Barth. bugzilla-tool --help spews way too much text https://bugs.webkit.org/show_bug.cgi?id=31771 * Scripts/bugzilla-tool: - Remove self.cached_scm initialization hack. * Scripts/modules/buildbot.py: - Make default_host accessible to callers. * Scripts/modules/commands/download.py: - Phrase help for all commands consistently and remove spurious help text punctuation. * Scripts/modules/commands/queries.py: Ditto. * Scripts/modules/commands/queues.py: Ditto. * Scripts/modules/commands/upload.py: Ditto. * Scripts/modules/multicommandtool.py: - Add HelpPrintingOptionParser.format_epilog to replace NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize per-command help (thus removing the need for the cached_scm hack in BugzillaTool). - Make --help only show a list of commands like "svn help" and "git help" do -- previously --help was listing all commands and options. - Sort list of commands alphabetically. 2009-11-21 Eric Seidel No review. Fixing a typo from the previous patch for bug 31767. AbstractQueue.run_bugzilla_tool throws an exception https://bugs.webkit.org/show_bug.cgi?id=31769 * Scripts/modules/commands/queues.py: 2009-11-21 Eric Seidel Reviewed by Adam Barth. commit-queue fails to run with "permissions error" due to bad bugzilla-tool path https://bugs.webkit.org/show_bug.cgi?id=31767 What we really want to test is BugzillaTool.path() instead of TrivialTool.path(). Since we don't have a good way to test BugzillaTool pieces, I've left out a test for now. * Scripts/bugzilla-tool: - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue. * Scripts/modules/commands/queues.py: - Use tool.path() instead of __file__. * Scripts/modules/multicommandtool.py: - Add a new path() method to MultiComandTool. * Scripts/modules/multicommandtool_unittest.py: - Provide a path() method. Little point in testing this mock implementation. 2009-11-21 Adam Barth Unreviewed "build" fix. Turns out I was testing the wrong copy of WebKitTools. * Scripts/modules/commands/download.py: 2009-11-21 Adam Barth Reviewed by Eric Seidel. Convert check-style to use LandingSequence https://bugs.webkit.org/show_bug.cgi?id=31763 Instead of manipulating the working copy by hand, we should use the LandingSequence in CheckStyle. This will make this code eaiser to test. * Scripts/modules/commands/download.py: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Unit test query commands https://bugs.webkit.org/show_bug.cgi?id=31755 These tests are pretty rough, but hopefully they'll grow. * Scripts/modules/commands/queries_unittest.py: Added. * Scripts/modules/mock_bugzillatool.py: Added. * Scripts/run-webkit-unittests: 2009-11-20 Eric Seidel Reviewed by Adam Barth. Fix a bunch of unit test regressions from our recent bugzilla-toll hacking https://bugs.webkit.org/show_bug.cgi?id=31758 * Scripts/modules/multicommandtool.py: - Allow passing of explicit commands to MultiCommandTool.__init__ * Scripts/modules/multicommandtool_unittest.py: - Use new Command.name naming system. - Test Command auto-discovery. * Scripts/modules/workqueue.py: - bug_id no longer exists, use patch['bug_id'] instead. * Scripts/modules/workqueue_unittest.py: - WorkQueues require names now. - should_proceed_with_work_item must return a patch object. 2009-11-20 Chris Fleizach Reviewed by Beth Dakin. WAI-ARIA: add support for aria-owns https://bugs.webkit.org/show_bug.cgi?id=31702 * DumpRenderTree/AccessibilityUIElement.cpp: (ariaOwnsElementAtIndexCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::ariaOwnsElementAtIndex): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaOwnsElementAtIndex): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::ariaOwnsElementAtIndex): 2009-11-20 Eric Seidel Reviewed by Adam Barth. Fix exception thrown when running the commit-queue. * Scripts/modules/statusbot.py: patch is optional. * Scripts/modules/workqueue.py: WorkQUeue requires a name. 2009-11-20 Eric Seidel Reviewed by Adam Barth. Teach the StatusBot how to support more than just the commit-queue https://bugs.webkit.org/show_bug.cgi?id=31754 * Scripts/modules/workqueue.py: Another typo. 2009-11-20 Eric Seidel Reviewed by Adam Barth. Teach the StatusBot how to support more than just the commit-queue https://bugs.webkit.org/show_bug.cgi?id=31754 * Scripts/modules/commands/queues.py: Fix silly typo. 2009-11-20 Eric Seidel Reviewed by Adam Barth. Teach the StatusBot how to support more than just the commit-queue https://bugs.webkit.org/show_bug.cgi?id=31754 * CommitQueueStatus/index.yaml: - Add indices required for the new queries. * CommitQueueStatus/queue_status.py: - Add a patch-status page and move update_status to update-status. - Only display "commit-queue" status records for the commit-queue. - Add support for a queue_name property on status records. - Fix _int_from_request to actually work. * CommitQueueStatus/update_status.html: - Add support for a queue_name on status records. - Remove unused list of bug ids. * Scripts/modules/commands/queues.py - Make the queues pass the patch instead of the bug_id to StatusBot. * Scripts/modules/statusbot.py: - Support passing the queue_name to the status updates. - Support fetching patch status with patch_status(). * Scripts/modules/workqueue.py: - Pass the patch to the StatusBot instead of the bug_id. - Let WorkQueues have a name. 2009-11-20 Adam Barth Reviewed by Eric Seidel. Move bugzilla-tool commands into their own file https://bugs.webkit.org/show_bug.cgi?id=31752 This will let us write unit tests. * Scripts/bugzilla-tool: * Scripts/modules/commands/__init__.py: Added. * Scripts/modules/commands/download.py: Added. * Scripts/modules/commands/queries.py: Added. * Scripts/modules/commands/queues.py: Added. * Scripts/modules/commands/upload.py: Added. * Scripts/modules/grammar.py: Added. 2009-11-20 Adam Barth Reviewed by Eric Seidel. BuildQueue should check if the tree is currently buildable https://bugs.webkit.org/show_bug.cgi?id=31744 * Scripts/bugzilla-tool: * Scripts/modules/landingsequence.py: * Scripts/modules/webkitlandingscripts.py: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Move prepare_clean_working_directory into the LandingSequence https://bugs.webkit.org/show_bug.cgi?id=31743 * Scripts/bugzilla-tool: * Scripts/modules/landingsequence.py: 2009-11-20 Yael Aharon Reviewed by Kenneth Rohde Christiansen. NPN_ReloadPlugins does not reload the page even if reloadPages is true. https://bugs.webkit.org/show_bug.cgi?id=30460 Added code for calling NPN_ReloadPlugins with reloadPages true and false. * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke): 2009-11-20 Adam Barth Reviewed by Eric Seidel. Pass the port information to the child process https://bugs.webkit.org/show_bug.cgi?id=31736 We need to do this so the child process knows what to build! * Scripts/bugzilla-tool: * Scripts/modules/landingsequence.py: * Scripts/modules/webkitport.py: * Scripts/modules/webkitport_unittest.py: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Support Qt port in build-queue https://bugs.webkit.org/show_bug.cgi?id=31733 * Scripts/bugzilla-tool: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Implement a build-queue https://bugs.webkit.org/show_bug.cgi?id=31725 Currently this just builds the first 10 patches in the review queue. We'll want to do something smarter soon. * Scripts/bugzilla-tool: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Make commit-queue and style-queue show up in help https://bugs.webkit.org/show_bug.cgi?id=31724 We need to store their names on their class to make these commands properly register themselves with MultiCommandTool. * Scripts/bugzilla-tool: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Implement bugzilla-tool build-attachment https://bugs.webkit.org/show_bug.cgi?id=31722 This command builds an attachment from bugzilla. It leaves the built patch in the working copy. * Scripts/bugzilla-tool: * Scripts/modules/landingsequence.py: * Scripts/modules/webkitlandingscripts.py: 2009-11-20 Alejandro G. Castro Reviewed by Xan Lopez. [GTK] DRT release event does not create the state correctly https://bugs.webkit.org/show_bug.cgi?id=31717 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 2009-11-20 Eric Seidel Reviewed by Adam Barth. MultiCommandTool should find Command objects automatically instead of with a manual list https://bugs.webkit.org/show_bug.cgi?id=31710 * Scripts/bugzilla-tool: * Scripts/modules/multicommandtool.py: - Use some wild python-fu to crawl all the known subclasses of Command. 2009-11-20 Adam Barth Unreviewed "build" fix. Added missing import. * Scripts/bugzilla-tool: 2009-11-20 Adam Barth Unreviewed "build" fix. I failed to update LandingSequence.test properly. * Scripts/modules/landingsequence.py: 2009-11-20 Adam Barth Reviewed by Eric Seidel. Create LandingSequence as the all-sing, all-dance landing class https://bugs.webkit.org/show_bug.cgi?id=31709 Client can inherit from this class to carefully control exactly which steps they wish to have happen in the landing sequence. * Scripts/bugzilla-tool: * Scripts/modules/landingsequence.py: Added. * Scripts/modules/webkitlandingscripts.py: Added. 2009-11-19 Adam Barth Reviewed by Eric Seidel. Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand https://bugs.webkit.org/show_bug.cgi?id=31707 This is to help when we implement build-attachment. * Scripts/bugzilla-tool: 2009-11-19 Adam Barth Reviewed by Eric Seidel. Support Qt port in bugzilla-tool https://bugs.webkit.org/show_bug.cgi?id=31701 Now we support building with Qt! * Scripts/bugzilla-tool: * Scripts/modules/webkitport.py: Added. * Scripts/modules/webkitport_unittest.py: Added. * Scripts/run-webkit-unittests: 2009-11-19 Zoltan Horvath Reviewed by Adam Barth. Remove inserting stderr into patch in bugzilla-tool https://bugs.webkit.org/show_bug.cgi?id=29914 Modify SCM python module's run_command function to avoid return of stderr by default, so stderr won't be inserted into the patches. Modify the related unit test. * Scripts/modules/scm.py: * Scripts/modules/scm_unittest.py: 2009-11-19 Eric Seidel Reviewed by Adam Barth. bugzilla-tool needs per-command help https://bugs.webkit.org/show_bug.cgi?id=31697 Added support for "bugzilla-tool help command-name" and a unit test to make sure it works. * Scripts/modules/multicommandtool.py: * Scripts/modules/multicommandtool_unittest.py: 2009-11-19 Eric Seidel Reviewed by Adam Barth. Move MultiCommandTool and Command into a separate file and add some basic unit tests https://bugs.webkit.org/show_bug.cgi?id=31695 * Scripts/bugzilla-tool: * Scripts/modules/multicommandtool.py: Added. * Scripts/modules/multicommandtool_unittest.py: Added. * Scripts/run-webkit-unittests: 2009-11-19 Eric Seidel No review, just adding a FIXME. Split out command parsing and help printing from BugzillaTool https://bugs.webkit.org/show_bug.cgi?id=31688 * Scripts/bugzilla-tool: Add an extra comment about current design failures. 2009-11-19 Eric Seidel Reviewed by Adam Barth. Split out command parsing and help printing from BugzillaTool https://bugs.webkit.org/show_bug.cgi?id=31688 * Scripts/bugzilla-tool: - Add new MultiCommandTool class to contain option parsing and help printing logic. - Rename private methods to use _ pattern. - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command. - 2009-11-19 Eric Seidel Reviewed by Adam Barth. Re-factor help printing to use modern python idioms https://bugs.webkit.org/show_bug.cgi?id=31685 * Scripts/bugzilla-tool: 2009-11-19 Eric Seidel Reviewed by Darin Adler. commit-queue empty queue logs twice https://bugs.webkit.org/show_bug.cgi?id=31679 * Scripts/bugzilla-tool: 2009-11-19 Eric Seidel Reviewed by Darin Adler. bugzilla-tool's reviewer/committer rejection message should be clearer https://bugs.webkit.org/show_bug.cgi?id=31126 Add more explanatory prose to bugzilla-tool's flag permission rejection message. * Scripts/modules/bugzilla.py: 2009-11-19 Eric Z. Ayers Reviewed by Pavel Feldman. Forces a WM_PAINT event on calling layoutTestController.display() in order to enable the timeline-paint.html test on Windows. ::UpdateWindow() does not force an event becaue the window is not visible. https://bugs.webkit.org/show_bug.cgi?id=31402 * DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView): 2009-11-19 Michelangelo De Simone No review needed. Added myself to committers list. * Scripts/modules/committers.py: 2009-11-19 Adam Barth Reviewed by Eric Seidel. Bugzilla-tool command classes should match command names https://bugs.webkit.org/show_bug.cgi?id=31666 I renamed all the commands except CommitMessageForCurrentDiff because the new name would conflict with an existing class. * Scripts/bugzilla-tool: 2009-11-19 Pavel Feldman Reviewed by Gustavo Noronha Silva. Web Inspector: Implement "show inspector" in WebKit GTK API and enable console tests. https://bugs.webkit.org/show_bug.cgi?id=31669 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): 2009-11-19 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Minor refactoring + more documentation. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::clearHistory): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2009-11-19 Fumitoshi Ukai Reviewed by Eric Seidel. Ignore websocket tests when --no-http is specified. https://bugs.webkit.org/show_bug.cgi?id=31662 * Scripts/run-webkit-tests: 2009-11-18 Adam Barth Reviewed by Eric Seidel. Normalize ' and " in bugzilla-tool https://bugs.webkit.org/show_bug.cgi?id=31655 We decided " is better than ' and we should be consistent. * Scripts/bugzilla-tool: 2009-11-18 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. [Qt] Remove support for Qt v4.3 or older versions https://bugs.webkit.org/show_bug.cgi?id=29469 * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/ImageDiff.pro: 2009-11-18 Shinichiro Hamaji Reviewed by Eric Seidel. GitTest.test_create_binary_patch fails if /tmp is symlink https://bugs.webkit.org/show_bug.cgi?id=31536 * Scripts/modules/scm_unittest.py: 2009-11-18 Yaar Schnitman Reviewed by Darin Adler. Configuration for Chromium Build Slaves. https://bugs.webkit.org/show_bug.cgi?id=31442 * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2009-11-18 Eric Seidel Reviewed by Darin Adler. workqueue.py results in totally broken commit-queue UI https://bugs.webkit.org/show_bug.cgi?id=31645 * Scripts/bugzilla-tool: - Remove unneeded use of PatchCollection. - Grab a new copy of the cq'd patches every run of the queue. 2009-11-18 Sam Weinig Reviewed by Anders Carlsson. Make the Mac Geolocation API async. Update DRT to use the new async Mac Geolocation API. * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]): 2009-11-18 Laszlo Gombos Reviewed by Kenneth Rohde Christiansen. Add and option to toggle HTML5 datalist support to build-webkit https://bugs.webkit.org/show_bug.cgi?id=31599 * Scripts/build-webkit: 2009-11-18 Kevin Watters Reviewed by Kevin Ollivier. Enable wx plugin support using the Windows implementation as a base. https://bugs.webkit.org/show_bug.cgi?id=31636 * wx/build/settings.py: 2009-11-18 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Change the initialization order so that the controllers will be created before exporting them to the JS DOM window. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): 2009-11-18 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Fix a code copy and paste error. m_page should be page. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::createWindow): 2009-11-17 Mark Rowe Reviewed by Alexey Proskuryakov. WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file. This prevents symlinks from confusing the descendant check. 2009-11-17 Mark Rowe Reviewed by Alexey Proskuryakov. Failing to start the WebSocket server shouldn’t terminate entire test run If the WebSocket server fails to start have DRT load an error page in place of tests that require the server to be up rather than having run-webkit-tests abort immediately. * Scripts/run-webkit-tests: 2009-11-17 Eric Seidel Reviewed by Darin Adler. commit-queue is failing to set reviewer in ChangeLogs https://bugs.webkit.org/show_bug.cgi?id=31592 * Scripts/bugzilla-tool: Clarify the "applying" log message. * Scripts/modules/bugzilla.py: - Add a new _validate_committer_and_reviewer function as a temporary solution until we can make a real Attachment object which knows how to fill in its committer/reviewer fields automatically. 2009-11-17 Kenneth Rohde Christiansen Unreviewed buildbot fix. Revert part of earlier patch and add comment, as it was causing timeouts on the buildbot. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::notifyDone): 2009-11-17 Kenneth Rohde Christiansen Reviewed by Oliver Hunt. Make the timeout 15 sec as for the other DRT's and make it print out the same output when a test timeout. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::timerEvent): 2009-11-17 Joseph Pecoraro Reviewed by Timothy Hatcher. Fixed typos in comments. * Scripts/modules/committers.py: 2009-11-17 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: Make DRT show web inspector for tests in inspector/ folder. - Updated DRT to show/close inspector for all tests under /inspector - Introduced LayoutTestController::setTimelineProfilingEnabled and WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled - Removed reload on each inspector test - Renamed fast/inspector to fast/inspector-support in order not to trigger inspector for those. - Reimplemented timeline tests in order to get rid of reload there. - Moved tests that don't require harness into the fast group. https://bugs.webkit.org/show_bug.cgi?id=31472 * DumpRenderTree/LayoutTestController.cpp: (setTimelineProfilingEnabledCallback): (closeWebInspectorCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTimelineProfilingEnabled): * DumpRenderTree/mac/DumpRenderTree.mm: (shouldOpenWebInspector): (runTest): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTimelineProfilingEnabled): * DumpRenderTree/win/DumpRenderTree.cpp: (shouldOpenWebInspector): (runTest): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTimelineProfilingEnabled): 2009-11-17 Oliver Hunt Reviewed by Maciej Stachowiak. Incorrect use of JavaScriptCore API in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=31577 Return undefined rather than a literal null. * DumpRenderTree/AccessibilityUIElement.cpp: (setSelectedTextRangeCallback): (incrementCallback): (decrementCallback): (showMenuCallback): 2009-11-16 Chris Fleizach Reviewed by Beth Dakin. AX: aria-labelledby duplicates some of its WAI-ARIA label https://bugs.webkit.org/show_bug.cgi?id=31565 * DumpRenderTree/AccessibilityUIElement.cpp: (titleUIElementCallback): (getIsValidCallback): (AccessibilityUIElement::getJSClass): 2009-11-16 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. r50942 broke output from created windows. Make the m_enableTextOutput a member of the DRT and not the WebPage. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::javaScriptAlert): (WebCore::WebPage::javaScriptConsoleMessage): (WebCore::WebPage::javaScriptConfirm): (WebCore::WebPage::javaScriptPrompt): (WebCore::WebPage::acceptNavigationRequest): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::createWindow): * DumpRenderTree/qt/DumpRenderTree.h: (WebCore::DumpRenderTree::setTextOutputEnabled): (WebCore::DumpRenderTree::isTextOutputEnabled): (WebCore::WebPage::shouldInterruptJavaScript): (WebCore::WebPage::isTextOutputEnabled): (WebCore::WebPage::setViewGeometry): 2009-11-16 Kenneth Rohde Christiansen Reviewed by Gustavo Noronha Silva. Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin as the implementation is being used by at least Qt and Gtk+. Update buildsystems as well. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: * GNUmakefile.am: 2009-11-16 Yuzo Fujishima Reviewed by Alexey Proskuryakov. Disable wss until all platforms support pyOpenSSL https://bugs.webkit.org/show_bug.cgi?id=31479 * Scripts/run-webkit-tests: 2009-11-14 Antonio Gomes Reviewed by Kenneth Christiansen. [Qt] Implement load error pages support for Qt's DRT. https://bugs.webkit.org/show_bug.cgi?id=31509 For now, it will not be a default feature, and layout tests that want to make use of this have to explicitily call 'handleErrorPages();' for the test source. Any of the other DumpRenderTree's (mac, win and gtk) support handling error pages. Qt's will be the first. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::supportsExtension): (WebCore::WebPage::extension): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldHandleErrorPages): (LayoutTestController::handleErrorPages): 2009-11-16 Eric Seidel Reviewed by Adam Barth. Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment https://bugs.webkit.org/show_bug.cgi?id=31549 Renamed --commit-queue to --non-interactive in most places and remove the code in land-patches which is no longer needed. * Scripts/bugzilla-tool: 2009-11-16 Eric Seidel Reviewed by Adam Barth. The commit-queue should use land-attachment https://bugs.webkit.org/show_bug.cgi?id=31548 * Scripts/bugzilla-tool: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Convert CommitQueue over to PatchCollection https://bugs.webkit.org/show_bug.cgi?id=31547 Also fixes a bug in workqueue and adds a test! * Scripts/bugzilla-tool: * Scripts/modules/workqueue.py: * Scripts/modules/workqueue_unittest.py: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Move StyleQueue over to using PatchCollection https://bugs.webkit.org/show_bug.cgi?id=31544 That's what the class it's for. * Scripts/bugzilla-tool: * Scripts/modules/patchcollection.py: * Scripts/modules/patchcollection_unittest.py: 2009-11-16 Eric Seidel Reviewed by Adam Barth. bugzilla-tool needs a land-attachment command https://bugs.webkit.org/show_bug.cgi?id=31546 * Scripts/bugzilla-tool: - Move all the logic into AbstractLandingCommand and add a new LandAttachment command subclass. - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land. 2009-11-16 Eric Seidel Reviewed by Adam Barth. Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment https://bugs.webkit.org/show_bug.cgi?id=31543 Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'. * Scripts/bugzilla-tool: 2009-11-16 Eric Seidel Reviewed by Adam Barth. Disable the style queue from posting to the commit queue status page. * Scripts/bugzilla-tool: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Implement PatchCollection https://bugs.webkit.org/show_bug.cgi?id=31541 This class holds a set of patches and lets clients iterate through them. Optionally, clients can install a filter. * Scripts/modules/patchcollection.py: Added. * Scripts/modules/patchcollection_unittest.py: Added. * Scripts/run-webkit-unittests: 2009-11-16 Eric Seidel Reviewed by Adam Barth. bugzilla-tool land-patches will close bugs with patches r=? https://bugs.webkit.org/show_bug.cgi?id=28230 The commit-queue shouldn't close patches with outstanding reviews on them, even if many reviewers seem to be against multi-patch bugs. * Scripts/bugzilla-tool: 2009-11-16 Eric Seidel Reviewed by Adam Barth. bugzilla-tool check-style should work with attachment ids instead of bug ids https://bugs.webkit.org/show_bug.cgi?id=31540 * Scripts/bugzilla-tool: 2009-11-16 Eric Seidel Reviewed by Adam Barth. WorkQueue is the only place that should know about special exit codes https://bugs.webkit.org/show_bug.cgi?id=31534 Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error and add tests for handling exit codes. I also cleaned up workqueue_unittest.py more. * Scripts/bugzilla-tool: * Scripts/modules/workqueue.py: * Scripts/modules/workqueue_unittest.py: 2009-11-16 Eric Seidel Reviewed by Adam Barth. Re-factor workqueue_unittest to allow for more than one test. https://bugs.webkit.org/show_bug.cgi?id=31535 * Scripts/modules/workqueue_unittest.py: 2009-11-16 Eric Seidel Reviewed by Adam Barth. land-patches needs to be re-factored into smaller chunks https://bugs.webkit.org/show_bug.cgi?id=31532 * Scripts/bugzilla-tool: fix a couple obvious typos. 2009-11-16 Eric Seidel Reviewed by Adam Barth. land-patches needs to be re-factored into smaller chunks https://bugs.webkit.org/show_bug.cgi?id=31532 The next patch will move these methods into WebKitLandingScripts. * Scripts/bugzilla-tool: - Split out _land_patch and _close_bug_if_no_active_patches. 2009-11-16 Adam Barth Reviewed by Eric Seidel. Fix silly copy-and-paste code. I am a terrible coder. * Scripts/modules/bugzilla.py: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Implement a StyleQueue https://bugs.webkit.org/show_bug.cgi?id=31537 The first iteration of the style queue only produces output locally. There is also a limit of 10 patches because it's not that useful to iterate through the entire review queue at this point. We can remove the limit later. * Scripts/bugzilla-tool: * Scripts/modules/bugzilla.py: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Unit test WorkQueue https://bugs.webkit.org/show_bug.cgi?id=31531 Adds basic unit testing for WorkQueue. Just runs through one cycle. * Scripts/bugzilla-tool: * Scripts/modules/statusbot.py: * Scripts/modules/workqueue.py: * Scripts/modules/workqueue_unittest.py: Added. * Scripts/run-webkit-unittests: 2009-11-16 Eric Seidel Reviewed by Adam Barth. bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs https://bugs.webkit.org/show_bug.cgi?id=31530 * Scripts/bugzilla-tool: 2009-11-16 Eric Seidel Reviewed by Adam Barth. bugzilla-tool needs apply-attachment https://bugs.webkit.org/show_bug.cgi?id=31528 * Scripts/bugzilla-tool: - Add ApplyAttachment command. - Abstract applying code into WebKitApplyingScripts. - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional. * Scripts/modules/bugzilla.py: - Add fetch_attachment and bug_id_for_attachment_id. * Scripts/modules/bugzilla_unittest.py: - Add test for new parsing. - Fix previous parsing test which broke with Adam's check-style patch (bug 31515). 2009-11-16 Eric Seidel Reviewed by Adam Barth. Document check-style's use of force_clean. * Scripts/bugzilla-tool: * Scripts/modules/scm.py: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Move WorkQueue to its own file https://bugs.webkit.org/show_bug.cgi?id=31529 WorkQueue and WorkQueueDelegate are separate concerns from bugzilla-tool. Also added a missing include to logging.py. * Scripts/bugzilla-tool: * Scripts/modules/logging.py: * Scripts/modules/workqueue.py: 2009-11-16 Adam Barth Reviewed by Eric Seidel. Move OutputTee to logging.py. * Scripts/bugzilla-tool: * Scripts/modules/logging.py: 2009-11-15 Adam Barth Reviewed by Eric Seidel. Refactor bugzilla-tool to allow for multiple queues https://bugs.webkit.org/show_bug.cgi?id=31513 Divide the commit queue class into three class to make creating additional queues easier. * Scripts/bugzilla-tool: 2009-11-15 Shinichiro Hamaji Reviewed by Eric Seidel. svn-apply may not handle git patches created by bugzilla-tool https://bugs.webkit.org/show_bug.cgi?id=31457 * Scripts/modules/scm.py: * Scripts/modules/scm_unittest.py: 2009-11-15 Shinichiro Hamaji Reviewed by Eric Seidel. bugzilla-tool should post git binary diff https://bugs.webkit.org/show_bug.cgi?id=31458 Add --binary option to Git.create_patch. * Scripts/modules/scm.py: * Scripts/modules/scm_unittest.py: 2009-11-15 Adam Barth Reviewed by Darin Adler. Add bugzilla-tool check-style https://bugs.webkit.org/show_bug.cgi?id=31515 * Scripts/bugzilla-tool: * Scripts/modules/bugzilla.py: 2009-11-13 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Make the Qt Linux only --valgrind feature, suppress errors defined in the SuppressedValgrindErrors file. * Scripts/run-webkit-tests: 2009-11-13 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Set the locale to C and not to the current one in use on the system. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2009-11-13 Adam Roben Add support for http/tests/security/isolatedWorld/didClearWindowObject.html Fixes Tell the WebFrameLoadDelegate when window objects in isolated worlds are cleared Reviewed by Dave Hyatt. * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Added. Moved code here from -webView:didClearWindowObject:forFrame:. (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]): Added. Sets a __worldID property on the global object whose value is the ID of this world. (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]): Respond to this new delegate callback by calling through to one of the above new methods. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (worldMap): Added. Returns a HashMap containing all the worlds we've created. (worldIDForWorld): Added. Returns the ID for this world, or 0 if we haven't kept track of this world. (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap() instead of declaring our own. * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObject): Moved code from hear to didClearWindowObjectForFrameInStandardWorld. (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld): Respond to this new delegate callback by calling through to one of the below new methods. (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld): Added. Sets a __worldID property on the gobal object whose value is the ID of this world. (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): Added. Moved code here from didClearWindowObject. * DumpRenderTree/win/FrameLoadDelegate.h: Added the didClearWindowObjectForFrame* functions. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (worldMap): Added. Returns a HashMap containing all the worlds we've created. (worldIDForWorld): Added. Returns the ID of this world, or 0 if we haven't kept track of this world. (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap() instead of declaring our own. 2009-11-13 Adam Roben Finish replacing worldIDs with world objects The only remaining use of worldIDs was in a method only used by DRT for the isolated worlds tests. Fixes Replace worldIDs with world objects Reviewed by Mark Rowe. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::evaluateScriptInIsolatedWorld): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld): Updated for changes to WebFrame. Now holds the map of worldID -> world at this level instead of making WebKit do it. 2009-11-13 Tor Arne Vestbø Reviewed by Simon Hausmann. [Qt] Ensure the DRT does not output anything until first test is run * DumpRenderTree/qt/DumpRenderTree.cpp: * DumpRenderTree/qt/DumpRenderTree.h: 2009-11-13 Kenneth Rohde Christiansen Reviewed by Tor Arne Vestbø. Clear the undo stack in before each new test run. Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2009-11-13 Andras Becsi Reviewed by Kenneth Rohde Christiansen. [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::resetSettings): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): 2009-11-13 Eric Seidel Reviewed by Adam Barth. Update committers.py based on svn records https://bugs.webkit.org/show_bug.cgi?id=31366 This list was generated using validate-committer-lists from https://bugs.webkit.org/show_bug.cgi?id=30970 and makes committers.py current for committers who have committed in the last 3 years. * Scripts/modules/committers.py: 2009-11-12 Anantanarayanan G Iyengar Reviewed by Adam Barth. The document-open.html test was flaky at times. The test invokes the layout test plugin which in its destroy stream handler opens a new document. This basically tears down the stream and the associated plugin instance. The pluginLog function in the layout test plugin attempts to retrieve the window script object on a torn down plugin instance which crashed consistently on windows in the debugger. The functions which issue these logs already have a valid window script object. We now have variants of the pluginLog function which take in a window script object with and without variable arguments. https://bugs.webkit.org/show_bug.cgi?id=31067 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginLogWithWindowObject): (pluginLogWithWindowObjectVariableArgs): (pluginLog): (notifyTestCompletion): (testDocumentOpen): (testWindowOpen): 2009-11-12 Joanmarie Diggs Reviewed by Gustavo Noronha Silva. https://bugs.webkit.org/show_bug.cgi?id=30997 [Gtk] Implemment AtkDocument Added testing support. * DumpRenderTree/AccessibilityUIElement.cpp: * DumpRenderTree/AccessibilityUIElement.h: (getDocumentEncodingCallback): (getDocumentURICallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::documentEncoding): (AccessibilityUIElement::documentURI): 2009-11-12 Adam Roben Replace worldIDs with world objects Part of Implement new SPI for dealing with user scripts/stylesheets and isolated worlds Reviewed by Sam Weinig. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): Changed these functions to create a new WebJSWorld each time they're called and to pass that world to WebKit. 2009-11-11 Chris Fleizach Reviewed by Oliver Hunt. need to implement aria tree roles https://bugs.webkit.org/show_bug.cgi?id=31284 * DumpRenderTree/AccessibilityUIElement.cpp: (disclosedRowAtIndexCallback): (selectedRowAtIndexCallback): (isEqualCallback): (isAttributeSettableCallback): (isActionSupportedCallback): (disclosedByRowCallback): (hierarchicalLevelCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::isEqual): * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::hierarchicalLevel): (AccessibilityUIElement::disclosedRowAtIndex): (AccessibilityUIElement::selectedRowAtIndex): (AccessibilityUIElement::disclosedByRow): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::disclosedRowAtIndex): (AccessibilityUIElement::selectedRowAtIndex): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::disclosedByRow): (AccessibilityUIElement::hierarchicalLevel): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::hierarchicalLevel): (AccessibilityUIElement::disclosedRowAtIndex): (AccessibilityUIElement::selectedRowAtIndex): (AccessibilityUIElement::disclosedByRow): 2009-11-11 Shinichiro Hamaji Reviewed by Darin Adler. svn-apply can not handle git binary diffs https://bugs.webkit.org/show_bug.cgi?id=26830 Support "literal" type git binary diffs. * Scripts/VCSUtils.pm: * Scripts/modules/scm_unittest.py: * Scripts/svn-apply: 2009-11-11 Dmitry Titov Not reviewed, removing duplicate entry for myself in committers.py. * Scripts/modules/committers.py: 2009-11-11 Alexey Proskuryakov Reviewed by Darin Adler and Mark Rowe. https://bugs.webkit.org/show_bug.cgi?id=31200 Tests in http/tests/security/mixedContent start to fail when new tests are added * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug. 2009-11-11 Gustavo Noronha Silva Reviewed by Jan Alonzo. Create, and display a window for the inspector, for inspector tests. Need to also show/hide the inspector window to avoid having problems with code assuming it is realized https://bugs.webkit.org/show_bug.cgi?id=31347 * DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorShowWindow): (webInspectorCloseWindow): (webInspectorInspectWebView): (createWebView): 2009-11-11 Kenneth Rohde Christiansen Unreviewed Qt buildbot fix. My previous fix was wrong, so revert that change and fix it by returning when the document of the frame has no document element. Idea is borrowed from mac and win DRT. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dumpFramesAsText): 2009-11-11 Eric Seidel Reviewed byg Kenneth Rohde Christiansen. Update Kenneth's committer record to include the email he uses on lists.webkit.org. * Scripts/modules/committers.py: 2009-11-11 Eric Seidel Reviewed by Gustavo Noronha Silva. Several committers use separate email addresses for bugzilla and svn.webkit.org https://bugs.webkit.org/show_bug.cgi?id=31364 Update records for existing committers to include email addresses used in svn.webkit.org and lists.webkit.org. Most committers use the same email address in all 3 places, but some use separate addresses. committers.py needs record of each of these addresses. * Scripts/modules/committers.py: 2009-11-11 Eric Seidel No review, adding second email address for an existing committer. Add Yong Li's second bugzilla account to his committer record. See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27 * Scripts/modules/committers.py: 2009-11-11 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. If the frame has no innerText don't append it, and do not add a newline which breaks some cross platform results. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dumpFramesAsText): 2009-11-11 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Implement missing functionality in the Gtk/Qt TestNetscapePlugin. * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_destroy_instance): (webkit_test_plugin_destroy_stream): 2009-11-11 Kenneth Rohde Christiansen Reviewed by Mark Rowe. Implement the functionality needed by plugins/window-open.html * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): (webkit_test_plugin_set_window): 2009-11-11 Tor Arne Vestbø Reviewed by Simon Hausmann. [Qt] Force -graphicssystem raster and -style windows when running DRT * DumpRenderTree/qt/main.cpp: * Scripts/run-webkit-tests: 2009-11-11 Tor Arne Vestbø Reviewed by Simon Hausmann. Compute correct library paths for Qt * Scripts/webkitdirs.pm: 2009-11-10 Mark Rowe Reviewed by Sam Weinig. Tests in http/tests/security/mixedContent start to fail when new tests are added The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error about the validity of the self-signed certificates used in the regression tests. We would then add the host to the ignore list for SSL certificate errors and retry the request. If this happened during a test that had enabled frame load delegate logging this would result in extra log messages being generated, causing the test to fail. We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any tests. * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): 2009-11-10 Andras Becsi Reviewed by Kenneth Rohde Christiansen. [Qt] Remove obsolete scrollbar policy settings from DRT constructor. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): 2009-11-10 Philippe Normand Reviewed by Jan Alonzo. [GTK] Remove WebSocket configuration from WebKitWebSettings https://bugs.webkit.org/show_bug.cgi?id=31244 Follow-up of r50724. Don't set the enable-web-socket property anymore. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-11-10 Oliver Hunt Reviewed by Maciej Stachowiak. Rename 3D Canvas related classes to use WebGL prefix https://bugs.webkit.org/show_bug.cgi?id=29095 Checkin new version of do-webcore-rename used to do the WebGL type rename, and upate webkitdirs script to new method of testing for WebGL. * Scripts/do-webcore-rename: * Scripts/webkitdirs.pm: 2009-11-09 Oliver Hunt Reviewed by Geoff Garen. Make do-webcore-rename work with git. * Scripts/do-webcore-rename: 2009-11-09 Simon Hausmann Adding Kenneth to the reviewers list. * Scripts/modules/committers.py: 2009-11-09 Martin Robinson Reviewed by Jan Alonzo. [GTK] Expose Page::tabKeyCyclesThroughElements in the API https://bugs.webkit.org/show_bug.cgi?id=30482 LayoutTestControllerGtk now uses the exposed Page::tabKeyCyclesThroughElements API * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTabKeyCyclesThroughElements): 2009-11-08 Shu Chang Reviewed by Holger Freyther. [Qt] Added support for key code 8 (backspace) in EventSenderQt. This helps to pass the test case below. Also replaced hardcoded code numbers with defined constants. https://bugs.webkit.org/show_bug.cgi?id=31185 Test: editing/undo/undo-deleteWord.html * DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown): 2009-11-07 Antonio Gomes Reviewed by Holger Freyther. [Qt] [DRT] Fix wrong logic in LayoutTestController processWork https://bugs.webkit.org/show_bug.cgi?id=31164 Fixed wrong logic to assume WorkQueue is done in QT's DRT. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::processWork): 2009-11-05 Antonio Gomes Reviewed by Holger Freyther. [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method https://bugs.webkit.org/show_bug.cgi?id=31158 By invoking a script queue'd by queueScript(), 'true' was beeing returned always, which from WorkQueue prospective means that a load has been started and the queue processing should stop and wait for the load to finish. Spinning it off into a loading and a non-loading variants was the solution adopted by Mac's DRT to work around this problem. The former keeps returning 'true' while the later executes the script synchronously and returns 'false' making it possible to the WorkQueue to proceed right away. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::processWork): (LayoutTestController::queueLoadingScript): (LayoutTestController::queueNonLoadingScript): * DumpRenderTree/qt/LayoutTestControllerQt.h: * DumpRenderTree/qt/WorkQueueItem.h: (LoadingScriptItem::LoadingScriptItem): (LoadingScriptItem::invoke): (NonLoadingScriptItem::NonLoadingScriptItem): (NonLoadingScriptItem::invoke): 2009-11-07 Mark Rowe Rubber-stamped by Cameron Zwarich. Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH. * Scripts/commit-log-editor: 2009-11-07 Mark Rowe Reviewed by Darin Adler. Fix . commit-log-editor does not support all the email address configurations that prepare-Changelog supports Move logic for determining the name and email address to use in a ChangeLog entry from prepare-ChangeLog to VCSUtils so that commit-log-editor can use it. It wants to check whether the author of the patch matches committer, and therefore needs access to the email address that would be used in a ChangeLog entry. Based on a patch by Pierre d'Herbemont. * Scripts/VCSUtils.pm: * Scripts/commit-log-editor: * Scripts/prepare-ChangeLog: * Scripts/webkitdirs.pm: 2009-11-06 Anantanarayanan G Iyengar Reviewed by Adam Barth. Added functionality to the layout test plugin to invoke document.open and window.open with default arguments. The associated webkit bug is https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't work in Chromium (V8) if there is no calling javascript context. To achieve this effect we invoke these functions in the layout test plugin in the NPP_SetWindow for the window.open test case and in NPP_DestroyStream for the document.open test case. * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testDocumentOpen): (testWindowOpen): (pluginAllocate): * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetWindow): (NPP_DestroyStream): * DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): 2009-11-06 Eric Seidel Reviewed by Adam Barth. bugzilla-tool crashed with exception https://bugs.webkit.org/show_bug.cgi?id=31092 * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error. 2009-11-04 Eric Seidel No review, just add a line which got left out of the patch uploaded for commit. commit-queue is crashing when trying to reject patches after unknown failures https://bugs.webkit.org/show_bug.cgi?id=31091 * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash. 2009-11-04 Adam Roben Remove bogus else clause in bugzilla-tool Fixes REGRESSION (r47121): bugzilla-tool create-bug raises exception after entering bug description Reviewed by David Kilzer. * Scripts/bugzilla-tool: (CreateBug): else clauses are only hit if no exception is raised, so it makes no sense to try to re-raise the exception in an else clause. The exception will automatically be re-raised if it doesn't match any of the except clauses, so we don't have to do anything special here at all to get the desired behavior. 2009-11-04 Eric Seidel Reviewed by David Kilzer. svn-apply's fixChangeLogPatch function seems broken https://bugs.webkit.org/show_bug.cgi?id=30683 Update fixChangeLogPatch to be able to handle patches which don't start at line 1. Add unit tests for svn-apply to scm_unittest.py. * Scripts/VCSUtils.pm: * Scripts/modules/scm_unittest.py: 2009-11-04 Chris Fleizach Reviewed by Beth Dakin. Need to implement ARIA role="combobox" https://bugs.webkit.org/show_bug.cgi?id=31096 * DumpRenderTree/AccessibilityUIElement.cpp: (showMenuCallback): (getIsExpandedCallback): (AccessibilityUIElement::getJSClass): * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu): * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu): * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isSelected): (AccessibilityUIElement::isExpanded): (AccessibilityUIElement::showMenu): 2009-11-04 Eric Seidel Reviewed by Adam Barth. commit-queue is crashing when trying to reject patches after unknown failures https://bugs.webkit.org/show_bug.cgi?id=31091 * Scripts/bugzilla-tool: - patch['id'] was a copy/paste mistake. This code has no 'patch' variable so we have to find out what the current patch is by asking bugzilla again. - Discovered that this code was also leaking file descriptors, so fixed that. 2009-11-04 Adam Roben Make run-webkit-tests work for the Debug_Internal Windows configuration In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug suffix. Fixes . Reviewed by Sam Weinig. * Scripts/run-webkit-tests: Don't add the _debug suffix in Debug_Internal, either. 2009-11-04 Eric Seidel Reviewed by Adam Barth. committers.py needs a way to store non-bugzilla email addresses https://bugs.webkit.org/show_bug.cgi?id=31037 Make Committer and Reviewer constructors take a single email or a list of emails. Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email. Expose reviewers(), used by validate-committer-lists on bug 30970. * Scripts/modules/committers.py: * Scripts/modules/committers_unittest.py: Added tests for the new code. 2009-11-03 Yuzo Fujishima Reviewed by David Levin. Start/Stop Web Socket and Web Socket Secure servers for layout tests. https://bugs.webkit.org/show_bug.cgi?id=27491 The test path determination logic is changed to handle websocket and websocket/ssl cases. The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement. Functions to start or stop Web Socket servers are added. * Scripts/run-webkit-tests: 2009-11-03 Eric Seidel No review, just changing wording of log message. Change log string to say "failed" instead of "rejected" when a commit fails due to an out of date checkout. This makes grepping the commit-queue log for rejected patches easier. * Scripts/bugzilla-tool: 2009-11-03 Eric Seidel No review, adding commonly known committers missing from the file. * Scripts/modules/committers.py: Add committers found by looking at SVN records. 2009-11-03 Eric Seidel No review, just sort-order cleanup. * Scripts/modules/committers.py: Sort committers/reviewers alphabetically. 2009-11-03 Stephen White (Unreviewed). Add myself to committers.py. * Scripts/modules/committers.py: 2009-11-03 Robin Dunn Reviewed by Kevin Ollviier. Add packaging scripts for Debian-based Linux distros. https://bugs.webkit.org/show_bug.cgi?id=31075 * wx/packaging/build-debian-installer.py: Added. * wx/packaging/debian: Added. 2009-11-03 Dan Bernstein Reviewed by Anders Carlsson and Beth Dakin. https://bugs.webkit.org/show_bug.cgi?id=31070 Added an 'ondestroy' parameter to the test plug-in. When the plug-in is destroyed, it executes the value of the 'ondestroy' parameter as a script. * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate): Initialize onDestroy. * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define onDestroy. * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if specified. (NPP_Destroy): Execute the value of 'ondestroy' as a script. 2009-11-02 Joanmarie Diggs Reviewed by Xan Lopez. https://bugs.webkit.org/show_bug.cgi?id=31035 [GTK] some accessibility tests hitting assertion in debug builds Get the correct Gtk+ object before attempting to turn it into an AtkObject. * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::rootElement): 2009-11-02 Chris Fleizach Reviewed by Beth Dakin. Support ARIA "tab" roles https://bugs.webkit.org/show_bug.cgi?id=30842 * DumpRenderTree/AccessibilityUIElement.cpp: * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 2009-11-01 Eric Seidel Reviewed by David Levin. buildbots should use --exit-after-N-failures https://bugs.webkit.org/show_bug.cgi?id=30809 Make the bots exit after 20 failures to prevent never-ending test runs where every test spends a minute crashing. * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2009-11-01 Laszlo Gombos Reviewed by Eric Seidel. Turn on warnings for QtWebKit for gcc https://bugs.webkit.org/show_bug.cgi?id=30958 * DumpRenderTree/qt/main.cpp: (crashHandler): Mark function NO_RETURN 2009-11-01 Jessie Berlin Adding myself to the committers list. * Scripts/modules/committers.py: 2009-10-30 Jon Honeycutt Fix an issue that Adam noticed in DRT. Reviewed by Darin Adler. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::role): Get the length of the role text, and create a buffer dynamically. 2009-10-30 Eric Seidel No review, rolling out r50105. http://trac.webkit.org/changeset/50105 This commit was causing: https://bugs.webkit.org/show_bug.cgi?id=30869 We'll re-implement the feature a different way. * Scripts/bugzilla-tool: 2009-10-29 Jon Honeycutt Test for MSAA: Accessibility of headings is not correct https://bugs.webkit.org/show_bug.cgi?id=30937 Reviewed by Adam Roben. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::role): Allow the role returned to be a BSTR. (AccessibilityUIElement::description): Fix a copy/paste error. 2009-10-29 Jon Honeycutt Test for MSAA: Accessibility of links is wrong https://bugs.webkit.org/show_bug.cgi?id=30928 Reviewed by Darin Adler. * DumpRenderTree/AccessibilityUIElement.cpp: (getAccessibilityValueCallback): Return the accessibility value. (AccessibilityUIElement::getJSClass): Added "accessibilityValue" value. * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::accessibilityValue): Stubbed. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::accessibilityValue): Stubbed. * DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::accessibilityValue): Get the object's value, and return it as a JS string. 2009-10-30 Kevin Ollivier Fix typo in command name used by wx build system. * wx/build/build_utils.py: 2009-10-30 Adam Barth Reviewed by Darin Adler. Patch v1 is a dumb default name for patches https://bugs.webkit.org/show_bug.cgi?id=30952 Let's use "Patch" instead. * Scripts/bugzilla-tool: 2009-10-30 Andras Becsi Unreviewed trivial buildfix. [Qt] Buildfix for r50333. * DumpRenderTree/qt/DumpRenderTree.pro: 2009-10-30 Antonio Gomes Reviewed by Holger Freyther. [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue https://bugs.webkit.org/show_bug.cgi?id=30953 DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch makes qt DRT to share this implementation (as gtk and mac ports do). * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/WorkQueue.cpp: Removed. * DumpRenderTree/qt/WorkQueue.h: Removed. 2009-10-30 Kenneth Rohde Christiansen Unreviewed potential buildbot fix. Second try: Reset page history before running each test. Apparently the QWebHistory::clear() keeps the current page in history which is not what we want, so we not additionally sets the history capacity to 0 (forces removing everything) and then sets it back to its original value. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2009-10-30 Kenneth Rohde Christiansen Unreviewed potential buildbot fix. Reset page history before running each test. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): 2009-10-30 Roland Steiner Reviewed by Eric Seidel. Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak. Bug 28420 - Implement HTML5 rendering (https://bugs.webkit.org/show_bug.cgi?id=28420) No new tests (no functional change). * Scripts/build-webkit: 2009-10-29 Dan Bernstein Reviewed by Mark Rowe. Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine from the two scripts that define it but don’t use it to the script that uses it but doesn’t define it. * Scripts/VCSUtils.pm: * Scripts/svn-apply: * Scripts/svn-unapply: 2009-10-29 Xan Lopez Reviewed by Gustavo Noronha. Use the GTK+ main loop instead of rolling our own mini-version of it. * DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): (runTest): (webViewLoadFinished): 2009-10-29 Kenneth Rohde Christiansen Reviewed by Oliver Hunt. Implement the Qt version of DRT dumpBackForwardList(). * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::dumpHistoryItem): (WebCore::DumpRenderTree::dumpBackForwardList): 2009-10-29 Kenneth Rohde Christiansen Reviewed by Adam Roben. Implement DRT functionality for Qt introduced in r28690 and r28705. - Implemented pathToLocalResource which exposes the functionality of converting a given unix path to the correct location on Windows. - Implemented a way to remove machine-dependent information from paths in layout test results. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::urlSuitableForTestResult): (WebCore::WebPage::javaScriptConsoleMessage): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pathToLocalResource): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2009-10-28 Roland Steiner Adding myself to the committers list. * Scripts/modules/committers.py: 2009-10-28 Chris Fleizach Adding myself to the committers list. * Scripts/modules/committers.py: 2009-10-28 Gustavo Noronha Silva Reviewed by Jan Alonzo. [GTK] API to start inspector for a WebView https://bugs.webkit.org/show_bug.cgi?id=22551 Use the new inspector API to implement the LayoutTestController interfaces used to test the inspector. * DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorInspectWebView): (createWebView): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): 2009-10-28 Shinichiro Hamaji Reviewed by Eric Seidel. [Qt] WebFrame::counterValueForElementById must not be exposed https://bugs.webkit.org/show_bug.cgi?id=30882 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById): 2009-10-28 Kenneth Rohde Christiansen Rubberstamped by Oliver Hunt. Fix the warning: "warning: ignoring return value of 'char* getcwd(char*, size_t)', declared with attribute warn_unused_result". by actually checking the result. In the case it is null, an error has occoured, so treat it as the other fatal errors. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::initializeFonts): 2009-10-27 Shinichiro Hamaji Reviewed by Darin Adler. Provide a way to get counter values with layoutTestContoller https://bugs.webkit.org/show_bug.cgi?id=30555 Define layoutTestContoller.counterValueForElementById. * DumpRenderTree/LayoutTestController.cpp: (counterValueForElementByIdCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::counterValueForElementById): 2009-10-27 Kenneth Rohde Christiansen Rubberstamped by Oliver Hunt. Change two methods to be internal for DRT use only. Part of [Qt] Review all new API in Qt 4.6 https://bugs.webkit.org/show_bug.cgi?id=29843#c11 * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::whiteListAccessFromOrigin): 2009-10-27 Eric Seidel Reviewed by Adam Barth. REGRESSION: svn-apply exits(1) when applying a patch with a file add https://bugs.webkit.org/show_bug.cgi?id=30826 * Scripts/svn-apply: - Add () around all system() calls. - Use the correct system() == 0 or die instead of system() or die - Add descriptive messages to all die statements. 2009-10-27 Steve Block Reviewed by NOBODY. Adds steveblock@google.com to list of committers. * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers. 2009-10-27 Eric Seidel Reviewed by Adam Barth. svn-apply can exit(0) even on patch failure https://bugs.webkit.org/show_bug.cgi?id=29622 * Scripts/svn-apply: - Add a bunch of "or die" statements, hopefully catching all possible cases where failure could still exit(0). 2009-10-27 Eric Seidel Reviewed by Adam Barth. svn-* scripts should share code through VCSUtils.pm https://bugs.webkit.org/show_bug.cgi?id=30791 Just moving code into a shared location. * Scripts/VCSUtils.pm: * Scripts/prepare-ChangeLog: * Scripts/resolve-ChangeLogs: * Scripts/svn-apply: * Scripts/svn-create-patch: * Scripts/svn-unapply: * Scripts/update-webkit: 2009-10-27 Vadim Zeitlin Suppress a huge number of MSVC warnings when building wxWebKit. * wx/build/settings.py: 2009-10-26 Eric Seidel No review, just adding Mike Belshe to the committers list. * Scripts/modules/committers.py: 2009-10-26 Laszlo Gombos Reviewed by Darin Adler. Make .rc files compile on Windows without depending on MFC headers https://bugs.webkit.org/show_bug.cgi?id=30750 * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use windows.h instead of afxres.h because it exists even when MFC is not installed, and is all that's needed here. * FindSafari/FindSafari.rc: Ditto 2009-10-24 Eric Seidel Reviewed by Adam Barth. bugzilla-tool post-diff should know how to mark commit-queue=? https://bugs.webkit.org/show_bug.cgi?id=29202 * Scripts/bugzilla-tool: - Add --commit-queue option to post-diff, post-commits and create-bug. * Scripts/modules/bugzilla.py: - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch. - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch. 2009-10-23 Eric Seidel Reviewed by Adam Barth. bugzilla-tool commit-queue does not notice modifications to committers.py https://bugs.webkit.org/show_bug.cgi?id=30084 * Scripts/bugzilla-tool: - Make commit-queue re-exec itself instead of using while(1). - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch. - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too). 2009-10-22 Eric Seidel Reviewed by Adam Barth. commit-queue will get stuck on patches if land-patches terminates unexpectedly https://bugs.webkit.org/show_bug.cgi?id=30634 * Scripts/bugzilla-tool: - Add a way for land-patches to exit(2) to indicate an error, but one it has handled. - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'. 2009-10-26 Yuzo Fujishima Reviewed by Eric Seidel. Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example. https://bugs.webkit.org/show_bug.cgi?id=30763 * pywebsocket/mod_pywebsocket/__init__.py: * pywebsocket/mod_pywebsocket/dispatch.py: * pywebsocket/mod_pywebsocket/headerparserhandler.py: * pywebsocket/mod_pywebsocket/standalone.py: * pywebsocket/setup.py: * pywebsocket/test/test_dispatch.py: 2009-10-26 Carol Szabo Reviewed by David Levin. REGRESSION: 2 failures in run-webkit-unittests https://bugs.webkit.org/show_bug.cgi?id=30645 * Scripts/modules/cpp_style_unittest.py: Fixed a few test scenarios which apparently lost some spaces from text literals. 2009-10-26 Kevin Ollivier wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit. * Scripts/webkitdirs.pm: 2009-10-26 Csaba Osztrogonác Reviewed by Darin Adler. Unification of using null device in perl scripts. https://bugs.webkit.org/show_bug.cgi?id=30572 * Scripts/VCSUtils.pm: * Scripts/bisect-builds: * Scripts/resolve-ChangeLogs: * Scripts/run-iexploder-tests: * Scripts/run-jsc: * Scripts/run-mangleme-tests: * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: Using File::Spec->devnull() instead of hard coded /dev/null. 2009-10-26 Eric Seidel Reviewed by Holger Freyther. Reviewers are missing from committers.py https://bugs.webkit.org/show_bug.cgi?id=30733 * Scripts/modules/committers.py: 2009-10-23 Eric Seidel No review, only adding Alice to the list of reviewers. * Scripts/modules/committers.py: 2009-10-23 Eric Seidel Reviewed by Eric Carlson. fast/media/mq-transform-02.html failed on Leopard Commit Bot https://bugs.webkit.org/show_bug.cgi?id=30700 * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Update QuickTime version check. 2009-10-23 Kevin Ollivier wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get character measurement APIs that are private on Tiger. * wx/build/settings.py: 2009-10-22 Gavin Barraclough Reviewed by NOBODY (build fix). Build fix following bug #30696. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld): 2009-10-22 Gavin Barraclough Reviewed by Sam Weinig & Geoff Garen. https://bugs.webkit.org/show_bug.cgi?id=30696 Enable isolated-worlds tests on mac. Add private interface for DRT to invoke execution in a given world. * DumpRenderTree/LayoutTestController.cpp: (evaluateScriptInIsolatedWorldCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::evaluateScriptInIsolatedWorld): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld): 2009-10-21 Eric Seidel Reviewed by Adam Barth. bugzilla-tool's "patch failed to download an apply" error should give more information https://bugs.webkit.org/show_bug.cgi?id=30632 * Scripts/modules/scm.py: - Use the common run_command method instead of custom POpen code. - Make run_command know how to take pipes as input. * Scripts/modules/scm_unittest.py: - Add new tests to cover change. - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times. 2009-10-21 Kent Tamura Unreviewed. Adding myself to the committers list. * Scripts/modules/committers.py: 2009-10-21 Robin Dunn Reviewed by Kevin Ollivier. Update the Windows installer builder to work with Vista / Win 7 and with git. https://bugs.webkit.org/show_bug.cgi?id=30649 * wx/build/build_utils.py: * wx/packaging/build-mac-installer.py: * wx/packaging/build-win-installer.py: * wx/packaging/wxWebKitInstaller.iss.in: 2009-10-21 Alejandro G. Castro Reviewed by Gustavo Noronha. [GTK] Added conditional code to avoid using gdk_window_get_root_coords if we do not have a gtk+ release newer than 2.17.3. https://bugs.webkit.org/show_bug.cgi?id=30636 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 2009-10-21 Shu Chang Reviewed by Eric Seidel. [Qt] Added dummy implementation for keepWebHistory() https://bugs.webkit.org/show_bug.cgi?id=30592 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::keepWebHistory): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2009-10-21 Alejandro G. Castro Reviewed by Xan Lopez. [GTK] Fixed the double click condition, it is not double click if we move in just in one direction. https://bugs.webkit.org/show_bug.cgi?id=30636 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 2009-10-21 Alejandro G. Castro Reviewed by Xan Lopez. [GTK] Initialize the events completly before emitting them. https://bugs.webkit.org/show_bug.cgi?id=30633 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 2009-10-21 Kevin Ollivier wx build fix. Fix for when linking using --as-needed with gcc. * wx/browser/wscript: 2009-10-21 Kevin Ollivier wxMac 10.4 build fix. Build and link against a version of libcurl new enough to support all the features used by CURL backend. * wx/build/settings.py: * wx/install-unix-extras: 2009-10-20 Anton Muhin Reviewed by Adam Barth. Add {ager,antonm,yurys}@chromium.org into committers.py https://bugs.webkit.org/show_bug.cgi?id=30560 * Scripts/modules/committers.py: 2009-10-20 Kenneth Rohde Christiansen Reviewed by Tor Arne Vestbø. Make the Netscape Test plugin available to the Qt launcher. * Scripts/run-launcher: 2009-10-20 Fumitoshi Ukai Reviewed by David Levin. Removed WebSocket runtime settings. https://bugs.webkit.org/show_bug.cgi?id=29896 WebSocket runtime configuration is supported by chromium/v8 only. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-10-19 Nate Chapin Reviewed by Adam Barth. Add testFail() to test plugin so we can test our handling of a plugin invoke call returning false. https://bugs.webkit.org/show_bug.cgi?id=30239 * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail(). (pluginInvoke): (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown. 2009-10-19 Zan Dobersek Reviewed by Gustavo Noronha. Enable DOM pasting when running layout tests. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-10-18 Kenneth Rohde Christiansen Reviewed by Simon Hausmann. Use the setPreferredContentsSize method instead of setFixedContentsSize, as the method has been renamed. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setFixedContentsSize): 2009-10-16 Steve Falkenburg Reviewed by Dan Bernstein. https://bugs.webkit.org/show_bug.cgi?id=30456 Fixes for new Debug_All Windows build configuration. * DumpRenderTree/win/DumpRenderTree.cpp: (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming. * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX. 2009-10-16 Eric Seidel Reviewed by Adam Barth. commit-queue status bot should list which buildbot is blocking the queue https://bugs.webkit.org/show_bug.cgi?id=30452 Add new methods and testing. * Scripts/bugzilla-tool: * Scripts/modules/buildbot.py: * Scripts/modules/buildbot_unittest.py: 2009-10-16 Eric Seidel Reviewed by Adam Barth. run-webkit-tests fails when CWD is not inside a WebKit checkout https://bugs.webkit.org/show_bug.cgi?id=30451 * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure. * Scripts/modules/scm_unittest.py: - Remove use of original_path (we don't need to restore the CWD). - Don't use '.' to find the webkit checkout, use __file__ instead. 2009-10-16 Steve Falkenburg Reviewed by Adam Roben. Add a Debug_All configuration to build entire stack as debug. Change Debug_Internal to: - stop using _debug suffix for all WebKit/Safari binaries - not use _debug as a DLL naming suffix - use non-debug C runtime lib. * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration. * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration. * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration. * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add missing debug.vsprops inherited property sheet. Add Debug_All configuration. * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all". * WinLauncher/WinLauncher.vcproj: Removed extraneous definitions inherited from vsprops. Add Debug_All configuration. 2009-10-16 Carol Szabo Reviewed by David Levin. check-webkit-style is wrong about indent checking in namespaces in header files and a few other things https://bugs.webkit.org/show_bug.cgi?id=30362 The few other things include: + check-webkit-style does not require spaces around the equal sign inside 'if' statements and around binary operators that take numeric literals. + check-webkit-style reports false errors for the / operator when part of a filename in the #include directive. * Scripts/modules/cpp_style.py: Improved indentation checking and space checking around binary operators. While the checks are still not perfect, they are clearly better than before. * Scripts/modules/cpp_style_unittest.py: Added test cases for the newly supported checks and modified old test cases to match the new guidelines 2009-10-16 Kevin Ollivier wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp. * wx/build/settings.py: 2009-10-15 Yuzo Fujishima Reviewed by David Levin. Add mod_pywebsocket to test Web Sockets. http://code.google.com/p/pywebsocket/ https://bugs.webkit.org/show_bug.cgi?id=27490 * pywebsocket/COPYING: Added. * pywebsocket/MANIFEST.in: Added. * pywebsocket/README: Added. * pywebsocket/example/echo_client.py: Added. * pywebsocket/example/echo_wsh.py: Added. * pywebsocket/mod_pywebsocket/__init__.py: Added. * pywebsocket/mod_pywebsocket/dispatch.py: Added. * pywebsocket/mod_pywebsocket/handshake.py: Added. * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added. * pywebsocket/mod_pywebsocket/msgutil.py: Added. * pywebsocket/mod_pywebsocket/standalone.py: Added. * pywebsocket/mod_pywebsocket/util.py: Added. * pywebsocket/setup.py: Added. * pywebsocket/test/config.py: Added. * pywebsocket/test/mock.py: Added. * pywebsocket/test/run_all.py: Added. * pywebsocket/test/test_dispatch.py: Added. * pywebsocket/test/test_handshake.py: Added. * pywebsocket/test/test_mock.py: Added. * pywebsocket/test/test_msgutil.py: Added. * pywebsocket/test/test_util.py: Added. * pywebsocket/test/testdata/handlers/blank_wsh.py: Added. * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added. * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added. * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added. * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added. * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added. * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added. * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added. 2009-10-15 James Robinson Reviewed by David Levin. Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file. https://bugs.webkit.org/show_bug.cgi?id=30426 * Scripts/modules/cpp_style.py: * Scripts/modules/cpp_style_unittest.py: 2009-10-15 Brian Weinstein Reviewed by Adam Roben. Fixes . REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows. Added a check for isChromium() in pdevenv, and pass /useenv if we are not building Chromium. * Scripts/pdevenv: 2009-10-15 Robin Dunn Reviewed by Kevin Ollivier. Add Mac package building scripts for wx. https://bugs.webkit.org/show_bug.cgi?id=30405 * wx/build/build_utils.py: * wx/build/settings.py: * wx/packaging/build-mac-installer.py: Added. 2009-10-15 Zan Dobersek Reviewed by Gustavo Noronha. Enable Web Sockets support when running layout tests. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-10-15 Xan Lopez Reviewed by Gustavo Noronha. Need to initialize event.button.button, since in most cases a button number is not passed as an argument. * DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): (mouseUpCallback): 2009-10-15 Kevin Ollivier wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to the OS if none was explicitly set. * wx/build/settings.py: 2009-10-14 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: enable developers extras within inspector layout tests. https://bugs.webkit.org/show_bug.cgi?id=30014 * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): 2009-10-14 José Millán Soto Reviewed by Jan Alonzo. GtkLauncher is using a deprecated signal https://bugs.webkit.org/show_bug.cgi?id=30364 Modified GtkLauncher to use notify::title signal instead of deprecated title-changed signal * GtkLauncher/main.c: (notify_title_cb): (create_browser): 2009-10-14 Brady Eidson Reviewed by Sam Weinig. Don't set the history delegate on new windows that are opened during a test, as the history delegate: 1 - Disables WebHistory 2 - Doesn't make sense in that context anyway. * DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): 2009-10-14 Kevin Ollivier wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET. * wx/build/settings.py: * wx/install-unix-extras: 2009-10-14 Brady Eidson Reviewed by Sam Weinig. WebKit Win API should provide a delegate interface for global history. https://bugs.webkit.org/show_bug.cgi?id=29905 * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpHistoryDelegateCallbacks): (LayoutTestController::setDumpHistoryDelegateCallbacks): * DumpRenderTree/win/DumpRenderTree.cpp: (shouldLogHistoryDelegates): (runTest): (createWebViewAndOffscreenWindow): (main): * DumpRenderTree/win/DumpRenderTree.vcproj: Add the IWebHistoryDelegate to DRT Windows: * DumpRenderTree/win/HistoryDelegate.cpp: Added. (wstringFromBSTR): (HistoryDelegate::HistoryDelegate): (HistoryDelegate::~HistoryDelegate): (HistoryDelegate::QueryInterface): (HistoryDelegate::AddRef): (HistoryDelegate::Release): (HistoryDelegate::didNavigateWithNavigationData): (HistoryDelegate::didPerformClientRedirectFromURL): (HistoryDelegate::didPerformServerRedirectFromURL): (HistoryDelegate::updateHistoryTitle): (HistoryDelegate::populateVisitedLinksForWebView): * DumpRenderTree/win/HistoryDelegate.h: Added. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::removeAllVisitedLinks): 2009-10-14 Shu Chang Reviewed by Simon Hausmann. [Qt] Implement support for setPOSIXLocale on Qt. https://bugs.webkit.org/show_bug.cgi?id=30268 * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPOSIXLocale): * DumpRenderTree/qt/LayoutTestControllerQt.h: 2009-10-13 Stephanie Lewis Unreviewed, adding myself to reviewers list. * Scripts/modules/committers.py: 2009-10-13 Stephanie Lewis Reviewed by Mark Rowe. Fix null assignment so root tests work again. * Scripts/webkitdirs.pm: 2009-10-13 Andras Becsi Reviewed by Simon Hausmann. [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes out of jsobjects into separate files to get a more structured DumpRenderTree implementation. This is done in preparation of implementing missing features in DRT. No functionality changes made yet. * DumpRenderTree/qt/DumpRenderTree.cpp: * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/EventSenderQt.cpp: Added. (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::keyDown): (EventSender::contextClick): (EventSender::scheduleAsynchronousClick): (EventSender::frameUnderMouse): * DumpRenderTree/qt/EventSenderQt.h: Added. (EventSender::clearKillRing): * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::windowCount): (LayoutTestController::clearBackForwardList): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::provisionalLoad): (LayoutTestController::timerEvent): (LayoutTestController::encodeHostName): (LayoutTestController::decodeHostName): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setFixedContentsSize): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::disableImageLoading): (LayoutTestController::dispatchPendingLoadRequests): (LayoutTestController::setDatabaseQuota): (LayoutTestController::clearAllDatabases): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::waitForPolicyDelegate): (LayoutTestController::overridePreference): * DumpRenderTree/qt/LayoutTestControllerQt.h: Added. (LayoutTestController::isLoading): (LayoutTestController::setLoading): (LayoutTestController::shouldDumpAsText): (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::shouldDumpChildrenAsText): (LayoutTestController::shouldDumpDatabaseCallbacks): (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::shouldWaitUntilDone): (LayoutTestController::canOpenWindows): (LayoutTestController::shouldDumpTitleChanges): (LayoutTestController::waitForPolicy): (LayoutTestController::dumpAsText): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpDatabaseCallbacks): (LayoutTestController::dumpStatusCallbacks): (LayoutTestController::setCanOpenWindows): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::display): (LayoutTestController::dumpTitleChanges): (LayoutTestController::dumpSelectionRect): * DumpRenderTree/qt/TextInputControllerQt.cpp: Added. (TextInputController::TextInputController): (TextInputController::doCommand): * DumpRenderTree/qt/TextInputControllerQt.h: Added. * DumpRenderTree/qt/WorkQueue.cpp: * DumpRenderTree/qt/WorkQueue.h: * DumpRenderTree/qt/WorkQueueItem.h: * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added. (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files * DumpRenderTree/qt/jsobjects.h: 2009-10-13 Dmitry Titov Not reviewed, adding myself to the list of reviewers. * Scripts/modules/committers.py: 2009-10-13 Anders Carlsson Reviewed by Sam Weinig. Add "privacy mode" to Netscape Plug-in API Make the private browsing mode testable by the test plug-in. * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetValue): 2009-10-13 Pavel Feldman No review, just adding self to the list of reviewers. * Scripts/modules/committers.py: 2009-10-12 Pavel Feldman Reviewed by Adam Roben. Web Inspector: Use proper web view in inspector layout tests for windows. https://bugs.webkit.org/show_bug.cgi?id=30298 * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): 2009-10-12 Fumitoshi Ukai Reviewed by Sam Weinig. Enable experimentalWebSocket in DumpRenderTree for LayoutTest. https://bugs.webkit.org/show_bug.cgi?id=29841 * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-10-12 Yaar Schnitman Reviewed by Dimitri Glazkov. Chromium Port - Windows https://bugs.webkit.org/show_bug.cgi?id=29969 * Scripts/pdevenv: removed msvc's /useenv for chromium builds * Scripts/webkitdirs.pm: 2009-10-12 Csaba Osztrogonac Reviewed by Darin Adler. jsc scripts cleanup and Qt/GTK fix https://bugs.webkit.org/show_bug.cgi?id=30288 Duplicated jscPath() moved to webkitdirs.pm. New jscProductDir() added to webkitdirs.pm instead of duplicated codes. Configuration added (release/debug) to path for Qt-port on Windows. * Scripts/run-javascriptcore-tests: * Scripts/run-jsc: * Scripts/run-sunspider: * Scripts/sunspider-compare-results: * Scripts/webkitdirs.pm: 2009-10-11 Adam Barth Unreviewed. Add Collin to committers.py. * Scripts/modules/committers.py: 2009-10-11 Kevin Ollivier wx build fix, add bindings to source/include dirs now that there are sources there. * wx/build/settings.py: 2009-10-09 Mark Rowe Reviewed by Brady Eidson. Enable plug-in halting in DumpRenderTree. We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins. This is sufficient to ensure that the crash covered by no longer occurs. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:shouldHaltPlugin:]): 2009-10-08 Brady Eidson Reviewed by Dan Bernstein. Ask the History Delegate to populate the visited links hash. and https://webkit.org/b/29904 Add the ability for LayoutTestController to clear all visited links. Also lets the History Delegate dump visited links, but only if this test specifically cleared them. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (removeAllVisitedLinksCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::removeAllVisitedLinks): * DumpRenderTree/mac/HistoryDelegate.mm: (-[HistoryDelegate populateVisitedLinksForWebView:]): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::removeAllVisitedLinks): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::removeAllVisitedLinks): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::removeAllVisitedLinks): 2009-10-08 Daniel Bates Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=30175 The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return the OLE drag-and-drop return value like the function it emulates. Currently, UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine whether the drag-and-drop operation was successful or was cancelled. This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop return value according to whether the drop operation was successful or not. * DumpRenderTree/win/EventSender.cpp: (doMouseUp): Added parameter oleDragAndDropReturnValue. (replaySavedEvents): Ditto. * DumpRenderTree/win/EventSender.h: * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value. 2009-10-08 Alejandro G. Castro Reviewed by Xan Lopez. [GTK] Added support for a parameter setting the button that was pressed in the mouseDown function. https://bugs.webkit.org/show_bug.cgi?id=30220 * WebKitTools/DumpRenderTree/gtk/EventSender.cpp: 2009-10-08 Alejandro G. Castro Reviewed by Xan Lopez. [GTK] Added a line to the bottom of the expected result to match the output of the test. https://bugs.webkit.org/show_bug.cgi?id=30220 * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste- expected.txt: 2009-10-08 Adam Roben Use QueryInterface to get IWebInspectorPrivate Fixes Make IWebInspectorPrivate be accessed in a more standard way Reviewed by John Sullivan and Tim Hatcher. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::evaluateInWebInspector): Get the IWebInspector by calling IWebViewPrivate::inspector, then use QueryInterface to get to the IWebInspectorPrivate interface. 2009-10-07 Adam Roben Implement DRT support for origin whitelisting Fixes . Reviewed by Eric Seidel. * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Reset any origin whitelist, to match Mac DRT. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::whiteListAccessFromOrigin): Call through to IWebViewPrivate::whiteListAccessFromOrigin. 2009-10-07 Brady Eidson Reviewed by Darin Adler. Send title changes to the global history delegate. and https://webkit.org/b/29904 * DumpRenderTree/mac/HistoryDelegate.mm: (-[HistoryDelegate webView:updateHistoryTitle:forURL:]): 2009-10-07 Adam Barth Unreviewed. Remove some folks from committers.py who were listed on the WebKit Team wiki page but who weren't actually listed as commit+. At some point, we should coorelate this list with the committers mailing list. * Scripts/modules/committers.py: 2009-10-07 Adam Barth Unreviewed. Import a bunch of committers from the WebKit Team page on the wiki into committers.py. * Scripts/modules/committers.py: 2009-10-07 Adam Barth Unreviewed. Added Aaron Boodman to committers.py. * Scripts/modules/committers.py: 2009-10-07 Evan Martin Reviewed by Darin Adler. Add API to LayoutTestController for re/setting the system locale. https://bugs.webkit.org/show_bug.cgi?id=18994 * DumpRenderTree/LayoutTestController.cpp: (setLocaleCallback): (LayoutTestController::staticFunctions): (LayoutTestController::setLocale): * DumpRenderTree/LayoutTestController.h: 2009-10-06 Shinichiro Hamaji Reviewed by Jan Alonzo. [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts https://bugs.webkit.org/show_bug.cgi?id=29689 Build fix by adding -lfontconfig for DumpRenderTree. * GNUmakefile.am: 2009-10-07 Csaba Osztrogonac Reviewed by Simon Hausmann. Re-enable use-remote-links-to-tests for Qt. Disabled in r46416. * Scripts/run-webkit-tests: 2009-10-07 Xan Lopez Reviewed by Gustavo Noronha. "delete" in EventSender is the backspace key, not the delete one. * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): 2009-10-07 Xan Lopez Reviewed by Gustavo Noronha. getChildrenWithRange expects as last parameter the end index, not the length of the range. Correct this and clarify the variable names to reflect how the code works. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::getChildAtIndex): 2009-10-06 Mark Rowe Reviewed by Simon Fraser. update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the the fact we have already changed the working directory to the top of the open source tree. 2009-10-06 Julie Parent Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email, rather than my committer email. * Scripts/modules/committers.py: 2009-10-06 Jakub Wieczorek Reviewed by Eric Seidel. [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset(). r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset it after each layout test as it should do, making the DRT dump additional output for all of the subsequent layout tests. * DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): 2009-10-06 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the fast/dom/assign-to-window-status.html test, which is passing as a result. https://bugs.webkit.org/show_bug.cgi?id=30127 * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::statusBarMessage): * DumpRenderTree/qt/DumpRenderTree.h: * DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpStatusCallbacks): (LayoutTestController::dumpStatusCallbacks): 2009-10-06 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown() ignores the argument indicating which mouse button to trigger. https://bugs.webkit.org/show_bug.cgi?id=30048 This affects the fast/events/mouse-click-events.html layout test. * DumpRenderTree/qt/jsobjects.cpp: (EventSender::mouseDown): (EventSender::mouseUp): * DumpRenderTree/qt/jsobjects.h: 2009-10-06 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Fix the EventSender::keyDown() implementation https://bugs.webkit.org/show_bug.cgi?id=30043 It should post both a key press event and a key release event, just like other ports do. * DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown): 2009-10-05 Kevin Ollivier wx build fix. Add jpeg to the list of libs to link against. * wx/build/settings.py: 2009-10-05 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] EventSender::keyDown() cannot send function-key events. https://bugs.webkit.org/show_bug.cgi?id=30044 This affects the fast/events/keydown-function-keys.html layout test. * DumpRenderTree/qt/jsobjects.cpp: (EventSender::keyDown): 2009-10-05 Vadim Zeitlin Added --wx-compiler-prefix waf option to allow building wxWebKit with wxWidgets built using "nmake COMPILER_PREFIX=something-non-default". * wx/build/settings.py: * wx/build/wxpresets.py: 2009-10-05 Pavel Feldman Reviewed by Timothy Hatcher. Web Inspector: add testing harness for Web Inspector. https://bugs.webkit.org/show_bug.cgi?id=30010 * DumpRenderTree/LayoutTestController.cpp: (showWebInspectorCallback): (closeWebInspectorCallback): (evaluateInWebInspectorCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector): (LayoutTestController::evaluateInWebInspector): 2009-10-05 Tor Arne Vestbø Reviewed by Ariyha Hidayat. Pass arguments to system() as a string instead of array When passed as an array entries with a space fail to translate to two arguments to the child process, so instead of manually splitting all the entries in @buildArgs we pass the whole thing as a string instead. * Scripts/webkitdirs.pm: 2009-10-04 Carol Szabo Reviewed by David Levin. check-webkit-style misses whitespace errors for operators: <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||. https://bugs.webkit.org/show_bug.cgi?id=30021 * Scripts/modules/cpp_style.py: Added the operators mentioned above to the same list as == and !=. 2009-10-02 Julie Parent Unreviewed. Adding myself and Ojan Vafai as committers, because we are committers. * Scripts/modules/committers.py: 2009-10-02 Brian Weinstein Reviewed by Adam Roben. svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff, this will help the patch merging process when TryBots are used. * Scripts/svn-create-patch: 2009-10-02 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Implement layoutTestController.overridePreference(). https://bugs.webkit.org/show_bug.cgi?id=29970 * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::setPrivateBrowsingEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::overridePreference): * DumpRenderTree/qt/jsobjects.h: 2009-10-01 Chris Marrin Reviewed by Oliver Hunt. Turn on ENABLE_3D_CANVAS in TOT https://bugs.webkit.org/show_bug.cgi?id=29906 * Scripts/build-webkit: 2009-10-01 Kenneth Rohde Christiansen Rubberstamped by Simon Hausmann. Enable HTTP tests for Qt * Scripts/run-webkit-tests: 2009-10-01 Yaar Schnitman Reviewed by Dimitri Glazkov. build-webkit --chromium now also works on cygwin. https://bugs.webkit.org/show_bug.cgi?id=29973 * Scripts/webkitdirs.pm: 2009-10-01 Zoltan Horvath Reviewed by Simon Hausmann. [Qt] Don't use TCmalloc in DumpRenderTree https://bugs.webkit.org/show_bug.cgi?id=27029 Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT. * DumpRenderTree/qt/DumpRenderTree.pro: 2009-10-01 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Implement eventSender.scheduleAsynchronousClick(). https://bugs.webkit.org/show_bug.cgi?id=29931 * DumpRenderTree/qt/jsobjects.cpp: (EventSender::scheduleAsynchronousClick): * DumpRenderTree/qt/jsobjects.h: 2009-10-01 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove fast/events/open-window-from-another-frame.html from the Skipped list. https://bugs.webkit.org/show_bug.cgi?id=29930 * DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::setPopupBlockingEnabled): * DumpRenderTree/qt/jsobjects.h: 2009-09-30 Cameron McCormack Unreviewed. Added myself to the list of committers. * Scripts/modules/committers.py: 2009-09-30 Eric Seidel No review, just adding Geoff to the list of reviewers. * Scripts/modules/committers.py: 2009-09-30 Dan Bernstein Reviewed by Sam Weinig. Added the WebKit Layout Tests fonts that are referenced in LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added. * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added. 2009-09-30 Csaba Osztrogonac Reviewed by David Kilzer. Make sunspider scripts work on Windows platform. https://bugs.webkit.org/show_bug.cgi?id=29656 * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter. * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter. * Scripts/webkitdirs.pm: currentPerlPath() added. 2009-09-29 Brady Eidson Rubberstamped by Dan Bernstein. Fix license and some sorting in new files. * DumpRenderTree/mac/HistoryDelegate.h: * DumpRenderTree/mac/HistoryDelegate.mm: 2009-09-29 Yaar Schnitman Reviewed by David Kilzer. Fixed how error codes are handled. https://bugs.webkit.org/show_bug.cgi?id=29898 * Scripts/update-webkit: * Scripts/update-webkit-chromium: 2009-09-29 Brady Eidson Reviewed by John Sullivan. Updated way-out-of-date sorting throughout the dump methods/flags. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpAsPDFCallback): (dumpAsTextCallback): (dumpFrameLoadCallbacksCallback): (dumpResourceLoadCallbacksCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsText): (LayoutTestController::setDumpAsText): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::setDumpFrameLoadCallbacks): (LayoutTestController::dumpSelectionRect): (LayoutTestController::setDumpSelectionRect): (LayoutTestController::dumpSourceAsWebArchive): (LayoutTestController::setDumpSourceAsWebArchive): (LayoutTestController::dumpStatusCallbacks): (LayoutTestController::setDumpStatusCallbacks): (LayoutTestController::dumpTitleChanges): (LayoutTestController::setDumpTitleChanges): (LayoutTestController::dumpWillCacheResponse): (LayoutTestController::setDumpWillCacheResponse): 2009-09-29 Brady Eidson Reviewed by John Sullivan. WebKit Mac API should provide a delegate interface for global history. and https://webkit.org/b/29904 Adding the dumping of global history delegate callbacks. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL: * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (allocateGlobalControllers): (shouldLogFrameLoadDelegates): (shouldLogHistoryDelegates): (runTest): Dump history delegate callbacks: * DumpRenderTree/mac/HistoryDelegate.h: Added. * DumpRenderTree/mac/HistoryDelegate.mm: Added. (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]): (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]): (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]): 2009-09-29 Daniel Bates Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=28902 Fixes an issue where the drop effect returned by Window Dump Render Tree was always DROPEFFECT_NONE (since it was hard coded to do so). This patch corrects this issue by determining the actual drop effect performed by the corresponding drag-and-drop operation so that we can return it. * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect. (DraggingInfo::DraggingInfo): (DraggingInfo::performedDropEffect): Added method. (DraggingInfo::setPerformedDropEffect): Added method. * DumpRenderTree/win/EventSender.cpp: (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect. Moved delete draggingInfo to UIDelegate::doDragDrop. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect(). 2009-09-29 Dan Bernstein Reviewed by Adam Roben. Remove copying of unnecessary or nonexistent files from the ImageDiff post-build event. * DumpRenderTree/win/ImageDiff.vcproj: 2009-09-29 Csaba Osztrogonac Reviewed by David Kilzer. [Qt] Make build-webkit script work on Windows https://bugs.webkit.org/show_bug.cgi?id=29802 * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: - Removed unnecessary -p switch for mkdir on Windows. - Use canonical path, which uses slashes or backslashes depends on platform. - isWindows() only test for Windows and not for Cyqwin. 2009-09-29 Andras Becsi Reviewed by Simon Hausmann. Fix time measurement in build-webkit after refactoring done in r48853. * Scripts/build-webkit: 2009-09-29 Andras Becsi Reviewed by Tor Arne Vestbø. [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard. This fixes https://bugs.webkit.org/show_bug.cgi?id=19674. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): 2009-09-29 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Implement eventSender.contextClick(). https://bugs.webkit.org/show_bug.cgi?id=29821 * DumpRenderTree/qt/jsobjects.cpp: (EventSender::contextClick): * DumpRenderTree/qt/jsobjects.h: 2009-09-28 Fumitoshi Ukai Reviewed by Eric Seidel. Add experimentalWebSocketsEnabled in WebPreferences. https://bugs.webkit.org/show_bug.cgi?id=28941 * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-09-28 Yaar Schnitman Reviewed by David Kilzer. Integrated chromium port building into webkit tools update-webkit and build-webkit. https://bugs.webkit.org/show_bug.cgi?id=29749 * Scripts/build-webkit: When --chromium is specified, will build the chromium port (currently only Mac is supported). * Scripts/update-webkit: When --chromium is specified, delegates to update-webkit-chromium. * Scripts/webkitdirs.pm: Added chromium specific defs. * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch chromium port's dependencies and update its project files. 2009-09-28 Fumitoshi Ukai Unreviewed. Add myself to list of committers. * Scripts/modules/committers.py: 2009-09-27 Jakub Wieczorek Reviewed by Darin Adler. run-webkit-tests: Do not strip the metrics when there is no expected result for a test. https://bugs.webkit.org/show_bug.cgi?id=29771 * Scripts/run-webkit-tests: 2009-09-27 Jakub Wieczorek Reviewed by Simon Hausmann. [Qt] Implement layoutTestController.waitForPolicyDelegate. https://bugs.webkit.org/show_bug.cgi?id=25037 * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::acceptNavigationRequest): * DumpRenderTree/qt/DumpRenderTree.pro: * DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::reset): (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate): * DumpRenderTree/qt/jsobjects.h: (LayoutTestController::waitForPolicy): 2009-09-26 David Kilzer mark-bug-fixed: add -o|--open switch Reviewed by Eric Seidel. The -o|--open switch uses the open(1) command on Mac OS X to open the bug URL in the default web browser. If there are similar mechanisms on other platforms, they may be added later. * Scripts/mark-bug-fixed: (MarkBugFixed.__init__): Added -o|--open switch to list of parse options. (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging code into main() and extracted prompting code into _prompt_user_for_correctness(). (MarkBugFixed._open_bug_in_web_browser): Added. (MarkBugFixed._prompt_user_for_correctness): Added. (MarkBugFixed.main): Added logging code from _determine_bug_id_and_svn_revision(). Added code to call _open_bug_in_web_browser() if the switch is set. Added code to call _prompt_user_for_correctness() when needed. * Scripts/modules/bugzilla.py: (Bugzilla.short_bug_url_for_bug_id): Added. 2009-09-26 David Kilzer svn-unapply and svn-apply don't work when used outside multiple svn working directories Reviewed by Eric Seidel. Some users have a workflow where svn-create-patch, svn-apply and svn-unapply are used outside of multiple svn working directories. Instead of aborting the scripts in these cases, print a warning and assume that Subversion is being used. * Scripts/VCSUtils.pm: (determineVCSRoot): Call warn() instead of die() if both isGit() and isSVN() initially return false. Set $VCSUtils::isSVN to 1 to enforce the assumption about Subversion, then return determineSVNRoot(). * Scripts/svn-apply: Switch to using isGit() and isSVN() from VCSUtils.pm. They both already cache their values and checking here is redundant since determineVCSRoot() is called later. 2009-09-26 Zan Dobersek Reviewed by Gustavo Noronha. [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts https://bugs.webkit.org/show_bug.cgi?id=29689 Load test fonts through FontConfig before each test. This ensures a more proper rendering of the tests. * DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): (runTest): (main): * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf. * GNUmakefile.am: 2009-09-25 David Kilzer mark-bug-fixed: add -u|--update-only switch Reviewed by Eric Seidel. * Scripts/mark-bug-fixed: (MarkBugFixed.__init__): Added -u|--update-only switch to list of parse options. (MarkBugFixed.main): When -u|--update-only is specified, add a comment to the bug without marking it Resolved/Fixed. 2009-09-25 Darin Adler Reviewed by Geoffrey Garen. * Scripts/prepare-ChangeLog: Leave files from the script-tests directory out, just as we do for the resources directory. 2009-09-25 Adam Barth Unreviewed. Added Tony to committers.py because he's a committer now. * Scripts/modules/committers.py: 2009-09-25 Eric Seidel Reviewed by Simon Fraser. REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots https://bugs.webkit.org/show_bug.cgi?id=28624 Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): 2009-09-25 Eric Seidel Reviewed by Adam Barth. commit-queue should auto-retry patches which fail to commit due to out of date files https://bugs.webkit.org/show_bug.cgi?id=28316 * Scripts/bugzilla-tool: - Handle new CheckoutNeedsUpdate exception. * Scripts/modules/logging_unittest.py: - Call the ScriptError constructor correctly (this test had regressed). * Scripts/modules/scm.py: - Added the ability to define custom error handlers for run_command and added a commit_error_handler which throws CheckoutNeedsUpdate instead of ScriptError. - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible. * Scripts/modules/scm_unittest.py: - Added tests of new error handlers. 2009-09-25 Eric Seidel Reviewed by Adam Barth. commit-queue should give better feedback when failing a patch https://bugs.webkit.org/show_bug.cgi?id=29316 * Scripts/bugzilla-tool: - Update ScriptError uses to the new constructor format. - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output so that we can print to both stdout as well as an output buffer for error reporting. - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError. - Use e.message_with_output() when failing a patch (this is the real fix here). I also removed use of "This patch will require manual commit." as that's not always true. - Add missing word "bug" from log message. * Scripts/modules/scm.py: - Make ScriptError save a bunch more data so that error messages can be nicer. - Update ScriptError callers. 2009-09-24 John Gregg Reviewed by Eric Seidel. Enable switch for notifications (experimental) in Page Settings https://bugs.webkit.org/show_bug.cgi?id=28930 Now that desktop notifications are controlled by run-time switch, set that switch to true for DumpRenderTree. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::QueryInterface): 2009-09-24 Kevin Ollivier wx build fix. SnowLeopard fixes for Mac dependencies. * wx/build/build_utils.py: * wx/build/settings.py: * wx/install-unix-extras: 2009-09-24 Gustavo Noronha Silva Reviewed by Oliver Hunt. Add support for DRT to send mouse wheel events. https://bugs.webkit.org/show_bug.cgi?id=29348 [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally * DumpRenderTree/gtk/EventSender.cpp: (mouseWheelToCallback): 2009-09-17 Eric Seidel Reviewed by David Levin. commit-queue needs web-based status reporting https://bugs.webkit.org/show_bug.cgi?id=29307 Add a first-pass web-based status for the commit-queue. The bot is currently reachable at: http://webkit-commit-queue.appspot.com/ * CommitQueueStatus/app.yaml: Added. - Application description file required by App Engine. * CommitQueueStatus/filters/__init__.py: Added. - Required by python to treat 'filters' as a module. * CommitQueueStatus/filters/webkit_extras.py: Added. - Support for turning 'bug 123' and 'patch 123' into links. This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page). * CommitQueueStatus/index.html: Added. * CommitQueueStatus/index.yaml: Added. - Some auto-generated file from app engine. * CommitQueueStatus/queue_status.py: Added. - The core logic of this bot. We could eventually split this file out into pieces. * CommitQueueStatus/stylesheets/main.css: Added. - Some basic lame-o CSS to make the page look less awful. * CommitQueueStatus/update_status.html: Added. - The form that the commit-queue (or a human) can use to update the status. * Scripts/bugzilla-tool: - Add some very basic update_status calls. * Scripts/modules/statusbot.py: Added. - Knows how to post to the CommitQueueStatus web application. 2009-09-24 David Kilzer mark-bug-fixed: add -m|--comment switch Reviewed by Adam Roben. * Scripts/mark-bug-fixed: (MarkBugFixed.__init__): Added -m|--comment switch to list of parse options. (MarkBugFixed.main): When specified, prepend comment from -m|--comment command-line switch to the bug comment. 2009-09-24 Gustavo Noronha Silva Reviewed by Jan Alonzo. [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly https://bugs.webkit.org/show_bug.cgi?id=29693 Show the window, to be able to synthesize events correctly. * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): (main): 2009-09-24 Oliver Hunt Reviewed by NOBODY(rollout) Roll out r48712 as it is incorrect. * DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): 2009-09-24 Benjamin Poulain Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=29005 The indices of RuntimeArray should be enumerated like for a regular array. * DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]): 2009-09-23 David Kilzer Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool Reviewed by Darin Adler. Also fixed a bug where specifying a revision on the command-line as 'r12345' would fail. See . * Scripts/bugzilla-tool: Updated module import statements. (parse_bug_id): Removed. Moved to bugzilla.py. (bug_comment_from_svn_revision): Removed. Moved to comments.py. (bug_comment_from_commit_text): Removed. Moved to comments.py. (MarkBugFixed): Removed. Code moved to mark-bug-fixed. (BugzillaTool.__init__): Removed mark-fixed subcommand. * Scripts/mark-bug-fixed: Added. * Scripts/modules/bugzilla.py: (parse_bug_id): Added. Moved from bugzilla-tool. * Scripts/modules/comments.py: Added. (bug_comment_from_svn_revision): Added. Moved from bugzilla-tool. (bug_comment_from_commit_text): Added. Moved from bugzilla-tool. 2009-09-23 Marshall Culpepper Reviewed by Eric Seidel. jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return "false" in non-implemented stub for setAlwaysAcceptCookies. https://bugs.webkit.org/show_bug.cgi?id=29661 * DumpRenderTree/win/DumpRenderTree.vcproj: * DumpRenderTree/win/DumpRenderTree.cpp: 2009-09-23 Gustavo Noronha Silva Reviewed by Xan Lopez. [GTK] need to dump number of pending unload handlers https://bugs.webkit.org/show_bug.cgi?id=29685 Implement dumping of the number of pending unload handlers. The following tests will pass: fast/loader/unload-form-about-blank.html fast/loader/unload-form-post-about-blank.html fast/loader/unload-form-post.html fast/loader/unload-form.html fast/loader/unload-hyperlink.html fast/loader/unload-javascript-url.html fast/loader/unload-reload.html fast/loader/unload-window-location.html * DumpRenderTree/gtk/DumpRenderTree.cpp: (getFrameNameSuitableForTestResult): (webViewLoadFinished): 2009-09-22 Shinichiro Hamaji Reviewed by Eric Seidel. js tests should move into jstests subdirectory instead of resources/ https://bugs.webkit.org/show_bug.cgi?id=25880 Remove support of resources directory. * Scripts/make-script-test-wrappers: 2009-09-22 Eric Seidel No review, only fixing typo (missing space character). Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220 * Scripts/run-webkit-tests: 2009-09-22 Eric Seidel Reviewed by Darin Adler. run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC) https://bugs.webkit.org/show_bug.cgi?id=29220 * Scripts/run-webkit-tests: 2009-09-22 Eric Seidel Reviewed by David Kilzer. svn-apply can't handle single-line binary file additions https://bugs.webkit.org/show_bug.cgi?id=29100 Fixed the regexp and added a unit test. * Scripts/modules/scm_unittest.py: * Scripts/svn-apply: 2009-09-11 Eric Seidel Reviewed by David Kilzer. post-diff and post-commits should be able to find bug urls in ChangeLogs. https://bugs.webkit.org/show_bug.cgi?id=29206 * Scripts/bugzilla-tool: - Share common options by adding a PostDiffAsPatchToBug.posting_options() method. - Rename --no-comment to --add-log-as-comment and reverse behavior. Comments tend to just be noise. I'll eventually remove this argument if no one uses it. - Split out code into helper functions to try and make execute() more legible. - Make post-diff find the bug url in the ChangeLogs if not passed as an argument. - Fallback to bug urls in commit diffs, instead of just in commit messages, meaning post-commits will now find bug urls in ChangeLogs. 2009-09-21 Csaba Osztrogonac Reviewed by Maciej Stachowiak. --parse-only parameter wasn't passed to SunSpider/sunspider script. https://bugs.webkit.org/show_bug.cgi?id=29611 * Scripts/run-sunspider: Missing parameter passing added. 2009-09-20 David Kilzer run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module Reviewed by Mark Rowe. The require statement is like the use statement, except that it is run during script execution instead of during the 'BEGIN' phase. This makes it possible to change @INC before the require statement is run. See 'require' and 'use' in the perlfunc(1) manpage and 'BEGIN' in perlmod(1) manpage. * Scripts/run-webkit-tests: Replace eval statement with require statement. 2009-09-18 Kevin Ollivier wx build fixes. Fix the config name under git and allow users to specify their own waf install for experimenting with new versions. * Scripts/webkitdirs.pm: * wx/build/settings.py: 2009-09-18 Alex Milowski Reviewed by Maciej Stachowiak. Added checkWebCoreMathMLSupport and hasMathMLSupport to support checking for whether MathML tests should be run * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: 2009-08-28 Darin Adler Reviewed by Mark Rowe. Break more of run-webkit-tests into separate functions https://bugs.webkit.org/show_bug.cgi?id=29497 Some small steps toward improving run-webkit-tests. My goal is to refactor much more of the script into functions. Later we can add parallel test running to the tool. But better structure may help even if someone decides to translate this into another scripting language instead. * Scripts/run-webkit-tests: Break more pieces of the script into seprate functions. Added readSkippedFiles, findTestsToRun, and printResults functions. Removed custom code to skip results.html and instead just put it into the ignoredFiles hash. Fixed some indentation. Sorted function declarations, global variables, and options at the top of the file alphabetically so they're not in a semi-random order. 2009-09-17 Kevin Ollivier wx build fix, add missing dependency. * wx/browser/wscript: 2009-09-16 Mark Rowe Split the SnowLeopard build across a few machines. * BuildSlaveSupport/build.webkit.org-config/config.json: 2009-09-16 Kevin Ollivier wx build fix to support monolithic builds on Windows. * wx/build/wxpresets.py: 2009-09-16 Kevin Ollivier wx build fix, improve debug support and 2.9 support on MSW. * wx/build/settings.py: * wx/build/wxpresets.py: 2009-09-16 Gustavo Noronha Silva Blind try at fixing new test failure on Windows. * DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didReceiveTitle): 2009-09-15 Alex Milowski Reviewed by Tor Arne Vestbø. Added mathml toggle * Scripts/build-webkit: 2009-09-15 Kevin Ollivier wx build fix. Allow waf build to support Python < 2.6. * wx/build/waf_extensions.py: 2009-09-14 Chris Marrin Reviewed by Oliver Hunt. Add LayoutTests infrastructure to enable and disable webgl tests. https://bugs.webkit.org/show_bug.cgi?id=29254 * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: 2009-09-14 Simon Fraser Reviewed by Darin Adler. Add --iterations option to run-webkit-tests to repeat the tests N times https://bugs.webkit.org/show_bug.cgi?id=29263 When run with --iterations N, run-webkit-tests will repeat the tests N times. * Scripts/run-webkit-tests: 2009-09-14 Brady Eidson Not reviewed, maybe should've been: Cleaning up more Windows-specific fallout from the fix for: and https://bugs.webkit.org/show_bug.cgi?id=29160 * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Correct printf() formatter, and call the correct method to get the Sender. 2009-09-14 Jon Honeycutt GTK build fix. Unreviewed. * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::setLogScrollingStartEvents): 2009-09-11 Jon Honeycutt DRT/test part of WebKit should broadcast an MSAA event when jumping to a named anchor https://bugs.webkit.org/show_bug.cgi?id=28899 Reviewed by Adam Roben. * DumpRenderTree/AccessibilityController.cpp: (logScrollingStartEventsCallback): Turn on logging of scrolling start events. (AccessibilityController::getJSClass): Add a "logScrollingStartEvents" to the AccessibilityController's JS class definition. (AccessibilityController::resetToConsistentState): Turn off logging of scrolling start events. * DumpRenderTree/AccessibilityController.h: Declare setLogScrollingStartEvents(). Add a member for the scrolling start event hook. * DumpRenderTree/mac/AccessibilityControllerMac.cpp: (AccessibilityController::setLogScrollingStartEvents): Stubbed. * DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::AccessibilityController): Initialize the handle to 0. (logEventProc): Renamed from logFocusEventProc; now logs scrolling start events, too. Removed the assertion that the event is a focus event. Added a switch to print a message for focus, scrolling start, and other, unknown events. (AccessibilityController::setLogFocusEvents): Changed to use logEventProc. (AccessibilityController::setLogScrollingStartEvents): If turning logging off, unhook the scrolling start event hook, and clear the member holding the handle. If turning on, query for the root accessible, so that accessibility is enabled for the WebView, and call SetWinEventHook to setup an event hook using logEventProc as the callback function. 2009-09-14 Brady Eidson Windows build fix. * DumpRenderTree/LayoutTestController.cpp: (setAuthenticationPasswordCallback): (setAuthenticationUsernameCallback): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): 2009-09-14 Brady Eidson Reviewed by Alexey Proskuryakov. Safari 4 cannot be used to update firmware on Linksys routers. and https://bugs.webkit.org/show_bug.cgi?id=29160 Add the ability for DRT to handle authentication challenges. * DumpRenderTree/LayoutTestController.cpp: (setAuthenticationPasswordCallback): (setAuthenticationUsernameCallback): (setHandlesAuthenticationChallengesCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::handlesAuthenticationChallenges): (LayoutTestController::setHandlesAuthenticationChallenges): (LayoutTestController::authenticationUsername): (LayoutTestController::setAuthenticationUsername): (LayoutTestController::authenticationPassword): (LayoutTestController::setAuthenticationPassword): * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): * DumpRenderTree/win/ResourceLoadDelegate.h: 2009-09-12 Mark Rowe Reviewed by Dan Bernstein. Test for and . Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New. This is the trigger for both and . * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): 2009-09-14 Kevin Ollivier wx build fix for non-wxPython builds and a fix for errors when updating swig.py. * wx/build/build_utils.py: * wx/build/settings.py: 2009-09-14 Csaba Osztrogonac Reviewed by Tor Arne Vestbø. [Qt] Build fix for windows build. * Scripts/bisect-builds: Add missing paranthesis for tmpdir function. 2009-09-13 Kevin Ollivier Fix typo accidently landed in last commit. * wx/build/settings.py: 2009-09-13 Kevin Ollivier wx build fix, error out if using the wrong Python. * wx/build/settings.py: 2009-09-13 Xan Lopez Build fix for GTK+ < 2.14. Do not use gtk_widget_get_window, access the window directly through the struct. * DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback): 2009-09-13 Martin Robinson Reviewed by Xan Lopez and Jan Alonzo. [GTK] EventSender does not set 'window' property on synthesized GDK events https://bugs.webkit.org/show_bug.cgi?id=29169 Set the window property on synthesized GDK events in the GTK+ EventSender. * DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (keyDownCallback): 2009-09-12 Drew Wilson Reviewed by Mark Rowe. run-webkit-tests has a timeout value that is too low https://bugs.webkit.org/show_bug.cgi?id=29223 * Scripts/run-webkit-tests: Changed timeout value to 20 seconds to avoid timing out too early. 2009-09-11 Kevin Ollivier wx build fix. Mark dependencies as mandatory and declare which MSVC versions and architectures are supported for building wxWebKit. * wx/build/settings.py: 2009-09-11 Eric Seidel Reviewed by David Levin. bugzilla-tool rollout threw exception under svn https://bugs.webkit.org/show_bug.cgi?id=29211 * Scripts/modules/scm.py: add missing return, and convert number arguments to strings. * Scripts/modules/scm_unittest.py: add testing for this fix. 2009-09-11 Brian Weinstein Add myself to the committers list. * Scripts/modules/committers.py: 2009-09-11 Eric Seidel Reviewed by Adam Barth. bugzilla-tool land-patches should only fail-fast in --commit-queue mode https://bugs.webkit.org/show_bug.cgi?id=29201 * Scripts/bugzilla-tool: 2009-09-11 Adam Roben Make commit-log-editor move common prefixes to the top of the log Fies commit-log-editor should move common prefixes to the top of the commit log Reviewed by Darin Adler. * Scripts/commit-log-editor: Find and remove the longest common prefix ending in a double newline from each ChangeLog entry, then put that common prefix at the top of the commit log. (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds, removes, and returns the longest common prefix ending in a double newline from a hash of strings 2009-09-11 Eric Seidel Fix obvious typo in previous commit, no review. bugzilla-tool should automate rollouts https://bugs.webkit.org/show_bug.cgi?id=26715 * Scripts/bugzilla-tool: add back missing "scm" argument. 2009-09-11 Eric Seidel Reviewed by Adam Barth. bugzilla-tool should automate rollouts https://bugs.webkit.org/show_bug.cgi?id=26715 bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit. The --complete-rollout option will automatically land and update the bug. Eventually --complete-rollout will be default, but that will require more testing. This first pass is good enough for others to try and file bugs about. * Scripts/bugzilla-tool: - Move modified_changelogs into scm.py. - Move svn_revision_from_commit_text logic into scm.py. - Add RolloutCommit command. * Scripts/modules/bugzilla.py: - Add reopen_bug command used by RolloutCommit. * Scripts/modules/scm.py: - Add functions to support RolloutCommit. - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge). - Add a str() call so that svn_commit_log can take a numeric argument. - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead. - Made dry_run commits return something that svn_revision_from_commit_text can parse. * Scripts/modules/scm_unittest.py: - Add read_from_path for easy file reading. - Put test4 on a new line to make reverts work w/o conflict. - Add an "svn update" call so that the checkout revision matches the server revision. - Add tests for svn_revision_from_commit_text. - Add a simple test for apply_reverse_diff. - Add a new self.scm member and use it in the new tests (eventually other tests can use it too). - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected. 2009-09-11 Adam Roben Get user script/stylesheet tests running on Windows Fixes User script/stylesheet tests are skipped on Windows Reviewed by John Sullivan. * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations against comsuppw.lib so we can use _bstr_t. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include order, added #include of comutil.h for _bstr_t. (bstrT): Helper function to convert a JSStringRef to a _bstr_t. (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet): Implemented. Implementations were based on those in LayoutTestControllerMac.mm. 2009-09-10 David Kilzer run-webkit-tests: make -h show help Reviewed by Mark Rowe. * Scripts/run-webkit-tests: Updated to make -h switch show help. 2009-09-10 Fumitoshi Ukai Reviewed by Alexey Proskuryakov. Add WebCore/websockets directory in wx build system. https://bugs.webkit.org/show_bug.cgi?id=28038 * wx/build/settings.py: 2009-09-10 Martin Robinson [GTK] EventSender does not properly convert some keyDown strings https://bugs.webkit.org/show_bug.cgi?id=29119 Add more keyDown string to character code conversions for GTK+ EventSender. * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): 2009-09-09 Steve Block Reviewed by Maciej Stachowiak. Geolocation Coordinates::toString() prints bogus values for unspecified properties. https://bugs.webkit.org/show_bug.cgi?id=29080 * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list. 2009-09-09 Eric Seidel Reviewed by Eric Carlson. reviewer/committer lookups are backwards https://bugs.webkit.org/show_bug.cgi?id=29113 I also moved Eric Carlson from the committer list to the reviewer list now that he is one. * Scripts/modules/bugzilla.py: * Scripts/modules/committers.py: 2009-09-09 Cameron McCormack Reviewed by Eric Seidel. svn-unapply doesn't revert directories correctly https://bugs.webkit.org/show_bug.cgi?id=29065 * Scripts/svn-unapply: Make svnStatus consistently return status lines including a newline. * Scripts/svn-apply: Keep svnStatus in sync with the one in svn-unapply, in lieu of moving it to a common file. 2009-09-09 Cameron McCormack Reviewed by Eric Seidel. svn-apply doesn't handle changes to files copied to new directories properly https://bugs.webkit.org/show_bug.cgi?id=29059 * Scripts/svn-apply: Don't treat "--- revision 0" patches as being additions if we know that we've just copied a file to this name. 2009-09-09 Eric Seidel Reviewed by David Levin. commit-queue hangs if a builder has never built https://bugs.webkit.org/show_bug.cgi?id=29091 * Scripts/modules/buildbot.py: * Scripts/modules/buildbot_unittest.py: 2009-09-09 Zan Dobersek Reviewed by Gustavo Noronha. [GTK] DumpRenderTree needs eventSender object and implementation https://bugs.webkit.org/show_bug.cgi?id=25990 Implements most of the EventSender object's functionality for the DumpRenderTree tool. Implementation still lacks support for drag and drop tests and forward leaps. Based on work by Holger Hans Peter Freyther. * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Focus on the view before loading a new test. (webViewWindowObjectCleared): * DumpRenderTree/gtk/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (contextClickCallback): (updateClickCount): (mouseDownCallback): (mouseUpCallback): (mouseMoveToCallback): (beginDragWithFilesCallback): (replaySavedEvents): (keyDownCallback): (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback): (getClass): (makeEventSender): * DumpRenderTree/gtk/EventSender.h: Added. * GNUmakefile.am: Add build rules for EventSender. 2009-09-09 Daniel Bates Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=28953 Added pre- and post- build events so that on build failure, the file buildfailed is written to the directory $(WebKitOutputDir). * WinLauncher/WinLauncher.vcproj: 2009-09-09 Kenneth Rohde Christiansen Unreviewed. Add myself to list of committers. * Scripts/modules/committers.py: 2009-09-08 Eric Seidel Reviewed by David Levin. commit-queue gets stuck if a non-committer sets commit-queue+ or review+ https://bugs.webkit.org/show_bug.cgi?id=28605 https://bugs.webkit.org/show_bug.cgi?id=28916 * Scripts/bugzilla-tool: - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit" comment now that it's used for rejecting patches for invalid committers too. - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them. - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916. * Scripts/modules/bugzilla.py: - Make _parse_attachment_element not validate reviewer/committer. - Share flag parsing code in _parse_attachment_flag. - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails. - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not. - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction. * Scripts/modules/bugzilla_unittest.py: - Update this test to no longer expect committer/reviewer validation. * Scripts/modules/committers.py: - Return None on failed lookups instead of raising Exceptions. * Scripts/modules/committers_unittest.py: - Update tests to expect None returns instead of exceptions. 2009-09-09 David Kilzer Fix obvious copy-paste error in AccessibilityUIElement::clickPointY() Reviewed by Mark Rowe. No change to layout test results. * DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::clickPointY): Changed to return y value instead of x value. 2009-09-08 Dimitri Glazkov Reviewed by Mark Rowe. Reduce dglazkov's boboiness by properly concatenating revision value. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution rather than "+". 2009-09-08 Kevin Ollivier wxWebKit Python extension build fix - get swig.py if it doesn't exist. * wx/build/build_utils.py: 2009-09-08 Mark Rowe Fix an incorrect variable name in UpdateChromiumSource. * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2009-09-08 Mark Rowe Don't check for leaks on the release SnowLeopard builder. * BuildSlaveSupport/build.webkit.org-config/config.json: 2009-09-08 Mark Rowe Add a SnowLeopard release builder. * BuildSlaveSupport/build.webkit.org-config/config.json: 2009-09-08 David Levin Reviewed by Darin Adler. Remove end of line whitespace check from check-webkit-style. https://bugs.webkit.org/show_bug.cgi?id=29053 * Scripts/modules/cpp_style.py: 2009-09-08 Cameron McCormack Reviewed by Darin Adler. Fix DumpRenderTree build from clean tree on Tiger https://bugs.webkit.org/show_bug.cgi?id=28927 * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the DerivedSources/DumpRenderTree directory exists when building on Tiger. 2009-09-08 Kevin Ollivier wx build fix after introduction of platform/mock directory. * wx/build/settings.py: 2009-09-08 Yael Aharon Unreviewed. Add myself to list of committers. * Scripts/modules/committers.py: 2009-09-08 Laszlo Gombos Unreviewed. Add myself to list of committers. * Scripts/modules/committers.py: 2009-09-08 Cameron McCormack Reviewed by Darin Adler. prepare-ChangeLog too chatty on file additions https://bugs.webkit.org/show_bug.cgi?id=29019 * Scripts/prepare-ChangeLog: Omit description of added properties on newly added files. 2009-09-08 Steve Block Reviewed by Adam Barth. Adds a LayoutTestController method to set the permission state for Geolocation. This is required to use the mock Geolocation service for testing. https://bugs.webkit.org/show_bug.cgi?id=29027 * DumpRenderTree/LayoutTestController.cpp: Modified. (setDatabaseQuotaCallback): Modified. Style fix. (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state. (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController. * DumpRenderTree/LayoutTestController.h: Modified. (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state. (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set. (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state. * DumpRenderTree/mac/UIDelegate.mm: Modified. (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state. 2009-09-08 Laszlo Gombos Reviewed by Simon Hausmann. [Qt] QtWebKit single API to enable persistency https://bugs.webkit.org/show_bug.cgi?id=28682 Use the new enablePersistentStorage API instead of enabling all persistent features one-by-one. * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree): 2009-09-07 Andras Becsi Reviewed by Tor Arne Vestbø. Refactor --strict switch to --ignore-metrics and correct the implementation to make the feature usable on all platforms. https://bugs.webkit.org/show_bug.cgi?id=28907 run-webkit-tests --ignore-metrics strips the font related metrics from the actual and expected data before comparing them. In this way the render trees can be checked for obvious differences but a successful test implies by no means that the layout is actually correct. * Scripts/run-webkit-tests: 2009-09-07 Steve Block Reviewed by Adam Barth. Adds a mock Geolocation service. This will be used to provide predictable behavior of the Geolocation API for use in LayoutTests. Later changes will integrate the the mock Geolocation service with DumpRenderTree. https://bugs.webkit.org/show_bug.cgi?id=28264 * DumpRenderTree/LayoutTestController.cpp: Modified. (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service. (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service. (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController. * DumpRenderTree/LayoutTestController.h: Modified. * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified. (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service. (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service. 2009-09-07 Drew Wilson Reviewed by David Levin. Enable SHARED_WORKERS by default https://bugs.webkit.org/show_bug.cgi?id=28959 * Scripts/build-webkit: 2009-09-07 Kevin Ollivier wx build fixes for wx SVN trunk. * wx/build/settings.py: 2009-09-04 Kevin Ollivier wx build fix. Switch USE_ defines over to the compiler so that they can be checked by files not including config.h (like WebCorePrefix.h). * wx/build/settings.py: 2009-09-04 Adam Barth Unreviewed build fix. Update declaration of FrameLoadDelegate to reflect that IWebFrameLoadDelegatePrivate2 inherits from IWebFrameLoadDelegatePrivate. * DumpRenderTree/win/FrameLoadDelegate.h: 2009-09-04 Adam Barth Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=24696 Add testing instrumentation for mixed content. * DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:]): (-[FrameLoadDelegate webView:didRunInsecureContent:]): * DumpRenderTree/win/FrameLoadDelegate.cpp: (descriptionSuitableForTestResult): (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::didDisplayInsecureContent): (FrameLoadDelegate::didRunInsecureContent): * DumpRenderTree/win/FrameLoadDelegate.h: 2009-09-03 Kevin Watters Reviewed by Kevin Ollivier. [wx] Frames support https://bugs.webkit.org/show_bug.cgi?id=19041 * wx/build-wxwebkit: 2009-09-02 David Kilzer svn-apply --force doesn't actually work Reviewed by Eric Seidel. This fixes "svn-apply --force" and adds unit tests for the scm.apply_patch() method which uses this script. * Scripts/svn-apply: Created $globalExitCode variable that defaults to 0. Exit with a value of $globalExitCode when the script is finished. (applyPatch): Ignore a non-zero $exitCode if $force is true, but set $globalExitCode to $exitCode so that svn-apply exits with a non-zero status if any patches did not apply cleanly. Also print out the actual patch command if $force was not true. * Scripts/modules/scm.py: (scripts_directory): Added. Extracted from script_path(). (script_path): Extracted scripts_directory(). * Scripts/modules/scm_unittest.py: Import urllib. (SVNTestRepository.setup): Save the original working directory in test_object since this represents the WebKit repository from where the unit tests are run. (SCMTest): Created new super class to hold utility methods. (SCMTest._create_patch): Creates a patch file on disk and a dictionary for use with scm.svn_apply(). (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink back to WebKitTools/Scripts in the test repository so that scm.apply_patch() is able to find the svn-apply script. (SVNTest): Inherit from SCMTest instead of unittest.TestCase. (SVNTest.tearDown): Make sure to change directories back to the original_path before the next test. (SVNTest.test_apply_svn_patch): New test case for applying an svn patch with scm.apply_patch(). (SVNTest.test_apply_svn_patch_force): New test case for applying an svn patch with scm.apply_patch() that conflicts. (GitTest): Inherit from SCMTest instead of unittest.TestCase. (GitTest.tearDown): Make sure to change directories back to the original_path before the next test. (GitTest.test_apply_git_patch): New test case for applying a git patch with scm.apply_patch(). (GitTest.test_apply_git_patch_force): New test case for applying a git patch with scm.apply_patch() that conflicts. 2009-09-02 Tor Arne Vestbø Reviewed by Mark Rowe. [Qt] Add support for platform-spesific layout-test results For the Qt port we use the qt-[mac|linux|win] directories and then fall back to the generic qt directory for both test results and skipped list. * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: 2009-09-02 Laurent Cerveau Reviewed by David Kilzer. build-webkit script should print build time at end * Scripts/build-webkit: Added startTime and endTime variable so that the build time is computed and printed as part of the build message; display formatting has been separated in a dedicated subroutine. 2009-09-02 David Kilzer svn-create-patch should check if the repo path is the same when trying to find the root Reviewed by Eric Seidel. * Scripts/VCSUtils.pm: (determineSvnRoot): Added back check for repository root that was removed in r46134 when this code lived in svn-create-patch. It's necessary to check both the repository root and the repository UUID in case two different working directories are checked out from the same repository. 2009-09-02 Timothy Hatcher Use new 512x512 icons for nightly builds. Rubber-stamped by Mark Rowe. * WebKitLauncher/webkit.icns: 2009-09-02 Kevin Ollivier waf build fix. Remove local variable shadowing global. * wx/build/settings.py: 2009-09-02 Zan Dobersek Reviewed by David Kilzer. Calls exitStatus function from the main package where it is also defined. * Scripts/VCSUtils.pm: 2009-09-02 Kevin Ollivier waf build fixes for Windows/MSVC and Mac/Snow Leopard. * wx/browser/wscript: * wx/build/build_utils.py: * wx/build/settings.py: 2009-08-10 Kevin Ollivier Reviewed by Eric Seidel. Changes needed for build-webkit to support the waf build system for the wx port. https://bugs.webkit.org/show_bug.cgi?id=27619 * Scripts/build-webkit: * Scripts/run-launcher: * Scripts/webkitdirs.pm: 2009-09-02 David Kilzer With Subversion 1.6, update-webkit prompts on conflicts Reviewed by Eric Seidel. * Scripts/update-webkit: Added "--accept postpone" to @svnOptions when running with svn-1.6 or newer. 2009-09-02 David Kilzer Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer() Reviewed by Eric Seidel. * Scripts/VCSUtils.pm: (@EXPORT): Added &isSVNVersion16OrNewer. (svnVersion): Added. Internal method that gets the SVN version and caches it. (isSVNVersion16OrNewer): Added. Method that does the SVN 1.6 version check. * Scripts/prepare-ChangeLog: Switched to use new isSVNVersion16OrNewer() method. * Scripts/resolve-ChangeLogs: Ditto. * Scripts/svn-create-patch: Ditto. 2009-09-02 David Kilzer Clean up VCSUtils.pm Reviewed by Eric Seidel. * Scripts/VCSUtils.pm: Added proper package statement. Fixed indentation of BEGIN block. Listed each exported method on a line by itself. Added methods to the export list after adding the package statement. Sorted module variables. Moved definiton of $gitRoot next to other module variables. 2009-09-01 Tor Arne Vestbø Rubber-stamped by Simon Hausmann. [Qt] Fix layout-test plugins/plugin-javascript-access.html * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: 2009-09-02 Shinichiro Hamaji Reviewed by Eric Seidel. js tests should move into jstests subdirectory instead of resources/ https://bugs.webkit.org/show_bug.cgi?id=25880 make-script-wrappers supports both resources and script-tests directories. run-webkit-tests ignores files in script-tests. Move script tests of animations to check the new script is working. * Scripts/make-script-test-wrappers: * Scripts/run-webkit-tests: 2009-09-02 Szabo Carol Reviewed by David Levin. check-webkit-style uses python from /usr/bin instead of the PATH https://bugs.webkit.org/show_bug.cgi?id=28225 * Scripts/bugzilla-tool: * Scripts/check-webkit-style: * Scripts/run-webkit-unittests: * Scripts/update-sources-list.py: Changed the first line from #!/usr/bin/python to #!/usr/bin/env python which causes python to be invoked from the path location returned by "which python" when any of these scripts are launched. these are currently all the python scripts in WebKitTools/Scripts. 2009-09-01 David Kilzer bugzilla-tool post-commits posts commits backwards Reviewed by Adam Barth. * Scripts/modules/scm.py: (Git.commit_ids_from_commitish_arguments): Reverse the list of commits returned from git-rev-list since we always want to post the oldest patches first to bugs.webkit.org. * Scripts/modules/scm_unittest.py: (run): Added return statement to return the output now that we want it sometimes. (SVNTestRepository._setup_test_commits): Added a fourth commit so the GitTest.test_commitish_order() test has more commits to work with. (GitTest.test_commitish_order): Added unit test for change to Git.commit_ids_from_commitish_arguments() in scm.py. 2009-09-01 David Kilzer Implement bugzilla-tool mark-fixed Reviewed by David Levin. The mark-fixed subcommand is for those times when you don't use bugzilla-tool to commit a patch, but you want to use it to close the bug with a committed-revision message. * Scripts/bugzilla-tool: (bug_comment_from_svn_revision): Added. Extracted from bug_comment_from_commit_text(). (bug_comment_from_commit_text): Extracted bug_comment_from_svn_revision() from this method. (MarkBugFixed.__init__): Added. (MarkBugFixed._fetch_commit_log): Added. Retrieves the commit log from the last commit if no svn revision is specified, else the commit log for the specified svn revision. (MarkBugFixed._determine_bug_id_and_svn_revision): Added. Attempts to determine the bug id and svn revision if one or both were not defined on the command line. (MarkBugFixed.execute): Added. Adds a comment about the revision that fixed the bug and closes the bug. (BugzillaTool.__init__): Added mark-fixed subcommand. * Scripts/modules/bugzilla.py: (Bugzilla.fetch_title_from_bug): Added. Returns the title of a bug given a bug id. * Scripts/modules/scm.py: (SCM.strip_r_from_svn_revision): Added. Utility method to strip the leading 'r' from an svn revision. (SCM.svn_commit_log): Added. Subclasses must override. (SCM.last_svn_commit_log): Added. Subclasses must override. (SVN.svn_commit_log): Added. Returns svn log for a given revision. (SVN.last_svn_commit_log): Added. Uses svnversion to find the last commit in an svn working directory and then runs svn log. (Git.svn_commit_log): Added. Returns svn log for a given revision. (Git.last_svn_commit_log): Added. Runs git-svn-log with a limit of one log message. 2009-09-01 David Kilzer svn-apply --force doesn't actually work Reviewed by Brady Eidson. * Scripts/svn-apply: (applyPatch): Add "--force" to $options arrayref if $force is set. 2009-09-01 David Kilzer resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch Reviewed by Adam Roben. When git-filter-branch has been invoked to rewrite ChangeLog files on series of git commits, it changes directories into .git-rewrite/t before re-running resolve-ChangeLogs. This causes determineVCSRoot() in VCSUtils.pm to return ".git-rewrite/t", which causes that path to be prepended to all ChangeLog paths, which results in an error like this: error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git. Died at WebKitTools/Scripts/resolve-ChangeLogs line 376. The correct way to fix this is not to try to find the repository root when invoked by git-filter-branch. * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true, set $relativePath to '.' instead of calling chdirReturningRelativePath(determineVCSRoot()). (isInGitFilterBranch): Added. Checks for the existence of the MAPPED_PREVIOUS_COMMIT environment variable. 2009-09-01 Xan Lopez Reviewed by Gustavo Noronha. Add support for Fedora distros in the http tests https://bugs.webkit.org/show_bug.cgi?id=28263 Add detection code for Fedora distribution, and use the proper httpd conf file when needed. * Scripts/run-webkit-httpd: * Scripts/run-webkit-tests: * Scripts/webkitdirs.pm: 2009-09-01 Jan Michael Alonzo Reviewed by Eric Seidel. [Gtk] DRT needs implementation of overridePreference https://bugs.webkit.org/show_bug.cgi?id=28830 Implement overridePreference. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): (setDefaultsToConsistentStateValuesForTesting): (runTest): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (toWebSettingKey): (LayoutTestController::overridePreference): 2009-09-01 Joseph Pecoraro svn-[un]apply should change directories to the repository root before [un]applying Reviewed by Eric Seidel. Jump back and forth between the repository root directory (to apply) and the directory the script was run from (to find the patch). * Scripts/svn-apply: * Scripts/svn-unapply: 2009-08-31 Adam Roben Fall back to a Release version of Safari if a Debug one doesn't exist Reviewed by Sam Weinig. * Scripts/webkitdirs.pm: (safariPath): If the user is working with a Debug build, but there's no Debug version of Safari present, fall back to using a Release version of Safari. 2009-08-31 Adam Roben Make safariPath() work for Debug builds of Safari on Windows Reviewed by Sam Weinig. * Scripts/webkitdirs.pm: (safariPath): If the user is working with a Debug build, add the _debug suffix to Safari.exe. 2009-08-28 Eric Seidel Reviewed by Adam Barth. commit-queue needs a master process https://bugs.webkit.org/show_bug.cgi?id=28040 Add a bugzilla-tool commit-queue command Keeps per-bug logs, but doesn't yet upload them anywhere. * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue' * Scripts/modules/buildbot.py: remove noisy log message * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python 2009-08-28 Jan Michael Alonzo Reviewed by Gustavo Noronha. [GTK] Geolocation needs permission API before being enabled by default Build the Gtk port with geolocation enabled. This option is only enabled for the buildbot. The autotools option will be enabled by default once the permissions API is implemented. * Scripts/build-webkit: 2009-08-26 Cameron McCormack Reviewed by David Kilzer. Make prepare-ChangeLog notice property changes https://bugs.webkit.org/show_bug.cgi?id=28675 Make the generated ChangeLog entry include a short description of property changes if there were such changes. Also make prepare-ChangeLog not bail if the only changes are property changes. * Scripts/prepare-ChangeLog: 2009-08-26 Adam Barth Reviewed by Oliver Hunt. Don't let local files access web URLs https://bugs.webkit.org/show_bug.cgi?id=28480 A bunch of our LayoutTests rely on our old behavior, so we explicitly grant local files universal access during testing. Mainly, these tests involve making XMLHttpRequests for data URLs. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-08-26 John Gregg Reviewed by David Levin. Minor style correction and include fix for notifications https://bugs.webkit.org/show_bug.cgi?id=28745 * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: change to correct EnumStyle (DRTDesktopNotificationPresenter::checkNotificationPermission): 2009-08-26 David Levin Reviewed by Alexey Proskuryakov. XMLHttpRequest.withCredentials=false shouldn't save cookies. https://bugs.webkit.org/show_bug.cgi?id=28743 Added the support to the layout test controller on OSX and Windows (for CFNETWORK) to allow for changing the accept cookie policy. * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): Added a bool to track the state of accepting cookies. (setAlwaysAcceptCookiesCallback): Standard wrapper method to go from js to a C++ method. (LayoutTestController::staticFunctions): Added the setAlwaysAcceptCookies method to the js layoutTestController. * DumpRenderTree/LayoutTestController.h: (LayoutTestController::alwaysAcceptCookies): Returns the value. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies): Stub out method. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset the accept cookie to its default. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAlwaysAcceptCookies): Does the work for OSX to change the cookie accept policy. * DumpRenderTree/win/DumpRenderTree.cpp: (setAlwaysAcceptCookies): Method to handle all the calls necessary to change the accept cookie policy on Windows. (resetDefaultsToConsistentValues): Reset the accept cookie to its default. * DumpRenderTree/win/DumpRenderTreeWin.h: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAlwaysAcceptCookies): Stub out method. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAlwaysAcceptCookies): Stub out method. 2009-08-26 Dimitri Glazkov Unreviewed. Remove accidentally left in clobber option. https://bugs.webkit.org/show_bug.cgi?id=28400 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option. 2009-08-26 Dimitri Glazkov Reviewed by Mark Rowe. Add canary-style Chromium WebKit build slave to the waterfall. https://bugs.webkit.org/show_bug.cgi?id=28400 * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands. 2009-08-25 Cameron McCormack Reviewed by Darin Adler. make-script-test-wrappers should be executable https://bugs.webkit.org/show_bug.cgi?id=28669 Make make-script-test-wrappers and update-sources-list.py both be executable. * Scripts/update-sources-list.py: * Scripts/make-script-test-wrappers: 2009-08-25 Brent Fulgham Build fix Revise Debug_Cairo targets to point inherit from the debug_wincairo.vsprops property sheet so that they link against the proper libraries in Debug build. * DumpRenderTree/win/DumpRenderTree.vcproj: * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: * WinLauncher/WinLauncher.vcproj: 2009-08-25 David Levin Reviewed by Adam Roben. PLATFORM(CFNETWORK) should be USE(CFNETWORK). https://bugs.webkit.org/show_bug.cgi?id=28713 * DumpRenderTree/win/DumpRenderTree.cpp: (main): 2009-08-25 Tor Arne Vestbø Reviewed by Ariya Hidayat. [Qt/Mac] Use CONFIG+=build_all only when building libraries If no configuration is specified when building WebKit we pass the debug_and_release option to QMake which results in Makefiles for both configurations being generated. Previously we built both of these configurations by default, for all targets (both the QtWebKit framework/dyldlib and the various executables such as QtLauncher and tests). This makes sense for the libraries, which get the _debug suffix and can be loaded on demand by setting the DYLD_IMAGE_SUFFIX, but for executables we ended up building the same executable twice. We now only build one instance of each executable, and since this is a developer build we build the debug-version. Passing either --debug or --release to build-webkit will override this, and even in the default case the release version can still be built by running 'make release' in the the build directory of each target. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * Scripts/webkitdirs.pm: 2009-08-24 Hironori Bono Reviewed by Adam Barth. Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet". . Because of the lack of mappings from GDK key-codes to WebKit key-codes, Chromium cannot send valid key-codes to JavaScript when a user types function keys. This change just copies the mappings from 'KeyEventGtk.cpp'. To write layout tests for this issue, added mappings from function-key names to platform-specific key-codes to EventSendingController objects so that eventSender.keyDown() can send function-key events without using platform-specific key codes. (Unfortunately, this eventSender.keyDown() change is only for Mac. So this change adds this new test to Skipped tests for other platforms to prevent this change from crashing the build trees.) * DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]): 2009-08-23 Jan Michael Alonzo Reviewed by Xan Lopez. [Gtk] API for disabling local file access to web URLs https://bugs.webkit.org/show_bug.cgi?id=28663 Enable this setting for DRT. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): 2009-08-22 Adam Barth Revert 47684. We're going to do this later once clients have had a chance to opt into the setting they like. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-08-22 Adam Barth Reviewed by Eric Seidel. Don't let local files access web URLs https://bugs.webkit.org/show_bug.cgi?id=28480 A bunch of our LayoutTests rely on our old behavior, so we explicitly grant local files universal access during testing. Mainly, these tests involve making XMLHttpRequests for data URLs. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): * DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage): * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): 2009-08-22 Mark Rowe Rubber-stamped by Anders Carlsson. Bring signed updates to the Mac nightly builds. * WebKitLauncher/Info.plist: * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: * WebKitLauncher/WebKitNightlyEnablerSparkle.m: (initializeSparkle): * WebKitLauncher/nightly.webkit.org.public.pem: Added. 2009-08-21 Jan Michael Alonzo Rubberstamped by Simon Fraser. Remove GNOME keyring support in build-webkit. This dependency's already been removed in the Gtk port. * Scripts/build-webkit: 2009-08-20 Brian Weinstein Reviewed by Adam Roben. Based on original patch by Stephanie Lewis. Added support of the Windows malloc history format to parse-malloc history, so we can read and parse it. * Scripts/parse-malloc-history: 2009-08-20 Chris Fleizach Reviewed by Darin Adler. Enable various "grouping" ARIA roles https://bugs.webkit.org/show_bug.cgi?id=28486 Expose the ability to retrieve the subrole through accessibility for DRT. * DumpRenderTree/AccessibilityUIElement.cpp: * DumpRenderTree/AccessibilityUIElement.h: * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: * DumpRenderTree/mac/AccessibilityUIElementMac.mm: * DumpRenderTree/win/AccessibilityUIElementWin.cpp: 2009-08-20 Joseph Pecoraro Unreviewed. Added myself as a committer. * Scripts/modules/committers.py: 2009-08-20 Xan Lopez Reviewed by Gustavo Noronha. Fix memory leaks. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): 2009-08-20 Eric Seidel Reviewed by Adam Barth. bugzilla-tool post-diff can post partial diffs from SVN checkouts. https://bugs.webkit.org/show_bug.cgi?id=28445 Pass the checkout root as the cwd. Also wrote a test to ensure this. * Scripts/modules/scm.py: * Scripts/modules/scm_unittest.py: 2009-08-20 Mark Rowe Reviewed by Adele Peterson. Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue. * DumpRenderTree/AccessibilityUIElement.cpp: (attributeValueCallback): 2009-08-20 Ariya Hidayat Unreviewed, build fix. [Qt] The template-based qMax() compares two qreals. * DumpRenderTree/qt/ImageDiff.cpp: (main): 2009-08-20 David Levin Reviewed by David Kilzer. bugzilla-tool patch retrieval should handle 302 redirects. https://bugs.webkit.org/show_bug.cgi?id=28485 * Scripts/modules/scm.py: Pass the --location parameter to curl so that 302's are followed. 2009-08-20 Aaron Boodman One more speculative build for gtk. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: 2009-08-20 Aaron Boodman Speculative build for gtk. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::whiteListAccessFromOrigin): 2009-08-20 Mark Rowe Ignore some leaks that are known to originate from ImageIO. * Scripts/run-webkit-tests: 2009-08-20 Aaron Boodman With David Levin. Speculative build fix for qt. * DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::whiteListAccessFromOrigin): * DumpRenderTree/qt/jsobjects.h: 2009-08-19 Mark Rowe Reviewed by Dan Bernstein. Fix Plug-in-related leaks seen on the build bot Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit. * Scripts/check-for-global-initializers: 2009-08-19 Aaron Boodman Reviewed by David Levin. https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to specify a more granular policy for cross-origin XHR access. * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests. (whiteListAccessFromOriginCallback): Ditto. (LayoutTestController::staticFunctions): Ditto. * DumpRenderTree/LayoutTestController.h: Ditto. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto. (LayoutTestController::whiteListAccessToOrigin): Ditto. * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto. (LayoutTestController::whiteListAccessFromOrigin): Ditto. * DumpRenderTree/qt/jsobjects.cpp: Ditto. (LayoutTestController::whiteListAccessFromOrigin): Ditto. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin(). (LayoutTestController::whiteListAccessFromOrigin): Ditto. * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test. (resetWebViewToConsistentStateBeforeTesting): Ditto. * DumpRenderTree/mac/DumpRenderTree.mm: Ditto. (resetWebViewToConsistentStateBeforeTesting): Ditto. * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto. 2009-08-19 Mark Rowe Rubber-stamped by Dan Bernstein. Ignore some leaks that are known to originate from QTKit. * Scripts/run-webkit-tests: 2009-08-19 Eric Seidel Reviewed by Adam Barth. commit-queue/bugzilla-tool can get wedged if git is mid-rebase https://bugs.webkit.org/show_bug.cgi?id=28436 Make clean_working_directory cancel rebases too (even though that's a bit of a hack). This code will only ever be run when --force-clean is passed. I also added a new unit test to make sure this code actually works. :) * Scripts/modules/scm.py: * Scripts/modules/scm_unittest.py: 2009-08-19 Eric Seidel Reviewed by David Levin. WebKit needs a changelogs.py to hold changelog-related code https://bugs.webkit.org/show_bug.cgi?id=28477 This is moving code and adding tests. There was only one functional change (which was removing a trailing newline from the last_entry() result). * Scripts/bugzilla-tool: * Scripts/modules/changelogs.py: Added. * Scripts/modules/changelogs_unittest.py: Added. * Scripts/run-webkit-unittests: 2009-08-20 Eric Seidel Reviewed by Adam Barth. bugzilla-tool needs a way to ask build.webkit.org if the bots are passing https://bugs.webkit.org/show_bug.cgi?id=28222 Basic support for now. This has been in testing for 24 hours now and worked great! * Scripts/bugzilla-tool: * Scripts/modules/buildbot.py: Added. * Scripts/modules/buildbot_unittest.py: Added. * Scripts/run-webkit-unittests: 2009-08-19 Jan Michael Alonzo Reviewed by Gustavo Noronha. [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the default timeout used by run-webkit-tests. Mac and Win ports were recently bumped in http://trac.webkit.org/changeset/r47465. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump): 2009-08-19 David D. Kilzer DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger Reviewed by Mark Rowe. Provide pre-generated swig source files for Tiger so it may benefit from the faster run-webkit-tests. * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Generated by swig. * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added. Generated by swig. (swig_type_info::SWIG_TypeNameComp): (swig_type_info::SWIG_TypeEquiv): (swig_type_info::SWIG_TypeRegisterTL): (swig_type_info::SWIG_TypeCheck): (swig_type_info::SWIG_TypeCast): (swig_type_info::SWIG_TypeDynamicCast): (swig_type_info::SWIG_TypeName): (swig_type_info::SWIG_TypePrettyName): (swig_type_info::SWIG_TypeQueryTL): (swig_type_info::SWIG_TypeClientDataTL): (swig_type_info::SWIG_PackData): (swig_type_info::SWIG_UnpackData): (swig_type_info::SWIG_PropagateClientDataTL): (swig_type_info::SWIG_PackVoidPtr): (swig_type_info::SWIG_UnpackVoidPtr): (swig_type_info::SWIG_PackDataName): (swig_type_info::SWIG_UnpackDataName): * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on Tiger using pre-generated files. 2009-08-18 Shinichiro Hamaji Reviewed by David Kilzer. run-webkit-tests hangs when WebCore tries to log too much https://bugs.webkit.org/show_bug.cgi?id=15743 Read stdout and stderr in parallel. * Scripts/run-webkit-tests: 2009-08-18 Mark Rowe Rubber-stamped by Oliver Hunt. Add a new build configuration that checks for leaks during the layout tests, and hook a new machine up to it. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: 2009-08-18 Aaron Boodman Reviewed by Maciej Stachowiak. https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests. No new tests: Already covered by existing tests. * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest. 2009-08-18 Mark Rowe Rubber-stamped by Geoff Garen. Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests. * DumpRenderTree/mac/LayoutTestControllerMac.mm: * DumpRenderTree/win/LayoutTestControllerWin.cpp: 2009-08-18 Brian Weinstein Rubber-stamped by Adam Roben. Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them, and removed include to fix building on VC++ Express. * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota): 2009-08-18 Brian Weinstein Reviewed by Oliver Hunt. Fix of DRT on Windows doesn't support LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota. Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface. Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setDatabaseQuota): * DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::exceededDatabaseQuota): 2009-08-18 Peter Kasting Reviewed by Eric Seidel. https://bugs.webkit.org/show_bug.cgi?id=28415 Set svn:eol-style CRLF on all .sln and .vcproj files that don't already have it. * record-memory-win/record-memory-win.vcproj: * WinLauncher/WinLauncher.vcproj: * WebKitLauncherWin/WebKitLauncherWin.vcproj: * DumpRenderTree/win/ImageDiff.vcproj: * FindSafari/FindSafari.vcproj: 2009-08-18 Drew Wilson Reviewed by Eric Seidel. Need to extend DumpRenderTree to expose number of worker threads https://bugs.webkit.org/show_bug.cgi?id=28292 Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit. * DumpRenderTree/LayoutTestController.cpp: (getWorkerThreadCountCallback): (LayoutTestController::staticValues): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::workerThreadCount): * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::workerThreadCount): * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::workerThreadCount): * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::workerThreadCount): 2009-08-18 Xan Lopez Reviewed by Jan Alonzo. Initialize x and y in the GtkAllocation structure to shut up valgrind. * DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): 2009-08-17 Shinichiro Hamaji Reviewed by Darin Adler. Some HTMLs are modified by make-script-test-wrappers https://bugs.webkit.org/show_bug.cgi?id=28213 Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and re-generated wml/* and Geolocation/* . * Scripts/make-script-test-wrappers: 2009-08-17 Shinichiro Hamaji Reviewed by Eric Seidel. -webkit-box-orient:horizontal doesn't work on