2006-10-31 MorganL Reviewed by Maciej. Fixes http://bugs.webkit.org/show_bug.cgi?id=11286 Includes some CRLF -> LF fixups. * platform/win/CookieJarWin.cpp: (WebCore::cookies): 2006-10-31 Adam Roben Reviewed by Steve. Fix some incorrect forward declarations. * loader/FrameLoader.h: * page/Frame.h: 2006-10-31 Darin Adler * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to try to fix the build on the buildbot. 2006-10-31 Darin Adler * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds. (WebCore::FrameMac::markMisspellings): Ditto. 2006-10-31 John Sullivan * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): build fix: needed #ifndef BUILDING_ON_TIGER in one more place 2006-10-30 John Sullivan Reviewed by Adam Roben - fixes Bad grammar ranges are not visibly marked This patch introduces much of the guts of grammar checking, though still not enough to actually check grammar sensibly, due to: Many false reports of bad grammar appear, caused by insufficient context passed to grammar checker * platform/Logging.h: * platform/Logging.cpp: new log channel SpellingAndGrammar * bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): initialize new log channel * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest in the event of a tie), and do further processing with that one (select range; create marker that causes range to be visibly marked with a funky underline; update spelling panel appropriately). (WebCore::FrameMac::markMisspellings): More or less the same types of changes as in advanceToNextMisspelling The loops are structured just differently enough to make sharing code between these two functions a little tricky, so I decided to save that for a later patch. (WebCore::FrameMac::respondToChangedSelection): remove grammar markers when we remove spelling markers 2006-10-31 Nikolas Zimmermann Reviewed by Mitz. Fix Qt/Linux build with older gcc3.3.4. * bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): 2006-10-31 Zack Rusin Reviewed by Mitz. Fix the Qt build after last nights changes. * WebCore/platform/qt/FrameQt.cpp: * WebCore/platform/qt/EditorClientQt.h: * WebCore/platform/qt/EditorClientQt.cpp: * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp: * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp: * WebCore/CMakeLists.txt: * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp: * WebKitQt/QtLauncher/CMakeLists.txt: * WebKitQt/WebKitPart/CMakeLists.txt: 2006-10-30 Darin Adler Reviewed by Anders. - remove BrowserExtension * WebCore.vcproj/WebCore/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction): * bridge/BrowserExtension.h: Removed. * bridge/mac/BrowserExtensionMac.h: Removed. * bridge/mac/BrowserExtensionMac.mm: Removed. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): * bridge/win/BrowserExtensionWin.cpp: Removed. * bridge/win/BrowserExtensionWin.h: Removed. * bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): * loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): * loader/FrameLoader.h: * loader/icon/IconLoader.cpp: * loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createWindow): * page/Frame.cpp: (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired): * page/Frame.h: * page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isEmpty): (WebCore::FrameLoadRequest::resourceRequest): (WebCore::FrameLoadRequest::frameName): (WebCore::FrameLoadRequest::setFrameName): * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate): * platform/gdk/BrowserExtensionGdk.h: Removed. * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): * platform/gdk/TemporaryLinkStubs.cpp: * platform/network/ResourceRequest.h: (WebCore::ResourceRequest::isEmpty): 2006-10-31 Nikolas Zimmermann Reviewed by Oliver. Modified from original due to earlier reversion Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436 Better SVG integration in WebKit, Part I. The patch is mostly about creating a new platform/graphics directory, and moving the kcanvas resources (clipper/masker/marker) there (in svg budir), with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership issues, by using ref counting (the SVG classes now store RefPtrs to the resources). KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch. All details of the patch, and upcoming patches can be found in the bug report. * CMakeLists.txt: * WebCore.xcodeproj/project.pbxproj: * graphics/svg/SVGResource.cpp: Removed. * graphics/svg/SVGResourceClipper.cpp: Removed. * graphics/svg/SVGResourceClipper.h: Removed. * graphics/svg/SVGResourceImage.h: Removed. * graphics/svg/SVGResourceListener.h: Removed. * graphics/svg/SVGResourceMarker.cpp: Removed. * graphics/svg/SVGResourceMarker.h: Removed. * graphics/svg/SVGResourceMasker.cpp: Removed. * graphics/svg/SVGResourceMasker.h: Removed. * kcanvas/KCanvasClipper.cpp: Removed. * kcanvas/KCanvasClipper.h: Removed. * kcanvas/KCanvasCreator.cpp: Removed. * kcanvas/KCanvasCreator.h: Removed. * kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById): * kcanvas/KCanvasFilters.h: * kcanvas/KCanvasImage.h: Removed. * kcanvas/KCanvasMarker.cpp: Removed. * kcanvas/KCanvasMarker.h: Removed. * kcanvas/KCanvasMasker.cpp: Removed. * kcanvas/KCanvasMasker.h: Removed. * kcanvas/KCanvasResource.cpp: Removed. * kcanvas/KCanvasResource.h: Removed. * kcanvas/KCanvasResourceListener.h: Removed. * kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources): * kcanvas/device/KRenderingDevice.h: * kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): * kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener): * kcanvas/device/KRenderingPaintServerGradient.h: * kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener): * kcanvas/device/KRenderingPaintServerPattern.h: * kcanvas/device/KRenderingPaintServerSolid.h: * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed. * kcanvas/device/qt/KCanvasClipperQt.h: * kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer): * kcanvas/device/qt/KRenderingDeviceQt.h: * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: * kcanvas/device/qt/KRenderingPaintServerQt.cpp: * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: * kcanvas/device/qt/RenderPathQt.h: Removed. * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): * kcanvas/device/quartz/KCanvasItemQuartz.mm: * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed. * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed. * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed. * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed. * kcanvas/device/quartz/KRenderingDeviceQuartz.h: * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource): * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown): * kcanvas/device/quartz/KRenderingPaintServerQuartz.h: * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup): * kcanvas/device/quartz/QuartzSupport.mm: * ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer): * ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource): * ksvg2/svg/SVGClipPathElement.h: * ksvg2/svg/SVGFEImageElement.cpp: * ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource): * ksvg2/svg/SVGFilterElement.h: * ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification): * ksvg2/svg/SVGGradientElement.h: * ksvg2/svg/SVGImageElement.cpp: * ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): * ksvg2/svg/SVGLinearGradientElement.h: * ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource): * ksvg2/svg/SVGMarkerElement.h: * ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): * ksvg2/svg/SVGMaskElement.h: * ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource): * ksvg2/svg/SVGPatternElement.h: * ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): * ksvg2/svg/SVGRadialGradientElement.h: * ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource): * platform/GraphicsContext.cpp: Removed. * platform/GraphicsContext.h: Removed. * platform/GraphicsTypes.cpp: Removed. * platform/GraphicsTypes.h: Removed. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage): * platform/graphics/GraphicsContext.h: * platform/graphics/GraphicsTypes.cpp: (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName): * platform/graphics/GraphicsTypes.h: (WebCore::): * platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<): * platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener): * platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById): * platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper): * platform/graphics/svg/SVGResourceImage.h: Added. * platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById): * platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker): * platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById): * platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker): * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip): * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer): * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask): * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip): * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask): * platform/qt/GraphicsContextQt.cpp: * rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded): * rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): * rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow): 2006-10-30 John Sullivan Reviewed by Brady - minor cleanup to make future patches clearer * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test with "continue" to better match structure of similar code in markMisspellings; a few other style tweaks. (WebCore::FrameMac::markMisspellings): renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around a block just after a break and outdented accordingly. 2006-10-30 John Sullivan Reviewed by Geoff Garen WebCore part of change to push the code that updates the spelling panel into WebCore, in preparation for some grammar-checking stuff. * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): no more return value for this method, and update the spelling panel with the misspelled word here rather than in the WebKit callers. 2006-10-30 Oliver Hunt Reviewed by Anders. Roll out last patch * CMakeLists.txt: * ChangeLog: * WebCore.xcodeproj/project.pbxproj: * graphics/svg/SVGResource.cpp: * graphics/svg/SVGResourceClipper.cpp: * graphics/svg/SVGResourceClipper.h: * graphics/svg/SVGResourceImage.h: * graphics/svg/SVGResourceListener.h: * graphics/svg/SVGResourceMarker.cpp: * graphics/svg/SVGResourceMarker.h: * graphics/svg/SVGResourceMasker.cpp: * graphics/svg/SVGResourceMasker.h: * kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasClipper::KCanvasClipper): (WebCore::KCanvasClipper::~KCanvasClipper): (WebCore::KCanvasClipper::resetClipData): (WebCore::KCanvasClipper::addClipData): (WebCore::KCanvasClipper::clipData): (WebCore::KCanvasClipper::externalRepresentation): (WebCore::getClipperById): * kcanvas/KCanvasClipper.h: Added. (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::KCClipDataList): (WebCore::KCClipDataList::addPath): (WebCore::KCanvasClipper::isClipper): * kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById): * kcanvas/KCanvasFilters.h: * kcanvas/KCanvasImage.h: Added. (WebCore::KCanvasImage::KCanvasImage): (WebCore::KCanvasImage::~KCanvasImage): * kcanvas/KCanvasMarker.cpp: Added. (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::~KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::setRef): (WebCore::KCanvasMarker::refX): (WebCore::KCanvasMarker::refY): (WebCore::KCanvasMarker::setAngle): (WebCore::KCanvasMarker::angle): (WebCore::KCanvasMarker::setAutoAngle): (WebCore::KCanvasMarker::setUseStrokeWidth): (WebCore::KCanvasMarker::useStrokeWidth): (WebCore::KCanvasMarker::draw): (WebCore::KCanvasMarker::externalRepresentation): (WebCore::getMarkerById): * kcanvas/KCanvasMarker.h: Added. (WebCore::KCanvasMarker::isMarker): * kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::~KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById): * kcanvas/KCanvasMasker.h: Added. (WebCore::KCanvasMasker::isMasker): (WebCore::KCanvasMasker::mask): * kcanvas/KCanvasResource.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasResource::KCanvasResource): (WebCore::KCanvasResource::~KCanvasResource): (WebCore::KCanvasResource::addClient): (WebCore::KCanvasResource::clients): (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): * kcanvas/KCanvasResource.h: (WebCore::): (WebCore::KCanvasResource::isPaintServer): (WebCore::KCanvasResource::isFilter): (WebCore::KCanvasResource::isClipper): (WebCore::KCanvasResource::isMarker): (WebCore::KCanvasResource::isMasker): * kcanvas/KCanvasResourceListener.h: Added. (KCanvasResourceListener::KCanvasResourceListener): (KCanvasResourceListener::~KCanvasResourceListener): * kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources): * kcanvas/device/KRenderingDevice.h: * kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry): * kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener): * kcanvas/device/KRenderingPaintServerGradient.h: * kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener): * kcanvas/device/KRenderingPaintServerPattern.h: * kcanvas/device/KRenderingPaintServerSolid.h: * kcanvas/device/qt/KCanvasClipperQt.cpp: (WebCore::KCanvasClipperQt::applyClip): * kcanvas/device/qt/KCanvasClipperQt.h: (WebCore::KCanvasClipperQt::KCanvasClipperQt): * kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer): * kcanvas/device/qt/KRenderingDeviceQt.h: * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: * kcanvas/device/qt/KRenderingPaintServerQt.cpp: * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: * kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): * kcanvas/device/quartz/KCanvasItemQuartz.mm: * kcanvas/device/quartz/KCanvasMaskerQuartz.h: (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz): * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::KCanvasMaskerQuartz::applyMask): * kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz): (WebCore::KCanvasImageQuartz::KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::init): (WebCore::KCanvasImageQuartz::size): * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip): (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::cgLayer): (WebCore::KCanvasImageQuartz::setCGLayer): * kcanvas/device/quartz/KRenderingDeviceQuartz.h: * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource): * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown): * kcanvas/device/quartz/KRenderingPaintServerQuartz.h: * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup): * kcanvas/device/quartz/QuartzSupport.mm: * ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer): * ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource): * ksvg2/svg/SVGClipPathElement.h: * ksvg2/svg/SVGFEImageElement.cpp: * ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource): * ksvg2/svg/SVGFilterElement.h: * ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification): * ksvg2/svg/SVGGradientElement.h: * ksvg2/svg/SVGImageElement.cpp: * ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient): * ksvg2/svg/SVGLinearGradientElement.h: * ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource): * ksvg2/svg/SVGMarkerElement.h: * ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): * ksvg2/svg/SVGMaskElement.h: * ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource): * ksvg2/svg/SVGPatternElement.h: * ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient): * ksvg2/svg/SVGRadialGradientElement.h: * ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource): * platform/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage): * platform/GraphicsContext.h: Added. * platform/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName): * platform/GraphicsTypes.h: Added. (WebCore::): * platform/graphics/GraphicsContext.cpp: * platform/graphics/GraphicsContext.h: * platform/graphics/GraphicsTypes.cpp: * platform/graphics/GraphicsTypes.h: * platform/qt/GraphicsContextQt.cpp: * rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded): * rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): * rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow): 2006-10-30 John Sullivan Reviewed by Geoff Garen. Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used grammar-related method. * bridge/EditorClient.h: declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled() * bridge/mac/WebCoreFrameBridge.h: removed bridge equivalents * bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): convert bridge-using code to editor()->client()-using code (WebCore::FrameMac::markMisspellingsInAdjacentWords): ditto (WebCore::FrameMac::markMisspellings): ditto (WebCore::FrameMac::respondToChangedSelection): ditto * editing/Editor.h: * editing/Editor.cpp: (WebCore::Editor::client): new method, returns EditorClient pointer. In an ideal world all the code that needed to access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor. But for now it's too tricky to extricate the spelling-related code from FrameMac.mm. 2006-10-30 Geoffrey Garen Reviewed by Darin. Removed a number of editing and selection methods from the bridge. I moved cross-platform editing and selection code into Editor and SelectionController, respecitvely. I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting everything + the kitchen sink. Specific comments below for interesting things. * bindings/objc/DOMInternal.h: Moved exception handling helper methods into a new file so that WebKit can use them, too. Added a helper method for handling exceptions when selecting a Range. * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into WebKit, since they have to do with creating an NSAttributedString for API consumption, and not much to do with general Frame functionality. * editing/Editor.h: Moved lastEditCommand tracking (at least the data, for now) into the Editor. Eventually, the Frame will not have to notify the Editor of what the lastEditCommand was, since the Editor will perform all EditCommands. * editing/SelectionController.h: The code here is just stuff moved from the bridge. * editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions and return them. The bridge method to select a DOM range did this implicitly, since all ObjC DOM operations handle DOM exceptions by throwing them as ObjC exceptions. * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity. The two enumerations are numerically identical, but that's an implementation detail of TextAffinity that clients shouldn't be required to know about. 2006-10-30 Timothy Hatcher Rolling out the following change because this crash: REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) And this regression: REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/ 2006-09-06 David Harrison Reviewed and tweaked by Tim H. WebKit doesn't trigger Auto Font Activation If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] to trigger a search that will include auto activation. No PLT or iBench perf impact. No layout tests affected. Not testable in an automated way that will work on all systems. * platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): 2006-10-30 Justin Garcia Reviewed by harrison REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460) * editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Only create VisiblePositions when we're going to use them to create a range for an emitted character. We should further speed TextIterators up by avoiding creating VisiblePositions for TIs that are only used for the characters they emit (like the one that plainText uses). 2006-10-30 Sam Weinig Reviewed by Mitz. Fix for http://bugs.webkit.org/show_bug.cgi?id=11441 More rendering code cleaning * WebCore.xcodeproj/project.pbxproj: * rendering/RenderApplet.cpp: (WebCore::RenderApplet::RenderApplet): (WebCore::RenderApplet::createWidgetIfNecessary): * rendering/RenderApplet.h: * rendering/RenderArena.cpp: (WebCore::): (WebCore::RenderArena::RenderArena): (WebCore::RenderArena::allocate): (WebCore::RenderArena::free): * rendering/RenderArena.h: * rendering/RenderBR.cpp: (WebCore::RenderBR::RenderBR): (WebCore::RenderBR::baselinePosition): (WebCore::RenderBR::lineHeight): (WebCore::RenderBR::setStyle): (WebCore::RenderBR::caretMinOffset): (WebCore::RenderBR::positionForCoordinates): (WebCore::RenderBR::inlineBox): * rendering/RenderBR.h: * rendering/RenderBlock.cpp: * rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::setHasMarkupTruncation): (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo): (WebCore::RenderBlock::BlockSelectionInfo::block): (WebCore::RenderBlock::BlockSelectionInfo::state): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::CompactInfo::clear): * rendering/RenderButton.cpp: (WebCore::RenderButton::removeChild): (WebCore::RenderButton::paintObject): * rendering/RenderButton.h: (WebCore::RenderButton::renderName): (WebCore::RenderButton::removeLeftoverAnonymousBoxes): * rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer): * rendering/RenderContainer.h: (WebCore::RenderContainer::firstChild): (WebCore::RenderContainer::lastChild): (WebCore::RenderContainer::calcMinMaxWidth): * rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): (WebCore::toRoman): (WebCore::toHebrew): (WebCore::RenderCounter::calcMinMaxWidth): * rendering/RenderCounter.h: * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle): * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcMinMaxWidth): * rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::renderName): * rendering/RenderFlexibleBox.h: * rendering/RenderFlow.cpp: * rendering/RenderFlow.h: * rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtPoint): * rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::renderName): * rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::layout): (WebCore::RenderFormElement::textAlignment): * rendering/RenderFormElement.h: * rendering/RenderFrame.cpp: * rendering/RenderFrame.h: (WebCore::RenderFrame::element): * rendering/RenderFrameSet.cpp: * rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::element): * rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): (WebCore::RenderHTMLCanvas::paint): * rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::renderName): * rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setStyle): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText): * rendering/RenderImage.h: (WebCore::RenderImage::element): * rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::~RenderInline): (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::paint): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::calcMinMaxWidth): (WebCore::RenderInline::requiresLayer): (WebCore::RenderInline::width): (WebCore::RenderInline::height): (WebCore::RenderInline::renderName): (WebCore::RenderInline::nodeAtPoint): (WebCore::RenderInline::positionForCoordinates): * rendering/RenderInline.h: (WebCore::RenderInline::layout): * rendering/RenderLayer.cpp: * rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::root): (WebCore::RenderLayer::setPos): (WebCore::RenderLayer::height): (WebCore::RenderLayer::relativePositionOffset): * rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderLineEdit::selectionStart): (WebCore::RenderLineEdit::selectionEnd): (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange): * rendering/RenderLineEdit.h: * rendering/RenderListBox.cpp: * rendering/RenderListBox.h: (WebCore::RenderListBox::renderName): * rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle): (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint): * rendering/RenderListItem.h: * rendering/RenderListMarker.cpp: * rendering/RenderListMarker.h: (WebCore::RenderListMarker::renderName): (WebCore::RenderListMarker::isListMarker): 2006-10-30 Timothy Hatcher Reviewed by Hyatt. Basic table editing and culling Refined the criteria for deletable elements, rely on the renderer more. Corrected the interface positioning for elements that have borders. * editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::DeleteButtonController::show): 2006-10-30 Darin Adler - fix build * loader/ResourceLoader.h: Added header guard. 2006-10-31 Darin Adler Reviewed by Adam. - fix FrameLoader files so they can be built on non-Mac platforms * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader. (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader. * page/Page.h: * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong the other day. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Removed code to create the frame loader. (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader. * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC) around the PolicyCheck definition. * loader/FormState.cpp: Changed import to include. * loader/FrameLoader.cpp: Ditto. * loader/MainResourceLoader.h: Ditto. * loader/FrameLoaderTypes.h: Added a header guard. * loader/NetscapePlugInStreamLoader.h: Changed import to include. Added #if PLATFORM(MAC) around Mac-specific details. * loader/SubresourceLoader.h: Ditto. * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to m_loader from m_frameLoader. * CMakeLists.txt: Updated. * WebCoreSources.bkl: Updated. 2006-10-30 Nikolas Zimmermann Reviewed and landed by Anders. Patch by Zack rusin to fix: http://bugs.webkit.org/show_bug.cgi?id=11429 Fix startup crash. * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): 2006-10-30 Zach Rusin Reviewed and landed by Anders. * platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::receivedResponse): * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::FrameQtClientDefault): * platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest): More build fixes. 2006-10-30 Simon Hausmann Reviewed and landed by Anders. - fix Qt build * platform/qt/FrameQtClient.cpp: ResourceLoaderClient -> ResourceHandleClient 2006-10-30 Darin Adler Reviewed by John Sullivan. - work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle - moved bodyBackgroundColor function from Frame to WebFrame in WebKit * page/PageState.h: * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had. * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor(). * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a double for the date instead of an NSDate. * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and saveDocumentToPageCache methods. * bridge/mac/WebCorePageState.h: * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into an Objective-C wrapper for PageState. * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of NSDate and WebCorePageState. * loader/FrameLoaderClient.h: Changed NSDate to double. * loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache here that used to be in invalidateCurrentItemPageCache on the WebKit side. (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date. (WebCore::FrameLoader::open): Moved one of the open functions that was part of commitProvisionalLoad inside the commitProvisionalLoad function, so that it can extract the parameters from the response. Changed the open function that takes a PageState to use the new C++ PageState. (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open function; tightened up logic, removing a few cases that could never happen, as well as the unused reload boolean. * ForwardingHeaders/kjs/property_map.h: Added. * WebCore.exp: Updated. * WebCore.xcodeproj/project.pbxproj: Updated. 2006-10-29 Maciej Stachowiak Reviewed by Anders. - added ResourceResponse class and didReceiveResponse delegate call * WebCore.xcodeproj/project.pbxproj: Added new files. * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed expiresTimeForResponse: method. * dom/XMLTokenizer.cpp: (WebCore::openFunc): Updated to use ResourceResponse. * loader/FrameLoader.h: Update loadResourceSynchronously to use ResourceResponse. * loader/LoaderFunctions.h: * loader/icon/IconLoader.cpp: (IconLoader::didReceiveResponse): Updated from receivedResponse and made cross-platform. * loader/icon/IconLoader.h: updated for above change * loader/loader.cpp: (WebCore::Loader::receivedResponse): reduced to just saving the PlatformResponse (ideally we'd phase out use of this). (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse logic. * loader/loader.h: * loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously): Return results as ResourceResponse. * loader/mac/IconLoaderMac.mm: remove receivedResponse. * loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): take ResourceResponse as argument. * platform/network/ResourceHandle.cpp: * platform/network/ResourceHandle.h: Remove calls for broken out response pieces. * platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveResponse): New delegate method. * platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove storage of response bits, we're not gonna return them seprately any more. * platform/network/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): Freshly implemented. Same for below. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::isMultipart): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate): * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Send didReceiveResponse client method. * platform/network/cf/ResourceResponseCFNet.h: Added. * platform/network/cf/ResourceResponseCFNet.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from CFURLResponseRef. * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Don't bother cleaning up fields we no longer have. (WebCore::ResourceHandle::receivedResponse): Send didReceiveResponse client method. * platform/network/mac/ResourceResponseMac.h: Added. * platform/network/mac/ResourceResponseMac.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from an NSURLResponse*. * rendering/HitTestResult.cpp: * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Prepare for use of ResourceResponse. * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseText): Store http response info in the form of a ResourceResponse, change all methods to account for this. (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData): * xml/xmlhttprequest.h: 2006-10-29 Darin Adler - fix build * loader/DocumentLoader.h: Add declarations so this compiles without ObjC. * loader/NetscapePlugInStreamLoader.h: Ditto. * loader/ResourceLoader.h: Ditto. 2006-10-29 Darin Adler - one last name change -- WebFormState.h to FormState.h - added more empty placeholder platform-independent files for currently-Mac-specific loader classes * loader/FormState.cpp: Updated include. * loader/FrameLoader.cpp: Updated include. * loader/mac/FrameLoaderMac.mm: Updated include. * loader/WebFormState.h: Removed. * loader/FormState.h: Added. * loader/DocumentLoader.cpp: Added. * loader/MainResourceLoader.cpp: Added. * loader/NetscapePlugInStreamLoader.cpp: Added. * loader/ResourceLoader.cpp: Added. * loader/SubresourceLoader.cpp: Added. * WebCore.xcodeproj/project.pbxproj: Updated for changes above. 2006-10-29 Darin Adler - did the do-webcore-rename renames, including a number of changes to the names of loader files (and WebResourceLoader -> ResourceLoader), jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(), and improvements to the names of decoder classes and their source files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec) * CMakeLists.txt: * WebCore.exp: * WebCore.vcproj/WebCore/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * WebCoreSources.bkl: * bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::updateDOMNodeDocument): * bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::parseCode): * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::implementsCall): * bindings/js/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode): * bindings/js/kjs_window.cpp: (KJS::Window::interpreter): (KJS::Window::retrieveWindow): (KJS::Window::retrieve): (KJS::ScheduledAction::execute): * bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]): * bridge/mac/FrameMac.mm: (WebCore::FrameMac::executionContextForDOM): (WebCore::FrameMac::bindingRootObject): (WebCore::FrameMac::windowScriptObject): (WebCore::FrameMac::windowScriptNPObject): (WebCore::FrameMac::partClearedInBegin): * bridge/mac/WebCoreEncodings.mm: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): (-[WebCoreFrameBridge stringWithData:]): (-[WebCoreFrameBridge executionContextForView:]): * bridge/win/FrameWin.cpp: * dom/Document.cpp: (WebCore::Document::inputEncoding): (WebCore::Document::setCharset): (WebCore::Document::createHTMLEventListener): (WebCore::Document::setDecoder): * dom/Document.h: (WebCore::Document::decoder): * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): * html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::canvasCreateErrorCheck): (WebCore::HTMLParser::isInline): * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject): * html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript): * html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken): * ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener): * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setEncoding): * loader/CachedCSSStyleSheet.h: * loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument): (WebCore::CachedXBLDocument::setEncoding): * loader/CachedXBLDocument.h: * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): (WebCore::CachedXSLStyleSheet::setEncoding): * loader/CachedXSLStyleSheet.h: * loader/Decoder.cpp: Removed. * loader/Decoder.h: Removed. * loader/FrameLoader.cpp: * loader/FrameLoader.h: * loader/FrameLoaderClient.h: * loader/MainResourceLoader.h: Added. * loader/NetscapePlugInStreamLoader.h: Added. * loader/Request.h: (WebCore::Request::cachedResource): * loader/ResourceLoader.h: Added. * loader/SubresourceLoader.h: Added. * loader/TextResourceDecoder.cpp: Added. (WebCore::TextResourceDecoder::determineContentType): (WebCore::TextResourceDecoder::defaultEncoding): (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::~TextResourceDecoder): (WebCore::TextResourceDecoder::setEncoding): (WebCore::TextResourceDecoder::checkForBOM): (WebCore::TextResourceDecoder::checkForCSSCharset): (WebCore::TextResourceDecoder::checkForHeadCharset): (WebCore::TextResourceDecoder::detectJapaneseEncoding): (WebCore::TextResourceDecoder::decode): (WebCore::TextResourceDecoder::flush): * loader/TextResourceDecoder.h: Added. * loader/WebDocumentLoader.h: Removed. * loader/WebLoader.h: Removed. * loader/WebMainResourceLoader.h: Removed. * loader/WebNetscapePlugInStreamLoader.h: Removed. * loader/WebSubresourceLoader.h: Removed. * loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest): * loader/mac/DocumentLoaderMac.mm: * loader/mac/FormDataStream.m: Added. * loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::open): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): * loader/mac/ImageDocumentMac.mm: * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): * loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::releaseDelegate): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::setDefersLoading): * loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::releaseResources): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didReceiveData): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel): * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::frameLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::willCacheResponse): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::response): (WebCore::ResourceLoader::inConnectionCallback): (WebCore::ResourceLoader::cancelledError): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation): (WebCore::ResourceLoader::delegate): (WebCore::ResourceLoader::releaseDelegate): (-[WebCoreResourceLoaderAsDelegate initWithLoader:]): * loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): * loader/mac/WebFormDataStream.h: Removed. * loader/mac/WebFormDataStream.m: Removed. * page/Frame.cpp: (WebCore::Frame::javaScriptEnabled): (WebCore::Frame::scriptProxy): (WebCore::Frame::executeScript): (WebCore::Frame::write): (WebCore::Frame::userGestureHint): (WebCore::Frame::saveInterpreterBuiltins): (WebCore::Frame::restoreInterpreterBuiltins): (WebCore::Frame::backslashAsCurrencySymbol): * page/Frame.h: * page/FramePrivate.h: * platform/StreamingTextDecoder.cpp: Removed. * platform/StreamingTextDecoder.h: Removed. * platform/StreamingTextDecoderICU.cpp: Removed. * platform/StreamingTextDecoderICU.h: Removed. * platform/TextCodec.cpp: Added. * platform/TextCodec.h: Added. * platform/TextCodecICU.cpp: Added. * platform/TextCodecICU.h: Added. * platform/TextCodecLatin1.h: * platform/TextCodecUTF16.h: * platform/TextDecoder.h: * platform/TextEncoding.cpp: * platform/TextEncodingRegistry.cpp: * platform/image-decoders/jpeg/jmorecfg.h: * platform/mac/StreamingTextDecoderMac.cpp: Removed. * platform/mac/StreamingTextDecoderMac.h: Removed. * platform/mac/TextCodecMac.cpp: Added. * platform/mac/TextCodecMac.h: Added. * platform/network/ResourceHandleInternal.h: * platform/network/mac/ResourceHandleMac.mm: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::bindingRootObject): * platform/qt/LoaderFunctionsQt.cpp: (WebCore::CheckCacheObjectStatus): * rendering/RenderObject.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol): * xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): * xml/xmlhttprequest.h: 2006-10-29 Darin Adler Rubber stamped by Adam (kinda). - add Mac suffixes and correct filenames inside loader/mac * WebCore.xcodeproj/project.pbxproj: Updated for changes below. * loader/mac/FrameLoader.mm: Removed. * loader/mac/WebDocumentLoader.mm: Removed. * loader/mac/WebLoader.mm: Removed. * loader/mac/WebMainResourceLoader.mm: Removed. * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed. * loader/mac/WebSubresourceLoader.mm: Removed. * loader/mac/FrameLoaderMac.mm: Added. * loader/mac/DocumentLoaderMac.mm: Added. * loader/mac/ResourceLoaderMac.mm: Added. * loader/mac/MainResourceLoaderMac.mm: Added. * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added. * loader/mac/SubresourceLoaderMac.mm: Removed. 2006-10-29 Darin Adler Reviewed by Adam. - moving towards use of FrameLoader cross-platform; get FrameLoader.h and FrameLoader.cpp mostly ready * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and FormState.cpp. Removed WebFormState.mm. * loader/FrameLoader.h: Put in lots of #if statements to see if we can get this header compiling on non-Mac. * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader. * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out. * loader/FrameLoaderClient.h: Added some ifdefs. * loader/WebDocumentLoader.h: Ditto. * loader/WebLoader.h: Ditto. * loader/WebMainResourceLoader.h: Ditto. * loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense): Rewrote to work without bridge, partly to remove the need for ObjC bridge type in the header, and also because we're tearing down the bridge. * loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): Removed unused m_contentLength and m_bytesReceived. (WebCore::MainResourceLoader::didReceiveResponse): Ditto. (WebCore::MainResourceLoader::didReceiveData): Ditto. * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData. * bridge/mac/WebCoreFrameBridge.mm: Ditto. * loader/mac/FormState.mm: Removed. * loader/FormState.cpp: Added. 2006-10-29 Darin Adler Rubber stamped by Adam. - moving towards use of FrameLoader cross-platform; move the headers for the Mac loader from loader/mac into loader, in preparation for making them useful on non-Mac * WebCore.xcodeproj/project.pbxproj: * loader/mac/FrameLoader.h: Removed. * loader/mac/WebDocumentLoader.h: Removed. * loader/mac/WebFormState.h: Removed. * loader/mac/WebLoader.h: Removed. * loader/mac/WebMainResourceLoader.h: Removed. * loader/mac/WebNetscapePlugInStreamLoader.h: Removed. * loader/mac/WebSubresourceLoader.h: Removed. * loader/FrameLoader.h: Added. * loader/WebDocumentLoader.h: Added. * loader/WebFormState.h: Added. * loader/WebLoader.h: Added. * loader/WebMainResourceLoader.h: Added. * loader/WebNetscapePlugInStreamLoader.h: Added. * loader/WebSubresourceLoader.h: Added. 2006-10-29 Adam Roben Reviewed by Geoff. Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in r17405. * platform/DeprecatedString.h: 2006-10-29 Beth Dakin Rubber stamped by Geoff. This is a followup to my HitTestResult checkin. Most of the HitTestResult local variables in the code were named i or info for when the class was named NodeInfo. This patch renames all of these local variables to result. * dom/Document.cpp: (WebCore::Document::prepareMouseEvent): * html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): * html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent): * rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint): * rendering/EllipsisBox.h: * rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint): * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): (WebCore::RenderBlock::nodeAtPoint): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): * rendering/RenderBox.h: * rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines): * rendering/RenderFlow.h: * rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::nodeAtPoint): * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint): * rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): * rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint): * rendering/RenderInline.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateHoverActiveState): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInScrollbar): * rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): (WebCore::RenderObject::setInnerNode): (WebCore::RenderObject::nodeAtPoint): * rendering/RenderObject.h: * rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): * rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): * rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint): * rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): * rendering/RenderTableRow.h: * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint): * rendering/RenderTableSection.h: * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): * rendering/RootInlineBox.h: 2006-10-29 Adam Roben More semi-fixes. * page/Page.cpp: Forgot to wrap the actual definition of setDefersLoading() in PLATFORM(MAC). * platform/PlatformWheelEvent.h: Fix up preprocessor directives. 2006-10-29 Adam Roben Build semi-fix. Move all FrameLoader-related code in Page.{cpp,h} within #if PLATFORM(MAC), since this class currently only exists on Mac. * page/Page.cpp: * page/Page.h: 2006-10-29 Geoffrey Garen build fix. * platform/PlatformString.h: (WebCore::String::operator NSString*): 2006-10-29 Geoffrey Garen Rolled out accidental commit. * platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator NSString*): 2006-10-29 Geoffrey Garen RS by Darin. Rolled out change to map NULL Strings to nil NSStrings because it caused even more AppKit crashes. Maybe we should remove the NSString * operator entirely, since its use is not straight-forward, and require callers to specify explicitly whether they tolerate NULL. * platform/AtomicString.h: * platform/PlatformString.h: (WebCore::String::operator NSString*): * platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]): 2006-10-29 Darin Adler Reviewed by Geoff. - fixed storage leak showing up on the buildbot * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create): Release the NSURLRequest after passing it to load. Also clean up logic a bit. 2006-10-29 Darin Adler Rubber stamped by Adam. - renamed WebFrameLoaderClient to match the class name inside it * loader/mac/WebFrameLoaderClient.h: Removed. * loader/FrameLoaderClient.h: Moved it here. * WebCore.xcodeproj/project.pbxproj: Updated project. * bridge/mac/FrameMac.mm: Updated includes. * bridge/mac/WebCoreFrameBridge.mm: Ditto. * loader/mac/FrameLoader.mm: Ditto. * loader/mac/WebLoader.h: Ditto. 2006-10-29 Darin Adler Reviewed by Mitz. - fix crash visible on buildbot and also when running the test anchor-image-scrolled-x-y.html under libgmalloc * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle now that the class is named ResourceHandle. * loader/mac/WebSubresourceLoader.mm: Renaming, plus: (WebCore::SubresourceLoader::didFinishLoading): Get the handle into a local RefPtr before calling finishJobAndHandle, since we might get cancelled inside that function, so we should not rely on m_handle to keep the ResourceHandle alive. (WebCore::SubresourceLoader::didFail): Ditto. (WebCore::SubresourceLoader::didCancel): Ditto. 2006-10-29 Maciej Stachowiak - build fix * platform/network/mac/ResourceHandleMac.mm: 2006-10-29 Maciej Stachowiak Rubber stamped by Darin. - renamed ResourceLoader to ResourceHandle (and same for related classes) * CMakeLists.txt: * Projects/gdk/webcore-gdk.bkl: * WebCore.vcproj/WebCore/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * WebCoreSources.bkl: * bridge/mac/FrameMac.mm: * bridge/win/FrameWin.cpp: * dom/XMLTokenizer.cpp: * loader/Cache.cpp: * loader/CachedResource.h: * loader/LoaderFunctions.h: * loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didReceiveData): (IconLoader::didFinishLoading): * loader/icon/IconLoader.h: * loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest): * loader/loader.h: * loader/mac/IconLoaderMac.mm: (IconLoader::receivedResponse): * loader/mac/LoaderFunctionsMac.mm: * loader/mac/WebLoader.h: * loader/mac/WebSubresourceLoader.h: * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData): * platform/gdk/FrameGdk.h: * platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveCharset): * platform/network/ResourceHandle.cpp: Added. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::isErrorPage): (WebCore::ResourceHandle::error): (WebCore::ResourceHandle::setError): (WebCore::ResourceHandle::responseEncoding): (WebCore::ResourceHandle::responseHTTPHeadersAsString): (WebCore::ResourceHandle::kill): (WebCore::ResourceHandle::requestHeaders): (WebCore::ResourceHandle::url): (WebCore::ResourceHandle::postData): (WebCore::ResourceHandle::method): (WebCore::ResourceHandle::client): * platform/network/ResourceHandle.h: Added. (WebCore::ResourceHandle::getInternal): * platform/network/ResourceHandleClient.h: Added. (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFinishLoading): (WebCore::ResourceHandleClient::receivedRedirect): (WebCore::ResourceHandleClient::receivedResponse): (WebCore::ResourceHandleClient::receivedAllData): * platform/network/ResourceHandleInternal.h: Added. (WebCore::ResourceHandleInternal::ResourceHandleInternal): * platform/network/ResourceLoader.cpp: Removed. * platform/network/ResourceLoader.h: Removed. * platform/network/ResourceLoaderClient.h: Removed. * platform/network/ResourceLoaderInternal.h: Removed. * platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): * platform/network/cf/ResourceLoaderCFNet.cpp: Removed. * platform/network/gdk/ResourceHandleCurl.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): * platform/network/gdk/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::get): (WebCore::ResourceHandleManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel): * platform/network/gdk/ResourceHandleManager.h: Added. * platform/network/gdk/ResourceLoaderCurl.cpp: Removed. * platform/network/gdk/ResourceLoaderManager.cpp: Removed. * platform/network/gdk/ResourceLoaderManager.h: Removed. * platform/network/mac/ResourceHandleMac.mm: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::redirectedToURL): (WebCore::ResourceHandle::addData): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError): * platform/network/mac/ResourceLoaderMac.mm: Removed. * platform/network/qt/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel): * platform/network/qt/ResourceHandleManager.h: Added. * platform/network/qt/ResourceHandleQt.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::extractCharsetFromHeaders): * platform/network/qt/ResourceLoaderManager.cpp: Removed. * platform/network/qt/ResourceLoaderManager.h: Removed. * platform/network/qt/ResourceLoaderQt.cpp: Removed. * platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setHasReceivedResponse): (WebCore::ResourceHandle::hasReceivedResponse): * platform/network/win/ResourceHandleWin.h: Added. * platform/network/win/ResourceLoaderWin.cpp: Removed. * platform/network/win/ResourceLoaderWin.h: Removed. * platform/qt/FrameQt.cpp: * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData): * platform/qt/FrameQtClient.h: * platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ServeSynchronousRequest): * xml/XSLTProcessor.cpp: * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::didReceiveData): * xml/xmlhttprequest.h: t2006-10-29 Darin Adler Reviewed by Maciej. - eliminate use of NSArray to carry form data around * WebCore.exp: * WebCore.xcodeproj/project.pbxproj: * bridge/mac/FormDataMac.h: Removed. * bridge/mac/FormDataMac.mm: Removed. * bridge/mac/FrameMac.h: * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): * loader/FormData.h: (WebCore::FormData::isEmpty): * loader/mac/FrameLoader.h: * loader/mac/FrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): * loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): * loader/mac/WebFormDataStream.h: * loader/mac/WebFormDataStream.m: (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody): * loader/mac/WebSubresourceLoader.h: * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create): * platform/network/mac/ResourceLoaderMac.mm: 2006-10-29 Maciej Stachowiak Reviewed by Darin. - create SubresourceLoader with a ResourceRequest, not broken out request bits * loader/mac/WebSubresourceLoader.h: * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create): * platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): 2006-10-29 Maciej Stachowiak Reviewed by Darin. - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp * WebCore.xcodeproj/project.pbxproj: * bridge/mac/WebCoreFrameBridge.h: * loader/mac/FrameLoader.h: * loader/mac/FrameLoader.mm: * loader/mac/LoaderFunctionsMac.mm: * loader/mac/WebLoader.h: * loader/mac/WebSubresourceLoader.h: * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): * platform/network/ResourceLoader.h: * platform/network/ResourceLoaderInternal.h: * platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::redirectedToURL): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::finishJobAndHandle): (WebCore::ResourceLoader::reportError): * platform/network/mac/WebCoreResourceLoader.h: Removed. * platform/network/mac/WebCoreResourceLoaderImp.h: Removed. * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed. 2006-10-28 Darin Adler Reviewed by Maciej. - eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDecider, WebCoreFrameLoaderAsDelegate, and WebCoreMainResourceLoaderAsPolicyDelegate - grouped the state related to policy decisions into a PolicyCheck class to simplify the FrameLoader logic - removed six methods from the bridge, reducing FrameLoader's use of the bridge to a single method - changed form state to always use HashMap instead of NSDictionary - moved the defersLoading flag from WebView to WebCore::Page and changed code to consistently call it defersLoading rather than defersCallbacks - updated for rename of PassRefPtr::release to releaseRef - replaced all uses of __APPLE__ with appropriate PLATFORM defines - cleaned up kjs_binding.h a bit - cleaned up FrameMac.h a bit * loader/mac/WebPolicyDecider.h: Removed. * loader/mac/WebPolicyDecider.mm: Removed. * WebCore.xcodeproj/project.pbxproj: Updated for removal. * WebCore.exp: * bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::wasRunByUserGesture): * bindings/js/kjs_binding.h: (KJS::ScriptInterpreter::setCurrentEvent): (KJS::ScriptInterpreter::setInlineCode): (KJS::ScriptInterpreter::setProcessingTimerCallback): (KJS::ScriptInterpreter::getCurrentEvent): (KJS::cacheDOMObject): (KJS::DOMExceptionTranslator::DOMExceptionTranslator): * bridge/AXObjectCache.h: * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::handleMouseMoveEvent): * bridge/mac/PageMac.mm: (WebCore::Page::Page): * bridge/mac/WebCoreEditCommand.mm: * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): * css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText): * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): * css/CSSValueList.cpp: (WebCore::CSSValueList::append): * css/cssparser.cpp: (WebCore::CSSParser::parseValue): * css/cssparser.h: * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateSelection): (WebCore::Document::implicitClose): (WebCore::Document::setFocusNode): * dom/Document.h: * editing/ReplaceSelectionCommand.h: * html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): * loader/mac/FrameLoader.h: (WebCore::PolicyCheck::request): * loader/mac/FrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::open): (WebCore::FrameLoader::stopLoading): (WebCore::setAllDefersLoading): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::dropRequest): (WebCore::FrameLoaderClient::~FrameLoaderClient): * loader/mac/WebFormState.h: * loader/mac/WebFormState.mm: * loader/mac/WebFrameLoaderClient.h: * loader/mac/WebLoader.h: (WebCore::WebResourceLoader::defersLoading): * loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::setDefersLoading): * loader/mac/WebMainResourceLoader.h: * loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::releaseDelegate): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading): * page/Frame.cpp: (WebCore::Frame::paint): * page/FrameView.cpp: (WebCore::FrameView::layout): * page/FrameView.h: * page/Page.cpp: (WebCore::Page::setDefersLoading): * page/Page.h: (WebCore::Page::defersLoading): * platform/DeprecatedString.h: * platform/DeprecatedStringList.h: * platform/FontFallbackList.h: * platform/PlatformKeyboardEvent.h: * platform/PlatformMouseEvent.h: * platform/PlatformWheelEvent.h: * platform/mac/ClipboardMac.h: * platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::dragNSImage): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation): * rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): * rendering/break_lines.cpp: (WebCore::nextBreakablePosition): 2006-10-28 Adam Roben Reviewed by Maciej. Fix layout tests that broke after r17399. Mitz discovered that the failures were caused by HitTestResult::m_point being uninitialized much of the time. HitTestResults are now always constructed with a point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that point instead of being passed one explicitly. * WebCore.exp: Change constructor symbol. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and hitTest(). (WebCore::FrameMac::handleMouseMoveEvent): Ditto. * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto. * dom/Document.cpp: (WebCore::Document::elementFromPoint): Ditto. (WebCore::Document::prepareMouseEvent): Ditto. * page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Ditto. (WebCore::Frame::hitTestResultAtPoint): Ditto. * page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Ditto. * rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Initalize m_point with the passed point. * rendering/HitTestResult.h: Update constructor declaration. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Update to new constructor and hitTest(). (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the HitTestResult instead of being passed one. (WebCore::RenderLayer::hitTestLayer): Ditto. * rendering/RenderLayer.h: Update declarations. 2006-10-28 Nikolas Zimmermann Reviewed by Anders. Fix Qt/Linux build. * CMakeLists.txt: * platform/qt/FrameQtClient.cpp: (WebCore::numRequests): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests): * platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::updateFromElement): 2006-10-28 David Carson Tweaked by Sam. Reviewed by Brady. Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437 Initialize m_modifyBiasSet to false, as it sometimes gets used before it has been initalized. * editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): 2006-10-28 Beth Dakin Reviewed by Darin. This is the WebCore half of pushing elementAtPoint and the backend of WebElementDictionary into WebCore. Most of the changes below are to accommodate one of the following: -NodeInfo is now a stand-alone class called HitTestResult. Previously it was defined in RenderObject.h, but not for any particular reason. The WebElementDictionary functionality that was pushed into WebCore has been pushed specifically into the this class. In fact, WebElementDictionary now keeps a HitTestResult as a member varibale. -The enumeration AccessPolicy is now called ClipboardAccessPolicy and is defined in its own header. It was previously defined in ClipboardMac.h, but is now defined independently to avoid including ClipboardMac.h from within FrameMac.h since FrameMac.h is now included in WebElementDictionary.m in WebKit. -Element now has a virtual target() for the sake of NodeInfo::targetFrame() * WebCore.exp: Several WebCore functions are newly called from WebKit, so they have been added here. * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.mm: Must include Image.h because of adjustments to ClipboardMac. * bridge/mac/FrameMac.h: Adjust to HitTestResult changes. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy and HitTestResult changes. (WebCore::FrameMac::eventMayStartDrag): Same. (WebCore::FrameMac::handleMouseMoveEvent): Same. (WebCore::FrameMac::dispatchCPPEvent): Same. (WebCore::FrameMac::mayDHTMLCut): Same. (WebCore::FrameMac::mayDHTMLCopy): Same. (WebCore::FrameMac::mayDHTMLPaste): Same. (WebCore::FrameMac::tryDHTMLCut): Same (WebCore::FrameMac::tryDHTMLCopy): Same. (WebCore::FrameMac::tryDHTMLPaste): Same. * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to HitTestResult changes. (-[WebCoreAXObject accessibilityHitTest:]): Same. * bridge/mac/WebCoreFrameBridge.h: Same. * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for ClipboardAccessPolicy changes. (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same. (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same. * dom/Document.cpp: (WebCore::Document::elementFromPoint): Adjust for HitTestResult changes. (WebCore::Document::prepareMouseEvent): Same. * dom/Element.h: (WebCore::Element::target): Now has a virtual target() * html/HTMLAnchorElement.h: Same. * html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult changes. * html/HTMLAreaElement.h: Virtual target() * html/HTMLBaseElement.h: (WebCore::HTMLBaseElement::target): Same. * html/HTMLFormElement.h: Same. * html/HTMLLinkElement.h: Same. * html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult changes. * html/HTMLMapElement.h: Same. * page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Same. (WebCore::Frame::hitTestResultAtPoint): Same. * page/Frame.h: Same. * page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Same. * platform/mac/ClipboardAccessPolicy.h: Added. (WebCore::): * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, include ClipboardAccessPolicy.h, and rename AccessPolicy to ClipboardAccessPolicy. * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy. (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::setAccessPolicy): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::setDropEffect): (WebCore::ClipboardMac::setEffectAllowed): * rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult changes. * rendering/EllipsisBox.h: * rendering/HitTestResult.cpp: Added. (WebCore::HitTestResult::HitTestResult): (WebCore::HitTestResult::~HitTestResult): (WebCore::HitTestResult::operator=): (WebCore::HitTestResult::setInnerNode): (WebCore::HitTestResult::setInnerNonSharedNode): (WebCore::HitTestResult::setURLElement): (WebCore::HitTestResult::setScrollbar): (WebCore::HitTestResult::targetFrame): (WebCore::HitTestResult::boundingBox): (WebCore::HitTestResult::isSelected): (WebCore::HitTestResult::title): * rendering/HitTestResult.h: Added. (WebCore::HitTestResult::readonly): (WebCore::HitTestResult::active): (WebCore::HitTestResult::mouseMove): (WebCore::HitTestResult::innerNode): (WebCore::HitTestResult::innerNonSharedNode): (WebCore::HitTestResult::point): (WebCore::HitTestResult::URLElement): (WebCore::HitTestResult::scrollbar): (WebCore::HitTestResult::setPoint): (WebCore::HitTestResult::setReadonly): (WebCore::HitTestResult::setActive): (WebCore::HitTestResult::setMouseMove): * rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes. * rendering/InlineBox.h: Same. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): Same. * rendering/InlineFlowBox.h: Same. * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint): Same. * rendering/InlineTextBox.h: Same. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Same. (WebCore::RenderBlock::nodeAtPoint): Same. * rendering/RenderBlock.h: Same. * rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Same. * rendering/RenderBox.h: Same. * rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines): Same. * rendering/RenderFlow.h: Same. * rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::nodeAtPoint): Same. * rendering/RenderForeignObject.h: Same. * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint): Same. * rendering/RenderFrameSet.h: Same. * rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Same. * rendering/RenderImage.h: Same. * rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint): Same. * rendering/RenderInline.h: Same. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Same. (WebCore::RenderLayer::hitTest): Same. (WebCore::RenderLayer::hitTestLayer): Same. (WebCore::RenderLayer::updateHoverActiveState): Same. * rendering/RenderLayer.h: Same. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInScrollbar): Same. * rendering/RenderListBox.h: Same. * rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): Same. (WebCore::RenderObject::setInnerNode): Same. (WebCore::RenderObject::nodeAtPoint): Same. * rendering/RenderObject.h: Remove NodeInfo class and forward declare HitTestResult. * rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult changes. * rendering/RenderPath.h: Same. * rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Same. * rendering/RenderSVGImage.h: Same * rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint): Same. * rendering/RenderSVGText.h: Same. * rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): Same. * rendering/RenderTableRow.h: Same. * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint): Same. * rendering/RenderTableSection.h: Same. * rendering/RenderText.h: Same. (WebCore::RenderText::nodeAtPoint): Same. * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): Same. * rendering/RenderTextControl.h: Same. * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): Same. * rendering/RootInlineBox.h: Same. 2006-10-27 Maciej Stachowiak Reviewed by Anders. - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance impact of fixing it again. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear): 2006-10-27 Maciej Stachowiak Reviewed by John & Adam. - assorted speedups to fix perf regression from fixing correctness regression * WebCore.exp: exported new methods. * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: * loader/CachedResource.cpp: Removed now obsolete getCFURL. * loader/CachedResource.h: * loader/mac/CachedResourceMac.mm: Added. (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is now cached in the CachedObject. * loader/mac/FrameLoader.h: * loader/mac/FrameLoader.mm: (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets the WebKit side do faster dispatch for clients that implement the fast path delegate. * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods, just call loadedResourceFromMemoryCache. * loader/mac/WebFrameLoaderClient.h: 2006-10-27 Oliver Hunt Reviewed by Maciej. build fix * dom/Document.cpp: (WebCore::Document::referrer): 2006-10-27 Geoffrey Garen Reviewed by Maciej. Moved some WebCoreFrameBridge functions into FrameLoader. I had to make FrameLoader.h capable of compiling in C++-only source files by adding some forward declarations and __OBJC__ #ifdefs. * WebCore.exp: * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::createEmptyDocument): (WebCore::FrameMac::tokenizerProcessedData): * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: * dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer): * loader/LoaderFunctions.h: * loader/mac/FrameLoader.h: * loader/mac/FrameLoader.mm: (WebCore::numRequests): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::startLoadingResource): * loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckIfReloading): * page/Frame.h: * page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): (WebCore::FrameTree::traverseNext): * page/FrameTree.h: * platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): 2006-10-27 Timothy Hatcher Reviewed by Darin. HTML Editing: Basic table editing and culling Expanded the Deletion UI to lists, positioned block element and block elementss with borders. * editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection): 2006-10-27 John Sullivan Reviewed by Kevin Decker Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time you haven't not finished reading this. * rendering/InlineTextBox.h: * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be considered also. (WebCore::InlineTextBox::paintDocumentMarkers): Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground markers should be painted, instead of a marker type. This avoids walking the collection of markers multiple times back to back. Now handles grammar markers. 2006-10-27 Timothy Hatcher Reviewed by Beth. Renamed Copy Files to Copy Generated Headers. Copy 4 DOM*Internal.h headers. * WebCore.xcodeproj/project.pbxproj: * bindings/scripts/CodeGeneratorObjC.pm: 2006-10-27 John Sullivan Reviewed by Anders * WebCore.exp: exported symbol for FrameMac->advanceToNextSpelling() * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly. 2006-10-27 Justin Garcia Reviewed by harrison REGRESSION: First newline missing from textarea's value The regression is that foo, return, bar in a textarea serializes as 'foobar'. Before my change in r17223, return (an InsertLineBreak) would insert a '\n' (the line break) then a br to prevent the '\n' from collapsing, since the insertion is being done at the end of a block (the textarea's shadow div). Then, inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar". After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed the order). Then inserting "bar" would displace the '\n' and "foo"
"bar" would serialize as "foobar" because when serializing RenderTextControl intentionally asks textContent to not convert brs to newlines. It seems to think that the only brs in the shadow div will be placeholders or collapsed. We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak to insert two '\n's when at the end of a block in white-space:pre text. This alone would have fixed the bug, but introduced a new one, because foo, return, bar would produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second '\n' is collapsed, because of 9661). So, then I changed placeholder displacement to displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as a br or '\n' that will collapse (become superfluous) when content is inserted just before it. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove a br or '\n' if content inserted just before it will cause it to collapse. * editing/CompositeEditCommand.h: * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node to prevent a collapse as was used for the line break. Fixed comments. * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call the renamed function. 2006-10-27 Geoffrey Garen Reviewed by Brady. Fixed semantic inaccuracy in String::operator NSString *(), where a NULL String became an empty NSString *, instead of nil. This will become important as we start using this conversion more. Added work-around for AppKit crash that semantic accuracy revealed. No testcase because I don't think there's a way to reflect this change in a webpage yet. * platform/PlatformString.h: (WebCore::String::operator NSString*): * platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]): 2006-10-27 David Harrison Reviewed by Maciej, Expose blockquotes in AXAttributedStringForTextMarkerRange * bridge/mac/WebCoreAXObject.mm: (blockquoteLevel): Calculate and return the blockquote level of the element. (AXAttributeStringSetBlockquoteLevel): Add, if non-zero, or clear the block quote level attribute. (AXAttributedStringAppendText): Send AXAttributeStringSetBlockquoteLevel. 2006-10-27 Darin Adler - fix one error in the Qt build * platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Updated. 2006-10-27 Darin Adler Reviewed by Maciej. * WebCore.exp: Export more symbols needed by WebKit. 2006-10-26 Geoffrey Garen Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV. Fixed layout test crash. Oops. * loader/mac/WebDocumentLoader.mm: (WebCore::canonicalizedTitle): 2006-10-26 John Sullivan Reviewed by Brady - fixed Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com This restores some of the nil-handling that was implicit before some of the code was converted from Objective-C to C++. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame 2006-10-26 Geoffrey Garen Reviewed by Darin, Maciej. Removed many uses of NSString *. Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing stringByCollapsingNonPrintingCharacters with a c++ equivalent. PLT says no performance regression. * WebCore.exp: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge receivedData:textEncodingName:]): * loader/mac/FrameLoader.h: * loader/mac/FrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post): * loader/mac/WebDocumentLoader.h: * loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): * loader/mac/WebFrameLoaderClient.h: * loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy): 2006-10-26 Timothy Hatcher Reviewed by Adam. Table deletion outline is misplaced at nytimes.com The main table at nytimes.com has a fixed width of 874px, but the table ends up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct this. The other bug was a missing top and left of 0px on the container element, causing the deletion UI to sometimes be offset below the table. Now check for the element's renderer at the beginning of show() and return early if it is null. * editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::updateOutlineStyle): (WebCore::DeleteButtonController::show): 2006-10-26 Anders Carlsson Build fix. * html/CanvasRenderingContext2D.cpp: Include MathExtras.h 2006-10-26 John Sullivan Reviewed by Anders. Some changes to support new grammar checking code in WebKit. * WebCore.exp: added mangled symbol for Document->removeMarkers() so I can call it from WebKit * WebCore.xcodeproj/project.pbxproj: Made Document.h and DocumentMarker.h private so I can include them from WebKit. Made HTMLCollection.h private because Document.h uses it. * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: removed unmarkAllMisspellings(); WebKit now calls through to the Document directly 2006-10-26 Anders Carlsson Reviewed by Brady. Add reverseFind to String and use it instead of findRev. Use CString instead of DeprecatedCString in one place. * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): * ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget): * loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset): * platform/PlatformString.h: (WebCore::String::reverseFind): * platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind): * platform/StringImpl.h: 2006-10-26 John Sullivan Reviewed by Darin More plumbing for grammar checking. Still no grammars is checked. * dom/DocumentMarker.h: (WebCore::DocumentMarker::): added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum" * platform/GraphicsContext.h: renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar; now takes a bool parameter for whether it represents bad grammar or a misspelling * platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed an existing "assert" to "ASSERT". * rendering/InlineTextBox.h: renamed function paintSpellingMarker to paintSpellingOrGrammarMarker; * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents bad grammar or a misspelling (WebCore::InlineTextBox::paintAllMarkersOfType): now handles markers of type Grammar === Safari-521.29 === 2006-10-26 Sam Weinig Reviewed by Mitz. Fix for http://bugs.webkit.org/show_bug.cgi?id=11424 Cleanup rendering code - Assorted code cleanup. * rendering/AutoTableLayout.cpp: * rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::totalPercent): * rendering/CounterListItem.h: * rendering/CounterNode.cpp: * rendering/CounterNode.h: (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::isReset): * rendering/CounterResetNode.cpp: * rendering/CounterResetNode.h: * rendering/DataRef.h: (WebCore::DataRef::DataRef): * rendering/DeprecatedRenderSelect.h: * rendering/DeprecatedSlider.cpp: * rendering/DeprecatedSlider.h: * rendering/EllipsisBox.cpp: * rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): * rendering/FixedTableLayout.cpp: * rendering/FixedTableLayout.h: * rendering/GapRects.h: * rendering/InlineBox.cpp: * rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::clearTruncation): (WebCore::InlineBox::markDirty): * rendering/InlineFlowBox.cpp: * rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::setConstructed): (WebCore::InlineFlowBox::setEdges): (WebCore::InlineFlowBox::setVerticalOverflowPositions): (WebCore::InlineFlowBox::setVerticalSelectionPositions): * rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations): * rendering/InlineTextBox.cpp: * rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox): (WebCore::InlineTextBox::end): (WebCore::InlineTextBox::textObject): * rendering/Length.h: (WebCore::Length::Length): * rendering/ListMarkerBox.cpp: * rendering/ListMarkerBox.h: * rendering/RenderPartObject.h: * rendering/RootInlineBox.cpp: * rendering/RootInlineBox.h: * rendering/SVGInlineFlowBox.cpp: * rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): * rendering/SVGRootInlineBox.cpp: * rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox): * rendering/TableLayout.h: (WebCore::TableLayout::TableLayout): (WebCore::TableLayout::~TableLayout): * rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiRun::BidiRun): * rendering/break_lines.h: 2006-10-26 Justin Garcia Reviewed by john Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon. * editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor. Wrapped the plain text fragment in a style span with the document default style so that it will appear unstyled regardless of where it is inserted. Could have also inserted the plain text fragment and then applied the document default style to it, but there is not yet any redundant style prevention in ApplyStyleCommand, so this is cleaner. * editing/Editor.h: * editing/JSEditor.cpp: 2006-10-26 Oliver Hunt Reviewed by Anders. Fixes -- needed to update existing canvas path elements when transforms are performed on the context. * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): 2006-10-26 Nikolas Zimmermann Reviewed by Darin. Fix Qt/Linux build. * platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add): * platform/network/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::receivedResponse): * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): * platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest): 2006-10-26 Adam Roben Reviewed by Adele. Fix: add "type-to-select" feature for list boxes (s into RenderThemeMac, as this is really a platform-specific look. * css/html4.css: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListButtonStyle): 2006-10-23 Maciej Stachowiak Reviewed by Brady. - moved things around so loadURL:... is only called from one place * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): 2006-10-23 Justin Garcia Reviewed by john Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document Added special cases in InsertLineBreakCommand for inserting before and after tables and horizontal rules. Also, perform InsertLineBreak instead of InsertParagraphSeparator at these positions. * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use the canonical form of the caret position when we check for the new special cases because we know that we canonicalize VisiblePositions to those positions. Added code to handle inserting before/after tables and horizontal rules. Fixed a bug when inserting at the end of a block (it checked for a collapse of the inserted br by looking for the absence of a br, but the line break might have been a '\n' in white-space:pre text). Removed unused LOGs. * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an InsertLineBreakCommand when before/after a table or a horizontal rule so that we don't have to maintain two pieces of special case code. Migrated to enclosingBlock. * editing/htmlediting.cpp: Added a FIXME. * editing/visible_units.cpp: (WebCore::startOfParagraph): Added a workaround for 8622. 2006-10-23 Adam Roben Reviewed by Adele. Make popups a little more flexible. * platform/PopupMenu.h: 2006-10-23 Sam Weinig Reviewed by Tim H. Cleanup CodeGeneratorJS.pm * bindings/scripts/CodeGeneratorJS.pm: 2006-10-23 Adam Roben Rubberstamped by Brady. * loader/icon/IconLoader.h: Changed angle-brackets to quotes for #include of ResourceLoader.h, since it's a WebCore header. 2006-10-23 Darin Adler - fixed mistake that was preventing any loading from happening * platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): Changed parameter back to int. Perhaps we want to move to "long long" consistently, but I'll leave that up to Maciej. 2006-10-23 Maciej Stachowiak Reviewed by Anders. - start converting ResourceLoaderClient to new API Did the bits I could do without introducing new types: - renamed receivedData to didReceiveData - renamed version of receivedAllData that doesn't pass any data to didFinishLoading * bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]): * loader/icon/IconLoader.cpp: (IconLoader::didReceiveData): (IconLoader::didFinishLoading): * loader/icon/IconLoader.h: * loader/loader.cpp: (WebCore::Loader::didReceiveData): * loader/loader.h: * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::didReceiveData): * platform/gdk/FrameGdk.h: * platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): (WebCore::ResourceLoaderClient::didFinishLoading): (WebCore::ResourceLoaderClient::receivedResponse): * platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceLoader::cancel): * platform/network/gdk/ResourceLoaderManager.cpp: (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove): * platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::remove): * platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel): * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::didReceiveData): * platform/qt/FrameQtClient.h: * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData): * xml/xmlhttprequest.h: 2006-10-23 Maciej Stachowiak Rubber stamped by Anders. - marked files executable * ksvg2/scripts/csscssmakeprops: * ksvg2/scripts/csscssmakevalues: 2006-10-22 Maciej Stachowiak Reviewed by Anders. - moved ResourceLoader and related files to platform/network in preparation for building out this API. I tried to update all the build systems but I'm not sure they are all fixed properly * page/ResourceRequest.h: Moved to platform/network. * platform/ResourceLoader.cpp: Moved to platform/network. * platform/ResourceLoader.h: Moved to platform/network. * platform/ResourceLoaderClient.h: Moved to platform/network. * platform/ResourceLoaderInternal.h: Moved to platform/network. * platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf. * platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk. * platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk. * platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk. * platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac. * platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt. * platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt. * platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt. * platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win. * platform/win/ResourceLoaderWin.h: Moved to platform/network/win. * webcore-base.bkl: Updated for new paths. * CMakeLists.txt: ditto * Projects/gdk/webcore-gdk.bkl: ditto * WebCore.xcodeproj/project.pbxproj: ditto * WebCoreSources.bkl: ditto 2006-10-22 Sam Weinig Reviewed by Tim H. - Add DOMHTMLFormElementPrivate.h to the project. * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOMPrivate.h: 2006-10-22 Darin Adler - another try at fixing Qt * CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp. - and fix a couple warnings while I'm at it * platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA): Don't do unsigned *= float. * rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable inside #if so it's consistent. 2006-10-21 Darin Adler - fix the Qt build * platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldShowDeleteInterface): * platform/qt/EditorClientQt.h: * platform/qt/FrameQt.cpp: 2006-10-21 Darin Adler Reviewed by Adele. - convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed) Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but there's currently another class with that name). Renamed WebMainResourceLoader to WebCore::MainResourceLoader. Renamed WebSubresourceLoader to WebCore::SubresourceLoader. Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader. Converted the classes to C++ and added Objective-C delegates to forward from API that still requires Objective-C. Did not yet rename the source files. * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes. * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project. * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace. * loader/mac/WebLoader.h: * loader/mac/WebLoader.mm: * loader/mac/WebMainResourceLoader.h: * loader/mac/WebMainResourceLoader.mm: * loader/mac/WebNetscapePlugInStreamLoader.h: * loader/mac/WebNetscapePlugInStreamLoader.mm: * loader/mac/WebSubresourceLoader.h: * loader/mac/WebSubresourceLoader.mm: Translate to C++. * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): * loader/mac/WebFrameLoader.h: * loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): * loader/mac/WebFrameLoaderClient.h: Call the new C++ API. 2006-10-21 Adam Roben Reviewed by Anders. Popup tweaks. * platform/PopupMenu.h: 2006-10-21 Darin Adler * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): Oops, edited this before landing it and introduced a null-deref! This fixes it. 2006-10-21 Darin Adler Reviewed by Anders. - fix http://bugs.webkit.org/show_bug.cgi?id=11379 assertion failure seen in editing tests (in new DeleteButtonController) I cleaned up the relationship between the Frame, Editor, EditorClient, and DeleteButtonController a bit while also making the simple change to fix the assertion failure. * bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): * page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership. * page/Frame.cpp: (WebCore::Frame::Frame): Ditto. (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents function, and moved it to Editor rather than right on the DeleteButtonController. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto. * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same. * editing/DeleteButtonController.h: * editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*. The general pattern is that we always use the Frame* as the frame identifier. See FrameTree, for example. (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection function. Includes an additional check for whether the container is contentEditable, which was missing from the old version. This prevents the assertion failure. Also added a check that the table itself is editable. (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper. (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary selection parameter. No need to pass in the state of the frame since we can get it if we need it. (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer. * editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be formatted on multiple lines as usual. (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller. (WebCore::Editor::respondToChangedContents): Ditto. (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership. * editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being defined inline to decouple so that we don't have to include DeleteButtonController.h. That way changes to DeleteButtonController.h cause very little to recompile. * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Updated to call the editor instead of the delete button controller for the selection change. 2006-10-21 Anders Carlsson Reviewed by Darin. * loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): * platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't leak the header dictionary. 2006-10-21 Darin Adler Reviewed by Adam. - http://bugs.webkit.org/show_bug.cgi?id=11376 build scripts should invoke make with "-j" option for multiple processors * WebCore.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make. 2006-10-21 Timothy Hatcher Reviewed by Geoff. HTML Editing: Basic table editing and culling Initial implementaltion of table deletion user interface: * Interface shows up on the nearest table containing the entire selection. * Shows a Dashboard style close button in the top left corner. * Shows a 60% opaque black outline around the table. * Adds a new EditorClient function shouldShowDeleteInterface. Also adds a new constructor CachedImage and setter functions on HTMLImageElement and HTMLImageLoader allowing an Image object to be set and image element in the page. This change also paves the way to allow an NSImage setter on DOMHTMLImageElement. * Resources/deleteButton.tiff: Added. * Resources/deleteButtonPressed.tiff: Added. * WebCore.xcodeproj/project.pbxproj: * bridge/EditorClient.h: * editing/DeleteButton.cpp: Added. (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click * editing/DeleteButton.h: Added. * editing/DeleteButtonController.cpp: Added. (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size (WebCore::DeleteButtonController::show): shows the interface on a new element (WebCore::DeleteButtonController::hide): hides the existing interface (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element * editing/DeleteButtonController.h: Added. (WebCore::DeleteButtonController::target): getter for the current target * editing/Editor.cpp: (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client * editing/Editor.h: (WebCore::Editor::frame): new getter (WebCore::Editor::deleteButtonController): ditto * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection * html/HTMLImageElement.h: (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): ditto * html/HTMLImageLoader.h: * loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): new constructor that takes an Image * loader/CachedImage.h: ditto * page/Frame.cpp: (WebCore::Frame::selectionController): cleanup coding style (WebCore::Frame::editor): ditto (WebCore::Frame::command): ditto (WebCore::Frame::appliedEditing): tell the delete button outline to update (WebCore::Frame::unappliedEditing): ditto (WebCore::Frame::reappliedEditing): ditto * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed 2006-10-21 Sam Weinig Reviewed by Tim H. Cleanup bindings generation a little through re-factoring and general style cleanup. * bindings/scripts/CodeGenerator.pm: * bindings/scripts/CodeGeneratorJS.pm: * bindings/scripts/CodeGeneratorObjC.pm: 2006-10-21 Nikolas Zimmermann Reviewed by Mitz. Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor. * CMakeLists.txt: * platform/qt/EditorClientQt.cpp: Added. (WebCore::EditorClientQt::shouldDeleteRange): * platform/qt/EditorClientQt.h: Added. (WebCore::EditorClientQt::~EditorClientQt): * platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): * platform/qt/FrameQt.h: 2006-10-21 Sam Weinig Reviewed by Tim H. Fix for http://bugs.webkit.org/show_bug.cgi?id=11372 Auto-generate a few more Objective-C DOM methods. - Auto-generate getMatchedCSSRules and getComputedStyle methods. * bindings/objc/DOMCSS.h: * bindings/objc/DOMCSS.mm: * bindings/objc/DOMExtensions.h: * bindings/objc/PublicDOMInterfaces.h: * bindings/scripts/CodeGeneratorObjC.pm: * dom/Document.idl: * page/DOMWindow.idl: 2006-10-21 Nikolas Zimmermann Reviewed by aliu, landed by aliu. Fix Qt/Linux build. * CMakeLists.txt: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): * platform/qt/SoundQt.cpp: Added. (WebCore::systemBeep): 2006-10-21 Nikolas Zimmermann Reviewed by Mitz, landed by ap. Fix obscure crashes in RenderTableSection on Rob's musicdb file. The problem was a missing layout() call on the frame view. Thanks go to Mitz Pettel for the initial hint! * platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::paintEvent): 2006-10-20 Steve Falkenburg Reviewed by Anders. Send User-Agent on requests. Send custom request headers properly. * platform/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers 2006-10-20 Timothy Hatcher Reviewed by Hyatt. Fix some bad formatting. * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): 2006-10-20 Darin Adler Reviewed by John. - fixed REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings * loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key" as the key, not the dictionary itself. 2006-10-20 Alice Liu Reviewed by Maciej. This is the initial foundation for the EditingController class and everything else it needs to work. The idea is that the Frame has an EditingController object that it calls to handle editing commands, the most simple examples being copy/paste. This controller will handle these editing commands in WebCore, and only hand off to WebKit to call editing delegates (to the let the app intercept editing actions if it wants to). Thus we need a platform-specific client to which the EditingController hands off the delegate calls, WebCoreEditingControllerClient. On the WebCore side this is an abstract base class, and on the WebKit(Mac) side this is an ObjC++ subclass, WebEditingControllerClient. How does the EditingController get a handle to its platform-specific client? In WebKit, the creator of a platform-specific Frame creates the client (which is ref-counted) and passes it down the chain of constructors until it gets back to the EditingController, which then refs it in its constructor and derefs in its destructor. No Layout tests needed. * WebCore.xcodeproj/project.pbxproj: Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile * bridge/EditorClient.h: Added. (WebCore::EditorClient::~EditorClient): * bridge/mac/FrameMac.h: Added an EditingClient to the constructor, to pass down to Frame constructor * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Passed client down to Frame constructor * bridge/mac/WebCoreFrameBridge.h: Added an EditingClient to the constructor, to pass down to FrameMac constructor * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Passed client down to FrameMac constructor * editing/Editor.cpp: Added. Mostly stuf implementations of the following functions, except for a couple. These are all needed by cut, copy, paste, delete. (WebCore::generalPasteboard): (WebCore::Editor::canCopy): (WebCore::Editor::canCut): (WebCore::Editor::canDelete): (WebCore::Editor::canDeleteRange): (WebCore::Editor::canPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::isSelectionRichlyEditable): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::Editor): (WebCore::Editor::~Editor): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste): (WebCore::Editor::performDelete): * editing/Editor.h: Added. * page/Frame.h: Added an EditingClient to the constructor, to pass down to Editor constructor * page/Frame.cpp: (WebCore::Frame::Frame): Passed down to Editor constructor (WebCore::Frame::editor): Accessor for Editor stored in FramePrivate * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added an Editor object to the FramePrivate data * platform/Sound.h: Added. Made a platform-independent accessor to a beep function * platform/mac/SoundMac.mm: Added. (WebCore::systemBeep): calls mac system beep 2006-10-20 David Hyatt Make sure to support the "encoding" property on form elements for legacy compatibility. Reviewed by darin/john No test cases added. Not sure how to do a form submission of various encodings as a layout test. * html/HTMLFormElement.h: (WebCore::HTMLFormElement::encoding): (WebCore::HTMLFormElement::setEncoding): * html/HTMLFormElement.idl: 2006-10-20 Nikolas Zimmermann Reviewed and by Anders. Fix warnings in JS generation by killing the whole isRefPtr logic, and just using WTF::getPtr as Sam Weinig suggested. Also kill some places using get() where getPtr() is cleaner - not for m_impl.get(). * CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs. * bindings/scripts/CodeGeneratorJS.pm: 2006-10-20 Darin Adler - rolled out my loader change; caused world leak and possibly a plug-in crash 2006-10-20 Anders Carlsson Reviewed by Tim H * loader/mac/LoaderFunctionsMac.mm: Autorelease the header NSDictionary. 2006-10-20 Anders Carlsson Reviewed by Geoff. * bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Check if the timeout id is still in the table before trying to access it. If it isn't in the table it has been deleted inside of the execute method. 2006-10-20 Anders Carlsson Reviewed by Darin and Geoff. Remove debugging output. * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): 2006-10-20 David Harrison Reviewed by John. REGRESSON: Drag selecting is erratic No test because it would require autoscrolling, which is not available to layout tests. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use hitTest() to find the correct node. (WebCore::RenderLayer::hitTest): Trivial source formatting. 2006-10-20 Nikolas Zimmermann Reviewed and landed by Anders. Fix regression introduced during the ResourceLoader transition (Maciej's rewrite). * platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::add): 2006-10-20 Darin Adler Reviewed by Adele. - convert WebLoader and its 3 subclasses to C++ Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but there's currently another class with that name). Renamed WebMainResourceLoader to WebCore::MainResourceLoader. Renamed WebSubresourceLoader to WebCore::SubresourceLoader. Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader. Converted the classes to C++ and added Objective-C delegates to forward from API that still requires Objective-C. Did not yet rename the source files. * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes. * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project. * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace. * loader/mac/WebLoader.h: * loader/mac/WebLoader.mm: * loader/mac/WebMainResourceLoader.h: * loader/mac/WebMainResourceLoader.mm: * loader/mac/WebNetscapePlugInStreamLoader.h: * loader/mac/WebNetscapePlugInStreamLoader.mm: * loader/mac/WebSubresourceLoader.h: * loader/mac/WebSubresourceLoader.mm: Translate to C++. * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): * loader/mac/WebFrameLoader.h: * loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): * loader/mac/WebFrameLoaderClient.h: Call the new C++ API. 2006-10-20 Nikolas Zimmermann Reviewed and landed by Anders. Offer a way for WebKitPart to be able to detect when the webpage has been completly loaded (including subresources). Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp. * CMakeLists.txt: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::client): * platform/qt/FrameQt.h: * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::checkLoaded): (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests): (WebCore::FrameQtClientDefault::receivedAllData): * platform/qt/FrameQtClient.h: * platform/qt/LoaderFunctionsQt.cpp: (WebCore::CheckCacheObjectStatus): * platform/qt/PopupMenuQt.cpp: * platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::add): * platform/qt/ResourceLoaderManager.h: * platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::start): 2006-10-20 Steve Falkenburg Reviewed by Geoff. Fix compiler warnings * platform/ResourceLoaderClient.h: 2006-10-20 Sam Weinig Reviewed by Mitz. Win32 build fix and cleanup. * WebCore.vcproj/WebCore/WebCore.vcproj: * bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::submitForm): * page/ResourceRequest.h: (WebCore::ResourceRequest::addHTTPHeaderField): * platform/win/TemporaryLinkStubs.cpp: (WebCore::Slider::~Slider): (WebCore::Slider::setMinValue): (WebCore::searchableIndexIntroduction): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): (WebCore::FrameWin::runJavaScriptPrompt): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::createFrame): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::createPlugin): (WebCore::FrameWin::objectContentType): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::historyContains): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultLanguage): (WebCore::findWordBoundary): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::startHTTPRequest): (WebCore::TextField::TextField): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::hide): 2006-10-20 Rob Buis Reviewed by Darin. http://bugs.webkit.org/show_bug.cgi?id=11303 Path::transform() should be implemented on Qt build Use QPainterPath API to implement Path::transform. This fixes svg/custom/clip-path-with-transform.svg on the qt build. * platform/qt/PathQt.cpp: (WebCore::Path::transform): 2006-10-20 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg clipping and painting classes. * ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::parseMappedAttribute): (WebCore::SVGClipPathElement::canvasResource): * ksvg2/svg/SVGClipPathElement.h: * ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::canvasResource): * ksvg2/svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::rendererIsNeeded): * ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): * ksvg2/svg/SVGMaskElement.h: (WebCore::SVGMaskElement::rendererIsNeeded): * ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::setPaint): (WebCore::SVGPaint::cssText): * ksvg2/svg/SVGPaint.h: 2006-10-20 David Hyatt Make sure to do the code that checks the repeatInterval before the timer has been deleted. (Duh.) Reviewed by andersca * bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::setNestingLevel): (KJS::Window::timerFired): (KJS::DOMWindowTimer::fired): * platform/Timer.h: 2006-10-20 David Hyatt Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached. At that point clamp to 10ms to prevent excessive CPU usage. Reviewed by anders * bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::nestingLevel): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::DOMWindowTimer::fired): * platform/Timer.h: (WebCore::TimerBase::startRepeating): (WebCore::TimerBase::startOneShot): (WebCore::TimerBase::repeatInterval): (WebCore::TimerBase::augmentRepeatInterval): (WebCore::TimerBase::inHeap): (WebCore::Timer::Timer): (WebCore::Timer::fired): 2006-10-20 Steve Falkenburg Build fix * ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): 2006-10-19 Steve Falkenburg Reviewed by Adam. Use GetKeyState rather than GetAsyncKeyState since we're calling in these cases in direct response to an event, and want the key state associated with that event. Pass triggering event to url selection method. * bridge/mac/FrameMac.h: Add triggeringEvent parameter * bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter * bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter * bridge/win/FrameWin.h: Add triggeringEvent parameter * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method * page/Frame.cpp: (WebCore::Frame::changeLocation): Add 0 as triggeringEvent (WebCore::Frame::urlSelected): Pass through triggeringEvent * page/Frame.h: Add triggeringEvent parameter to urlSelected methods * platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState (WebCore::PlatformMouseEvent::PlatformMouseEvent): 2006-10-19 David Hyatt Correct typos from changing "flush" to "prune" using automated search/replace. Change the cache heuristic for flushing to allow a higher watermark before initiating an aggressive prune. This ensures that small cache sizes are no worse in terms of performance than the old buggy cache. Make sizes unsigned instead of ints in the cache's APIs and member variables. * loader/Cache.cpp: (WebCore::Cache::prune): (WebCore::Cache::setMaximumSize): * loader/Cache.h: (WebCore::Cache::maximumSize): 2006-10-19 Anders Carlsson Reviewed by Daddy Hyatt. Use a real hash map for the headers. * loader/LoaderFunctions.h: * loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): * platform/ResourceLoader.cpp: (WebCore::ResourceLoader::setRequestHeaders): (WebCore::ResourceLoader::requestHeaders): * platform/ResourceLoader.h: * platform/ResourceLoaderInternal.h: * platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): * xml/xmlhttprequest.h: 2006-10-19 Adam Roben Reviewed by Ada. Pippity-poppity popup tweaks. * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if requested and the new index is actually different than the old one. * platform/IntPoint.h: Added another casting operator. * platform/PopupMenu.cpp: Removed. The code in here, while platform-independent, was only useful for the NSPopUpButtonCell implementation of popup menus, so I've moved it to PopupMenuMac.mm. * platform/PopupMenu.h: Moved the definition of PopupMenu::create into the header since it's fairly simple. Made some more methods private now that we don't have subclasses and virtual methods anymore. (WebCore::PopupMenu::create): (WebCore::PopupMenu::menuList): (WebCore::PopupMenu::itemHeight): (WebCore::PopupMenu::windowRect): (WebCore::PopupMenu::listIndexAtPoint): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setScrollOffset): (WebCore::PopupMenu::scrollOffset): (WebCore::PopupMenu::wheelDelta): * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp. (WebCore::PopupMenu::populate): Call our own clear() method to clear the menu. * platform/win/IntPointWin.cpp: New casting operator. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINTS): 2006-10-19 Adam Roben Reviewed by Darin. Cleaning up Document::nextFocusNode and Document::previousFocusNode. * dom/Document.cpp: (WebCore::Document::nextFocusNode): (WebCore::Document::previousFocusNode): 2006-10-19 Maciej Stachowiak Reviewed by Geoff. - implement new ResourceRequest API and fix up code as appropriate * bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction): * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): * bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): * dom/DOMImplementation.cpp: (WebCore::addString): (WebCore::isSVG10Feature): (WebCore::isSVG11Feature): * dom/Document.h: * editing/CommandByName.cpp: * editing/JSEditor.cpp: * page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): * page/Frame.h: * page/FramePrivate.h: * page/ResourceRequest.h: (WebCore::): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::cachePolicy): (WebCore::ResourceRequest::setCachePolicy): (WebCore::ResourceRequest::timeoutInterval): (WebCore::ResourceRequest::setTimeoutInterval): (WebCore::ResourceRequest::mainDocumentURL): (WebCore::ResourceRequest::setMainDocumentURL): (WebCore::ResourceRequest::httpMethod): (WebCore::ResourceRequest::setHTTPMethod): (WebCore::ResourceRequest::httpHeaderField): (WebCore::ResourceRequest::setHTTPHeaderField): (WebCore::ResourceRequest::httpContentType): (WebCore::ResourceRequest::setHTTPContentType): (WebCore::ResourceRequest::httpReferrer): (WebCore::ResourceRequest::setHTTPReferrer): (WebCore::ResourceRequest::httpUserAgent): (WebCore::ResourceRequest::setHTTPUserAgent): (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody): (WebCore::ResourceRequest::addHTTPHeaderField): * platform/FontCache.cpp: (WebCore::computeHash): * platform/StringHash.h: (WTF::): * platform/StringImpl.cpp: (WebCore::equalIgnoringCase): * rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): 2006-10-19 Justin Garcia Reviewed by levi API: WebView should have a method something like incrementLeftMarginBy: or indentBy: Fixed indent/outdent to only increment the left margin, to match other browsers. Used blockquote class="webkit-indent-blockquote" to do this. Mail can now implement indent/outdent by customizing the appearance of these blockquotes, instead of using a new API. * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes. * editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Added. (WebCore::createIndentBlockquoteElement): Added. (WebCore::isIndentBlockquote): Added. (WebCore::isListOrBlockquote): Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed a bug in the code that added an extra br if the placeholder collapsed upon insertion. Used the new indentBlockquote checks and enclosing element getters. (WebCore::IndentOutdentCommand::indentRegion): Ditto. (WebCore::IndentOutdentCommand::outdentParagraph): Ditto. Cleaned up the logic to pull the selection out of a list a bit. * editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Added this generic enclosing element getter. * editing/htmlediting.h: 2006-10-19 Timothy Hatcher Rolling out the this change since it caused a bad regression: REGRESSION: Incomplete repaint of text area when deleting (11277) 2006-10-12 Adele Peterson Reviewed by Dave Harrison. - Fixed REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing) * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields. 2006-10-19 Nikolas Zimmermann Reviewed and landed by Anders. Fix Qt/Linux build. * CMakeLists.txt: * loader/Cache.h: * platform/qt/BrowserExtensionQt.cpp: * platform/qt/BrowserExtensionQt.h: * platform/qt/CursorQt.cpp: (WebCore::pointerCursor): * platform/qt/LoaderFunctionsQt.cpp: (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckCacheObjectStatus): * platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::receivedResponse): 2006-10-19 Sam Weinig Reviewed by ap. Win32 build fix. * bridge/win/FrameWin.cpp: * bridge/win/FrameWin.h: * platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding): 2006-10-19 Alexey Proskuryakov Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11141 REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href to document URL. This matches WinIE and partially matches Firefox - although the latter reports the href as if it were inherited, it still doesn't use it when resolving URIs in @import rules. Test: http/tests/uri/css-href.php * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged): * ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged): 2006-10-19 Anders Carlsson * loader/Cache.cpp: Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems with case-sensitive file systems. 2006-10-19 Anders Carlsson Reviewed by Maciej, Brady. Remove "charset" from the ResourceLoader metadata map and use a getter function instead. Also, rename charset to encoding in a couple of places. * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::setEncoding): * loader/CachedCSSStyleSheet.h: * loader/CachedResource.h: (WebCore::CachedResource::setEncoding): * loader/CachedScript.cpp: (WebCore::CachedScript::setEncoding): * loader/CachedScript.h: * loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::setEncoding): * loader/CachedXBLDocument.h: * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setEncoding): * loader/CachedXSLStyleSheet.h: * loader/loader.cpp: (WebCore::Loader::receivedResponse): * platform/ResourceLoader.cpp: (WebCore::ResourceLoader::responseEncoding): (WebCore::ResourceLoader::queryMetaData): * platform/ResourceLoader.h: * platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal): * platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::receivedResponse): * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData): 2006-10-19 David Hyatt Rewrite of the WebCore memory cache. The following changes have been made (along with many more): (1) Referenced objects are now also cached. (2) Pruning of the cache will occur once the cache is both full and in addition more than half full with unreferenced objects. (3) The prune is much more aggressive now, since referenced objects are counted when pruning. The cache will therefore often prune out every unreferenced object if lots of windows/tabs are open. (4) Consolidated the request methods for various types of resources to go through a single requestResource bottleneck function. (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was identical. (6) Changed "object" to "resource" everywhere. (7) The Cache is now an actual object, obtained via cache(). (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled and enabled. (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use. (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects in the LRU lists). Also fixed a bug with the "-SP" part of the algorithm where the access count was being incorrectly weighted too much due to a math error. (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about the size of referenced resources. Reviewed by Maciej, bradee-oh * bridge/mac/WebCoreCache.mm: (+[WebCoreCache statistics]): (+[WebCoreCache empty]): (+[WebCoreCache setDisabled:]): * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): * css/CSSImageValue.cpp: (WebCore::CSSImageValue::image): * dom/XMLTokenizer.cpp: (WebCore::openFunc): * html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): * loader/Cache.cpp: (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::resourceForURL): (WebCore::Cache::prune): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::addDocLoader): (WebCore::Cache::removeDocLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled): * loader/Cache.h: (WebCore::LRUList::LRUList): (WebCore::Cache::loader): (WebCore::Cache::maximumSize): (WebCore::Cache::disabled): (WebCore::Cache::addToLiveObjectSize): (WebCore::Cache::removeFromLiveObjectSize): (WebCore::Cache::TypeStatistic::TypeStatistic): * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): * loader/CachedCSSStyleSheet.h: * loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::~CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::data): * loader/CachedImage.h: (WebCore::CachedImage::stillNeedsLoad): * loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::finish): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired): (WebCore::CachedResource::setRequest): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setSize): * loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::setCharset): (WebCore::CachedResource::url): (WebCore::CachedResource::type): (WebCore::CachedResource::referenced): (WebCore::CachedResource::count): (WebCore::CachedResource::status): (WebCore::CachedResource::size): (WebCore::CachedResource::isLoaded): (WebCore::CachedResource::setLoading): (WebCore::CachedResource::isImage): (WebCore::CachedResource::accessCount): (WebCore::CachedResource::increaseAccessCount): (WebCore::CachedResource::setInCache): (WebCore::CachedResource::inCache): (WebCore::CachedResource::cachePolicy): (WebCore::CachedResource::response): (WebCore::CachedResource::allData): (WebCore::CachedResource::canDelete): (WebCore::CachedResource::schedule): (WebCore::CachedResource::accept): (WebCore::CachedResource::setAccept): * loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): * loader/CachedScript.h: * loader/CachedXBLDocument.cpp: * loader/CachedXBLDocument.h: * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): * loader/CachedXSLStyleSheet.h: * loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setAutoLoadImages): (WebCore::DocLoader::removeCachedResource): * loader/DocLoader.h: (WebCore::DocLoader::cachedResource): (WebCore::DocLoader::allCachedResources): (WebCore::DocLoader::autoLoadImages): (WebCore::DocLoader::cachePolicy): (WebCore::DocLoader::expireDate): (WebCore::DocLoader::frame): (WebCore::DocLoader::doc): (WebCore::DocLoader::loadInProgress): * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): * loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::cancelRequests): * loader/mac/LoaderFunctionsMac.mm: (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckCacheObjectStatus): * page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::Frame::Frame): (WebCore::Frame::stopLoading): (WebCore::Frame::setAutoLoadImages): (WebCore::Frame::autoLoadImages): (WebCore::Frame::begin): (WebCore::Frame::checkCompleted): (WebCore::Frame::reparseConfiguration): * page/Frame.h: * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): 2006-10-18 Maciej Stachowiak Reviewed by Geoff. - remove vestiges of KXMLCore name (former name of WTF). * config.h: 2006-10-18 Geoffrey Garen Reviewed by Beth. Fixed http://bugs.webkit.org/show_bug.cgi?id=11222 Some global JS objects lacked references to their property hashtables, so for-in enumeration didn't work. I added the references, and then removed a few bogus properties from the tables. The bogus ones got in there through bit rot. We should come up with some solution to these hand-written bindings bugs. Maybe we could use a script to autogenerate them or something. * bindings/js/kjs_window.cpp: (KJS::): (KJS::History::getValueProperty): 2006-10-18 Adam Roben Reviewed by Brady. Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of U+000019 (Backtab). This matches our windowsKeyCode for this key combination. * platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): 2006-10-18 Steve Falkenburg Reviewed by Adam, Brady. Loader tweaks. * platform/cf/ResourceLoaderCFNet.cpp: (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::didReceiveChallenge): (WebCore::runLoaderThread): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel): 2006-10-18 Timothy Hatcher Reviewed by Darin. Manipulating popup in HTML page crashed Xcode - Store the Mac popup button cell as a RetainPtr to prevent GC collection. - Convert more ObjC local statics and member variables to use RetainPtr. - Convert more CFRetain/CFRelease to HardRetain/HardRelease. * bindings/objc/DOM.mm: (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease * bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease (WebCore::AXObjectCache::get): use HardRetain and not CFRetain (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease * bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto * bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr * platform/cf/RetainPtr.h: (WTF::::operator): implement a missing operator= template function * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): remove nil initialization (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup (WebCore::PopupMenu::populate): ditto (WebCore::PopupMenu::show): ditto (WebCore::PopupMenu::hide): ditto (WebCore::PopupMenu::addSeparator): ditto (WebCore::PopupMenu::addGroupLabel): ditto (WebCore::PopupMenu::addOption): ditto 2006-10-18 Geoffrey Garen Reviewed by Adele. Fixed JavaScript timers do not fire if controls are tracking or menus are down (run loop modes) I spent a few hours trying to write an automated test, but DRT doesn't seem to support it. Manual tests attached to related bugs. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::passMouseDownEventToWidget): * platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime): 2006-10-18 Sam Weinig Reviewed by Maciej. More Win32 buildfix. * bridge/win/FrameWin.h: 2006-10-18 Sam Weinig Reviewed by Mitz Win32 build fix. * bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::BrowserExtensionWin): (WebCore::BrowserExtensionWin::createNewWindow): * bridge/win/BrowserExtensionWin.h: * bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow): * bridge/win/FrameWin.h: * platform/win/CursorWin.cpp: * platform/win/TemporaryLinkStubs.cpp: (Image::getHBITMAP): 2006-10-18 Justin Garcia Reviewed by harrison GMail Editor: Hang occurs when removing list styling on text in a rich text message List removal moves the contents of every list item out of the list it's in. When the code tried to move the contents of an empty list item (an li with no child nodes, not even a placeholder br), moveParagraph didn't prune the li, like it would if the li had a placeholder inside it. So the list removal code went into an infinite loop, continually attempting to de-list an empty list item. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): If the selection to move was empty and in an empty block that doesn't require a placeholder to prop itself open (like a bordered div or an li), remove it during the move. 2006-10-18 Adele Peterson Reviewed by Beth. - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343 REGRESSION (r16975): fast/events/objc-event-api is failing When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of a call to invalidateClick. This change moves it back to the sequence that existed before. This allows the click count to get properly reset during a selection. * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): 2006-10-17 Geoffrey Garen Reviewed by Anders. Factored common scaling code into a helper function. * platform/mac/ScreenMac.mm: (WebCore::scale): (WebCore::scaleScreenRectToPageCoordinates): (WebCore::scalePageRectToScreenCoordinates): 2006-10-17 Steve Falkenburg Build fixes * bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow): * bridge/win/BrowserExtensionWin.h: * bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow): * bridge/win/FrameWin.h: * platform/gdk/BrowserExtensionGdk.h: * platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): * platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow): * platform/qt/BrowserExtensionQt.h: 2006-10-17 Geoffrey Garen Reviewed by Anders. Renamed WindowArgs to WindowFeatures, and moved it into its own header. ("Features" is the term of art in IE documentation. "Args" is pirate talk.) * WebCore.xcodeproj/project.pbxproj: * bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction): * bridge/BrowserExtension.h: * bridge/WindowFeatures.h: Added. * bridge/mac/BrowserExtensionMac.h: * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): 2006-10-17 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11268 Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint. - Moves the contents of ksvg/bindings/js/ to bindings/js/. - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/. - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching the other CSSValue classing, and allowing the bindings to allocate appropriately. - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing generation for Objective-C. - Assorted style cleanups. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]): * bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]): * bindings/objc/DOMSVG.h: * bindings/objc/DOMSVGNumber.mm: (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]): * bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]): * bindings/objc/DOMSVGRect.mm: (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]): * bindings/scripts/CodeGeneratorObjC.pm: * css/StyleBase.h: (WebCore::StyleBase::isSVGColor): (WebCore::StyleBase::isSVGPaint): * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed. * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed. * ksvg2/bindings/js/JSSVGNumber.cpp: Removed. * ksvg2/bindings/js/JSSVGNumber.h: Removed. * ksvg2/bindings/js/JSSVGPoint.cpp: Removed. * ksvg2/bindings/js/JSSVGPoint.h: Removed. * ksvg2/bindings/js/JSSVGRect.cpp: Removed. * ksvg2/bindings/js/JSSVGRect.h: Removed. * ksvg2/svg/SVGColor.h: (WebCore::SVGColor::isSVGColor): * ksvg2/svg/SVGFECompositeElement.idl: * ksvg2/svg/SVGFEFloodElement.idl: * ksvg2/svg/SVGLocatable.idl: * ksvg2/svg/SVGMarkerElement.idl: * ksvg2/svg/SVGPaint.h: (WebCore::SVGPaint::isSVGPaint): * ksvg2/svg/SVGRectElement.idl: * ksvg2/svg/SVGZoomEvent.idl: Removed. 2006-10-17 David Hyatt Prepare for the elimination of the RenderLayer for elements. The layer is still present, but this patch makes everything work without a root layer being around. Reviewed by beth * rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::nodeAtPoint): * rendering/RenderLayer.cpp: (WebCore::frameVisibleRect): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::intersectsDamageRect): * rendering/RenderObject.cpp: (WebCore::RenderObject::setInnerNode): * rendering/RenderView.cpp: (WebCore::RenderView::paint): 2006-10-17 David Hyatt Back out my previous patch to the WebCore memory cache. * loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): * loader/Cache.h: * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::deref): * loader/CachedCSSStyleSheet.h: * loader/CachedImage.cpp: (WebCore::CachedImage::deref): * loader/CachedImage.h: * loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref): * loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList): * loader/CachedScript.cpp: (WebCore::CachedScript::deref): * loader/CachedScript.h: * loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::deref): * loader/CachedXBLDocument.h: * loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::deref): * loader/CachedXSLStyleSheet.h: 2006-10-17 Oliver Hunt Reviewed by Anders. Make north and east resize cursors use correct image * platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): 2006-10-17 Oliver Hunt Reviewed by Brady Various cursor fixes * page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): * platform/Cursor.h: * platform/mac/CursorMac.mm: (WebCore::pointerCursor): * platform/win/CursorWin.cpp: (WebCore::supportsAlphaCursors): (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::pointerCursor): 2006-10-17 Justin Garcia Reviewed by harrison REGRESSION: In Mail, caret is visible when the message body isn't focused * page/Frame.cpp: (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error (like when the frame that contains the caret isn't focused) then we don't want to paint the caret. We should eventually move to using a single bool for caret painting. 2006-10-17 Justin Garcia Reviewed by harrison REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body Functions call recomputCaretRect to see if the caret rect has changed, and, if it has, they invalidate (repaint) it. recomputeCaretRect was returning false if the caret turned into a range selection or was blown away. * editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Don't early return if !isCaret(). Obtain the FrameView* using the m_frame pointer, because m_sel may now be null. 2006-10-17 Geoffrey Garen Reviewed by Brady. BrowserExtension cleanup. - Removed unnecessary #include of BrowserExtension in Frame.h, added #includes to compensate in other files. - Removed unused versions of createNewWindow. * bindings/js/kjs_window.cpp: * bridge/BrowserExtension.h: * bridge/mac/BrowserExtensionMac.h: * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): * bridge/mac/WebCoreFrameBridge.mm: * html/HTMLFormElement.cpp: * loader/mac/LoaderFunctionsMac.mm: * page/Frame.h: * page/FramePrivate.h: 2006-10-15 Geoffrey Garen Reviewed by Adam. - Fixed "FIXME: Violates Liskov Substitution principle." IFRAME was never a true subclass of FRAME, since they disagreed on a number of behaviors, which, confusingly, IFRAME just overrode and contradicted. The fix here is to factor out things common to IFRAME and FRAME into a common base class, HTMLFrameElementBase. I also changed some " *" to "* " and added #includes in files that implicitly assumed that HTMLIFrameElement.h #included HTMLFrameElement.h. 2006-10-16 Justin Garcia Reviewed by sullivan REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237) We set m_needsLayout to false and call caretRect() in the hopes that it will give us the old caret rect. It in fact corrects the caret rect for an offset that it believes is due to scrolling but which is actually due to a change in selection without an accompanying layout. So it returns the new caret rect regardless of what m_needsLayout is set to. * editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that adds a one pixel slop to this new function. (WebCore::SelectionController::caretRepaintRect): Moved this code to repaintRectForCaret. (WebCore::SelectionController::recomputeCaretRect): Compare the old caret rect to the new one that's computed with a fresh layout. If they are different, invalidate both repaint rects. 2006-10-17 David Harrison Reviewed by Adele. VO not honoring secure edit fields in web pages * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isPasswordField]): New. Checks for input with inputType() of PASSWORD. (-[WebCoreAXObject subrole]): Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField]. (-[WebCoreAXObject roleDescription]): Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription. (-[WebCoreAXObject value]): Return nil if [self isPasswordField]. (-[WebCoreAXObject accessibilityAttributeNames]): Return generic attributes if [self isPasswordField]. (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Return empty array if [self isPasswordField]. 2006-10-17 David Hyatt Fix "flash to white' problem on yahoo.com as it finishes loading. Refine the FOUC suppression code so that it will only run if the body still has no renderer. * dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): 2006-10-17 David Hyatt Fix a bug where the WebCore memory cache could grow without bound during extended browsing sessions. Reviewed by mjs * loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): * loader/Cache.h: * loader/CachedCSSStyleSheet.cpp: * loader/CachedCSSStyleSheet.h: * loader/CachedImage.cpp: * loader/CachedImage.h: * loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref): * loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList): * loader/CachedScript.cpp: * loader/CachedScript.h: * loader/CachedXBLDocument.cpp: * loader/CachedXBLDocument.h: * loader/CachedXSLStyleSheet.cpp: * loader/CachedXSLStyleSheet.h: 2006-10-13 Justin Garcia Reviewed by harrison Editing: -indent: method unimplemented Added Frame and bridge methods. * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge indent]): (-[WebCoreFrameBridge outdent]): * page/Frame.cpp: (WebCore::Frame::indent): (WebCore::Frame::outdent): * page/Frame.h: 2006-10-16 Adam Roben Reviewed by John. More menulist cleanup/tweaking. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index' parameter to 'optionIndex' for clarity. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over items that are not enabled s don't appear indented in the actual control. 2006-10-16 Sam Weinig Reviewed by Adam. Win32 build fix. * WebCore.vcproj/WebCore/WebCore.vcproj: * bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow): * bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow): * bridge/win/FrameWin.h: * loader/loader.cpp: (WebCore::Loader::receivedResponse): * platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext): * platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURLRequest): (WebCore::ServeSynchronousRequest): (WebCore::CheckIfReloading): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (CachedResource::setResponse): (CachedResource::setAllData): * rendering/RenderThemeWin.cpp: (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): 2006-10-16 David Hyatt Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned element is the initial containing block (our RenderView). Reviewed by mjs Test cases added to fast/block/positioning for quirks and strict modes. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): * rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteVertical): * rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container): 2006-10-15 Krzysztof Kowalczyk Reviewed by Anders. Misc Gdk/Linux build fixes. * platform/gdk/BrowserExtensionGdk.h: * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected): * platform/gdk/FrameGdk.h: * platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption): * platform/gdk/RenderPopupMenuGdk.h: * platform/gdk/RenderThemeGdk.cpp: * platform/gdk/RenderThemeGdk.h: (WebCore::RenderThemeGdk::RenderThemeGdk): * platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): (BrowserExtensionGdk::BrowserExtensionGdk): (BrowserExtensionGdk::setTypedIconURL): (BrowserExtensionGdk::setIconURL): (BrowserExtensionGdk::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CacheObjectExpiresTime): (WebCore::ResponseURL): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): (FileChooser::disconnectUploadControl): * rendering/RenderTheme.h: * rendering/RenderThemeMac.h: 2006-10-15 Sam Weinig Reviewed by Mitz. Fix for http://bugs.webkit.org/show_bug.cgi?id=11294 Add getModifierState method to KeyboardEvent * bindings/objc/DOMEvents.h: * bindings/objc/DOMEvents.mm: * bindings/objc/PublicDOMInterfaces.h: * dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::getModifierState): * dom/KeyboardEvent.h: * dom/KeyboardEvent.idl: 2006-10-15 Nikolas Zimmermann Reviewed and landed by ap. Changed PlatformResponse handling for Qt. Don't just store a QString object containing the data but a new PlatformResponseQt struct containing data and url, and store it as pointer. This is compatible to the OS X handling and removes the Qt plaform specific hacks from CachedCSSStyleSheet, CachedResource & loader. Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move all methods from TemporaryLinkStubs related to loading in there, and implement some like ServeSynchronousRequest (yay for xslt handling!). * CMakeLists.txt: * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): * loader/CachedResource.h: (WebCore::CachedResource::CachedResource): * loader/loader.cpp: (WebCore::Loader::receivedResponse): * platform/ResourceLoaderClient.h: * platform/ResourceLoaderInternal.h: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::createEmptyDocument): * platform/qt/FrameQt.h: (WebCore::QtFrame): * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::loadFinished): (WebCore::FrameQtClientDefault::receivedAllData): * platform/qt/FrameQtClient.h: * platform/qt/LoaderFunctionsQt.cpp: Added. (WebCore::ServeSynchronousRequest): (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): * platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::remove): * platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::receivedResponse): * platform/qt/TemporaryLinkStubs.cpp: 2006-10-14 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg basic datastructure classes. * ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::valueAsString): (WebCore::SVGAngle::context): (WebCore::SVGAngle::setContext): * ksvg2/svg/SVGAngle.h: * ksvg2/svg/SVGColor.cpp: * ksvg2/svg/SVGColor.h: * ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement): (WebCore::SVGElement::parseMappedAttribute): (WebCore::SVGElement::childShouldCreateRenderer): * ksvg2/svg/SVGElement.h: (WebCore::svg_dynamic_cast): * ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): * ksvg2/svg/SVGFitToViewBox.h: * ksvg2/svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::parseMappedAttribute): * ksvg2/svg/SVGLangSpace.h: * ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::setValueAsString): (WebCore::SVGLength::dpi): (WebCore::SVGLength::updateValue): (WebCore::SVGLength::updateValueInSpecifiedUnits): (WebCore::SVGLength::context): (WebCore::SVGLength::setContext): * ksvg2/svg/SVGLength.h: * ksvg2/svg/SVGLengthList.cpp: * ksvg2/svg/SVGLengthList.h: * ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement): (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM): * ksvg2/svg/SVGNumberList.cpp: * ksvg2/svg/SVGNumberList.h: * ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::getCTM): * ksvg2/svg/SVGPreserveAspectRatio.h: * ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::reset): * ksvg2/svg/SVGStringList.h: * ksvg2/svg/SVGStylable.cpp: * ksvg2/svg/SVGStylable.h: * ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage): (WebCore::SVGTests::isValid): (WebCore::SVGTests::parseMappedAttribute): * ksvg2/svg/SVGTests.h: * ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute): * ksvg2/svg/SVGTransformable.h: * ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::parseMappedAttribute): * ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::parseMappedAttribute): * ksvg2/svg/SVGZoomAndPan.h: 2006-10-15 Nikolas Zimmermann Reviewed by Oliver. Implement some functions in FrameQt / ScrollViewQt. Added comments what needs to be done in quite some places, marked some functions as no-ops. * CMakeLists.txt: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::bindingRootObject): (WebCore::FrameQt::addPluginRootObject): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo): * platform/qt/FrameQt.h: * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt): (WebCore::FrameQtClientDefault::menubarVisible): (WebCore::FrameQtClientDefault::toolbarVisible): (WebCore::FrameQtClientDefault::statusbarVisible): (WebCore::FrameQtClientDefault::personalbarVisible): (WebCore::FrameQtClientDefault::locationbarVisible): * platform/qt/FrameQtClient.h: * platform/qt/ImageSourceQt.cpp: * platform/qt/RenderThemeQt.cpp: * platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollPointRecursively): * platform/qt/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): 2006-10-14 David Harrison Reviewed by Geoff. REGRESSION: Can't from tab from last link on the page to URL address field REGRESSION: Typing tab key enters no text The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless of whether frame->view()->advanceFocus() actually changed the focus. Trivial fix is to preventDefault() only if advanceFocus() returns true. * No test is possible because DumpRenderTree sets the WebView preference to tab to links, and that preference cannot be changed dynamically after the webview is initialized. Also, the "tab from last link" is not testable because DumpRenderTree uses the WebView for the whole window, so tabs can't shift focus out of the WebView regardless. * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): 2006-10-14 Nikolas Zimmermann Reviewed by Mitz. Fix Qt/Linux build & some little fixes: - Adapt to Maciej's FrameLoadRequest changes. - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object. - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit) - Fix CacheObjectExpiresTime/ResponseIsMultipart signature. * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): * loader/CachedResource.h: (WebCore::CachedResource::CachedResource): * loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): * platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow): * platform/qt/BrowserExtensionQt.h: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::openURLRequest): * platform/qt/FrameQt.h: * platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setURLForRect): * platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): 2006-10-14 David Carson Reviewed by Maciej. Fix: http://bugs.webkit.org/show_bug.cgi?id=11257 Removed Mac platform dependance, changed WebCore functions to use PlatformResponse/PlatformData rather than NSURLResponse/ NSData. * loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): * loader/CachedImage.cpp: (WebCore::CachedImage::createImage): * loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): * loader/CachedResource.h: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::response): (WebCore::CachedResource::allData): * loader/LoaderFunctions.h: * loader/loader.cpp: (WebCore::Loader::receivedResponse): * loader/mac/LoaderFunctionsMac.mm: (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): * platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): * platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): 2006-10-14 Krzysztof Kowalczyk Reviewed by Maciej. Fix GDK build by defining FrameGdkClient() constructor as non-virtual. Pure virtual classes require non-pure destructor, who knew. Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK), so that other platforms can also use CURL, if they wish. Silence compiler warning about unused variable in SharedTimerLinux.cpp * platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal): * platform/gdk/FrameGdk.h: (WebCore::FrameGdkClient::~FrameGdkClient): * platform/gdk/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::downloadTimerCallback): * platform/gdk/SharedTimerLinux.cpp: (WebCore::stopSharedTimer): 2006-10-13 Beth Dakin Reviewed by Geoff. Build fix from my last check-in. Make hasOutlineAnnotation() non- inline so that we don't have to include Document.h in RenderObject.h Doing so causes a build failure in WebKit, and it probably isn't a good idea anyway. * rendering/RenderObject.cpp: (WebCore::RenderObject::hasOutlineAnnotation): * rendering/RenderObject.h: (WebCore::RenderObject::hasOutline): 2006-10-13 Beth Dakin Patch written mostly by Ken Kraisler, but also by me. Reviewed by Hyatt. Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and PDF created by printing should have live hyperlinks * platform/GraphicsContext.cpp: (WebCore::GraphicsContext::focusRingBoundingRect): * platform/GraphicsContext.h: * platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setURLForRect): * platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setURLForRect): Implement method to add URL link to PDF document. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of querying the outline width * rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): Same as above. * rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Call the new paintOutline() (WebCore::RenderFlow::paintOutline): Take care of focus ring and pdf url rects, and outline painting. * rendering/RenderFlow.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF link to a rectanglular region. (WebCore::RenderObject::paintOutline): Take care of pdf rects as well as focus ring painting. * rendering/RenderObject.h: (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the element is a link and we are printing. (WebCore::RenderObject::hasOutline): Returns true is the style has an outline and hasOutlineAnnotation() is true. * rendering/RenderStyle.h: (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is greater than 0 and outlineStyle is greater than BHIDDEN. 2006-10-13 Justin Garcia Reviewed by ggaren and harrison 9A270: Mail crashes when I try to paste large items from Safari * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Even though we put nodes in the hash map in pre-order, they don't necessary come out of the iterator that way. If a node is a redundant style span and one of its pruned ancestors comes off the hash map after it, and that ancestor is a redundant style span or font tag, we will try to remove it even though it has already been removed and we'll crash. The test case added with the fix depends on our hash map implementation because it requires that a particular redundant style span come out of the iterator before its parent. So, it may eventually not provide coverage for the fix. 2006-10-13 Maciej Stachowiak Reviewed by Darin. - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool * WebCore.xcodeproj/project.pbxproj: * bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction): * bridge/BrowserExtension.h: * bridge/mac/BrowserExtensionMac.h: * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): * bridge/win/BrowserExtensionWin.h: * page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): * page/Frame.h: * page/FrameLoadRequest.h: Added. (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::lockHistory): (WebCore::FrameLoadRequest::setLockHistory): * page/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): 2006-10-13 John Sullivan Reviewed by Maciej * loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadDocumentLoader:]): Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can happen when loading a page during a decidePolicyForNavigationAction callback. 2006-10-13 Dave Hyatt Transparency layer work. Reviewed by aroben * platform/GraphicsContext.h: * platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): * platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer): (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer): 2006-10-13 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg paint server classes. * ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::parseMappedAttribute): (WebCore::SVGGradientElement::notifyAttributeChange): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::rebuildStops): * ksvg2/svg/SVGGradientElement.h: * ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement): (WebCore::SVGLinearGradientElement::parseMappedAttribute): (WebCore::SVGLinearGradientElement::buildGradient): * ksvg2/svg/SVGLinearGradientElement.h: * ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyClientsToRepaint): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::canvasResource): (WebCore::SVGPatternElement::getCTM): * ksvg2/svg/SVGPatternElement.h: (WebCore::SVGPatternElement::rendererIsNeeded): * ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement): (WebCore::SVGRadialGradientElement::parseMappedAttribute): (WebCore::SVGRadialGradientElement::buildGradient): * ksvg2/svg/SVGRadialGradientElement.h: * ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::parseMappedAttribute): * ksvg2/svg/SVGStopElement.h: 2006-10-13 Geoffrey Garen Reviewed by Darin, John. - Merged more frame and iframe code - Fixed a bug where iframes returned incorrect values for renderer-dependent properties during javascript: loads because they didn't have renderers at load time PLT insists this is a small performance win. Don't believe its lies. * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to width and height, for consistency with the rest of the DOM. * dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback queue that gets drained after the render tree is fully constructed. Currently, this is only used for frame loading. (WebCore::ContainerNode::attach): * dom/ContainerNode.h: * html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from attach() because loading iframes during attach() causes a crash. Moved frame loading logic into insertedIntoDocument(). That's a more logical place for it because document insertion is what triggers frame loading. Made frame loading a post-attach callback, instead of an immediate action, to fix the incorrect values bug. (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon require this call, once I remove the call from WebKit. (WebCore::HTMLFrameElement::setLocation): (WebCore::HTMLFrameElement::width): (WebCore::HTMLFrameElement::height): * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary killing of puppies. * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement (WebCore::HTMLIFrameElement::rendererIsNeeded): (WebCore::HTMLIFrameElement::createRenderer): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach): * page/FrameView.h: Removed unused method. 2006-10-13 David Harrison Reviewed by Justin. Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool) Tests added or changed: * editing/style/style-boundary-005.html: Added. Matches steps from bug. * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans). * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans). * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans). * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans). * dom/Text.cpp: (WebCore::Text::splitText): Comment changes. * editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): Renamed from isEmptyStyleSpan. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Rename emptySpans local to unstyledSpans. (WebCore::dummySpanAncestorForNode): New. To locate Apple style span created when splitting a text node. (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children of dummy span's parents, rather than traversing up from start and end locations. Old algorithm would miss empty spans in the bug case. (WebCore::ApplyStyleCommand::applyInlineStyle): Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans(). (WebCore::ApplyStyleCommand::removeCSSStyle): Renamed isEmptyStyleSpan() to isUnstyledStyleSpan(). (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Comment changes. * editing/ApplyStyleCommand.h: Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans(). * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Allow for Apple style span to be unstyled, because old email may have this in the DOM. Use !node->hasChildNodes() instead of !node->firstChild(). * editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Comment changes. * rendering/RenderTreeAsText.cpp: (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::operator<<): Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM 2006-10-13 Nikolas Zimmermann Reviewed by Eric. Fix Qt/Linux build after Adele's popup menu changes. * CMakeLists.txt: * platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::disconnectUploadControl): * platform/qt/PopupMenuQt.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption): * platform/qt/RenderPopupMenuQt.cpp: Removed. * platform/qt/RenderPopupMenuQt.h: Removed. * platform/qt/RenderThemeQt.cpp: 2006-10-13 Kevin McCullough Reviewed by Darin. fixed build failure * WebCore.xcodeproj/project.pbxproj: * loader/mac/WebFrameLoader.mm: 2006-10-13 Darin Adler Reviewed by Adele. - converted WebFormState from Objective-C to C++ * WebCore.exp: Added a new symbol, changed one symbol from C to C++. * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project". Added UChar.h and FrameLoaderTypes.h. * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h. * loader/mac/WebFormState.h: Converted class to C++. * loader/mac/WebFormState.mm: Ditto. * loader/mac/WebFrameLoader.h: * loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Changed Objective-C WebFormState uses to C++ WebCore::FormState. 2006-10-13 Adele Peterson Reviewed by Maciej. - Fix for REGRESSION: List box selection color should just be a darker version of regular selection color * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): * rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor): * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor): 2006-10-13 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg structure classes. * ksvg2/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement): * ksvg2/svg/SVGDefsElement.h: * ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement): * ksvg2/svg/SVGDescElement.h: * ksvg2/svg/SVGDocument.cpp: * ksvg2/svg/SVGDocument.h: * ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::SVGElementInstance): (WebCore::SVGElementInstance::correspondingElement): (WebCore::SVGElementInstance::correspondingUseElement): (WebCore::SVGElementInstance::parentNode): (WebCore::SVGElementInstance::childNodes): (WebCore::SVGElementInstance::previousSibling): (WebCore::SVGElementInstance::nextSibling): (WebCore::SVGElementInstance::firstChild): (WebCore::SVGElementInstance::lastChild): * ksvg2/svg/SVGElementInstance.h: * ksvg2/svg/SVGElementInstanceList.cpp: * ksvg2/svg/SVGElementInstanceList.h: * ksvg2/svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement): (WebCore::SVGGElement::parseMappedAttribute): (WebCore::SVGDummyElement::SVGDummyElement): * ksvg2/svg/SVGGElement.h: (WebCore::SVGGElement::rendererIsNeeded): * ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::createRenderer): * ksvg2/svg/SVGImageElement.h: * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY): (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::suspendRedraw): (WebCore::SVGSVGElement::unsuspendRedraw): (WebCore::SVGSVGElement::unsuspendRedrawAll): (WebCore::SVGSVGElement::forceRedraw): (WebCore::SVGSVGElement::getIntersectionList): (WebCore::SVGSVGElement::getEnclosureList): (WebCore::SVGSVGElement::checkIntersection): (WebCore::SVGSVGElement::checkEnclosure): (WebCore::SVGSVGElement::deselectAll): (WebCore::SVGSVGElement::createSVGLength): (WebCore::SVGSVGElement::createSVGAngle): (WebCore::SVGSVGElement::createSVGMatrix): (WebCore::SVGSVGElement::createSVGTransform): (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::setCurrentTime): * ksvg2/svg/SVGSVGElement.h: (WebCore::SVGSVGElement::rendererIsNeeded): * ksvg2/svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement): (WebCore::SVGSwitchElement::childShouldCreateRenderer): * ksvg2/svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::rendererIsNeeded): * ksvg2/svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement): (WebCore::SVGSymbolElement::parseMappedAttribute): * ksvg2/svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::shouldAttachChild): * ksvg2/svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::SVGTitleElement): * ksvg2/svg/SVGTitleElement.h: * ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::parseMappedAttribute): (WebCore::SVGUseElement::closeRenderer): * ksvg2/svg/SVGUseElement.h: (WebCore::SVGUseElement::rendererIsNeeded): 2006-10-12 Adele Peterson Reviewed by Anders. - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/ Test: fast/forms/listbox-width-change.html * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc. 2006-10-12 Maciej Stachowiak Reviewed by Oliver. - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies * WebCore.xcodeproj/project.pbxproj: * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]): * loader/mac/LoaderNSURLExtras.h: * loader/mac/LoaderNSURLRequestExtras.h: Added. * loader/mac/LoaderNSURLRequestExtras.m: Added. (isConditionalRequest): (setHTTPReferrer): * loader/mac/WebFrameLoader.mm: * loader/mac/WebSubresourceLoader.mm: 2006-10-12 Adele Peterson RS by Geoff. Renamed menuListIsDetaching to disconnectMenuList, uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser. These names match similar methods in WebCore a little better. * platform/FileChooser.h: * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList): * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]): (WebCore::FileChooser::disconnectUploadControl): * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl): * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl): * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): 2006-10-12 Adele Peterson Reviewed by Maciej. WebCore part of fix for need a means to attach user data to any menu that is popuped up in HTML Added private delegate method for clients that want access to a PopupMenu's NSMenu. * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu): * bridge/mac/WebCoreFrameBridge.h: * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up. 2006-10-12 Adele Peterson Reviewed by Alice. - Fix for After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list. * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching. * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up, in case the RenderMenuList goes away. Also, checks the pointer to the menu list immediately afterwards. 2006-10-12 Nikolas Zimmermann Reviewed by Maciej. Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html document.open(); document.write(..); and NO document.close(). On the Qt platform this leaves a HTMLDocument which is still in parsing mode (parsing() always returns true). DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem. Hmpf, this took me nine hours to debug today. Result: Couldn't find the real fix, going for a workaround for now. 540 minutes, 1 line of code changed after all -> 0,0019 lines per minute. * platform/qt/FrameQt.cpp: (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually. * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData(). 2006-10-12 Adam Roben Reviewed by Adele. Move popup menu code out of rendering/ and into platform/. RenderPopupMenu becomes PopupMenu, the RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated virtual methods go away, RenderTheme gets to stop worrying about popup menus, PopupMenu becomes ref-counted, and everyone becomes happy. * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project. * WebCore.xcodeproj/project.pbxproj: Ditto. * html/HTMLSelectElement.cpp: Remove unnecessary #include. * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp. Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate from RenderMenuList::showPopup/hidePopup. (WebCore::PopupMenu::create): New static creation method to hand back a PassRefPtr. (WebCore::PopupMenu::addItems): This platform-independent method should be called by PopupMenu::populate when the platform-specific implementation is ready to receive the menu items. Fixed an ASSERT while I was at it. * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more need for virtual methods. (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::popupHandle): * platform/mac/PopupMenuMac.mm: Moved from rendering/RenderPopupMenuMac.mm. Much renaming ensues. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): Since we don't have our own RenderStyle anymore, just pick up the style from our RenderMenuList. (WebCore::PopupMenu::addOption): Ditto. * platform/win/TemporaryLinkStubs.cpp: Rename-fest. (PopupMenu::PopupMenu): (PopupMenu::~PopupMenu): (PopupMenu::clear): (PopupMenu::populate): (PopupMenu::show): (PopupMenu::hide): (PopupMenu::addSeparator): (PopupMenu::addGroupLabel): (PopupMenu::addOption): * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): Use nice new simple PopupMenu::create to make the popup. (WebCore::RenderMenuList::hidePopup): * rendering/RenderMenuList.h: Hold a RefPtr instead of a RenderPopupMenu*. (WebCore::RenderMenuList::popup): * rendering/RenderPopupMenu.cpp: Removed. * rendering/RenderPopupMenu.h: Removed. * rendering/RenderPopupMenuMac.h: Removed. * rendering/RenderPopupMenuMac.mm: Removed. * rendering/RenderPopupMenuWin.h: Removed. * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method. * rendering/RenderTheme.h: Ditto. * rendering/RenderThemeMac.h: Ditto. * rendering/RenderThemeMac.mm: Ditto. * rendering/RenderThemeWin.cpp: Ditto. * rendering/RenderThemeWin.h: Ditto. 2006-10-12 Adele Peterson Reviewed by Dave Harrison. - Fixed REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing) * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields. 2006-10-12 Nikolas Zimmermann Reviewed by MacDome. Finally found a way to remove our begin() trickery in FrameQt. The (probably misnamed) Frame::setEncoding() function automatically calls Frame::receivedFirstData() which calls being on the working url, which has been passed to didOpenUrl(). Took me some hours to figure out that the missing charset logic, forced us to do hacks. * platform/ResourceLoader.h: * platform/ResourceLoaderInternal.h: * platform/qt/FrameQt.cpp: (WebCore::FrameQt::tokenizerProcessedData): * platform/qt/FrameQt.h: * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::FrameQtClientDefault): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedData): (WebCore::FrameQtClientDefault::receivedAllData): * platform/qt/FrameQtClient.h: * platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::remove): * platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::extractCharsetFromHeaders): 2006-10-12 Adam Roben Reviewed by Hyatt. Bandaid-ing a null-dereference crash until a real fix is made. * page/FrameView.cpp: (WebCore::FrameView::windowClipRect): 2006-10-12 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg text classes. * ksvg2/svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement): (WebCore::SVGTRefElement::updateReferencedText): (WebCore::SVGTRefElement::parseMappedAttribute): (WebCore::SVGTRefElement::childShouldCreateRenderer): (WebCore::SVGTRefElement::createRenderer): * ksvg2/svg/SVGTRefElement.h: (WebCore::SVGTRefElement::rendererIsNeeded): * ksvg2/svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::SVGTSpanElement): (WebCore::SVGTSpanElement::childShouldCreateRenderer): (WebCore::SVGTSpanElement::createRenderer): * ksvg2/svg/SVGTSpanElement.h: (WebCore::SVGTSpanElement::rendererIsNeeded): * ksvg2/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::parseMappedAttribute): * ksvg2/svg/SVGTextContentElement.h: * ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::localMatrix): (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::updateLocalTransform): (WebCore::SVGTextElement::nearestViewportElement): (WebCore::SVGTextElement::farthestViewportElement): (WebCore::SVGTextElement::getScreenCTM): (WebCore::SVGTextElement::getCTM): (WebCore::SVGTextElement::createRenderer): (WebCore::SVGTextElement::childShouldCreateRenderer): * ksvg2/svg/SVGTextElement.h: (WebCore::SVGTextElement::getTransformToElement): (WebCore::SVGTextElement::rendererIsNeeded): * ksvg2/svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute): * ksvg2/svg/SVGTextPositioningElement.h: 2006-10-12 Nikolas Zimmermann Reviewed by Maciej. Specialization of alert() for DumpRenderTree - just log the output, don't show any message box. * platform/qt/FrameQt.cpp: (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault. * platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): * platform/qt/FrameQtClient.h: 2006-10-12 Maciej Stachowiak Reviewed by Eric. - move m_responseMIMEType out of ResourceRequest, where it doesn't belong * page/FramePrivate.h: Add m_responseMIMEType * page/ResourceRequest.h: Remove m_responseMIMEType * page/Frame.cpp: (WebCore::Frame::setResponseMIMEType): added (WebCore::Frame::responseMIMEType): added (WebCore::Frame::begin): get MIME type from the right place (WebCore::Frame::write): ditto * page/Frame.h: * bindings/js/kjs_window.cpp: (KJS::createNewWindow): updated to use new Frame methods (KJS::WindowFunc::callAsFunction): ditto * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto (-[WebCoreFrameBridge canProvideDocumentSource]): ditto * loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): ditto 2006-10-12 Maciej Stachowiak Reviewed by Eric. REGRESSION: "Can't find the server" error page contains unstyled text and missing image We really need some way to test loadHTMLString since it keeps breaking! * loader/mac/WebFrameLoader.mm: (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source. 2006-10-12 Nikolas Zimmermann Reviewed by Eric. Fix Qt/Linux build. * CMakeLists.txt: * platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::create): 2006-10-12 Krzysztof Kowalczyk Reviewed by Maciej. Update Gdk\Linux build for recent changes, based on Qt code * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::setFrame): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::receivedData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected): * platform/gdk/FrameGdk.h: * platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::createJavaAppletWidget): (FileChooser::create): 2006-10-12 Dave Hyatt Patch to add more clipping retrieval functionality for widgets. Reviewed by mjs * page/Frame.h: Remove windowResizerRect. This is in the wrong place. * page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::windowClipRectForLayer): Break out windowClipRect into helper functions that can be called separately (to make it easier for scrollbars in overflow sections and list boxes to get to an enclosing layer and get the right clip. * page/FrameView.h: Add the new windowClipRect helper methods. * platform/ScrollBar.h: Add a new interface to ScrollbarClient so that scrollbars can hand back proper clip rects for themselves depending on how they are used. * platform/ScrollView.h: Stub out methods for talking to a double buffer backing store on Win32. * platform/Widget.h: Add the ability to query for invalidation suppression. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::windowClipRect): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::childrenClipRect): (WebCore::RenderLayer::selfClipRect): * rendering/RenderLayer.h: Enhance layers so that they can return either their foreground or background document clip rects. Make sure a layer scrollbar can return a proper clip. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::windowClipRect): * rendering/RenderListBox.h: Make sure a list box scrollbar can return a proper clip. * rendering/RenderObject.cpp: (WebCore::RenderObject::enclosingLayer): * rendering/RenderObject.h: Make enclosingLayer const. 2006-10-11 Darin Adler Reviewed by John. - some changes to prepare for converting more code to C++ * bridge/mac/WebCoreFrameBridge.h: Added import of so this header is self-sufficient. * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet). * loader/mac/LoaderNSURLExtras.h: * loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++. * loader/mac/LoaderNSURLExtras.m: * loader/mac/WebDataProtocol.mm: * loader/mac/WebDocumentLoader.mm: * loader/mac/WebFormDataStream.m: * loader/mac/WebLoader.mm: * loader/mac/WebMainResourceLoader.mm: * loader/mac/WebNetscapePlugInStreamLoader.mm: * loader/mac/WebPolicyDecider.mm: * loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h. 2006-10-11 John Sullivan Darin wrote this code; we tested it; I give it the thumbs up. - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes The hash table to look up an element class given a QualifiedName was not working at all. * dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing. * bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto 2006-10-11 Adam Roben Rubberstamped by Anders. Clean up FileChooser::create and Icon::newIconForFile. * WebCore.xcodeproj/project.pbxproj: * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create): * platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile): 2006-10-11 Oliver Hunt Reviewed by Adam. Fix for http://bugs.webkit.org/show_bug.cgi?id=11251 Corrects canvas tag to not throw JS exception when drawing zero sized rects, arcs, etc * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect): 2006-10-11 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11221 REGRESSION: iExploder crash due to style="cursor: url()" Take better care of empty cursor lists. Test: fast/css/invalid-cursor-property-crash.html * css/cssparser.cpp: (WebCore::CSSParser::parseValue): 2006-10-11 Adam Roben Fixing Windows for real this time. * platform/win/TemporaryLinkStubs.cpp: (FileChooser::create): 2006-10-11 Adam Roben Fix Windows build. * platform/win/TemporaryLinkStubs.cpp: (FileChooser::create): 2006-10-11 Antti Koivisto Reviewed by Hyatt. http://bugs.webkit.org/show_bug.cgi?id=4377 Respect css visibility semantics for layers too * rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers): * rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent): * rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): 2006-10-10 Maciej Stachowiak Reviewed by Oliver. - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes * WebCore.xcodeproj/project.pbxproj: * platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr): - use it in WidgetMac so it gets tested in at least one place * platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView): 2006-10-10 Brady Eidson Reviewed by Maciej. Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): * loader/mac/WebFrameLoader.h: * loader/mac/WebFrameLoader.mm: (-[WebFrameLoader initWithFrameBridge:]): (-[WebFrameLoader setFrameLoaderClient:]): 2006-10-10 Adam Roben Reviewed by Oliver. Make FileChooser ref-counted. * platform/FileChooser.h: * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create): * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl): * rendering/RenderFileUploadControl.h: 2006-10-10 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11248 Even More auto-generated Objective-C DOM bindings changes - Auto-generate DOMSVGPathElement. - Auto-generate the internal interfaces even for classes that have custom internal implementations. Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change. - Add SVG classes to DOMNode and DOMEvent internal interfaces. - Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible. - Assorted cleanups. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.mm: (WebCore::addElementClass): (WebCore::createElementClassMap): (WebCore::elementClass): (-[DOMNode description]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMElement _NPObject]): (WebCore::ObjCEventListener::handleEvent): * bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]): * bindings/objc/DOMInternal.h: * bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor WebCore::]): * bindings/objc/DOMSVGPathSegInternal.h: Removed. * bindings/scripts/CodeGeneratorObjC.pm: * css/CSSRule.idl: * css/CSSValue.idl: * css/StyleSheet.idl: * dom/Event.cpp: (WebCore::Event::isSVGZoomEvent): * dom/Event.h: * dom/Event.idl: * dom/Node.idl: * ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::isSVGZoomEvent): * ksvg2/events/SVGZoomEvent.h: * ksvg2/svg/SVGAnimatedAngle.idl: * ksvg2/svg/SVGCircleElement.idl: * ksvg2/svg/SVGClipPathElement.idl: * ksvg2/svg/SVGPathElement.idl: * ksvg2/svg/SVGPathSeg.idl: 2006-10-10 Oliver Hunt rubber stamped by Anders. More buildbot bustage * kcanvas/SVGInlineFlowBox.cpp: (WebCore::placeBoxesVerticallyWithAbsBaseline): 2006-10-10 Oliver Hunt Reviewed by Anders Unbreak build bots * dom/Text.cpp: * kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): * kcanvas/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): 2006-10-10 Oliver Hunt Reviewed by hyatt. Fixes bugs #6423, #6559, #10380 and #10839 * WebCore.xcodeproj/project.pbxproj: * css/svg.css: * dom/Text.cpp: (WebCore::Text::createRenderer): * kcanvas/RenderSVGInline.cpp: Added. (WebCore::RenderSVGInline::RenderSVGInline): (WebCore::RenderSVGInline::createInlineBox): * kcanvas/RenderSVGInline.h: Added. (WebCore::RenderSVGInline::renderName): (WebCore::RenderSVGInline::requiresLayer): * kcanvas/RenderSVGInlineText.cpp: Added. (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::selectionRect): * kcanvas/RenderSVGInlineText.h: Added. (WebCore::RenderSVGInlineText::renderName): (WebCore::RenderSVGInlineText::requiresLayer): * kcanvas/RenderSVGTSpan.cpp: Added. (WebCore::RenderSVGTSpan::RenderSVGTSpan): (WebCore::RenderSVGTSpan::absoluteRects): * kcanvas/RenderSVGTSpan.h: Added. (WebCore::RenderSVGTSpan::renderName): * kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::computeAbsoluteRepaintRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::createInlineBox): (WebCore::RenderSVGText::nodeAtPoint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::relativeBBox): * kcanvas/RenderSVGText.h: (WebCore::RenderSVGText::renderName): * kcanvas/SVGInlineFlowBox.cpp: Added. (WebCore::SVGInlineFlowBox::paint): (WebCore::SVGInlineFlowBox::placeBoxesHorizontally): (WebCore::SVGInlineFlowBox::verticallyAlignBoxes): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeSVGFlowHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically): * kcanvas/SVGInlineFlowBox.h: Added. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): * kcanvas/SVGRootInlineBox.cpp: Added. (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally): (WebCore::SVGRootInlineBox::verticallyAlignBoxes): * kcanvas/SVGRootInlineBox.h: Added. (WebCore::SVGRootInlineBox::SVGRootInlineBox): * ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::createRenderer): * ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::createRenderer): * rendering/InlineFlowBox.h: 2006-10-10 Adam Roben Reviewed by Adele. Improve popup menu behavior. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Cache m_lastOnChangeIndex so we know when to fire onChange. (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to specify whether we should fire onChange. (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire onChange when using the Enter key to change the selection. * html/HTMLSelectElement.h: * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Extract setText logic into its own method. (WebCore::RenderMenuList::setTextFromOption): New method. (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call onChange instead of calling it directly here. * rendering/RenderMenuList.h: 2006-10-10 Adele Peterson Reviewed by Beth. - Fix for After timers fix, crash below RenderLayer::autoscroll after moving/destroying active and After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea Moved autoscroll code to the Frame class * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame. * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags. Moved autoscroll code to Frame::handleMouseMoveEvent. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown): * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us. Now we scroll our views in WebCore. * page/Frame.cpp: (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag. (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate. Moved from FrameMac. (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too. (WebCore::Frame::mouseDownMayStartAutoscroll): Added. (WebCore::Frame::setMouseDownMayStartAutoscroll): Added. (WebCore::Frame::mouseDownMayStartDrag): Added. (WebCore::Frame::setMouseDownMayStartDrag): Added. (WebCore::Frame::autoscrollRenderer): Added (WebCore::Frame::setAutoscrollRenderer): Added. (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto. * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies. * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags. Moved from FrameMac. * page/FrameView.cpp: Store the current mouse position in window coordinates. The callers can convert to their own coordinate space. (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection). We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space. * rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too) (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer. 2006-10-10 Darin Adler Rubber stamped by Maciej. - convert many of the loader source files to Objective-C++ to prepare to convert some of them to C++ * WebCore.xcodeproj/project.pbxproj: * loader/mac/WebDataProtocol.m: Removed. * loader/mac/WebDocumentLoader.m: Removed. * loader/mac/WebFormState.m: Removed. * loader/mac/WebFrameLoader.m: Removed. * loader/mac/WebLoader.m: Removed. * loader/mac/WebMainResourceLoader.m: Removed. * loader/mac/WebNetscapePlugInStreamLoader.m: Removed. * loader/mac/WebPolicyDecider.m: Removed. * loader/mac/WebSubresourceLoader.m: Removed. * loader/mac/WebDataProtocol.mm: Added. * loader/mac/WebDocumentLoader.mm: Added. * loader/mac/WebFormState.mm: Added. * loader/mac/WebFrameLoader.mm: Added. * loader/mac/WebLoader.mm: Added. * loader/mac/WebMainResourceLoader.mm: Added. * loader/mac/WebNetscapePlugInStreamLoader.mm: Added. * loader/mac/WebPolicyDecider.mm: Added. * loader/mac/WebSubresourceLoader.mm: Added. 2006-10-10 Maciej Stachowiak Reviewed by Mitz. - fixed REGRESSION (r16960): crash on navigating to site http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE * loader/mac/WebFrameLoader.m: (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Add back a mistakenly removed retain. 2006-10-10 Maciej Stachowiak - fixed release build * WebCore.xcodeproj/project.pbxproj: 2006-10-10 Maciej Stachowiak Rubber stamped by Eric. - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile * WebCore.exp: * WebCore.xcodeproj/project.pbxproj: * loader/mac/LoaderNSURLExtras.m: Added. * loader/mac/WebDataProtocol.m: Added. * loader/mac/WebDocumentLoader.m: Added. * loader/mac/WebFormDataStream.m: Added. * loader/mac/WebFrameLoader.m: Added. * loader/mac/WebLoader.m: Added. (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]): * loader/mac/WebMainResourceLoader.m: Added. (-[WebMainResourceLoader didReceiveResponse:]): * loader/mac/WebPolicyDecider.m: Added. * loader/mac/WebSubresourceLoader.h: Added. * loader/mac/WebSubresourceLoader.m: Added. 2006-10-10 Maciej Stachowiak Reviewed by Oliver (sort of?) - WebCore part of moving down NSURL extras * WebCore.exp: * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: 2006-10-09 Rob Buis Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg animation classes. * ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent): * ksvg2/svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::handleTimerEvent): * ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement): (WebCore::SVGAnimateTransformElement::parseMappedAttribute): (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix): (WebCore::SVGAnimateTransformElement::initialMatrix): (WebCore::SVGAnimateTransformElement::transformMatrix): * ksvg2/svg/SVGAnimateTransformElement.h: * ksvg2/svg/SVGAnimatedPathData.cpp: * ksvg2/svg/SVGAnimatedPathData.h: * ksvg2/svg/SVGAnimatedPoints.cpp: * ksvg2/svg/SVGAnimatedPoints.h: * ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::targetElement): 2006-10-09 Maciej Stachowiak Reviewed by Oliver. - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isMainFrame]): 2006-10-09 Adam Roben Backing out accidental commit. * page/Frame.cpp: (WebCore::Frame::finishedParsing): 2006-10-09 Adam Roben Reviewed by Darin. Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as this could cause recursive calls to the destructor. RefPtr now also inherits from Noncopyable. * dom/NodeFilter.h: * dom/Traversal.h: * page/DOMWindow.h: * page/Frame.cpp: (WebCore::Frame::finishedParsing): * page/Frame.h: * page/Plugin.h: * platform/FontFallbackList.h: * platform/Icon.h: * platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::Shared::refCount): * platform/StringImpl.h: 2006-10-09 Oliver Hunt Reviewed by Anders. Correcting ifdef's * html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop): * html/CanvasGradient.h: * html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern): * html/CanvasPattern.h: * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern): * html/CanvasRenderingContext2D.h: * html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor): * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): * html/HTMLCanvasElement.h: 2006-10-09 Adam Roben Reviewed by Maciej. Fix a possible recursive destructor call. * page/Frame.cpp: (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor. (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if we're already being destroyed. 2006-10-09 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11234 Assorted Objective-C bindings changes - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement. - Auto-generate absoluteImageURL method for DOMHTMLInputElement and DOMHTMLObjectElement. - Auto-generate the internal methods for classes with ivars (notably DOMNodeIterator and DOMTreeWalker) - Put more methods in the WebCore namespace and factor out the displayString method into DOMInternal.h as done by Darin in his patch for http://bugs.webkit.org/show_bug.cgi?id=11219. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode dispatchEvent:]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): * bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]): * bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]): * bindings/objc/DOMExtensions.h: * bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): * bindings/objc/DOMInternal.h: (-[DOMNodeFilter WebCore::]): * bindings/objc/DOMInternal.mm: (-[WebScriptObject _init]): (-[WebScriptObject _initializeScriptDOMNodeImp]): (WebCore::displayString): * bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): (-[DOMObject finalize]): * bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]): * bindings/objc/DOMSVG.h: * bindings/objc/DOMSVGPathSegInternal.h: Added. * bindings/objc/DOMSVGPathSegInternal.mm: Added. (-[DOMSVGPathSeg WebCore::]): (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]): (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]): * bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]): * bindings/objc/PublicDOMInterfaces.h: * bindings/scripts/CodeGeneratorObjC.pm: * dom/NodeIterator.idl: * dom/TreeWalker.idl: * html/HTMLInputElement.idl: * html/HTMLObjectElement.idl: * ksvg2/svg/SVGDocument.idl: * ksvg2/svg/SVGElement.idl: * ksvg2/svg/SVGPathSeg.idl: * ksvg2/svg/SVGPathSegArcAbs.idl: * ksvg2/svg/SVGPathSegArcRel.idl: * ksvg2/svg/SVGPathSegClosePath.idl: * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl: * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl: * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl: * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl: * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl: * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl: * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: * ksvg2/svg/SVGPathSegLinetoAbs.idl: * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl: * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl: * ksvg2/svg/SVGPathSegLinetoRel.idl: * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl: * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl: * ksvg2/svg/SVGPathSegMovetoAbs.idl: * ksvg2/svg/SVGPathSegMovetoRel.idl: 2006-10-09 Don Gibson Unreviewed build fix. Fix windows build bustage. * platform/win/TemporaryLinkStubs.cpp: 2006-10-09 Krzysztof Kowalczyk Reviewed by Geoff. Fix memory leaks discovered via valgrind. Gdk build fixes. * Projects/gdk/webcore-gdk.bkl: * make-generated-sources.sh: * platform/cairo/ImageCairo.cpp: (WebCore::Image::draw): * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent): * platform/gdk/FrameGdk.h: * platform/gdk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth): 2006-10-09 Nikolas Zimmermann Reviewed by Beth. Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test. * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly (WebCore::GlyphMap::fillPage): 2006-10-09 Nikolas Zimmermann Unreviewed build fix. Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929. * platform/qt/FrameQt.cpp: (WebCore::FrameQt::createJavaAppletWidget): * platform/qt/FrameQt.h: * platform/qt/TemporaryLinkStubs.cpp: 2006-10-09 Brady Eidson Reviewed by Maciej Tiny changes to help reorganize WebFrameLoader code in WebKit * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance" * bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side 2006-10-09 Adam Roben Reviewed by Adele. Remove redundant call to Frame::cancelAndClear from ~Frame, since it's already called frome ~FrameMac. * page/Frame.cpp: (WebCore::Frame::~Frame): 2006-10-09 Anders Carlsson * bridge/win/FrameWin.h: Add function declaration. 2006-10-09 Anders Carlsson * platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Try fixing the Win32 build. 2006-10-09 Anders Carlsson Reviewed by Adam. Move applet widget creation to Frame and get rid of JavaAppletWidget. * WebCore.xcodeproj/project.pbxproj: * bridge/JavaAppletWidget.h: Removed. * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::createJavaAppletWidget): * bridge/mac/JavaAppletWidget.mm: Removed. * page/Frame.h: * rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary): 2006-10-09 Mitz Pettel Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=11220 Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276 Subversion does not support resource forks and HFS metadata, so the resources for this test need to be on a disk image. * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image. * manual-tests/resources/plain-text-paste.dmg: Added. * manual-tests/resources/plain-text-paste/._1.textClipping: Removed. * manual-tests/resources/plain-text-paste/._2.textClipping: Removed. * manual-tests/resources/plain-text-paste/._4.txt: Removed. * manual-tests/resources/plain-text-paste/._5.webloc: Removed. * manual-tests/resources/plain-text-paste/1.textClipping: Removed. * manual-tests/resources/plain-text-paste/2.textClipping: Removed. * manual-tests/resources/plain-text-paste/3.gif: Removed. * manual-tests/resources/plain-text-paste/4.txt: Removed. * manual-tests/resources/plain-text-paste/5.webloc: Removed. 2006-10-09 Rob Buis Reviewed by Darin. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in filter classes. * ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): * ksvg2/svg/SVGComponentTransferFunctionElement.h: * ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::parseMappedAttribute): (WebCore::SVGFEBlendElement::filterEffect): * ksvg2/svg/SVGFEBlendElement.h: * ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::filterEffect): * ksvg2/svg/SVGFEColorMatrixElement.h: * ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute): * ksvg2/svg/SVGFECompositeElement.h: * ksvg2/svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::stringToChannel): * ksvg2/svg/SVGFEDisplacementMapElement.h: * ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::filterEffect): * ksvg2/svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::SVGFEFuncAElement): * ksvg2/svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::SVGFEFuncBElement): * ksvg2/svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::SVGFEFuncGElement): * ksvg2/svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::SVGFEFuncRElement): * ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute): (WebCore::SVGFEGaussianBlurElement::filterEffect): * ksvg2/svg/SVGFEGaussianBlurElement.h: * ksvg2/svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement): (WebCore::SVGFELightElement::parseMappedAttribute): * ksvg2/svg/SVGFELightElement.h: * ksvg2/svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::SVGFEMergeElement): 2006-10-09 Rob Buis Reviewed by olliej. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in SVGPath* classes. * ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::createSVGPathSegClosePath): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::svgMoveTo): (WebCore::SVGPathElement::svgLineTo): (WebCore::SVGPathElement::svgLineToHorizontal): (WebCore::SVGPathElement::svgLineToVertical): (WebCore::SVGPathElement::svgCurveToCubic): (WebCore::SVGPathElement::svgCurveToCubicSmooth): (WebCore::SVGPathElement::svgCurveToQuadratic): (WebCore::SVGPathElement::svgCurveToQuadraticSmooth): (WebCore::SVGPathElement::svgArcTo): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::pathSegList): (WebCore::SVGPathElement::normalizedPathSegList): (WebCore::SVGPathElement::animatedPathSegList): (WebCore::SVGPathElement::animatedNormalizedPathSegList): (WebCore::SVGPathElement::toPathData): * ksvg2/svg/SVGPathElement.h: (WebCore::SVGPathElement::rendererIsNeeded): * ksvg2/svg/SVGPathSeg.h: * ksvg2/svg/SVGPathSegArc.cpp: 2006-10-09 Rob Buis Reviewed by aroben. http://bugs.webkit.org/show_bug.cgi?id=11217 Cleanup svg coding style Cleanup coding style in svg shape classes. * ksvg2/svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement): (WebCore::SVGCircleElement::parseMappedAttribute): (WebCore::SVGCircleElement::pushAttributeContext): * ksvg2/svg/SVGCircleElement.h: (WebCore::SVGCircleElement::rendererIsNeeded): * ksvg2/svg/SVGEllipseElement.cpp: * ksvg2/svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::rendererIsNeeded): * ksvg2/svg/SVGLineElement.cpp: (WebCore::SVGLineElement::parseMappedAttribute): (WebCore::SVGLineElement::pushAttributeContext): * ksvg2/svg/SVGLineElement.h: (WebCore::SVGLineElement::rendererIsNeeded): * ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::SVGPolyElement): (WebCore::SVGPolyElement::points): (WebCore::SVGPolyElement::animatedPoints): (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::notifyAttributeChange): * ksvg2/svg/SVGPolyElement.h: (WebCore::SVGPolyElement::rendererIsNeeded): * ksvg2/svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::SVGPolygonElement): (WebCore::SVGPolygonElement::toPathData): * ksvg2/svg/SVGPolygonElement.h: * ksvg2/svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::SVGPolylineElement): (WebCore::SVGPolylineElement::toPathData): * ksvg2/svg/SVGPolylineElement.h: * ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::parseMappedAttribute): (WebCore::SVGRectElement::pushAttributeContext): * ksvg2/svg/SVGRectElement.h: (WebCore::SVGRectElement::rendererIsNeeded): 2006-10-08 Darin Adler Reviewed by Maciej. - added a bit more WebCoreSystemInterface wkGetNSURLResponseCalculatedExpiration wkGetNSURLResponseLastModifiedDate wkGetNSURLResponseMustRevalidate * WebCore.exp: Added the new symbols. * platform/mac/WebCoreSystemInterface.h: Ditto. * platform/mac/WebCoreSystemInterface.mm: Ditto. - quiet down the code generation script * bindings/scripts/CodeGenerator.pm: 2006-10-08 Maciej Stachowiak Reviewed by Darin. - more code laundering - add wkSupportsMultipartXMixedReplace * WebCore.exp: * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: 2006-10-08 Nikolas Zimmermann Reviewed by Darin and Oliver. Fix artefacts when drawing polygons, most noticeable when painting
elements. * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage. (WebCore::GraphicsContext::drawConvexPolygon): 2006-10-08 Anders Carlsson Reviewed by Darin. * page/Frame.cpp: (WebCore::Frame::submitForm): No need to use latin1() here. 2006-10-08 Nikolas Zimmermann Reviewed by Darin. Kill warnings when generating IDL files on Qt/Linux, as the SOURCE_ROOT environment variable is not defined (and not needed) for us. * bindings/scripts/CodeGenerator.pm: 2006-10-08 Maciej Stachowiak Reviewed by Darin. - split didNotOpenURL: into general and page-cache-specific parts * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:]): (-[WebCoreFrameBridge invalidatePageCache:]): 2006-10-08 Anders Carlsson Reviewed by Darin. * loader/loader.cpp: Remove DeprecatedStringList.h include. * page/Frame.cpp: (WebCore::Frame::submitForm): Don't remove "attach" from mailto URLs, we don't do it anywhere else. 2006-10-08 Sam Weinig Reviewed by Darin. Patch for http://bugs.webkit.org/show_bug.cgi?id=11215 Yet another round of Objective-C SVG DOM bindings auto-generation - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent, DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, DOMSVGZoomAndPan and DOMSVGZoomEvent. - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement using the new [ConvertFromString] property. - Add forward declarations for NS* types to auto-generated classes. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOMHTMLAppletElement.mm: Removed. * bindings/objc/DOMHTMLEmbedElement.mm: Removed. * bindings/objc/DOMInternal.h: * bindings/objc/DOMSVG.h: * bindings/scripts/CodeGeneratorObjC.pm: * html/HTMLAppletElement.idl: * html/HTMLEmbedElement.idl: * ksvg2/svg/SVGPatternElement.idl: * ksvg2/svg/SVGPolygonElement.idl: * ksvg2/svg/SVGPolylineElement.idl: * ksvg2/svg/SVGRadialGradientElement.idl: * ksvg2/svg/SVGRenderingIntent.idl: * ksvg2/svg/SVGScriptElement.idl: * ksvg2/svg/SVGSetElement.idl: * ksvg2/svg/SVGStopElement.idl: * ksvg2/svg/SVGSwitchElement.idl: * ksvg2/svg/SVGSymbolElement.idl: * ksvg2/svg/SVGTRefElement.idl: * ksvg2/svg/SVGTSpanElement.idl: * ksvg2/svg/SVGTextContentElement.idl: * ksvg2/svg/SVGTextElement.idl: * ksvg2/svg/SVGTextPositioningElement.idl: * ksvg2/svg/SVGTitleElement.idl: * ksvg2/svg/SVGUseElement.idl: * ksvg2/svg/SVGViewElement.idl: * ksvg2/svg/SVGZoomEvent.idl: 2006-10-07 Anders Carlsson Reviewed by Maciej. Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList. * loader/loader.cpp: (WebCore::Loader::servePendingRequests): 2006-10-07 Anders Carlsson Reviewed by Darin. Convert a bunch of RefPtr to String. * bridge/mac/FrameMac.h: * bridge/mac/FrameMac.mm: (WebCore::FrameMac::didTellBridgeAboutLoad): (WebCore::FrameMac::haveToldBridgeAboutLoad): * dom/BeforeUnloadEvent.cpp: (WebCore::BeforeUnloadEvent::storeResult): * dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::result): * dom/Document.cpp: (WebCore::Document::createEntityReference): * dom/Entity.cpp: (WebCore::Entity::Entity): (WebCore::Entity::nodeName): (WebCore::Entity::toString): * dom/Entity.h: (WebCore::Entity::publicId): (WebCore::Entity::systemId): (WebCore::Entity::notationName): * dom/EntityReference.cpp: (WebCore::EntityReference::EntityReference): (WebCore::EntityReference::nodeName): (WebCore::EntityReference::cloneNode): (WebCore::EntityReference::toString): * dom/EntityReference.h: * dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent): (WebCore::KeyboardEvent::initKeyboardEvent): * dom/KeyboardEvent.h: (WebCore::KeyboardEvent::keyIdentifier): * dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent): * dom/MutationEvent.h: (WebCore::MutationEvent::prevValue): (WebCore::MutationEvent::newValue): (WebCore::MutationEvent::attrName): * dom/Notation.cpp: (WebCore::Notation::Notation): (WebCore::Notation::nodeName): * dom/Notation.h: (WebCore::Notation::publicId): (WebCore::Notation::systemId): * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::setData): (WebCore::ProcessingInstruction::nodeName): (WebCore::ProcessingInstruction::nodeValue): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::toString): * dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::target): (WebCore::ProcessingInstruction::data): (WebCore::ProcessingInstruction::localHref): 2006-10-07 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11206 10 more SVG Objective-C auto-generated bindings - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement, DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint. - Auto-generate the text method for DOMRange. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.mm: * bindings/objc/DOMExtensions.h: * bindings/objc/DOMInternal.h: * bindings/objc/DOMPrivate.h: * bindings/objc/DOMRGBColor.mm: * bindings/objc/DOMSVG.h: * bindings/objc/PublicDOMInterfaces.h: * bindings/scripts/CodeGeneratorObjC.pm: * dom/Range.idl: * ksvg2/svg/SVGFilterElement.cpp: * ksvg2/svg/SVGFilterElement.h: * ksvg2/svg/SVGFilterElement.idl: * ksvg2/svg/SVGForeignObjectElement.idl: * ksvg2/svg/SVGGElement.idl: * ksvg2/svg/SVGGradientElement.idl: * ksvg2/svg/SVGImageElement.idl: * ksvg2/svg/SVGLineElement.idl: * ksvg2/svg/SVGLinearGradientElement.idl: * ksvg2/svg/SVGMarkerElement.idl: * ksvg2/svg/SVGMaskElement.idl: * ksvg2/svg/SVGPaint.idl: 2006-10-07 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11198 Auto-generate a few more Objective-C DOM interfaces - Fully auto-generate DOMAbstractView and DOMRange. - Auto-generate just the interface for DOMRGBColor. - Add DOMRanges.h as the new top level file for Ranges module. - Add DOMRanges.h and DOMXPath.h to DOM.mm * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.h: * bindings/objc/DOM.mm: * bindings/objc/DOMAbstractView.h: Removed. * bindings/objc/DOMAbstractView.mm: Removed. * bindings/objc/DOMInternal.h: * bindings/objc/DOMPrivate.h: * bindings/objc/DOMRGBColor.h: Removed. * bindings/objc/DOMRGBColor.mm: * bindings/objc/DOMRange.h: Removed. * bindings/objc/DOMRanges.h: Added. * bindings/objc/PublicDOMInterfaces.h: * bindings/scripts/CodeGeneratorObjC.pm: * css/RGBColor.idl: * dom/Range.idl: * page/AbstractView.idl: Added. 2006-10-07 Andrew Wellington Reviewed by Eric. Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit http://bugzilla.opendarwin.org/show_bug.cgi?id=10837 Return null when there is no frame. This matches Firefox. * bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): 2006-10-07 David Hyatt Implement scroll corner painting (a white rect fill) for overflow areas to cover up scrollbar joins properly. Refactor painting of scrollbars and resizers into common functions. Eliminate the extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect. Reviewed by mitz * page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): * platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer): * rendering/RenderLayer.h: 2006-10-07 Mark Rowe Reviewed by Mitz. Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and matching recent ResourceLoader changes. * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected): * platform/gdk/PlatformScrollBar.h: * platform/gdk/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::start): * platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): * platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::addChild): (ScrollView::updateScrollbars): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion): 2006-10-06 Dave Hyatt Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip. * page/FrameView.cpp: (WebCore::FrameView::windowClipRect): * page/FrameView.h: * platform/ScrollView.h: * platform/Widget.cpp: (WebCore::Widget::windowClipRect): * platform/Widget.h: (WebCore::Widget::geometryChanged): (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent): * platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::documentClipRect): * rendering/RenderLayer.h: 2006-10-06 Steve Falkenburg Reviewed by Adam. Add another method we'll need for scrollbar dodging * platform/ScrollView.h: * platform/win/TemporaryLinkStubs.cpp: (ScrollView::resizerOverlapsContent): 2006-10-06 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11191 Auto-generate the interfaces even for Objective-C DOM bindings that need custom implementations - Fully auto-generate DOMEventTarget, DOMNodeFilter and DOMHTMLOptionElement. - Auto-generate just the interface for DOMHTMLAppletElement, DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect using the new IDL property ObjCCustomImplementation. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOMEventTarget.h: Removed. * bindings/objc/DOMHTMLAppletElement.h: Removed. * bindings/objc/DOMHTMLEmbedElement.h: Removed. * bindings/objc/DOMHTMLOptionElement.h: Removed. * bindings/objc/DOMHTMLOptionElement.mm: Removed. * bindings/objc/DOMInternal.h: * bindings/objc/DOMNodeFilter.h: Removed. * bindings/objc/DOMSVGNumber.h: Removed. * bindings/objc/DOMSVGPoint.h: Removed. * bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint matrixTransform:]): * bindings/objc/DOMSVGRect.h: Removed. * bindings/objc/PublicDOMInterfaces.h: * bindings/scripts/CodeGeneratorObjC.pm: * dom/EventTarget.idl: * html/HTMLAppletElement.idl: * html/HTMLEmbedElement.idl: * html/HTMLOptionElement.idl: * ksvg2/svg/SVGNumber.idl: * ksvg2/svg/SVGPoint.idl: * ksvg2/svg/SVGRect.idl: 2006-10-06 Nikolas Zimmermann Reviewed by Tim H. Make Qt/Linux compile again completly. * platform/qt/WidgetQt.cpp: (WebCore::Widget::removeFromParent): 2006-10-06 Nikolas Zimmermann Reviewed by Tim H. Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch. * platform/qt/PlatformScrollBar.h: * platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::scrollbarUnderMouse): * platform/qt/TemporaryLinkStubs.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (FrameView::passMousePressEventToScrollbar): 2006-10-06 Sam Weinig Reviewed by Tim H. Patch for http://bugs.webkit.org/show_bug.cgi?id=11177 Another round of Objective-C SVG DOM bindings auto-generation - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement, DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, DOMSVGFETileElement, DOMSVGFETurbulenceElement, DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint and DOMSVGRect. - IDL clean up. - Make numOctaves in SVGFETurbulenceElement use a long instead of an int in it's macro declaration and definition. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]): * bindings/objc/DOMInternal.h: * bindings/objc/DOMSVG.h: * bindings/objc/DOMSVGNumber.h: Added. * bindings/objc/DOMSVGNumber.mm: Added. (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]): * bindings/objc/DOMSVGPoint.h: Added. * bindings/objc/DOMSVGPoint.mm: Added. (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]): * bindings/objc/DOMSVGRect.h: Added. * bindings/objc/DOMSVGRect.mm: Added. (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]): * bindings/scripts/CodeGeneratorObjC.pm: * ksvg2/svg/SVGAnimatedNumberList.idl: * ksvg2/svg/SVGAnimatedRect.idl: * ksvg2/svg/SVGComponentTransferFunctionElement.idl: * ksvg2/svg/SVGCursorElement.idl: * ksvg2/svg/SVGFEBlendElement.idl: * ksvg2/svg/SVGFEColorMatrixElement.idl: * ksvg2/svg/SVGFEComponentTransferElement.idl: * ksvg2/svg/SVGFECompositeElement.idl: * ksvg2/svg/SVGFEDiffuseLightingElement.idl: * ksvg2/svg/SVGFEDisplacementMapElement.idl: * ksvg2/svg/SVGFEDistantLightElement.idl: * ksvg2/svg/SVGFEFloodElement.idl: * ksvg2/svg/SVGFEFuncAElement.idl: * ksvg2/svg/SVGFEFuncBElement.idl: * ksvg2/svg/SVGFEFuncGElement.idl: * ksvg2/svg/SVGFEFuncRElement.idl: * ksvg2/svg/SVGFEGaussianBlurElement.idl: * ksvg2/svg/SVGFEImageElement.idl: * ksvg2/svg/SVGFEMergeElement.idl: * ksvg2/svg/SVGFEMergeNodeElement.idl: * ksvg2/svg/SVGFEOffsetElement.idl: * ksvg2/svg/SVGFEPointLightElement.idl: * ksvg2/svg/SVGFESpecularLightingElement.idl: * ksvg2/svg/SVGFESpotLightElement.idl: * ksvg2/svg/SVGFETileElement.idl: * ksvg2/svg/SVGFETurbulenceElement.cpp: * ksvg2/svg/SVGFETurbulenceElement.h: * ksvg2/svg/SVGFETurbulenceElement.idl: * ksvg2/svg/SVGNumberList.idl: 2006-10-06 Adam Roben Backing out my previous change. * WebCore.xcodeproj/project.pbxproj: * page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): 2006-10-06 Adam Roben Build fix. * WebCore.xcodeproj/project.pbxproj: * page/FrameView.cpp: (WebCore::FrameView::windowResizerRect): 2006-10-06 Adam Roben Reviewed by Maciej. More loader tweaks. * platform/ResourceLoader.h: * platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal): * platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::newHTTPRequest): 2006-10-05 Steve Falkenburg Reviewed by aroben. Stub out some methods that we'll be able to use to dodge a window resizer. * bridge/win/FrameWin.h: * page/Frame.h: (WebCore::Frame::windowResizerRect): * page/FrameView.h: * platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect): * platform/Widget.h: * platform/win/TemporaryLinkStubs.cpp: (FrameView::windowResizerRect): (Widget::setParent): (Widget::parent): (FrameWin::windowResizerRect): 2006-10-05 Dave Hyatt Stub out setFrameGeometry. * platform/ScrollView.h: 2006-10-05 Adele Peterson Reverting autoscroll fix. I need to rework this a little. * page/Frame.cpp: (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::stopAutoscrollTimer): * page/Frame.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): 2006-10-05 Alice Reviewed by Adam. Fixed * editing/CommandByName.cpp: (WebCore::Frame::Command::): was calling the wrong enabledFn for arrow selection and navigation 2006-10-05 Adele Peterson Reviewed by Maciej. - Fix for After timers fix, crash below RenderLayer::autoscroll after moving/destroying active and After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto. * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled. (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::autoscrollRenderer): (WebCore::Frame::setAutoscrollRenderer): (WebCore::Frame::stopAutoscrollTimer): * page/Frame.h: 2006-10-05 Don Gibson Reviewed by Eric. Fix win32 build bustage after ggaren's Scrollbar renaming changes. Properly include PlatformScrollBar.h in WbCore.vcproj. Clean up WidgetWin.cpp a bit. * WebCore.vcproj/WebCore/WebCore.vcproj: * platform/Widget.h: * platform/win/PlatformScrollBar.h: * platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars): * platform/win/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion): * platform/win/WidgetWin.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setContainingWindow): (WebCore::Widget::containingWindow): 2006-10-05 Geoffrey Garen build fix. * WebCore.xcodeproj/project.pbxproj: * bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): * bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame): * bridge/mac/FrameViewMac.mm: (WebCore::FrameView::passMousePressEventToScrollbar): * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge installInFrame:]): * bridge/mac/WebCoreFrameView.h: * platform/ScrollBar.cpp: * platform/Widget.h: * platform/mac/PlatformScrollBar.h: * platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollbar:]): (-[WebCoreScrollBar detachPlatformScrollbar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::scrollbarHit): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): * platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): * platform/mac/WidgetMac.mm: (WebCore::Widget::removeFromParent): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar): 2006-10-05 Geoffrey Garen build fix. * platform/Widget.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar): 2006-10-06 Mitz Pettel http://bugs.webkit.org/show_bug.cgi?id=8276 Fix broken manual test added back in r13990. Add resource forks for test resources. * manual-tests/resources/plain-text-paste/._1.textClipping: Added. * manual-tests/resources/plain-text-paste/._2.textClipping: Added. * manual-tests/resources/plain-text-paste/._4.txt: Added. * manual-tests/resources/plain-text-paste/._5.webloc: Added. 2006-10-05 David Hyatt Rename addClip to clip. Reviewed by darin * kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): * kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): * kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * platform/GraphicsContext.h: * platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip): * platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): * platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM): * platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addRoundedRectClip): * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintTextMatchMarker): * rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended): * rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject): * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::setClip): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): 2006-10-05 Mitz Pettel Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=10386 Delete RenderImageButton.* and remove references from .vcproj and .bkl files * CMakeLists.txt: * WebCore.vcproj/WebCore/WebCore.vcproj: * WebCoreSources.bkl: * rendering/RenderImageButton.cpp: Removed. * rendering/RenderImageButton.h: Removed. 2006-10-05 Mitz Pettel Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=11067 manual-tests/scrollbar-hittest2.html is invalid * manual-tests/scrollbar-hittest2.html: 2006-10-05 David Carson Reviewed by Darin. http://bugs.webkit.org/show_bug.cgi?id=11152 Adjust the tokenizer chunk size to be smaller for mobile devices, and also decrease the yield timer for the tokenizer so that it can resume earlier. * html/HTMLTokenizer.cpp: * config.h: 2006-10-05 Adam Roben Removing accidentally-checked-in do-nothing code. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): 2006-10-05 David Carson Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11158 Initialize class variables * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): 2006-10-05 Don Gibson Reviewed by Darin, landed by Adam. http://bugs.webkit.org/show_bug.cgi?id=11176 Fix win32 build, adapt to Maciej's ResourceLoader changes. * platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::start): 2006-10-05 Marvin Decker Reviewed by Darin. http://bugs.webkit.org/show_bug.cgi?id=10989 Provide a way for embedders to implement BrowserExtensionWin * WebCore.vcproj/WebCore/WebCore.vcproj: * bridge/win/BrowserExtensionWin.cpp: Added. (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL): * bridge/win/BrowserExtensionWin.h: * bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow): * bridge/win/FrameWin.h: * platform/win/TemporaryLinkStubs.cpp: 2006-10-05 Geoffrey Garen Reviewed by Darin. Fixed - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names. - fixed RenderLayer to properly tear down scrollbars, removing them from their parents. * bindings/js/kjs_window.cpp: (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures): * bridge/BrowserExtension.h: * dom/Document.cpp: (WebCore::Document::setInPageCache): * html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute): * html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::scrollingMode): * page/Frame.cpp: (WebCore::Frame::finishedParsing): (WebCore::Frame::scrollbarsVisible): * page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): (WebCore::FrameView::handleMousePressEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::scrollbarMoved): * page/FrameView.h: * page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults): * page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar): * platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): * platform/ScrollBar.h: (WebCore::): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::Scrollbar::~Scrollbar): (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::controlSize): (WebCore::Scrollbar::hasPlatformScrollbars): (WebCore::Scrollbar::client): * platform/ScrollBarMode.h: (WebCore::): * platform/ScrollView.h: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::horizontaScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::verticalScrollbarWidth): (WebCore::RenderLayer::horizontalScrollbarHeight): (WebCore::RenderLayer::updateScrollInfoAfterLayout): * rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::valueChanged): * rendering/RenderListBox.h: * rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar): 2006-10-05 Don Gibson Reviewed by Adam. http://bugs.webkit.org/show_bug.cgi?id=11138 Incorrect mouse event generation on Windows * platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): (1) Set mouse button even for non-click-related messages. (2) Track clicks correctly for all buttons, not just the left button. 2006-10-05 Nikolas Zimmermann Reviewed and landed by ap. Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes. * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::renderPath): (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::renderPath): * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: (WebCore::KRenderingPaintServerPatternQt::renderPath): * kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties): * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup): (WebCore::KRenderingPaintServerSolidQt::renderPath): * kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke): 2006-10-05 Alexey Proskuryakov Reviewed by Darin. http://bugs.webkit.org/show_bug.cgi?id=11054 REGRESSION: Traditional Chinese encoding in login authentication 1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers. 2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding for encoding GB_2312-80 and several others. So, we need to override this behavior, too. * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): 2006-10-05 Eric Seidel Reviewed by mjs. Removed dead code. Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs * WebCore.xcodeproj/project.pbxproj: * ksvg2/ecma/GlobalObject.cpp: Removed. * ksvg2/ecma/GlobalObject.h: Removed. 2006-10-05 Adam Roben Reviewed by Maciej. Small ResourceLoaderInternal tweak. * platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal): 2006-10-05 Eric Seidel Reviewed by mjs. More incremental KCanvas cleanup and optimization. Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods. Optimized dash array usage to not malloc. Also removed un-needed KSVGRenderingStyle includes. * kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): * kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): * kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox): * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown): * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath): * kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext): * ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill): * ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer): * ksvg2/misc/KCanvasRenderingStyle.h: 2006-10-05 Maciej Stachowiak Reviewed by Adam. - changed ResourceLoader to be refcounted It keeps a ref on itself while loading as well. This makes for a much saner memory management model than the previous. * bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp finishJobAndHandle:]): * dom/XMLTokenizer.cpp: (WebCore::openFunc): * loader/icon/IconLoader.cpp: (IconLoader::IconLoader): (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData): * loader/icon/IconLoader.h: * loader/loader.cpp: (WebCore::Loader::servePendingRequests): * platform/ResourceLoader.cpp: (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::kill): * platform/ResourceLoader.h: * platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal): * platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): * xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): * xml/xmlhttprequest.h: 2006-10-05 Eric Seidel Reviewed by mjs. Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer. http://bugs.webkit.org/show_bug.cgi?id=11163 No SVG performance tests yet. * kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): * kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): * kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): 2006-10-05 Dave Hyatt Stub out some stuff for widget focusability. Reviewed by maciej * page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): * platform/ScrollView.h: * platform/Widget.h: 2006-10-05 Adam Roben Reviewed by Maciej and Tim H. Copy some WebKit frame lifetime logic into WebCore -- just a step along the path to frame lifetime being handled completely in WebCore. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): Move platform-independent parts of this method into Frame. * page/Frame.cpp: (WebCore::Frame::setView): Adding platform-independent parts of FrameMac::setView (WebCore::Frame::detachChildren): New method to accomplish what -[WebFrameBridge _detachChildren] currently does. (WebCore::Frame::clear): Call detachChildren * page/Frame.h: Add declaration for detachChildren 2006-10-04 Alice Liu Reviewed by Darin. Fixed REGRESSION: Business and People widgets fails to complete search query * xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::setRequestHeader): removed exception set when the request is not open yet 2006-10-04 Anders Carlsson Reviewed by John Sullivan. Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off * loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it. 2006-10-03 Alexey Proskuryakov Reviewed by Tim H. http://bugs.webkit.org/show_bug.cgi?id=11130 Convert "undefined" to AE missing value * bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): return missing value for UndefinedType. 2006-10-03 Dave Hyatt Scrolling work. Eliminate convertTo/FromContainingWindow as cross-platform functions. Add back in the windowToContents/contentsToWindow functions. Reviewed by anders * bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::shouldDragAutoNode): (WebCore::FrameMac::sendContextMenuEvent): * bridge/mac/FrameViewMac.mm: (WebCore::FrameView::passMousePressEventToScrollbar): * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]): * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): * page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEvent): (WebCore::Frame::handleMouseReleaseEvent): * page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent): (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::prepareMouseEvent): (WebCore::FrameView::handleWheelEvent): * page/FrameView.h: * platform/ScrollBar.cpp: (WebCore::ScrollBar::setValue): * platform/ScrollView.h: * platform/Widget.h: (WebCore::Widget::scrolled): * platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::scrollbarUnderMouse): * platform/mac/WidgetMac.mm: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): (WebCore::RenderLayer::positionScrollbars): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::shouldPaint): * rendering/RenderView.cpp: * rendering/RenderView.h: * rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidget): 2006-09-26 David Smith Reviewed by Timothy. http://bugs.webkit.org/show_bug.cgi?id=3723 Add -scrollDOMRangeToVisible: No automated tests are possible as this code path isn't reachable from JavaScript. * bridge/mac/WebCoreFrameBridge.h: * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollDOMRangeToVisible:]): 2006-10-03 Graham Dennis Reviewed by Timothy. When contentEditable, cursor doesn't change to hand Allow the behaviour of editable links to be specified by a WebPreference The preference WebKitEditableLinkBehavior has four options: - AlwaysLive: Safari 2.0 behaviour - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour) - LiveWhenNotFocused: Editable links are live only when their editable block is not focused, or when the shift key is pressed - DefaultBehavior: This is the same as OnlyLiveWithShiftKey. No layout tests, just a modification of a manual-test as it isn't possible to test this automatically. * bridge/mac/WebCoreSettings.h: * bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]): (-[WebCoreSettings editableLinkBehavior]): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): * html/HTMLAnchorElement.h: * manual-tests/contenteditable-link.html: * page/FrameView.cpp: (WebCore::nodeIsNotBeingEdited): (WebCore::selectCursor): * page/Settings.h: (WebCore::Settings::): (WebCore::Settings::Settings): (WebCore::Settings::editableLinkBehavior): (WebCore::Settings::setEditableLinkBehavior): 2006-10-03 Beth Dakin Reviewed Darin. No test cases needed. Implemented a version of StringImpl::append that takes a UChar* and a length. * platform/StringImpl.cpp: (WebCore::StringImpl::append): (WebCore::StringImpl::insert): Call new append instead of making a new StringImpl. * platform/StringImpl.h: 2006-10-03 MorganL Reviewed by Darin. Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099 HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND * platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onHandleCreated): 2006-10-02 Geoffrey Garen Feared, loathed, reviewed by Darin. More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach into FRAME, plus other cleanup. No new behavior, so no new test. Layout tests pass. Basic browsing and Mail editing seem to work. * dom/Node.cpp: (WebCore::Node::detach): Removed random commented-out code. * html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): (1) Removed reference to FrameView, to dissociate frame loading from rendering. (2) Renamed newURL to completeURL because the difference between newURL and URLString is that newURL is a KURL that is the complete version of URLString, not that it is new. (WebCore::HTMLFrameElement::willRemove): (1) Removed close() call and moved close() code into willRemove(), also removing close() call from detach(), since willRemove is the well-defined place from DOM tear-down, not detach(). (2) Removed manual renderer detach code because the DOM is not responsible for managing the render tree. I confirmed that this change not regress . (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements lost their content frames after being removed from the DOM. That's our current behavior, but it's going to change in future rounds of refactoring. This also fixes . (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to attach/detach, because the render tree should not be in charge of deciding when to load. * html/HTMLFrameElement.h: * html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject, because the renderer is a renderPartObject, not a renderPart. * html/HTMLIFrameElement.h: 2006-10-03 Mark Rowe Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=11137 Bug 11137: GdkLauncher dies with "pure virtual method called" if window is closed while page still loading * platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual methods to be called before the FrameGdk portion of "this" is torn down. 2006-10-03 Adam Roben Reviewed by Darin. Handle tab key presses in the DOM. * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling. * page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Rename and reimplement focusNextPrevNode. Now we just call Element::focus(). * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make it public. 2006-10-03 Justin Garcia Reviewed by mjs TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT. * dom/Range.cpp: (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming positions are non-null since most of it's callers would be in a bad state if the positions were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception. Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it from entering compareBoundaryPoints and hitting the assert. 2006-10-03 Adele Peterson Reviewed by Geoff. Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): 2006-10-04 Darin Adler Reviewed by Geoff. - fix http://bugs.webkit.org/show_bug.cgi?id=11132 Caret disappears when you're typing * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Remove unnecessary call to clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this. (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout to false so we can get the old caret repaint rect. Later we need to change the design so getting the rect doesn't have a side effect of causing a layout without invalidation. 2006-10-03 David Harrison Reviewed by Maciej. Candidate Window isn't displayed and only first candidate is displayed at typing location. Updated test: * fast/text/justified-text-rect.html * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): Make the selection's root editable element (or the document itself) be the basis for NSRange conversions. This supports "shadow DOM" like that for text fields and text areas. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass the document element as the scope. * editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Make the first parameter the scope. * editing/TextIterator.h: Make the first parameter of rangeFromLocationAndLength() the scope. 2006-10-03 Nikolas Zimmermann Reviewed by Eric. Fix Qt/Linux build. * CMakeLists.txt: Add counter related files. 2006-10-03 Mark Rowe Reviewed by Eric. http://bugs.webkit.org/show_bug.cgi?id=10981 Linux/GDK build fixes Based on a patch by Krzysztof Kowalczyk. * WebCoreSources.bkl: * platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::handleGdkEvent): * platform/gdk/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget): * platform/gdk/ScrollViewGdk.cpp: * platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passWheelEventToSubframe): (Cursor::Cursor): (Widget::invalidate): (Widget::invalidateRect): (ScrollView::wheelEvent): (ScrollView::convertToContainingWindow): (ScrollView::convertFromContainingWindow): (GraphicsContext::clip): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::updateThumbPosition): (PlatformScrollBar::updateThumbProportion): (ScrollBar::ScrollBar): (ScrollBar::setProportion): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): * platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): * platform/gdk/WidgetGdk.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow): 2006-10-02 Adam Roben Reviewed by Maciej. Let Windows determine which mouse button is pressed. * platform/PlatformMouseEvent.h: Add message parameter to constructor. * platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message parameter to determine which mouse button is pressed. 2006-10-02 Justin Garcia Reviewed by anders Build fix * editing/SelectionController.cpp: (WebCore::SelectionController::empty): * editing/SelectionController.h: 2006-10-02 Justin Garcia Reviewed by john Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element * editing/markup.cpp: (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced elements). Don't skip blocks that aren't containers (like horizontal rules). 2006-10-03 Darin Adler Reviewed by Justin Garcia. - correct mistaken code that would restart blinking every time "invalidateSelection" is called even if the caret has not moved * editing/SelectionController.h: * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Update for name change. (WebCore::SelectionController::recomputeCaretRect): New function. Computes caret rect and does any necessary invalidation if the rect changes. (WebCore::SelectionController::invalidateCaretRect): Renamed from needsCaretRepaint. Invalidates the caret rect unconditionally. Also calls recomputeCaretRect as a side effect. * page/Frame.cpp: (WebCore::Frame::invalidateSelection): Remove unneeded call to clearCaretRectIfNeeded. (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change. (WebCore::Frame::selectionLayoutChanged): Restructured to use the new recomputeCaretRect function and not restart blinking if caret has not changed position. (WebCore::Frame::caretBlinkTimerFired): Removed some checks that are not needed since selectionLayoutChanged already checks these. * page/FramePrivate.h: Removed unused m_blinkCaret. 2006-10-02 Beth Dakin Reviewed by Adam. Build fix. Add counters to vcproj. * WebCore.vcproj/WebCore/WebCore.vcproj: 2006-10-02 Brady Eidson Reviewed by Adele If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing icon data out because we don't correctly check SQL error conditions. * loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): 2006-10-02 Steve Falkenburg Reviewed by Hyatt. Added method to find out whether a layout has occurred. * page/FrameView.cpp: (WebCore::FrameView::didFirstLayout): * page/FrameView.h: 2006-10-02 Beth Dakin Reviewed by Darin. Initial implementation of CSS2 counters. See http:// bugs.webkit.org/show_bug.cgi?id=4980 for more details. * WebCore.xcodeproj/project.pbxproj: * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the increment/reset list now that this is implemented. * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): * css/Counter.h: (WebCore::Counter::Counter): (WebCore::Counter::~Counter): (WebCore::Counter::identifier): (WebCore::Counter::listStyle): (WebCore::Counter::separator): (WebCore::Counter::listStyleNumber): (WebCore::Counter::setIdentifier): (WebCore::Counter::setListStyle): (WebCore::Counter::setSeparator): * css/cssparser.cpp: (WebCore::CSSParser::addProperty): Take care of reset/increment (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): content can now take counters (WebCore::CSSParser::parseCounterContent): Parse counter() and counters() (WebCore::CSSParser::parseCounter): Parse counter-reset and counter-increment * css/cssparser.h: * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::applyProperty): * platform/PlatformString.h: * platform/String.cpp: (WebCore::String::insert): Implemented a version of insert that accepts a UChar* and a length. * platform/StringImpl.cpp: (WebCore::StringImpl::insert): Same as above. * platform/StringImpl.h: * rendering/CounterListItem.h: Added. * rendering/CounterNode.cpp: Added. (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): (WebCore::CounterNode::remove): (WebCore::CounterNode::setUsesSeparator): (WebCore::CounterNode::recountAndGetNext): (WebCore::CounterNode::recountTree): (WebCore::CounterNode::setSelfDirty): (WebCore::CounterNode::setParentDirty): * rendering/CounterNode.h: Added. (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::parent): (WebCore::CounterNode::previousSibling): (WebCore::CounterNode::nextSibling): (WebCore::CounterNode::firstChild): (WebCore::CounterNode::lastChild): (WebCore::CounterNode::value): (WebCore::CounterNode::setValue): (WebCore::CounterNode::count): (WebCore::CounterNode::setCount): (WebCore::CounterNode::setHasSeparator): (WebCore::CounterNode::isReset): (WebCore::CounterNode::hasSeparator): (WebCore::CounterNode::willNeedLayout): (WebCore::CounterNode::setWillNeedLayout): (WebCore::CounterNode::isRoot): (WebCore::CounterNode::setRenderer): (WebCore::CounterNode::renderer): * rendering/CounterResetNode.cpp: Added. (WebCore::CounterResetNode::CounterResetNode): (WebCore::CounterResetNode::insertAfter): (WebCore::CounterResetNode::removeChild): (WebCore::CounterResetNode::recountAndGetNext): (WebCore::CounterResetNode::setParentDirty): (WebCore::CounterResetNode::updateTotal): * rendering/CounterResetNode.h: Added. (WebCore::CounterResetNode::firstChild): (WebCore::CounterResetNode::lastChild): (WebCore::CounterResetNode::isReset): (WebCore::CounterResetNode::total): * rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject): Account for counter content. * rendering/RenderCounter.cpp: Added. (WebCore::RenderCounter::RenderCounter): (WebCore::RenderCounter::layout): (WebCore::toRoman): (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderCounter::convertValueToType): (WebCore::RenderCounter::calcMinMaxWidth): * rendering/RenderCounter.h: Added. (WebCore::RenderCounter::renderName): (WebCore::RenderCounter::isCounter): * rendering/RenderObject.cpp: (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to maps of CounterNodes (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::destroy): Destroy the maps. (WebCore::RenderObject::findCounter): Finds/creates counters. * rendering/RenderObject.h: (WebCore::RenderObject::isCounter): * rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::RenderStyle::arenaDelete): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setContent): (WebCore::ContentData::clearContent): (WebCore::RenderStyle::counterDataEquivalent): (WebCore::hasCounter): (WebCore::RenderStyle::hasCounterReset): (WebCore::RenderStyle::hasCounterIncrement): (WebCore::readCounter): (WebCore::RenderStyle::counterReset): (WebCore::RenderStyle::counterIncrement): * rendering/RenderStyle.h: (WebCore::StyleVisualData::operator==): (WebCore::CounterData::CounterData): (WebCore::CounterData::identifier): (WebCore::CounterData::listStyle): (WebCore::CounterData::separator): (WebCore::ContentData::contentCounter): (WebCore::ContentData::): (WebCore::RenderStyle::counterIncrement): (WebCore::RenderStyle::counterReset): (WebCore::RenderStyle::setCounterIncrement): (WebCore::RenderStyle::setCounterReset): (WebCore::RenderStyle::setCounterResetList): (WebCore::RenderStyle::setCounterIncrementList): (WebCore::RenderStyle::counterResetValueList): (WebCore::RenderStyle::counterIncrementValueList): 2006-10-02 Adele Peterson Reviewed by Adam. - Fix for Switch to use new list box implementation for