2013-04-29 Zan Dobersek [GTK] Export the COLLECT_NO_DEMANGLE variable on the builders https://bugs.webkit.org/show_bug.cgi?id=115323 Reviewed by Philippe Normand. Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders. Its presence enforces linkers to output mangled symbols when reporting linking failures due to unresolved references. People trying to fix the build can then simply copy the printed mangled symbol into the symbols.filter file instead of doing a manual build or connecting to the builders to discover the mangled version of the missing symbol. * BuildSlaveSupport/gtk/daemontools-buildbot.conf: 2013-04-28 Zan Dobersek Remove Chromium code from Tools/BuildSlaveSupport https://bugs.webkit.org/show_bug.cgi?id=115325 Reviewed by Benjamin Poulain. Remove the two Chromium-specific scripts and the Chromium-specific parts from the code covering archiving test results and built products. * BuildSlaveSupport/built-product-archive: (archiveBuiltProduct): (extractBuiltProduct): * BuildSlaveSupport/chromium/output-android-device-status: Removed. * BuildSlaveSupport/chromium/remove-crash-logs: Removed. * BuildSlaveSupport/test-result-archive: (archiveTestResults): 2013-04-28 Seokju Kwon Remove support for Chromium from webkitdirs.pm https://bugs.webkit.org/show_bug.cgi?id=115338 Reviewed by Darin Adler. * Scripts/webkitdirs.pm: (determineBaseProductDir): (argumentsForConfiguration): (builtDylibPathForName): (determineIsQt): (isAppleWebKit): 2013-04-28 Zan Dobersek Rename TestRunner's setAudioData to setAudioResult https://bugs.webkit.org/show_bug.cgi?id=115326 Reviewed by Darin Adler. Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose than the previous one. The change is a simple rename, there's no change in the method's functionality. The affected tests are adjusted accordingly. * DumpRenderTree/qt/TestRunnerQt.cpp: (TestRunnerQt::setAudioResult): * DumpRenderTree/qt/TestRunnerQt.h: (TestRunnerQt): * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setAudioResult): * WebKitTestRunner/InjectedBundle/TestRunner.h: (TestRunner): 2013-04-28 Zan Dobersek [WKTR] Tests dumping audio data shouldn't dump pixels https://bugs.webkit.org/show_bug.cgi?id=115270 Reviewed by Benjamin Poulain. Prevent dumping the pixel output when Web Audio tests are dumping output data as the testing output. Pixel output in these tests has no real meaning and is as such unnecessary. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setAudioData): 2013-04-27 Raphael Kubo da Costa [EFL] Unreviewed Intel bots fix after r149231. * efl/jhbuild.modules: Disable the libxml Python bindings since the bots don't have Python's development files installed. libxml should detect this kind of thing better. 2013-04-26 Ryuan Choi [EFL] Build break using jhbuild on ubuntu 13.04 https://bugs.webkit.org/show_bug.cgi?id=115225 Reviewed by Gyuyoung Kim. libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and libxml 2.9.0 has a bug to make regression which r138422 mentioned. So this patch bumped libxml version to 2.9.1. * efl/jhbuild.modules: 2013-04-26 Jeffrey Pfau delete-stale-build-files does not clear .d files http://bugs.webkit.org/show_bug.cgi?id=115293 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/delete-stale-build-files: (main): Add .d to the file type list 2013-04-26 Roger Fong Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders. Make the DebugSuffix configuration use _debug dependencies. * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Removed. * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: * win/AssembleBuildLogs/AssembleLogs.cmd: * win/record-memory/record-memory.vcxproj: * win/record-memory/record-memoryDebug.props: * win/record-memory/record-memoryDebugWinCairo.props: * win/record-memory/record-memoryProduction.props: * win/record-memory/record-memoryRelease.props: * win/record-memory/record-memoryReleaseWinCairo.props: 2013-04-26 Zan Dobersek [GTK] Clean up the TestWebKitAPI GNUmakefile.am https://bugs.webkit.org/show_bug.cgi?id=115233 Reviewed by Martin Robinson. Specify unconditional, non-installable program targets in one declaration. Only conditionally specify WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.). Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp. Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to be compiled with the -fno-rtti flag that's present in the global_cxxflags variable. * TestWebKitAPI/GNUmakefile.am: 2013-04-25 Andy Estes [WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out https://bugs.webkit.org/show_bug.cgi?id=115223 Reviewed by Darin Adler. Added an API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files. * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added. (TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out when it loads a request with a custom protocol. * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added. * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the NSURLProtocol subclass to TestProtocol.{h, mm} and did some miscellaneous cleanup. * TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h. * TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm. (+[TestProtocol canInitWithRequest:]): (+[TestProtocol canonicalRequestForRequest:]): (+[TestProtocol requestIsCacheEquivalent:toRequest:]): (+[TestProtocol scheme]): (-[TestProtocol startLoading]): (-[TestProtocol stopLoading]): 2013-04-26 Martin Robinson Remove the remaining Skia #ifdefs https://bugs.webkit.org/show_bug.cgi?id=114886 Reviewed by Benjamin Poulain. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: (createBitmapContextFromWebView): Remove Skia #ifdef references. 2013-04-26 Mary Wu [BlackBerry] Clean up load interface in WebPage https://bugs.webkit.org/show_bug.cgi?id=113267 Reviewed by Rob Buis. Update DumpRenderTree with change of load() interface in WebPage. RIM Bug# 315535, internally reviewed by Joe Mason. * DumpRenderTree/blackberry/DumpRenderTree.cpp: (BlackBerry::WebKit::DumpRenderTree::runTest): 2013-04-26 Zan Dobersek Remove the HeapGraphSerializer unit test https://bugs.webkit.org/show_bug.cgi?id=115231 Reviewed by Andreas Kling. Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921, specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files. * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed. 2013-04-25 Seokju Kwon Remove support for Chromium from build/update scripts https://bugs.webkit.org/show_bug.cgi?id=115218 Reviewed by Darin Adler. * Scripts/build-webkit: (writeCongrats): * Scripts/update-webkit: 2013-04-25 Seokju Kwon Remove support for Chromium from api-test https://bugs.webkit.org/show_bug.cgi?id=115211 Reviewed by Dirk Pranke. * Scripts/build-api-tests: * Scripts/run-api-tests: (isSupportedPlatform): 2013-04-25 Seokju Kwon Get rid of Chromium in build-dumprendertree https://bugs.webkit.org/show_bug.cgi?id=115212 Reviewed by Dirk Pranke. * Scripts/build-dumprendertree: 2013-04-25 Alexey Proskuryakov Pass relatedPage when creating a page in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=115206 Reviewed by Geoffrey Garen. To make sure that window.open() opens in the same process even when using multiple processes. * WebKitTestRunner/PlatformWebView.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]): (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::PlatformWebView): 2013-04-25 Ryosuke Niwa Fix autocompletion for Benjamin. The Bugzilla email address must come first. * Scripts/webkitpy/common/config/contributors.json: 2013-04-25 Ryosuke Niwa Build fix. Forgot to merge args. * Scripts/webkitpy/tool/bot/irc_command.py: (Hi.execute): 2013-04-25 Ryosuke Niwa webkitbot should recognize its own nickname in greetings. https://bugs.webkit.org/show_bug.cgi?id=115196 Reviewed by Andreas Kling. Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !. * Scripts/webkitpy/tool/bot/irc_command.py: (Hi.execute): 2013-04-25 Xavier Castano [GTK] Tools/gtk/install-dependencies added ragel dependency https://bugs.webkit.org/show_bug.cgi?id=115163 Reviewed by Xan Lopez. The install-dependencies script was missing a dependency on ragel which is expected when building HarfBuzz. * gtk/install-dependencies: Added a dependency on ragel for both apt and yum. 2013-04-25 Eduardo Lima Mitev [GTK] Remove pango from optional jhbuild dependencies https://bugs.webkit.org/show_bug.cgi?id=115162 Reviewed by Martin Robinson. Pango is not needed since revision r148293 that lowers the pango dependency to 1.30, which is available in most distributions. * gtk/jhbuild-optional.modules: Removes description of pango module. 2013-04-25 Seokju Kwon Remove Chromium-specific cases from FeatureList.pm https://bugs.webkit.org/show_bug.cgi?id=115169 Reviewed by Andreas Kling. * Scripts/webkitperl/FeatureList.pm: 2013-04-24 Seokju Kwon Remove checking chromium from run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=115139 Reviewed by Benjamin Poulain. * Scripts/run-webkit-tests: (useNewRunWebKitTests): 2013-04-24 Simon Fraser Pixel tests in SVG are all broken in WK2 https://bugs.webkit.org/show_bug.cgi?id=114218 Reviewed by Darin Adler. Window snapshots in WebKitTestRunner on Mac are window-sized (800x600), which is wrong for the W3C SVG tests that require a 480x360 snapshot. Fix by resizing the window, as well as the web view in PlatformWebView::resizeTo() so that window snapshots are correctly sized. Also do some drive-by cleanup of the window size constants in both DRT and WTR to remove magic numbers, and make the code more similar. * DumpRenderTree/TestRunner.cpp: (TestRunner::setShouldPaintBrokenImage): * DumpRenderTree/TestRunner.h: * DumpRenderTree/efl/DumpRenderTree.cpp: * DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorShowWindow): * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (sizeWebViewForCurrentTest): * DumpRenderTree/mac/DumpRenderTreeMac.h: * DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext): * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (DumpRenderTree::DumpRenderTree): (DumpRenderTree::open): * DumpRenderTree/qt/TestRunnerQt.cpp: * DumpRenderTree/qt/TestRunnerQt.h: * DumpRenderTree/win/DumpRenderTree.cpp: (sizeWebViewForCurrentTest): * DumpRenderTree/wx/DumpRenderTreeWx.cpp: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::sizeWebViewForCurrentTest): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::resizeTo): 2013-04-24 Byungwoo Lee [EFL] Fix build error after r148963. https://bugs.webkit.org/show_bug.cgi?id=115126 Reviewed by Laszlo Gombos. Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h * TestWebKitAPI/PlatformEfl.cmake: 2013-04-24 Carlos Garcia Campos [GTK] Use stamp files for generate-forwarding-headers makefile rules https://bugs.webkit.org/show_bug.cgi?id=115118 Reviewed by Martin Robinson. Use a stamp file for the TestWebKitAPI and WebKitTestRunner forwarding generator rules and don't call it for soup since there aren't soup directories in TestWebKitAPI and WebKitTestRunner. * TestWebKitAPI/GNUmakefile.am: * WebKitTestRunner/GNUmakefile.am: 2013-04-24 Simon Pena [GTK] Update build dependencies https://bugs.webkit.org/show_bug.cgi?id=115111 Reviewed by Martin Robinson. The install-dependencies script was missing a dependency on EGL, which is expected when building Cairo. * gtk/install-dependencies: Added a dependency on libegl1-mesa for both apt and yum. 2013-04-24 Seokju Kwon Remove the Chromium-specific helper from run_webkit_tests.py https://bugs.webkit.org/show_bug.cgi?id=114996 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): 2013-04-24 Sergio Correia [EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test https://bugs.webkit.org/show_bug.cgi?id=114850 Reviewed by Andreas Kling. Revision r148312 fixed WebPageProxy cleanup and also changed the process termination semantics when requested by the user so that a client is not notified of a crash anymore, since there was no crash anyway. That change broke WKViewClientWebProcessCallbacks WK2 API test, since it relied on being notified of a crash after calling WKPageTerminate(). As a result of not being notified of such non-existent crash, the test would timeout right after making the terminate call. This patch adds an InjectedBundle to be used for simulating a crash, by calling abort() upon receiving a "Crash" message, and thus we are able to keep testing the crash callback. This patch also re-enables the WKViewClientWebProcessCallbacks test, which had been disabled in revisions r148858 and r148855, since it was failing. * TestWebKitAPI/PlatformEfl.cmake: * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added. (TestWebKitAPI): (WKViewClientWebProcessCallbacksTest): (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest): (TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage): 2013-04-24 Christophe Dumez [EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions https://bugs.webkit.org/show_bug.cgi?id=115095 Reviewed by Antonio Gomes. Use different subfolders under DumpRenderTree Temp folder for every functionality (icon database, cache, localstorage, ...). This makes sure there is no conflict between the functionalities. In EFL's case, libsoup cache was causing problems for the icon database if sharing the same folder. * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): == Rolled over to ChangeLog-2013-04-24 ==