2011-11-07 Dan Bernstein REGRESSION (r98178): World of Warcraft Launcher crashes in FrameView::isOnActivePage() https://bugs.webkit.org/show_bug.cgi?id=71743 Reviewed by Beth Dakin. * page/FrameView.cpp: (WebCore::FrameView::isOnActivePage): Added a check for a null m_frame. 2011-11-07 Dmitry Lomov https://bugs.webkit.org/show_bug.cgi?id=71534 [V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache. Reviewed by David Levin. * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): * bindings/scripts/CodeGeneratorV8.pm: * html/canvas/DataView.cpp: * html/canvas/DataView.h: * html/canvas/Float32Array.h: * html/canvas/Float64Array.h: * html/canvas/Int16Array.h: * html/canvas/Int32Array.h: * html/canvas/Int8Array.h: * html/canvas/TypedArrayBase.h: * html/canvas/Uint16Array.h: * html/canvas/Uint32Array.h: * html/canvas/Uint8Array.h: 2011-11-07 Adam Barth addMessage's last few arguments should be optional https://bugs.webkit.org/show_bug.cgi?id=70946 Reviewed by Darin Adler. As requested by Darin Adler. I wanted to call this method addMessage, but the compiler was unhappy locating the overload on ScriptExecutionContext when Document had an override too. Changing the name to addConsoleMessage made all the code happier. * dom/Document.cpp: (WebCore::Document::processHttpEquiv): * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addMessage): * dom/ScriptExecutionContext.h: * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): * html/parser/XSSAuditor.cpp: (WebCore::XSSAuditor::filterToken): * loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): * page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation): (WebCore::ContentSecurityPolicy::logUnrecognizedDirective): * page/EventSource.cpp: (WebCore::EventSource::didReceiveResponse): * webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::looping): (WebCore::AudioBufferSourceNode::setLooping): * webaudio/AudioContext.cpp: (WebCore::AudioContext::createLowPass2Filter): (WebCore::AudioContext::createHighPass2Filter): * xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): 2011-11-07 Adam Barth WebWorkers fail with document.domain set when accessing from subdomain https://bugs.webkit.org/show_bug.cgi?id=67978 Reviewed by Sam Weinig. Workers should ignore document.domain when deciding which URLs a document can request, just like XMLHttpRequest and every other API. Test: http/tests/workers/worker-document-domain-security.html * workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL): 2011-11-07 Scott Graham Allow gamepad API to be enabled at runtime https://bugs.webkit.org/show_bug.cgi?id=71736 Part of full patch, found at https://bugs.webkit.org/show_bug.cgi?id=69451 Reviewed by Adam Barth. No new tests. No new functionality. * bindings/generic/RuntimeEnabledFeatures.cpp: * bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setGamepadsEnabled): (WebCore::RuntimeEnabledFeatures::gamepadsEnabled): 2011-11-07 Kentaro Hara Remove [CustomGetter] IDL for window.Option of V8 https://bugs.webkit.org/show_bug.cgi?id=71735 Reviewed by Nate Chapin. Currently, window.Option uses a custom getter to get the template of 'HTMLOptionElementConstructor'. However, this getter does not need to be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'. Tests: fast/js/custom-constructors.html fast/forms/option-index.html fast/forms/add-and-remove-option.html fast/dom/dom-add-optionelement.html * bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter. * page/DOMWindow.idl: Removed [CustomGetter] IDL from window.Option of V8. Renamed 'HTMLOptionElementConstructor' to 'HTMLOptionElementConstructorConstructor' in order to make window.Option use the template of (not 'HTMLOptionElement' but) 'HTMLOptionElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from the IDL type. 2011-11-07 Mark Hahnenberg De-virtualize JSObject::putWithAttributes https://bugs.webkit.org/show_bug.cgi?id=71716 Reviewed by Darin Adler. No new tests. Added putWithAttributes to the MethodTable, changed all the virtual implementations of putWithAttributes to static ones, and replaced all call sites with corresponding lookups in the MethodTable. * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::putWithAttributes): * bindings/js/JSDOMWindowShell.h: 2011-11-07 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=71490 Support uiStateTransitionProgress for scrollbars -and corresponding- Reviewed by Sam Weinig. Step 1 of supporting uiStateTransitionProgress is knowing when the mouse has entered or exited a scrollbar. These changes to Scrollbar pass that information on to the ScrollAnimator. Also, Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter. This is necessary because m_hoveredNode is not always up to date on a mouseUp, so mouseUp must hitTest the scrollbar to see if the mouse has exited the scrollbar. * platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): * platform/Scrollbar.h: These changes are required now that Scrollbar::mouseUp() takes a parameter. * WebCore.exp.in: * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent): * platform/chromium/PopupListBox.cpp: (WebCore::PopupListBox::handleMouseReleaseEvent): * platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::wndProc): ScrollAnimator passes the information on to AppKit. * platform/ScrollAnimator.h: (WebCore::ScrollAnimator::mouseEnteredScrollbar): (WebCore::ScrollAnimator::mouseExitedScrollbar): * platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::mouseEnteredScrollbar): (WebCore::ScrollAnimatorMac::mouseExitedScrollbar): There are several new pieces of AppKit api we must call into. * platform/mac/NSScrollerImpDetails.h: This is a temporary function that is needed for the time being since there is new AppKit api required for this to work. * platform/mac/ScrollAnimatorMac.mm: (supportsUIStateTransitionProgress): I refactored WebScrollbarPartAnimation so that it can handle the uiStateTransitionProgress animation as well as the alpha animations it already handled. This mostly involved re-naming things and making use of a new enum called FeatureToAnimate which keeps track of what the instance of WebScrollbarPartAnimation is animating. (-[WebScrollbarPartAnimation initWithScrollbarPainter:animate:scrollAnimator:animateFrom:animateTo:duration:]): (-[WebScrollbarPartAnimation setScrollbarPainter:]): (-[WebScrollbarPartAnimation setStartValue:]): (-[WebScrollbarPartAnimation setEndValue:]): (-[WebScrollbarPartAnimation setCurrentProgress:]): WebScrollbarPainterDelegate has two new animations, _verticalUIStateTransitionAnimation, and _horizontalUIStateTransitionAnimation. It also responds to a few new delegate calls. (-[WebScrollbarPainterDelegate cancelAnimations]): This is a new delegate call needed for uiStateTransitionProgress. (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): I re-named setUpAnimation to setUpAlphaAnimation since it does a lot of things that are specific to the alpha animation and I chose not to re-use it for uiStateTransition. (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): New delegate call for the uiStateTransition animation that sets up that animation and kicks it off. (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): 2011-11-07 Alice Boxhall Remove unnecessary use of function pointer in FrameSelection::modify() https://bugs.webkit.org/show_bug.cgi?id=71646 Reviewed by Ryosuke Niwa. * editing/FrameSelection.cpp: (WebCore::FrameSelection::modify): 2011-11-07 Andreas Kling Unreviewed Windows build fix after r99468. * css/CSSPrimitiveValue.h: Unmark single-argument constructors as explicit, since this conflicts with the template constructors in CSSPrimitiveValueMappings.h. 2011-11-07 Jer Noble Build fix due to a erroneous search-and-replace. Unreviewed build fix. Replace all instances of GenericClock with ClockGeneric. * WebCore.xcodeproj/project.pbxproj: * platform/ClockGeneric.cpp: (ClockGeneric::ClockGeneric): 2011-11-07 Adam Barth Move parseSandboxPolicy to SecurityContext https://bugs.webkit.org/show_bug.cgi?id=71732 Reviewed by Eric Seidel. As requested by Eric, this patch resolves a layering inversion. Now that we have SecurityContext to hold the sandbox bits and the origin, it's a logical place to put the parser for sandbox policies. * dom/SecurityContext.cpp: (WebCore::SecurityContext::parseSandboxPolicy): * dom/SecurityContext.h: * html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute): * page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::applySandboxPolicy): * page/SecurityOrigin.cpp: * page/SecurityOrigin.h: 2011-11-07 Jer Noble Rename PlatformClockPOSIX -> ClockGeneric, and use WTF::currentTime() for its timing source. https://bugs.webkit.org/show_bug.cgi?id=71702 Reviewed by Sam Weinig. No new tests; covered by existing tests. * platform/Clock.cpp: (Clock::create): * platform/ClockGeneric.cpp: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.cpp. (ClockGeneric::ClockGeneric): (ClockGeneric::setCurrentTime): (ClockGeneric::currentTime): (ClockGeneric::setPlayRate): (ClockGeneric::start): (ClockGeneric::stop): * platform/ClockGeneric.h: Renamed from Source/WebCore/platform/posix/PlatformClockPOSIX.h. (WebCore::ClockGeneric::playRate): (WebCore::ClockGeneric::isRunning): Boilerplate project file changes: * CMakeLists.txt: * Target.pri: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: 2011-11-07 Vangelis Kokkevis Create a separate setting for compositing of for scrollable [i]frames that forceCompositingMode can be used without turning frames into composited layers. https://bugs.webkit.org/show_bug.cgi?id=71714 Reviewed by James Robinson. * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setAcceleratedCompositingForScrollableFramesEnabled): (WebCore::Settings::acceleratedCompositingForScrollableFramesEnabled): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): * testing/Internals.cpp: (WebCore::Internals::setEnableCompositingForScrollableFrames): * testing/Internals.h: * testing/Internals.idl: 2011-11-07 Rafael Weinstein [MutationObservers] Fix mac build (with mutation_observers enabled) https://bugs.webkit.org/show_bug.cgi?id=71728 Reviewed by Tony Chang. Errant forward declaration of MutationObserverRegistration removed from Node.h this would have broken a port that tried to build with mutation_observers=1. * dom/Node.h: 2011-11-07 Kentaro Hara Remove [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8 https://bugs.webkit.org/show_bug.cgi?id=71660 Reviewed by Adam Barth. Currently, "new Audio()" uses a custom getter to get the template of 'HTMLAudioElementConstructor'. However, this getter does not need to be custom and can use a default getter 'DOMWindowInternal::DOMWindowConstructorGetter'. Tests: fast/js/custom-constructors.html media/audio-constructor.html media/audio-constructor-src.html media/audio-constructor-preload.html media/audio-controls-do-not-fade-out.html media/audio-controls-rendering.html * bindings/v8/custom/V8DOMWindowCustom.cpp: Removed a custom getter. * page/DOMWindow.idl: Removed [CustomGetter] IDL from 'HTMLAudioElementConstructor' of V8. Renamed 'HTMLAudioElementConstructor' to 'HTMLAudioElementConstructorConstructor' in order to make 'new Audio()' use the template of (not 'HTMLAudioElement' but) 'HTMLAudioElementConstructor'. Note that CodeGenerator*.pm strips /Constructor$/ from an IDL type. * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): If an IDL type is 'XXXXConstructorConstructor', then we do not add a header file 'XXXXConstructor.h' to JSDOMWindow.cpp, because the NamedConstructor declaration is written in the header file of class XXXX 'XXXX.h'. Incidentally, the reason why CodeGeneratorV8.pm does not need a corresponding change is that V8 is still generating the NamedConstructor declaration in its dedicated header file 'XXXXConstructor.h'. This V8 issue will be fixed in the upcoming patch that implements [NamedConstructor] IDL in V8. 2011-11-07 Robert Sesek [chromium] Update WebCore.gyp to not use WebKitLibraries in include_dirs https://bugs.webkit.org/show_bug.cgi?id=71694 Reviewed by Adam Barth. * WebCore.gyp/WebCore.gyp: 2011-11-07 Dominic Cooney Remove initPopStateEvent method https://bugs.webkit.org/show_bug.cgi?id=71691 Reviewed by Ojan Vafai. * dom/PopStateEvent.cpp: * dom/PopStateEvent.h: * dom/PopStateEvent.idl: 2011-11-07 Andreas Kling CSSValue: Devirtualize isFooType(). Reviewed by Darin Adler. Add a member to CSSValue to determine which subclass a given value object is, along with 5 bits to tell us whether the value is primitive/mutable/initial/inherited/a list. All non-private subclass constructors now take CSSValue::ClassType as their first argument. A few constructors were duplicated as private members to allow calling them from ::create() methods without passing an explicit ClassType. Furthermore, since CSSValue::cssValueType() can be inferred from the subclass type, we compute it instead of storing it in a member. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: Adding CSSValue.cpp. * css/CSSValue.cpp: Added. (WebCore::CSSValue::cssValueType): Out-of-line implementation of this method. Only used by CSSOM. * css/CSSValue.h: (WebCore::CSSValue::isMutableValue): (WebCore::CSSValue::isPrimitiveValue): (WebCore::CSSValue::isValueList): (WebCore::CSSValue::isInitialValue): (WebCore::CSSValue::isInheritedValue): (WebCore::CSSValue::isBorderImageValue): (WebCore::CSSValue::isBorderImageSliceValue): (WebCore::CSSValue::isCursorImageValue): (WebCore::CSSValue::isFontFamilyValue): (WebCore::CSSValue::isFontFeatureValue): (WebCore::CSSValue::isFontValue): (WebCore::CSSValue::isImageGeneratorValue): (WebCore::CSSValue::isImageValue): (WebCore::CSSValue::isImplicitInitialValue): (WebCore::CSSValue::isReflectValue): (WebCore::CSSValue::isShadowValue): (WebCore::CSSValue::isTimingFunctionValue): (WebCore::CSSValue::isWebKitCSSTransformValue): (WebCore::CSSValue::isCSSLineBoxContainValue): (WebCore::CSSValue::isFlexValue): (WebCore::CSSValue::isWebKitCSSFilterValue): (WebCore::CSSValue::isSVGColor): (WebCore::CSSValue::isSVGPaint): (WebCore::CSSValue::classType): (WebCore::CSSValue::CSSValue): (WebCore::CSSValue::isPrimitiveType): (WebCore::CSSValue::isListType): (WebCore::CSSValue::isMutableType): (WebCore::CSSValue::isInheritedType): (WebCore::CSSValue::isInitialType): Store subclass type information into a member variable and made all the isFooValue() functions non-virtual and inline. Some subclass type lookups (primitive values, notably) are cached in a bool member on construction. * css/CSSAspectRatioValue.h: (WebCore::CSSAspectRatioValue::CSSAspectRatioValue): * css/CSSBorderImageSliceValue.cpp: (WebCore::CSSBorderImageSliceValue::CSSBorderImageSliceValue): * css/CSSBorderImageSliceValue.h: * css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue): * css/CSSBorderImageValue.h: * css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::CSSCanvasValue): * css/CSSCrossfadeValue.h: (WebCore::CSSCrossfadeValue::CSSCrossfadeValue): * css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::CSSCursorImageValue): * css/CSSCursorImageValue.h: * css/CSSFlexValue.h: (WebCore::CSSFlexValue::CSSFlexValue): * css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue): * css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::CSSFunctionValue): * css/CSSGradientValue.h: (WebCore::CSSGradientValue::isLinearGradient): (WebCore::CSSGradientValue::isRadialGradient): (WebCore::CSSGradientValue::CSSGradientValue): (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): * css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue): * css/CSSImageGeneratorValue.h: * css/CSSImageValue.cpp: (WebCore::CSSImageValue::CSSImageValue): * css/CSSImageValue.h: * css/CSSInheritedValue.h: (WebCore::CSSInheritedValue::CSSInheritedValue): * css/CSSInitialValue.h: (WebCore::CSSInitialValue::CSSInitialValue): (WebCore::CSSInitialValue::create): * css/CSSLineBoxContainValue.cpp: (WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue): * css/CSSLineBoxContainValue.h: * css/CSSMutableValue.h: (WebCore::CSSMutableValue::CSSMutableValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSReflectValue.h: (WebCore::CSSReflectValue::CSSReflectValue): * css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::isLinearTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isCubicBezierTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isStepsTimingFunctionValue): (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue): (WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue): * css/CSSUnicodeRangeValue.h: (WebCore::CSSUnicodeRangeValue::CSSUnicodeRangeValue): * css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): * css/CSSValueList.h: * css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::FontFamilyValue): * css/FontFamilyValue.h: * css/FontFeatureValue.cpp: (WebCore::FontFeatureValue::FontFeatureValue): * css/FontFeatureValue.h: * css/FontValue.h: (WebCore::FontValue::FontValue): * css/ShadowValue.cpp: (WebCore::ShadowValue::ShadowValue): * css/ShadowValue.h: * css/WebKitCSSFilterValue.cpp: (WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue): * css/WebKitCSSFilterValue.h: * css/WebKitCSSTransformValue.cpp: (WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue): * css/WebKitCSSTransformValue.h: * svg/SVGColor.cpp: (WebCore::SVGColor::SVGColor): * svg/SVGColor.h: * svg/SVGPaint.cpp: (WebCore::SVGPaint::SVGPaint): * svg/SVGPaint.h: Propagate subclass type information and kill isFooType() virtuals. 2011-11-07 Mihnea Ovidenie Leaks seen in RenderRegion::setRenderBoxRegionInfo on Leaks bot https://bugs.webkit.org/show_bug.cgi?id=71259 Reviewed by Darin Adler. Leak fixes covered by existing tests. * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::logicalWidthChangedInRegions): The RenderBoxRegionInfo taken out of RenderRegion must be deleted on all code paths. * rendering/RenderRegion.cpp: (WebCore::RenderRegion::removeRenderBoxRegionInfo): The RenderBoxRegionInfo map owns the values, therefore, when values are removed from map they must also be deleted. 2011-11-07 Adam Barth iframe sandbox treats vertical tab as a valid delimiter https://bugs.webkit.org/show_bug.cgi?id=71704 Reviewed by Eric Seidel. This patch adjusts our parser slightly to match the HTML5 spec. The only difference is in how we handle vertical tabs. Previously, we treated them as a delimiter, but we're not supposed to do that. Test: fast/frames/sandboxed-iframe-parsing-space-characters.html * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::parseSandboxPolicy): 2011-11-07 Adam Barth Factor SecurityContext out of ScriptExecutionContext https://bugs.webkit.org/show_bug.cgi?id=71721 Reviewed by Eric Seidel. The new SecurityContext object lets us tightly scope control of the security-critical information in ScriptExecutionContext. Originally I had hoped to put all this state on SecurityOrigin, but SecurityOrigin gets shared between documents in some corner cases, so it's not a good fit for state like the sandbox flags and the CSP policy that really needs to be per-document. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/DOMAllInOne.cpp: * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext): * dom/ScriptExecutionContext.h: * loader/FrameLoader.h: * loader/FrameLoaderTypes.h: * page/SecurityOrigin.h: 2011-11-07 Kentaro Hara Refactor CodeGeneratorV8.pm before making a core change for bug 71093. https://bugs.webkit.org/show_bug.cgi?id=71659 Reviewed by Adam Barth. Just refactor CodeGeneratorV8.pm without any change in behavior, as the first step for fixing bug 71093. Tests: WebCore/bindings/scripts/test/TestObj.idl WebCore/bindings/scripts/test/TestInterface.idl * bindings/scripts/CodeGeneratorV8.pm: (GenerateHeader): Sort generated headers in alphabetical order. Removed unnecessary variable names from method signatures. These changes are for silencing style check errors when a new TestXXXX.idl is added. (GenerateConstructorCallback): Renamed variables to clarify their roles. (WriteData): Removed an unused array @implHeaderContent. * bindings/scripts/test/V8/V8TestInterface.h: Updated a run-binding-tests result. * bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto. * bindings/scripts/test/V8/V8TestObj.h: Ditto. * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto. 2011-11-07 Ken Buchanan Crash due to mixed direction text runs https://bugs.webkit.org/show_bug.cgi?id=66015 Reviewed by David Hyatt. Test for bug fix. * fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html: Added * fast/text/international/bidi-neutral-in-mixed-direction-run-cras-expected.txt: Added 2011-11-07 Tim Horton getBBox() on a SVGPathElement with curves incorrectly includes control points https://bugs.webkit.org/show_bug.cgi?id=53512 Reviewed by Oliver Hunt. Split Path::boundingRect() into two, adding Path::fastBoundingRect() for a rough estimate of the bounding rect (always equal to or larger than boundingRect()). fastBoundingRect() currently falls back to boundingRect() for all ports besides CG, though in most cases (on a port-by-port basis) the current implementation of boundingRect() will need to become fastBoundingRect(), and a new, more accurate method will be implemented for boundingRect(). All previous callers of boundingRect() are transitioned to using fastBoundingRect() except SVGPathElement::getBBox, which wants an accurate bounding box. The CoreGraphics implementation of Path::boundingRect() called CGPathGetBoundingBox, which includes the path's control points in its calculations. Snow Leopard added CGPathGetPathBoundingBox, which finds the bounding box of only points within the path, and does not include control points. On Snow Leopard and above, we now use the latter. Test: svg/custom/getBBox-path.svg * html/HTMLAreaElement.cpp: * html/canvas/CanvasRenderingContext2D.cpp: * platform/graphics/Path.cpp: * platform/graphics/Path.h: * platform/graphics/cg/GraphicsContextCG.cpp: * platform/graphics/cg/PathCG.cpp: (WebCore::Path::boundingRect): * rendering/RenderObject.h: * rendering/svg/RenderSVGPath.cpp: * svg/SVGPathElement.cpp: * svg/SVGPathElement.h: 2011-11-07 Vsevolod Vlasov Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space. https://bugs.webkit.org/show_bug.cgi?id=71710 Reviewed by Pavel Feldman. * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype.autoCompleteSoon): 2011-11-07 vsevik@chromium.org Web Inspector: Suggest box should consume enter key pressed event. https://bugs.webkit.org/show_bug.cgi?id=71700 Reviewed by Pavel Feldman. * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._attachInternal): (WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed): 2011-11-07 David Barr Optimize outline rendering to avoid transparency layers https://bugs.webkit.org/show_bug.cgi?id=60750 Add fast path for solid block outlines with alpha. Improve readability of piecewise path while at it. Reviewed by Simon Fraser. No intended change in behaviour, no new tests. * rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): 2011-11-07 Vsevolod Vlasov Web Inspector: Suggest box should not accept suggestion on space key pressed. https://bugs.webkit.org/show_bug.cgi?id=71706 Reviewed by Pavel Feldman. * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.onKeyDown): (WebInspector.TextPrompt.SuggestBox.prototype.tabKeyPressed): 2011-11-07 Andreas Kling Don't use CSSOM's CSSValue.cssValueType internally in WebCore. Reviewed by Darin Adler. Swap out cssValueType() usage for isPrimitiveValue(), isInitialValue() and isInheritedValue() to increase code clarity. The plan is to turn cssValueType() into a computed value based on the CSSValue subclass (coming soon to .) This is a clean-up in preparation for that. * bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::V8CSSStyleDeclaration::namedPropertyGetter): * css/CSSInheritedValue.h: (WebCore::CSSInheritedValue::isInheritedValue): * css/CSSInitialValue.h: (WebCore::CSSInitialValue::isInitialValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseColor): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyDeclaration): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillAttachment): (WebCore::CSSStyleSelector::mapFillClip): (WebCore::CSSStyleSelector::mapFillComposite): (WebCore::CSSStyleSelector::mapFillOrigin): (WebCore::CSSStyleSelector::mapFillImage): (WebCore::CSSStyleSelector::mapFillRepeatX): (WebCore::CSSStyleSelector::mapFillRepeatY): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::mapAnimationDelay): (WebCore::CSSStyleSelector::mapAnimationDirection): (WebCore::CSSStyleSelector::mapAnimationDuration): (WebCore::CSSStyleSelector::mapAnimationFillMode): (WebCore::CSSStyleSelector::mapAnimationIterationCount): (WebCore::CSSStyleSelector::mapAnimationName): (WebCore::CSSStyleSelector::mapAnimationPlayState): (WebCore::CSSStyleSelector::mapAnimationProperty): (WebCore::CSSStyleSelector::mapAnimationTimingFunction): * css/CSSValue.h: (WebCore::CSSValue::isInheritedValue): (WebCore::CSSValue::isInitialValue): * css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): * editing/EditingStyle.cpp: (WebCore::EditingStyle::extractFontSizeDelta): (WebCore::EditingStyle::mergeStyleFromRulesForSerialization): 2011-11-07 Sheriff Bot Unreviewed, rolling out r99432. http://trac.webkit.org/changeset/99432 https://bugs.webkit.org/show_bug.cgi?id=71709 It made layout tests extra slow on all bots (Requested by Ossy_night on #webkit). * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._attachInternal): (WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed): 2011-11-07 Andreas Kling REGRESSION(r99409): Broke transitions/clip-transition.html Reviewed by Darin Adler. Add missing base class initializers to CSSPrimitiveValue constructors. This was causing some CSSPrimitiveValues to masquerade as CSS_CUSTOM values. * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): 2011-11-07 ChangSeok Oh [EFL] Support requestAnimationFrame API https://bugs.webkit.org/show_bug.cgi?id=67112 Reviewed by Andreas Kling. Add some files to build-target when enabling requestAnimationFrame option. fast/animation/request-animation-frame-cancel.html fast/animation/request-animation-frame-cancel2.html fast/animation/request-animation-frame-display.html fast/animation/request-animation-frame-during-modal.html fast/animation/request-animation-frame-timestamps.html fast/animation/request-animation-frame-within-callback.html fast/animation/request-animation-frame.html * CMakeLists.txt: * UseJSC.cmake: 2011-11-07 Sam Weinig Add missing .in and .pl files to the Xcode project for easy access. Reviewed by Eric Carlson. * WebCore.xcodeproj/project.pbxproj: Add some missing files to the Xcode project. 2011-11-07 Jessie Berlin Need a way to allow a scheme access to Local Storage and Databases while Private Browsing is enabled. https://bugs.webkit.org/show_bug.cgi?id=71631 Reviewed by Jon Honeycutt. Check the SchemeRegistry before preventing read/write access to Local Storage and Databases in Private Browsing. * WebCore.exp.in: Export the symbols for registering the schemes as allowing Local Storage and Database access in Private Browsing. * dom/Document.cpp: (WebCore::Document::allowDatabaseAccess): Check if the scheme allows Database access in Private Browsing. * platform/SchemeRegistry.cpp: (WebCore::schemesAllowingLocalStorageAccessInPrivateBrowsing): (WebCore::schemesAllowingDatabaseAccessInPrivateBrowsing): (WebCore::SchemeRegistry::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing): (WebCore::SchemeRegistry::allowsLocalStorageAccessInPrivateBrowsing): (WebCore::SchemeRegistry::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing): (WebCore::SchemeRegistry::allowsDatabaseAccessInPrivateBrowsing): * platform/SchemeRegistry.h: * storage/Storage.cpp: (WebCore::Storage::length): Ask the storage area if it is disabled by Private Browsing in the frame instead of just checking if Private Browsing is enabled for that frame because the answer might depend on what type of storage that storage area is. (WebCore::Storage::key): Ditto. (WebCore::Storage::getItem): Ditto. (WebCore::Storage::contains): Ditto. * storage/StorageArea.h: Make it possible to query a StorageArea for whether it is disabled by Private Browsing in a Frame. * storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame): Renamed from privateBrowsingEnabled. Check not only if Private Browsing is enabled for the Frame, but also if the storage type is Local Storage and if there is an exception for the scheme of the resource currently loaded into the Frame. (WebCore::StorageAreaImpl::setItem): Renamed privateBrowsingEnabled -> disabledByPrivateBrowsingInFrame. (WebCore::StorageAreaImpl::removeItem): Ditto. (WebCore::StorageAreaImpl::clear): Ditto. * storage/StorageAreaImpl.h: 2011-11-07 Dominic Cooney Remove initCloseEvent method https://bugs.webkit.org/show_bug.cgi?id=71374 Reviewed by Ojan Vafai. Test: fast/dom/Window/window-properties.html * websockets/CloseEvent.h: (WebCore::CloseEvent::initCloseEvent): * websockets/CloseEvent.idl: 2011-11-07 Anders Carlsson Simplify NetscapePlugin::convertPoint and make it work (in theory) with transformed plug-ins https://bugs.webkit.org/show_bug.cgi?id=71699 Reviewed by Sam Weinig. Export AffineTransform symbols used by WebKit2. * WebCore.exp.in: 2011-11-07 Michael Saboff Towards 8 Bit Strings: Templatize JSC::Lexer class by character type https://bugs.webkit.org/show_bug.cgi?id=71331 Changed the SourceProvider::data() virtual method to return a StringImpl* instead of a UChar*. Changed Identifier() constructor to use JSGlobalData*. Reviewed by Darin Adler. No new tests - refactored SourceProvider class and sub-classes. * bindings/js/CachedScriptSourceProvider.h: (WebCore::CachedScriptSourceProvider::stringData): * bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::stringData): * bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue): 2011-11-07 Dominic Cooney Remove initOverflowEvent from JavaScript bindings https://bugs.webkit.org/show_bug.cgi?id=71687 Reviewed by Ojan Vafai. Now that OverflowEvent has a constructor, we don't need the initOverflowEvent method. It has to remain in the Objective C binding because it is part of the Objective C public API. * dom/OverflowEvent.idl: 2011-11-07 Noel Gordon Refactor canvas encoding mimeType validation https://bugs.webkit.org/show_bug.cgi?id=71651 Reviewed by Andreas Kling. No new tests, refactoring only, covered by existing canvas tests. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toEncodingMimeType): move encoder mimeType validation logic into a helper routine. (WebCore::HTMLCanvasElement::toDataURL): * html/HTMLCanvasElement.h: 2011-11-07 Vsevolod Vlasov Web Inspector: Suggest box should consume enter key pressed event. https://bugs.webkit.org/show_bug.cgi?id=71700 Reviewed by Pavel Feldman. * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._attachInternal): (WebInspector.TextPrompt.SuggestBox.prototype.enterKeyPressed): 2011-11-07 Dominic Cooney Remove initPageTransitionEvent method https://bugs.webkit.org/show_bug.cgi?id=71689 Reviewed by Ojan Vafai. initPageTransitionEvent was removed from the HTML spec; it has been replaced by new PageTransitionEvent(...). Removing a method, so no new tests. * dom/PageTransitionEvent.cpp: * dom/PageTransitionEvent.h: * dom/PageTransitionEvent.idl: 2011-11-07 Alexander Pavlov Web Inspector: TextPrompt+SuggestBox should autocomplete on "Right" keydown and with a single suggestion in place https://bugs.webkit.org/show_bug.cgi?id=71676 Reviewed by Pavel Feldman. * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.onKeyDown): (WebInspector.TextPrompt.SuggestBox.prototype._updateItems): * inspector/front-end/inspectorCommon.css: (body): Revert inadvertent style change from a preceding commit. 2011-11-07 Tor Arne Vestbø Fix the Qt build on Mac OS X when using the QuickTime media backend When QtWebKit is built on Mac OS X using the QuickTime media backend we build both KURLCFNet.cpp and KURLMac, just like the Mac port, so we have to guard the potentially duplicate symbol createCFURL with more than just !PLATFORM(MAC). Reviewed by Andreas Kling. * platform/cf/KURLCFNet.cpp: 2011-11-07 Pavel Feldman Not reviewed: follow up to r99407. Style the suggest box. https://bugs.webkit.org/show_bug.cgi?id=65511 * inspector/front-end/TextPrompt.js: * inspector/front-end/inspector.css: * inspector/front-end/textPrompt.css: 2011-11-07 Roland Steiner https://bugs.webkit.org/show_bug.cgi?id=70223 CSSStyleSheet: finding the owner node should be in its own method Add styleSheetOwnerNode() function that returns the owner Node of the style sheet, or 0. Reviewed by Dimitri Glazkov. No new tests. (refactoring) * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::styleSheetOwnerNode): (WebCore::CSSStyleSheet::document): * css/CSSStyleSheet.h: 2011-11-07 Yury Semikhatsky [Chromium] Web Inspector: use native worker inspector instead of fake workers https://bugs.webkit.org/show_bug.cgi?id=71670 Removed context menu option for switching between native and "fake" workers debugger. Native debugger is used by default on platforms that support it. Reviewed by Pavel Feldman. * English.lproj/localizedStrings.js: * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleFormatSource): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked): * inspector/front-end/scriptsPanel.css: (#shared-workers-list): 2011-11-07 Vsevolod Vlasov Web Inspector: Add advanced search shortcut to ShortcutsScreen. https://bugs.webkit.org/show_bug.cgi?id=71302 Reviewed by Pavel Feldman. * English.lproj/localizedStrings.js: * inspector/front-end/AdvancedSearchController.js: (WebInspector.AdvancedSearchController.createShortcut): * inspector/front-end/inspector.js: (WebInspector._registerShortcuts): 2011-11-07 Andreas Kling CSSImageValue: Remove inheritance from CachedImageClient. Reviewed by Antti Koivisto. CSSImageValue doesn't actually use any of the CachedImageClient functionality, and holds a reference to the resource via the CachedResourceHandle in StyleCachedImage. So we can safely remove the multiple inheritance and simplify the class. * css/CSSImageValue.cpp: (WebCore::CSSImageValue::~CSSImageValue): (WebCore::CSSImageValue::cachedImage): (WebCore::CSSImageValue::clearCachedImage): * css/CSSImageValue.h: 2011-11-07 Andreas Kling CSSPrimitiveValue: Remove unused virtual function parseString(). Reviewed by Antti Koivisto. * css/CSSPrimitiveValue.cpp: * css/CSSPrimitiveValue.h: 2011-11-07 Andrey Kosyakov Web Inspector: use toString as the Date object description. https://bugs.webkit.org/show_bug.cgi?id=71605 Reviewed by Yury Semikhatsky. Test: inspector/remote-object.html * inspector/InjectedScriptSource.js: (.): 2011-10-26 Andrey Kosyakov Web Inspector: [refactoring] get JS-specific methods out of SourceFrame https://bugs.webkit.org/show_bug.cgi?id=70885 Reviewed by Pavel Feldman. No new tests, as there's no new functionality. * inspector/front-end/JavaScriptSourceFrame.js: (WebInspector.JavaScriptSourceFrame): (WebInspector.JavaScriptSourceFrame.prototype.willHide): (WebInspector.JavaScriptSourceFrame.prototype.requestContent): (WebInspector.JavaScriptSourceFrame.prototype.canEditSource): (WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName): (WebInspector.JavaScriptSourceFrame.prototype.editContent): (WebInspector.JavaScriptSourceFrame.prototype.contentChanged): (WebInspector.JavaScriptSourceFrame.prototype.setReadonly): (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.): (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition): (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else): (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu): (WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu): (WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged): (WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged): (WebInspector.JavaScriptSourceFrame.prototype.cancelEditing): (WebInspector.JavaScriptSourceFrame.prototype.didEditContent): (WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor): (WebInspector.JavaScriptSourceFrame.prototype._onShowPopover.showObjectPopover): (WebInspector.JavaScriptSourceFrame.prototype._onShowPopover): (WebInspector.JavaScriptSourceFrame.prototype._onHidePopover): (WebInspector.JavaScriptSourceFrame.prototype.addBreakpoint): (WebInspector.JavaScriptSourceFrame.prototype.removeBreakpoint): (WebInspector.JavaScriptSourceFrame.prototype._mouseDown): (WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing): (WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition): (WebInspector.JavaScriptSourceFrame.prototype._createConditionElement): (WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine): (WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine): (WebInspector.JavaScriptSourceFrame.prototype._lineNumberAfterEditing): (WebInspector.JavaScriptSourceFrame.prototype._onTextViewerContentLoaded): (WebInspector.JavaScriptSourceFrameDelegate): (WebInspector.JavaScriptSourceFrameDelegate.prototype.requestContent): (WebInspector.JavaScriptSourceFrameDelegate.prototype.setBreakpoint): (WebInspector.JavaScriptSourceFrameDelegate.prototype.removeBreakpoint): (WebInspector.JavaScriptSourceFrameDelegate.prototype.updateBreakpoint): (WebInspector.JavaScriptSourceFrameDelegate.prototype.findBreakpoint): (WebInspector.JavaScriptSourceFrameDelegate.prototype.continueToLine): (WebInspector.JavaScriptSourceFrameDelegate.prototype.canEditScriptSource): (WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSource): (WebInspector.JavaScriptSourceFrameDelegate.prototype.setScriptSourceIsBeingEdited): (WebInspector.JavaScriptSourceFrameDelegate.prototype.suggestedFileName): (WebInspector.JavaScriptSourceFrameDelegate.prototype.addToWatch): * inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame): * inspector/front-end/ScriptsPanel.js: (WebInspector.SourceFrameDelegateForScriptsPanel): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.willHide): (WebInspector.SourceFrame.prototype.get textViewer): (WebInspector.SourceFrame.prototype.requestContent): (WebInspector.SourceFrame.prototype._saveViewerState): (WebInspector.SourceFrame.prototype._restoreViewerState): (WebInspector.SourceFrame.prototype.beforeTextChanged): (WebInspector.SourceFrame.prototype.afterTextChanged): (WebInspector.SourceFrame.prototype._initializeTextViewer): (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu): (WebInspector.SourceFrame.prototype.suggestedFileName): (WebInspector.SourceFrame.prototype.canEditSource): (WebInspector.SourceFrame.prototype.startEditing): (WebInspector.SourceFrame.prototype.commitEditing): (WebInspector.SourceFrame.prototype.didEditContent): (WebInspector.SourceFrame.prototype.editContent): (WebInspector.SourceFrame.prototype.cancelEditing): (WebInspector.SourceFrame.prototype.setReadOnly): * inspector/front-end/inspector.html: 2011-11-06 Andreas Kling CSSValue: Devirtualize cssValueType(). Reviewed by Antti Koivisto. Keep the cssValueType in a CSSValue member instead of using virtual functions. This is part of a project to completely devirtualize CSSValue and will incur a temporary object size regression for CSSValue while the work is ongoing. * css/CSSInheritedValue.cpp: * css/CSSInheritedValue.h: (WebCore::CSSInheritedValue::CSSInheritedValue): * css/CSSInitialValue.cpp: * css/CSSInitialValue.h: (WebCore::CSSInitialValue::CSSInitialValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSPrimitiveValue.h: * css/CSSValue.h: (WebCore::CSSValue::cssValueType): (WebCore::CSSValue::CSSValue): * css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): * css/CSSValueList.h: 2011-11-07 Pavel Feldman Web Inspector: introduce UserAgent override setting. https://bugs.webkit.org/show_bug.cgi?id=71627 Reviewed by Yury Semikhatsky. * English.lproj/localizedStrings.js: * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::applyUserAgentOverride): (WebCore::InspectorResourceAgent::setUserAgentOverride): * inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen): (WebInspector.HelpScreen.prototype.show): (WebInspector.HelpScreen.prototype._onBlur): * inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged): (WebInspector.NetworkManager.prototype._userAgentSettingChanged): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/SettingsScreen.js: (WebInspector.SettingsScreen): (WebInspector.SettingsScreen.prototype._createSelectSetting.get for): (WebInspector.SettingsScreen.prototype._createCustomSetting): (WebInspector.SettingsScreen.prototype._createUserActionControl.checkboxClicked): (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const): (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textDoubleClicked): (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.textChanged): * inspector/front-end/helpScreen.css: (.help-table td): (.help-content fieldset label): 2011-11-07 Alexander Pavlov Web Inspector: autocomplete combobox for Styles sidebar and Console. https://bugs.webkit.org/show_bug.cgi?id=65511 Reviewed by Pavel Feldman. * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype): (): * inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt): (WebInspector.TextPrompt.prototype.setSuggestBoxEnabled): (WebInspector.TextPrompt.prototype._attachInternal): (WebInspector.TextPrompt.prototype.applySuggestion): (WebInspector.TextPrompt.prototype.acceptSuggestion): (WebInspector.TextPromptWithHistory): * inspector/front-end/inspector.css: (.suggest-box.generic-suggest): (.suggest-box.generic-suggest.above-anchor): (.suggest-box.generic-suggest .content): 2011-11-07 Pavel Feldman Web Inspector: split script-formatter test into multiple tests. https://bugs.webkit.org/show_bug.cgi?id=71607 Reviewed by Yury Semikhatsky. Tests: inspector/debugger/script-formatter-breakpoints.html inspector/debugger/script-formatter-console.html * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._removeSourceFrame): 2011-11-07 Keishi Hattori Change ColorChooser from singleton to ordinary object https://bugs.webkit.org/show_bug.cgi?id=71644 Reviewed by Kent Tamura. Changing WebCore::ColorChooser from a singleton to an ordinary object can broaden how browsers implement the color chooser interface. * WebCore.exp.in: * html/ColorInputType.cpp: (WebCore::ColorInputType::~ColorInputType): (WebCore::ColorInputType::setValue): If a chooser exists, calls Chrome::setSelectedColorInColorChooser (WebCore::ColorInputType::handleDOMActivateEvent): (WebCore::ColorInputType::detach): (WebCore::ColorInputType::didCleanup): Called after cleanup is complete. (WebCore::ColorInputType::cleanupColorChooser): Renamed from cleanupColorChooserIfCurrentClient. * html/ColorInputType.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectColorInColorChooser): * html/HTMLInputElement.h: * loader/EmptyClients.h: (WebCore::EmptyChromeClient::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now. (WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Ditto. * page/Chrome.cpp: (WebCore::Chrome::cleanupColorChooser): Added colorChooser argument because there are many WebCore::ColorChoosers now. (WebCore::Chrome::setSelectedColorInColorChooser): Ditto. * page/Chrome.h: * page/ChromeClient.h: * platform/ColorChooser.cpp: (WebCore::ColorChooserClient::~ColorChooserClient): (WebCore::ColorChooserClient::newColorChooser): Creates a new color chooser that is connected to itself. (WebCore::ColorChooserClient::discardChooser): Discards the connected color chooser. (WebCore::ColorChooser::ColorChooser): ColorChooser is RefCounted. (WebCore::ColorChooser::create): Creates a ColorChooser that is connected to the given ColorChooserClient. (WebCore::ColorChooser::~ColorChooser): (WebCore::ColorChooser::didChooseColor): Called from WebKit side when user chose a color. Calls ColorChooserClient::didChooseColor (WebCore::ColorChooser::didCleanup): Called from WebKit side when user color chooser was cleaned up. Calls ColorChooserClient::didCleanup * platform/ColorChooser.h: (WebCore::ColorChooserClient::chooser): Returns the current ColorChooser. (WebCore::ColorChooser::disconnectClient): Disconnects the ColorChooserClient. * testing/Internals.cpp: (WebCore::Internals::selectColorInColorChooser): Added element argument. This calls didChooseColor on the ColorChooser of that element. * testing/Internals.h: * testing/Internals.idl: Removed connectColorChooserClient and updated selectColorInColorChooser. 2011-11-07 Alexander Pavlov Web Inspector: Cannot edit elements commented with