1 2013-10-23 Ryosuke Niwa <rniwa@webkit.org>
3 Clicking on a test name on the new flakiness dashboard should add a new test pane
4 https://bugs.webkit.org/show_bug.cgi?id=123194
6 Reviewed by Simon Fraser.
8 Added a new click handler on each test name inside the builder test view add a new test pane.
9 Moved the old trac link to a right-arrow inline SVG icon.
11 Also tweaked the style so that the builder test view looks different from other test panes.
14 (TestResultsView._urlFromTest): Extracted from TestResultsView._linkifiedTestName.
15 (TestResultsView._populateBuilderPane): Fetch the test when its name is clicked.
16 Added a circled right arrow for the old trac link.
17 * main.css: Tweaked the style to move the rounded border around the builder test view to be
18 around the form controls to clearly differentiate it from a regular test pane.
20 2013-10-22 Ryosuke Niwa <rniwa@webkit.org>
22 New flakiness dashboard's test pane should show the latest WebKit revision for each builder
23 https://bugs.webkit.org/show_bug.cgi?id=123189
25 Reviewed by Simon Fraser.
28 (TestResultsView._populateTestPane): Call _createTestResultHeader and _createTestResultRow with
29 a list of repository information.
30 (TestResultsView._createTestResultHeader): Optionally creates headers for a list of repositories.
31 (TestResultsView._createTestResultRow): Add a hyperlinked revision information for each builder.
32 Also add a hyperlink to file a Bugzilla bug when there is no bug associated with the test already.
34 (Build.formattedRevision): Extracted from Build.formattedRevisions.
35 (Build.formattedRevisions):
37 2013-10-22 Ryosuke Niwa <rniwa@webkit.org>
39 Make tables on the new flakiness dashboard sortable
40 https://bugs.webkit.org/show_bug.cgi?id=123141
42 Reviewed by Simon Fraser.
44 Use jquery.tablesorter.js to make test and builder tables sortable. The jquery plugin is already used by run-perf-tests.
47 (TestResultsView._populateTestPane): Add tablesorter to the class name and wrap tr's inside a tbody so that tablesorter
49 (TestResultsView._populateBuilderPane): Ditto.
51 (.resultsTable thead): Use cursor: pointer to signify the fact it's clickable.
52 (.resultsTable th): Don't repeat arrows.
53 (.resultsTable th.headerSortUp): Inline SVG up arrow.
54 (.resultsTable th.headerSortDown): Inline SVG down arrow.
56 2013-10-21 Ryosuke Niwa <rniwa@webkit.org>
58 New flakiness dashboard should hyperlink test names, WebKit revisions, and bubbles
59 https://bugs.webkit.org/show_bug.cgi?id=123134
61 Reviewed by Stephanie Lewis.
63 Copied admin.css, admin-header.php, admin-footer.php, builders.php, repositories.php from WebKit Perf Monitor.
64 (Unfortunately WebKit Perf Monitor hasn't been committed into WebKit repository just yet.)
66 Updated various parts of index.html to linkify test names, build numbers, and bubbles (to results page).
68 * admin/admin.css: Added.
69 * admin/builders.php: Added.
70 * admin/index.php: Removed the duplicated code now that it uses admin-header.php.
71 * admin/repositories.php: Added.
72 * api/manifest.php: Use camelCase for blame_url and build_url to be consistent with other JSON properties.
73 Also exported testCategories from config so that we can linkify test names in the dashboard.
74 * include/admin-footer.php: Added.
75 * include/admin-header.php: Added.
76 * include/config.json: Added test categories. This avoids hard-coding the URL to trac in php/js.
77 * include/init-database.sql: Added name and build_url to builders table and category to tests.
78 * include/test-results.php: Assume the test category to be LayoutTest for now.
81 (TestResultsView): Initialize _builders, _slaves, _repositories, _testCategories as dictionaries as intended.
82 (TestResultsView.setTestCategories): Added.
83 (TestResultsView._createResultCell): Dynamically resolve URLs of results page and and build page.
84 (TestResultsView._populateTestPane): Linkify the test name. Unfortunately we don't have a test object anywhere.
85 We need to figure out a way to find the test object here eventually. For now, hard-coding "LayoutTest" works.
86 (TestResultsView._linkifiedTestName): Added.
87 (TestResultsView._createBuildsAndComputeSlownessOfResults): Takes builderId to set "builder" property on each
88 result object as it's used by Build class.
89 (TestResultsView._populateBuilderPane):
93 (Build.buildUrl): Support $builderName so that we don't have to keep repeating builder names in the database.
94 (Build.revision): Don't access [0] if revisions[repositoryId] was undefined.
96 2013-10-21 Ryosuke Niwa <rniwa@webkit.org>
98 New flakiness dashboard should align results by revision numbers
99 https://bugs.webkit.org/show_bug.cgi?id=123129
101 Reviewed by Tim Horton.
103 * include/config.json: Specify the default cache time to be 10 minutes.
104 * include/json-shared.php: Added Expires and Cache-Control headers. It's configurable via config.json.
106 (TestResultsView._createResultCell): Don't put '-' in a result cell without time.
107 (TestResultsView._populateTestPane): Create an array of build times ordered from the newest to the oldest.
108 Not that build.time() is the newest commit time among all repository for each result. e.g. if we had
109 both WebKit and Safari repository information in a given result, the newer of the two will be used.
110 (TestResultsView._createTestResultHeader): Added.
111 (TestResultsView._createBuildsAndComputeSlownessOfResults): Extracted from _createTestResultRow so
112 that _populateTestPane could use Build object before calling _createTestResultRow.
113 (TestResultsView._createTestResultRow): Takes buildTimes. Insert an empty cell for a build time if
114 the current row doesn't contain that a result for that build time.
115 (TestResultsView._populateBuilderPane):
116 * main.css: Tweaked the style so that bubbles are aligned vertically without '-'.
118 (.resultsTable thead th):
119 (.resultsTable .resultCell):
121 (.resultsTable span a):
123 2013-10-21 Ryosuke Niwa <rniwa@webkit.org>
125 New flakiness dashboard show test time, modifiers, and flaky tests
126 https://bugs.webkit.org/show_bug.cgi?id=123119
128 Reviewed by Tim Horton.
130 * api/failing-tests.php: Manually serialize each row in the results to avoid hitting the memory limit.
132 (Database::query): Added.
133 (Database::fetch_next_row): Added.
134 * include/init-database.sql: Added modifiers and time columns to results table.
135 * include/test-results.php:
136 (store_test_results): Update start_time and end_time to the union of the new interval and the existing interval.
137 (recursively_add_test_results): Handle empty $full_name to eliminate the loop over tests in store_test_results.
138 Also verify that each test name, expected and actual results conform to the specific format to prevent XSS.
139 Also use insert_row instead of select_or_insert_row to avoid issuing an unnecessary SQL query.
140 (format_result): Extracted from format_result_rows. Used in failing-tests.php.
142 (TestResultsView): Added _currentBuilderFailureType and _currentBuilderDays.
143 (TestResultsView._createResultCell): Show the test time and the expected result.
144 (TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time
145 less than 10s or second if it's more than 10s so that the test time will always be shown in two digits.
146 Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
147 (TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type.
148 (TestResultsView._populateBuilderPane):
149 (TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations.
150 (TestResultsView.updateLocationHash):
151 (TestResultsView.loadTestsFromLocationHash):
154 (element): appendChild if an item is a Node. Otherwise, e.g. integer, create a text node out of toString() call.
155 * main.css: Updated styles.
157 2013-10-18 Ryosuke Niwa <rniwa@webkit.org>
159 New flakiness dashboard should support showing the failing tests per builder
160 https://bugs.webkit.org/show_bug.cgi?id=123011
162 Reviewed by Timothy Hatcher.
164 Added the feature. Also did some refactoring to add this feature.
167 * api/failing-tests.php: Added.
168 * api/manifest.php: Removed the code to make maps by id. The work is now done in index.html.
170 * common.css: Added. Extracted from index.html.
171 * include/test-results.php: Extracted parse_revisions_array and format_result_rows from results.php.
174 (TestResultsView.setAvailableTests): Added.
175 (TestResultsView.showTooltip): Fixed the code to compute x and y coordinates of the tooltip to take
176 scrolled positions into account.
177 (TestResultsView._createTestResultRow): Extracted from _populateTestPane.
178 (TestResultsView.fetchTest): Added the code to show "Loading..." in the pane while loading the JSON.
179 (TestResultsView.fetchTests): Respect the doNotUpdateHash flag.
180 (TestResultsView._populateBuilderPane): Added.
181 (TestResultsView.fetchFailingTestsForBuilder): Added.
182 (TestResultsView.updateLocationHash): Serialize builder & builderDays.
183 (TestResultsView.locationHashChanged): Don't delete existing test panes since that's now done in
184 loadTestsFromLocationHash.
185 (TestResultsView.loadTestsFromLocationHash): Take care of both 'tests' and 'builder' components.
186 (fetchManifest): Setup the UI to select a builder.