1 2015-02-13 Ryosuke Niwa <rniwa@webkit.org>
3 The status of a A/B testing request always eventually becomes "Failed"
4 https://bugs.webkit.org/show_bug.cgi?id=141523
6 Reviewed by Andreas Kling.
8 The bug was caused by /api/build-requests always setting the status of a build request to 'failed' when
9 'failedIfNotCompleted' was sent by the buildbot sync'er.
11 Fixed the bug by only setting the status to 'failed' if it wasn't set to 'completed'.
13 * public/api/build-requests.php:
16 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
18 Unreviewed, remove empty directories.
20 * public/data: Removed.
22 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
24 Perf dashboard should show the results of A/B testing
25 https://bugs.webkit.org/show_bug.cgi?id=141500
27 Reviewed by Chris Dumez.
29 Added the support for fetching test_runs for a specific test group in /api/runs/, and used it in the
30 analysis task page to fetch results for each test group.
32 Merged App.createChartData into App.Manifest.fetchRunsWithPlatformAndMetric so that App.BuildRequest
33 can use the formatter.
35 * public/api/runs.php:
36 (fetch_runs_for_config_and_test_group): Added.
37 (fetch_runs_for_config): Just return the fetched rows since main will format them with RunsGenerator.
38 (main): Use fetch_runs_for_config_and_test_group to fetch rows when a test group id is specified. Also
39 use RunsGenerator to format results.
40 (RunsGenerator): Added.
41 (RunsGenerator::__construct): Added.
42 (RunsGenerator::add_runs): Added.
43 (RunsGenerator::format_run): Moved.
44 (RunsGenerator::parse_revisions_array): Moved.
46 * public/v2/analysis.js:
47 (App.TestGroup): Fixed a typo. The property on a test group that refers to an analysis task is "task".
48 (App.TestGroup._fetchChartData): Added. Fetches all A/B testing results for this group.
49 (App.BuildRequest.configLetter): Renamed from config since this returns a letter that identifies the
50 configuration associated with this build request such as "A" and "B".
51 (App.BuildRequest.statusLabel): Added the missing label for failed build requests.
52 (App.BuildRequest.url): Added. Returns the URL associated with this build request.
53 (App.BuildRequest._meanFetched): Added. Retrieve the mean and the build number for this request via
57 (App.Pane._fetch): Set chartData directly here.
58 (App.Pane._updateMovingAverageAndEnvelope): Renamed from _computeChartData. No longer sets chartData
59 now that it's done in App.Pane._fetch.
60 (App.AnalysisTaskController._fetchedRuns): Updated per createChartData merge.
63 (Measurement.prototype.buildId): Added.
64 (TimeSeries.prototype.findPointByBuild): Added.
66 * public/v2/index.html: Fixed a bug that build status URL was broken. We can't use link-to helper since
67 url is not an Ember routed path.
69 * public/v2/manifest.js:
70 (App.Manifest.fetchRunsWithPlatformAndMetric): Takes testGroupId as the third argument. Merged
71 App.createChartData here so that App.BuildRequest can use the formatter
73 2015-02-12 Ryosuke Niwa <rniwa@webkit.org>
75 v2 UI should adjust the number of ticks on dashboards based on screen size
76 https://bugs.webkit.org/show_bug.cgi?id=141502
78 Reviewed by Chris Dumez.
80 * public/v2/interactive-chart.js:
81 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Compute the number of ticks based on the
84 2015-02-11 Ryosuke Niwa <rniwa@webkit.org>
86 New perf dashboard shows too much space around interesting data points
87 https://bugs.webkit.org/show_bug.cgi?id=141487
89 Reviewed by Chris Dumez.
91 Revise the y-axis range adjustment algorithm in r179913. Instead of showing the entire moving average,
92 show the current time series excluding points in the series outside the moving average envelope.
95 (App.Pane._computeChartData): Don't deal with missing moving average or enveloping strategy here.
96 (App.Pane._computeMovingAverageAndOutliers): Set isOutliner to true on all data points in the current
97 time series if the point lies outside the moving average envelope. Don't expose the moving average or
98 the envelope computed for this purpose if they're not set by the user.
101 (TimeSeries.prototype.minMaxForTimeRange): Takes a boolean argument, ignoreOutlier. When the flag is set
102 to true, min/max computation will ignore any point in the series with non-falsy "isOutliner" property.
104 * public/v2/interactive-chart.js:
105 (App.InteractiveChartComponent._constructGraphIfPossible): Unsupport hideMovingAverage and hideEnvelope.
106 (App.InteractiveChartComponent._computeYAxisDomain): Removed the commented out code. Also moved the code
107 to deal with showFullYAxis here.
108 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Rewrote the code. Takes ignoreOutliners as an
109 argument instead of directly inspecting showFullYAxis.
111 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
113 New perf dashboard shouldn't always show outliners
114 https://bugs.webkit.org/show_bug.cgi?id=141445
116 Reviewed by Chris Dumez.
118 Use the simple moving average with an average difference envelope to compute the y-axis range to show
119 to avoid expanding it spuriously to show one off outlier.
122 (App.Pane): Don't show the full y-axis range by default.
123 (App.Pane._computeChartData): Use the first strategies for the moving average and the enveloping if
124 one is not specified by the user but without showing them in the charts.
125 (App.Pane._computeMovingAverage): Takes moving average and enveloping strategies as arguments instead
126 of retrieving via chosenMovingAverageStrategy and chosenEnvelopingStrategy.
128 (App.ChartsController._parsePaneList): Added showFullYAxis as a query string argument to each pane.
129 (App.ChartsController._serializePaneList): Ditto.
131 * public/v2/chart-pane.css: Added a CSS rule for when y-axis is clickable.
133 * public/v2/index.html: Pass in showFullYAxis as an argument to the main interactive chart.
135 * public/v2/interactive-chart.js:
136 (App.InteractiveChartComponent._constructGraphIfPossible): Add an event listener on y-axis labels when
137 the chart is interactive so that toggle showFullYAxis. Also hide the moving average and/or the envelope
138 if they are not specified by the user (i.e. only used to adjust y-axis range).
139 (App.InteractiveChartComponent._updateDomain): Don't exit early if y-axis domains are different even if
140 x-axis domain remained the same. Without this change, the charts would never redraw.
141 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Use the moving average instead of the current
142 time series to compute the y-axis range if showFullYAxis is false. When showFullYAxis is true, expand
143 y-axis all the way down to 0 or the minimum value in the current time series whichever is smaller.
145 * public/v2/js/statistics.js:
146 (Statistics.MovingAverageStrategies): Use a wider window in Simple Moving Average by default.
148 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
150 Unreviewed build fix.
153 (set get App.Pane.Ember.Object.extend):
155 2015-02-10 Ryosuke Niwa <rniwa@webkit.org>
157 New perf dashboard should have the ability to overlay moving average with an envelope
158 https://bugs.webkit.org/show_bug.cgi?id=141438
160 Reviewed by Andreas Kling.
162 This patch adds three kinds of moving average strategies and two kinds of enveloping strategies:
164 Simple Moving Average - The moving average x̄_i of x_i is computed as the arithmetic mean of values
165 from x_(i - n) though x_(i + m) where n is a non-negative integer and m is a positive integer. It takes
166 n, backward window size, and m, forward window size, as an argument.
168 Cumulative Moving Average - x̄_i is computed as the arithmetic mean of all values x_0 though x_i.
169 That is, x̄_1 = x_1 and x̄_i = ((i - 1) * M_(i - 1) + x_i) / i for all i > 1.
171 Exponential Moving Average - x̄_i is computed as the weighted average of x_i and x̄_(i - 1) with α as
172 an argument specifying x_i's weight. To be precise, x̄_1 = x_1 and x̄_i = α * x_i + (α - 1) x̄_(i-1).
175 Average Difference - The enveloping delta d is computed as the arithmetic mean of the difference
176 between each x_i and x̄_i.
178 Moving Average Standard Deviation - d is computed like the standard deviation except the deviation
179 for each term is measured from the moving average instead of the sample arithmetic mean. i.e. it uses
180 the average of (x_i - x̄_i)^2 as the "sample variance" instead of the conventional (x_i - x̄)^2 where
181 x̄ is the sample mean of all x_i's. This change was necessary since our time series is non-stationary.
184 Each strategy is cloned for an App.Pane instance so that its parameterList can be configured per pane.
185 The configuration of the currently chosen strategies is saved in the query string for convenience.
187 Also added the "stat pane" to choose a moving average strategy and a enveloping strategy in each pane.
189 * public/v2/app.css: Specify the fill color for all SVG groups in the pane toolbar icons.
192 (App.Pane._fetch): Delegate the creation of 'chartData' to _computeChartData.
193 (App.Pane.updateStatisticsTools): Added. Clones moving average and enveloping strategies for this pane.
194 (App.Pane._cloneStrategy): Added. Clones a strategy for a new pane.
195 (App.Pane._configureStrategy): Added. Finds and configures a strategy from the configuration retrieved
196 from the query string via ChartsController.
197 (App.Pane._computeChartData): Added. Creates chartData from fetchedData.
198 (App.Pane._computeMovingAverage): Added. Computes the moving average and the envelope.
199 (App.Pane._executeStrategy): Added.
200 (App.Pane._updateStrategyConfigIfNeeded): Pushes the strategy configurations to the query string via
202 (App.ChartsController._parsePaneList): Merged the query string arguments for the range and point
203 selections, and added two new arguments for the moving average and the enveloping configurations.
204 (App.ChartsController._serializePaneList): Ditto.
205 (App.ChartsController._scheduleQueryStringUpdate): Observes strategy configurations.
206 (App.PaneController.actions.toggleBugsPane): Hides the stat pane.
207 (App.PaneController.actions.toggleSearchPane): Hides the stat pane.
208 (App.PaneController.actions.toggleStatPane): Added.
210 * public/v2/chart-pane.css: Added CSS rules for the new stat pane. Also added .foreground class for the
211 current (as opposed to baseline and target) time series for when it's the most foreground graph without
212 moving average and its envelope overlapping on top of it.
214 * public/v2/index.html: Added the templates for the stat pane and the corresponding icon (Σ).
216 * public/v2/interactive-chart.js:
217 (App.InteractiveChartComponent.chartDataDidChange): Unset _totalWidth and _totalHeight to avoid exiting
218 early inside _updateDimensionsIfNeeded when chartData changes after the initial layout.
219 (App.InteractiveChartComponent.didInsertElement): Attach event listeners here instead of inside
220 _constructGraphIfPossible since that could be called multiple times on the same SVG element.
221 (App.InteractiveChartComponent._constructGraphIfPossible): Clear down the old SVG element we created
222 but don't bother removing individual paths and circles. Added the code to show the moving average time
223 series when there is one. Also add "foreground" class on SVG elements for the current time series when
224 we're not showing the moving average. chart-pane.css has been updated to "dim down" the current time
225 series when "foreground" is not set.
226 (App.InteractiveChartComponent._minMaxForAllTimeSeries): Take the moving average time series into
227 account when computing the y-axis range.
228 (App.InteractiveChartComponent._brushChanged): Removed 'selectionIsLocked' argument as it's useless.
230 * public/v2/js/statistics.js:
231 (Statistics.MovingAverageStrategies): Added.
232 (Statistics.EnvelopingStrategies): Added.
234 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
236 The delta value in the chart pane sometimes doens't show '+' for a positive delta
237 https://bugs.webkit.org/show_bug.cgi?id=141340
239 Reviewed by Andreas Kling.
241 The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
242 it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
245 (App.Pane.computeStatus):
246 (App.createChartData):
248 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
250 Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
253 (App.PaneController._updateDetails):
255 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
257 Unreviewed. Commit the forgotten change.
259 * public/include/manifest.php:
261 2015-02-06 Ryosuke Niwa <rniwa@webkit.org>
263 New perf dashboard should have multiple dashboard pages
264 https://bugs.webkit.org/show_bug.cgi?id=141339
266 Reviewed by Chris Dumez.
268 Added the support for multiple dashboard pages. Also added the status of the latest data point.
269 e.g. "5% better than target"
271 * public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
272 Also hid the border lines around charts on the dashboard page for a cleaner look.
275 (App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
276 (App.IndexRoute.beforeModel): Added.
277 (App.DashboardRoute): Added.
278 (App.DashboardRoute.model): Added. Return the dashboard specified by the name.
279 (App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
280 (App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
281 (App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
282 (App.DashboardController): Renamed from App.IndexController.
283 (App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
284 and "defaultDashboard" as these are taken care of by newly added routers.
285 (App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
286 now done in actions.toggleEditMode.
287 (App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
288 an existing dashboard.
290 (App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
291 Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
292 (App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
293 (App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
295 (App.createChartData): Added deltaFormatter to show less significant digits for differences.
297 (App.PaneController._updateDetails): Updated per changes to computeStatus.
299 * public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
302 (TimeSeries.prototype.lastPoint): Added.
304 * public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
305 on the dashboard, and enumerate all predefined dashboards.
307 * public/v2/interactive-chart.js:
308 (App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
309 for the dashboard page.
311 * public/v2/manifest.js:
312 (App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
313 (App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
314 IDs are generated for each dashboard for forward compatibility.
316 (App.Manifest.dashboardByName): Added.
317 (App.Manifest.defaultDashboardName): Added.
318 (App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
320 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
322 Move commits viewer to the end of details view
323 https://bugs.webkit.org/show_bug.cgi?id=141315
325 Rubber-stamped by Andreas Kling.
327 Show the difference instead of the old value per kling's request.
330 (App.PaneController._updateDetails):
331 * public/v2/index.html:
333 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
335 Move commits viewer to the end of details view
336 https://bugs.webkit.org/show_bug.cgi?id=141315
338 Reviewed by Andreas Kling.
340 Improved the way list of commits are shown per kling's request.
343 (App.PaneController._updateDetails): Always show the old value even when a single point is selected.
345 * public/v2/chart-pane.css: Updated the style for the commits viewer.
347 * public/v2/commits-viewer.js:
348 (App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
349 (App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
351 * public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
352 moved the commits viewers out of the details tables so that they don't interleave revision data.
354 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
356 New perf dashboard should compare results to baseline and target
357 https://bugs.webkit.org/show_bug.cgi?id=141286
359 Reviewed by Chris Dumez.
361 Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
362 Also use d3.format to format the selected value to show four significant figures.
365 (App.Pane.searchCommit):
366 (App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
367 to compute the status text without having to recreate them.
368 (App.createChartData): Added.
369 (App.PaneController._updateDetails): Use 3d.format on current and old values.
370 (App.PaneController._computeStatus): Added. Computes the status text.
371 (App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
372 (App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
373 format the values using chartData.formatter.
375 * public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
376 the baseline and in blue if it's better than the target.
379 (TimeSeries.prototype.findPointAfterTime): Added.
381 * public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
382 the bug that we were not showing the old value's unit.
384 * public/v2/interactive-chart.js:
385 (App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
386 the code to show the baseline and the target lines.
388 * public/v2/manifest.js:
389 (App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
391 2015-02-05 Ryosuke Niwa <rniwa@webkit.org>
393 Unreviewed build fix.
396 (App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
398 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
400 New perf dashboard doesn't preserve the number of days when clicking on a dashboard chart
401 https://bugs.webkit.org/show_bug.cgi?id=141280
403 Reviewed by Chris Dumez.
405 Fixed the bug by passing in "since" as a query parameter to the charts page.
407 Also fixed the styling issue that manifests when a JSON fetching fails on "Dashboard" page.
409 * public/v2/app.css: Fixed CSS rules for error messages shown in the place of charts.
411 (App.IndexController): Changed the default number of days from one month to one week.
412 (App.IndexController._sharedDomainChanged): Set "since" property on the controller.
413 * public/v2/index.html: Pass in "since" property on the controller as a query parameter.
415 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
417 New perf dashboard erroneously clears zoom when poping history items
418 https://bugs.webkit.org/show_bug.cgi?id=141278
420 Reviewed by Chris Dumez.
422 The bug was caused by _sharedZoomChanged updating overviewSelection without updating mainPlotDomain.
424 Updating overviewSelection resulted in _overviewSelectionChanged, which observes changes to overviewSelection,
425 to schedule a call to propagateZoom, which in turn overrode "sharedZoom" we just parsed from the query string.
428 (App.PaneController._overviewSelectionChanged): Don't schedule propagateZoom if the selected domain is already
429 shown in the main plot.
430 (App.PaneController._sharedZoomChanged): Set both overviewSelection and mainPlotDomain to avoid overriding
431 "sharedZoom" via propagateZoom inside _overviewSelectionChanged.
433 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
435 New perf dashboard shows null as the aggregator name if no aggregation is done
436 https://bugs.webkit.org/show_bug.cgi?id=141256
438 Reviewed by Chris Dumez.
440 Don't show the aggregator name if there isn't one.
442 * public/v2/manifest.js:
445 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
447 Unreviewed build fix after r179611.
449 * public/v2/interactive-chart.js:
451 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
453 Perf dashboard doesn’t show the right unit for Safari UI tests
454 https://bugs.webkit.org/show_bug.cgi?id=141238
456 Reviewed by Darin Adler.
458 Safari UI tests use custom metrics that end with "Time". This patch teaches the perf dashboard how to
459 get the unit for a given metric based on the suffix of the metric name instead of hard-coding the mapping
460 between metrics and their units.
462 * public/js/helper-classes.js:
463 (PerfTestRuns): Use the suffix of the metric name to compute the unit.
464 * public/v2/manifest.js:
465 (App.Manifest.fetchRunsWithPlatformAndMetric): Ditto. Also set "useSI" property iff for "bytes".
466 * public/v2/interactive-chart.js:
467 (App.InteractiveChartComponent._constructGraphIfPossible): Respect useSI. Use toPrecision(3) otherwise.
468 (App.InteractiveChartComponent._relayoutDataAndAxes): Place the unit vertically on the left of ticks.
470 2015-02-04 Ryosuke Niwa <rniwa@webkit.org>
472 Interactive chart component provides two duplicate API for highlighting points
473 https://bugs.webkit.org/show_bug.cgi?id=141234
475 Reviewed by Chris Dumez.
477 Prior to this patch, the interactive chart component supported highlightedItems for finding commits
478 on the main charts page and markedPoints to show the two end points in the analysis task page.
480 This patch merges markedPoints into highlightedItems.
483 (App.AnalysisTaskController._fetchedRuns): Use highlightedItems.
484 * public/v2/chart-pane.css:
485 * public/v2/index.html: Ditto.
486 * public/v2/interactive-chart.js:
487 (App.InteractiveChartComponent._constructGraphIfPossible): Make this._highlights an array instead of
488 array of arrays. Also call _highlightedItemsChanged at the end to fix the bug that we never highlight
489 items if highlightedItems was set before the initial layout.
490 (App.InteractiveChartComponent._relayoutDataAndAxes):
491 (App.InteractiveChartComponent._updateHighlightPositions): Now that highlights are circles instead of
492 vertical lines, just set cx and cy as done for other "dots".
493 (App.InteractiveChartComponent._highlightedItemsChanged): Exit early only if _clippedContainer wasn't
494 already set; i.e. _constructGraphIfPossible hasn't been called. Also updated the logic to accommodate
495 the fact this._highlights is an array of elements instead of an array of arrays of elements. Finally,
496 set the radius of highlight circles here.
498 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
500 Don’t use repository names as id’s.
501 https://bugs.webkit.org/show_bug.cgi?id=141226
503 Reviewed by Chris Dumez.
505 Not using repository names as their id's reduces the need to fetch the entire repositories table.
506 Since names of repositories are available in manifest.json, we can resolve their names in the front end.
508 * Websites/perf.webkit.org/public/api/runs.php:
509 (parse_revisions_array): No longer uses $repository_id_to_name.
510 (main): No longer populates $repository_id_to_name.
512 * Websites/perf.webkit.org/public/api/triggerables.php:
513 (main): Don't resolve repository names.
515 * Websites/perf.webkit.org/public/include/manifest.php:
516 (ManifestGenerator::repositories): Use repositories ids as keys in the result and include their names.
517 (ManifestGenerator::bug_trackers): Don't resolve repository names.
519 * Websites/perf.webkit.org/public/js/helper-classes.js:
520 (TestBuild): Renamed repositoryName to repositoryId.
521 (TestBuild.revision): Ditto.
522 (TestBuild.formattedRevisions): Ditto. Continue to use the repository name in the formatted result
523 since this is the text shown to human.
525 * Websites/perf.webkit.org/public/v2/app.js:
526 (App.pane.searchCommit): Renamed repositoryName to repositoryId.
527 (App.PaneController._updateDetails): Ditto.
528 (App.AnalysisTaskController.updateRoots): Ditto.
530 * Websites/perf.webkit.org/public/v2/data.js:
531 (Measurement): Ditto.
532 (Measurement.prototype.commitTimeForRepository): Ditto.
533 (Measurement.prototype.formattedRevisions): Ditto.
535 * Websites/perf.webkit.org/public/v2/index.html: Use the repository name and the repository id as
536 select element's label and value respectively.
538 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
540 Unreviewed build fix. Declare $repository_id_to_name in the global scope.
542 * public/api/runs.php:
544 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
546 /api/runs.php should have main function
547 https://bugs.webkit.org/show_bug.cgi?id=141220
549 Reviewed by Benjamin Poulain.
551 Wrapped the code inside main function for clarity.
553 * public/api/runs.php:
555 2015-01-27 Ryosuke Niwa <rniwa@webkit.org>
557 Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
559 * tools/sync-with-buildbot.py:
560 (find_request_updates):
562 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
564 Perf dashboard always assigns the result of A/B testing with build request 1
565 https://bugs.webkit.org/show_bug.cgi?id=140382
567 Reviewed by Darin Adler.
569 The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
570 which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
572 Also fixed a typo as well as a bug that reports were never associated with builds.
574 * public/include/report-processor.php:
575 (ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
576 instead of the first non-null value.
577 (ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
578 (ReportProcessor::commit): Associate the report with the corresponding build as intended.
580 2015-01-23 Ryosuke Niwa <rniwa@webkit.org>
582 Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
584 * public/admin/tests.php:
586 2015-01-10 Ryosuke Niwa <rniwa@webkit.org>
588 Unreviewed build fix. Removed the stale code.
590 * public/admin/triggerables.php:
592 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
594 Perf dashboard should have the ability to post A/B testing builds
595 https://bugs.webkit.org/show_bug.cgi?id=140317
597 Rubber-stamped by Simon Fraser.
599 This patch adds the support for triggering A/B testing from the perf dashboard.
601 We add a few new tables to the database. "build_triggerables", which represents a set of builders
602 that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
603 of repositories for which an arbitrary revision can be specified for A/B testing.
604 "triggerable_configurations" specifies a triggerable available on a given test on a given platform.
605 "roots" table which specifies the revision used in a given root set in each repository.
607 * init-database.sql: Added "build_triggerables", "triggerable_repositories",
608 "triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
609 "platforms", and "tests" tables as well as columns to store status, status url, and creation time
610 to build_requests table. Also made each test group's name unique in a given analysis task as it
611 would be confusing to have multiple test groups of the same name.
613 * public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
615 * public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories
616 for which a specific revision can be set in an A/B testing on a given triggerable.
618 * public/api/build-requests.php: Added. Returns the list of open build requests on a specified
619 triggerable. Also updates the status' and the status urls of specified build requests when
620 buildRequestUpdates is provided in the raw POST data.
623 * public/api/runs.php:
624 (fetch_runs_for_config): Don't include results associated with a build request, meaning they are
625 results of an A/B testing.
627 * public/api/test-groups.php:
628 (main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.
630 * public/api/triggerables.php: Added.
631 (main): Returns a list of triggerables or a triggerable associated with a given analysis task.
633 * public/include/admin-header.php:
635 * public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.
636 (BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
637 and root sets used in those requests.D
638 (BuildRequestsFetcher::__construct):
639 (BuildRequestsFetcher::fetch_for_task):
640 (BuildRequestsFetcher::fetch_for_group):
641 (BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
642 (BuildRequestsFetcher::has_results):
643 (BuildRequestsFetcher::results):
644 (BuildRequestsFetcher::results_with_resolved_ids):
645 (BuildRequestsFetcher::results_internal):
646 (BuildRequestsFetcher::root_sets):
647 (BuildRequestsFetcher::fetch_roots_for_set):
649 * public/include/db.php:
650 (Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
651 (Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
652 table since it only has the primary key, id, column.
653 (Database::select_or_insert_row):
654 (Database::update_or_insert_row):
655 (Database::update_row): Added.
656 (Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
657 should be inserted when no row matches the specified criteria. This is used while updating
658 build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
659 new build requests in that API.
660 (Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
661 This is used in public/api/triggerables.php when no analysis task is specified.
663 * public/include/json-header.php:
664 (find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
665 triggerable associated with the closest ancestor of the test. Since issuing a new query for each
666 ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
667 find the closest ancestor with a triggerable.
669 * public/include/report-processor.php:
670 (ReportProcessor::process):
671 (ReportProcessor::resolve_build_id): Associate a build request with the newly created build
672 if jobId or buildRequest is specified.
674 * public/include/test-name-resolver.php:
675 (TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
676 test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
677 (TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
680 * public/include/test-path-resolver.php: Added.
681 (TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
682 "tests" table to do this since there could be arbitrary number of ancestors for a given test.
683 This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
684 in order to compute full test metric names.
685 (TestPathResolver::__construct):
686 (TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
687 the highest (a test without a parent).
688 (TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
689 the highest ancestor to the test itself.
690 (TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.
692 * public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.
694 (commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
695 for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
696 set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
697 result in [[WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4]].
699 * public/v2/analysis.js:
700 (App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
701 (App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
702 (App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
703 (App.TestGroup.create): Added. Creates a new A/B testing group.
704 (App.Triggerable): Added.
705 (App.TriggerableAdapter): Added.
706 (App.TriggerableAdapter.buildURL): Added.
707 (App.BuildRequest.testGroup): Renamed from group.
708 (App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
709 (App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
710 in this build request.
711 (App.BuildRequest.status): Added.
712 (App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
713 (App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.
716 (App.AnalysisTaskController.testGroups): Added.
717 (App.AnalysisTaskController.possibleRepetitionCounts): Added.
718 (App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
719 but an observer that updates "roots" property. Filter out the repositories that are not accepted
720 by the associated triggerable as they will be ignored.
721 (App.AnalysisTaskController.actions.createTestGroup): Added.
723 * public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
725 * tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back
726 the status of those builds to the perf dashboard. A similar script can be written to support
727 other continuous builds systems.
728 (main): Fetches the list of pending builds as well as currently running or completed builds from
729 a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
730 a single new build on each builder with no pending builds, and marks the set of open build requests
731 that have been scheduled to run on the buildbot but not found in the first step as stale.
732 (load_config): Loads a JSON that contains the configurations for each builder. e.g.
735 "platform": "mac-mavericks",
736 "test": ["Parser", "html5-full-render.html"],
737 "builder": "Trunk Syrah Production Perf AB Tests",
739 "forcescheduler": "force-mac-mavericks-release-perf",
740 "webkit_revision": "$WebKit",
741 "jobid": "$buildRequest"
746 (find_request_updates): Return a list of build request status updates to make based on the pending
747 builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
748 completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
749 if the build request had not been completed. This is necessary because a failed build will not
750 report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
751 (update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
752 of open requests the perf dashboard has.
753 (find_stale_request_updates): Compute the list of build requests that have been scheduled on the
754 buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
755 or human canceling a build may trigger such a state.
756 (schedule_request): Schedules a build with the arguments specified in the configuration JSON after
757 replacing repository names with their revisions and buildRequest with the build request id.
758 (config_for_request): Finds a builder for the test and the platform of a build request.
759 (fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
760 (property_value_from_build): Returns the value of a specific property in a buildbot build.
761 (request_id_from_build): Returns the build request id of a given buildbot build if there is one.
763 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
765 Cache-control should be set only on api/runs
766 https://bugs.webkit.org/show_bug.cgi?id=140312
768 Reviewed by Andreas Kling.
770 Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
771 since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
772 just set cache-control there instead of json-header.php which is used by other JSON APIs.
774 Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.
776 * public/api/analysis-tasks.php:
777 * public/api/runs.php: Set the cache control headers.
778 * public/api/test-groups.php:
779 * public/include/db.php: Set the default timezone to UTC.
780 * public/include/json-header.php: Don't set the cache control headers.
782 2015-01-09 Ryosuke Niwa <rniwa@webkit.org>
784 api/report-commit should authenticate with a slave name and password
785 https://bugs.webkit.org/show_bug.cgi?id=140308
787 Reviewed by Benjamin Poulain.
789 Use a slave name and a password to authenticate new commit reports.
791 * public/api/report-commits.php:
793 * public/include/json-header.php:
794 (verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
795 a slave name and a password instead of a builder name and a password.
796 * tests/api-report-commits.js: Updated tests.
798 (main): Renamed variables.
799 (submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.
801 2014-12-19 Ryosuke Niwa <rniwa@webkit.org>
803 Perf dashboard should support authentication via a slave password
804 https://bugs.webkit.org/show_bug.cgi?id=139837
806 Reviewed by Andreas Kling.
808 For historical reasons, perf dashboard conflated builders and build slaves. As a result we ended up
809 having to add multiple builders with the same password when a single build slave is shared among them.
811 This patch introduces the concept of build_slave into the perf dashboard to end this madness.
813 * init-database.sql: Added build_slave table as well as references to it in builds and reports.
815 * public/admin/build-slaves.php: Added.
817 * public/admin/builders.php: Added the support for updating passwords.
819 * public/include/admin-header.php:
820 (update_field): Takes an extra argument when a new value needs to be supplied by the caller instead of
821 being retrieved from $_POST.
822 (AdministrativePage::render_table): Use array_get to retrieve a value out of the database row since
823 the raw may not exist (e.g. new_password).
824 (AdministrativePage::render_form_to_add): Added the support for post_insertion. Don't render the form
825 control here when this flag evaluates to TRUE.
827 * public/include/report-processor.php:
828 (ReportProcessor::process): Added the logic to authenticate with slaveName and slavePassword if those
829 values are present in the report. In addition, try authenticating builderName with slavePassword if
830 builderPassword is not specified. When neither password is specified, exit with BuilderNotFound.
831 Also insert the slave or the builder whichever is missing after we've successfully authenticated.
832 (ReportProcessor::construct_build_data): Takes a builder ID and an optional slave ID instead of
834 (ReportProcessor::store_report): Store the slave ID with the report.
835 (ReportProcessor::resolve_build_id): Exit with MismatchingBuildSlave when the slave associated with
836 the matching build is different from what's being reported.
838 * tests/api-report.js: Added a bunch of tests to test the new features of /api/report.
841 2014-12-18 Ryosuke Niwa <rniwa@webkit.org>
843 New perf dashboard should not duplicate author information in each commit
844 https://bugs.webkit.org/show_bug.cgi?id=139756
846 Reviewed by Darin Adler.
848 Instead of each commit having author name and email, make it reference a newly added committers table.
849 Also replace "email" by "account" since some repositories don't use emails as account names.
851 This improves the keyword search performance in commits.php since LIKE now runs on committers table,
852 which only contains as many rows as there are accounts in each repository, instead of commits table
853 which contains every commit ever happened in each repository.
855 To migrate an existing database into match the new schema, run:
859 INSERT INTO committers (committer_repository, committer_name, committer_email)
860 (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
861 FROM commits WHERE commit_author_email IS NOT NULL);
863 ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;
865 UPDATE commits SET commit_committer = committer_id FROM committers
866 WHERE commit_repository = committer_repository AND commit_author_email = committer_email;
868 ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
869 ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;
873 * init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
874 reference to committers. Also added the missing drop table statements.
876 * public/api/commits.php:
877 (main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
878 an array here instead of doing it in format_commit.
879 (fetch_commits_between): Updated queries to JOIN commits with committers.
880 (format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
883 * public/api/report-commits.php:
884 (main): Store the reported committer information or update the existing entry if there is one.
886 * tests/admin-regenerate-manifest.js: Fixed tests.
888 * tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.
890 * tools/pull-svn.py: Renamed email to account.
892 (fetch_commit_and_resolve_author):
894 (resolve_author_name_from_account):
895 (resolve_author_name_from_email): Deleted.
897 2014-12-17 Ryosuke Niwa <rniwa@webkit.org>
899 Unreviewed build fix.
901 * public/v2/index.html: Include js files we extracted in r177424.
903 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
905 Unreviewed. Adding the forgotten svnprop.
907 * tools/pull-svn.py: Added property svn:executable.
909 2014-12-16 Ryosuke Niwa <rniwa@webkit.org>
911 Split InteractiveChartComponent and CommitsViewerComponent into separate files
912 https://bugs.webkit.org/show_bug.cgi?id=139716
914 Rubber-stamped by Benjamin Poulain.
916 Refactored InteractiveChartComponent and CommitsViewerComponent out of app.js into commits-viewer.js
917 and interactive-chart.js respectively since app.js has gotten really large.
920 * public/v2/commits-viewer.js: Added.
921 * public/v2/interactive-chart.js: Added.
923 2014-12-02 Ryosuke Niwa <rniwa@webkit.org>
925 New perf dashboard's chart UI is buggy
926 https://bugs.webkit.org/show_bug.cgi?id=139214
928 Reviewed by Chris Dumez.
930 The bugginess was caused by weird interactions between charts and panes. Rewrote the code to fix it.
932 Superfluous selectionChanged and domainChanged "event" actions were removed from the interactive chart
933 component. This is not how Ember.js components should interact to begin with. The component now exposes
934 selectedPoints and always updates selection instead of sharedSelection.
937 (App.ChartsController.present): Added. We can't call Date.now() in various points in our code as that
938 would lead to infinite mutual recursions since X-axis domain values wouldn't match up.
939 (App.ChartsController.updateSharedDomain): This function was completely useless. The overview's start
940 and end time should be completely determined by "since" and the present time.
941 (App.ChartsController._startTimeChanged): Ditto.
942 (App.ChartsController._scheduleQueryStringUpdate):
943 (App.ChartsController._updateQueryString): Set "zoom" only if it's different from the shared domain.
945 (App.domainsAreEqual): Moved from InteractiveChartComponent._xDomainsAreSame.
947 (App.PaneController.actions.createAnalysisTask): Use selectedPoints property set by the chart.
948 (App.PaneController.actions.overviewDomainChanged): Removed; only needed to call updateSharedDomain.
949 (App.PaneController.actions.rangeChanged): Removed. _showDetails (renamed to _updateDetails) directly
950 observes the changes to selectedPoints property as it gets updated by the main chart.
951 (App.PaneController._overviewSelectionChanged): This was previously a dead code. Now it's used again
952 with a bug fix. When the overview selection is cleared, we use the same domain in the main chart and
954 (App.PaneController._sharedDomainChanged): Fixed a but that it erroneously updates the overview domain
955 when domain arrays aren't identical. This was causing a subtle race with other logic.
956 (App.PaneController._sharedZoomChanged): Ditto. Also don't set mainPlotDomain here as any changes to
957 overviewSelection will automatically propagate to the main plot's domain as they're aliased.
958 (App.PaneController._currentItemChanged): Merged into _updateDetails (renamed from _showDetails).
959 (App.PaneController._updateDetails): Previously, this function took points and inspected _hasRange to
960 see if those two points correspond to a range or a single data point. Rewrote all that logic by
961 directly observing selectedPoints and currentItem properties instead of taking points and relying on
962 an instance variable, which was a terrible API.
963 (App.PaneController._updateCanAnalyze): Use selectedPoints property. Since this property is only set
964 when the main plot has a selected range, we don't have to check this._hasRange anymore.
966 (App.InteractiveChartComponent._updateDomain): No longer sends domainChanged "event" action.
967 (App.InteractiveChartComponent._sharedSelectionChanged): Removed. This is a dead code.
968 (App.InteractiveChartComponent._updateSelection):
969 (App.InteractiveChartComponent._xDomainsAreSame): Moved to App.domainsAreEqual.
970 (App.InteractiveChartComponent._setCurrentSelection): Update the selection only if needed. Also set
971 selectedPoints property.
973 (App.AnalysisTaskController._fetchedRuns):
974 (App.AnalysisTaskController._rootChangedForTestSet):
976 * public/v2/index.html:
977 Removed non-functional sharedSelection and superfluous selectionChanged and domainChanged actions.
979 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
981 Unreviewed. Fixed syntax errors.
984 * public/api/commits.php:
986 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
988 The dashboard on new perf monitor should be configurable
989 https://bugs.webkit.org/show_bug.cgi?id=138994
991 Reviewed by Benjamin Poulain.
993 For now, make it configurable via config.json. We should eventually make it configurable via
994 an administrative page but this will do for now.
996 * config.json: Added the empty dashboard configuration.
998 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
1001 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
1002 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
1003 Also obtain the default configuration from App.Manifest.
1004 (App.IndexController._normalizeTable): Moved to App.Dashboard.
1006 * public/v2/manifest.js:
1007 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
1008 (App.Repository.urlForRevisionRange): Ditto.
1009 (App.Dashboard): Added.
1010 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
1011 (App.Dashboard.rows): Ditto.
1012 (App.Dashboard.headerColumns): Ditto.
1013 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
1014 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
1015 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
1016 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
1018 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
1020 There should be a way to associate bugs with analysis tasks
1021 https://bugs.webkit.org/show_bug.cgi?id=138977
1023 Reviewed by Benjamin Poulain.
1025 Updated associate-bug.php to match the new database schema.
1027 * public/include/json-header.php:
1028 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
1029 already camel-cased in require_existence_of. This makes the function usable elsewhere.
1031 * public/privileged-api/associate-bug.php:
1032 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
1033 Also verify that those values are integers using require_format.
1035 * public/v2/analysis.js:
1036 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
1037 (App.Bug.label): Added.
1038 (App.BugAdapter): Added.
1039 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
1040 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
1042 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
1043 containing the bug information.
1046 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
1047 (App.AnalysisTaskRoute):
1048 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
1049 (App.AnalysisTaskController._fetchedManifest): Added.
1050 (App.AnalysisTaskController.actions.associateBug): Added.
1052 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
1054 * public/v2/data.js:
1055 (Measurement.prototype.associateBug): Deleted.
1057 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
1058 Added a table show the bug information. Also hide the chart until chartData is available.
1060 * public/v2/manifest.js:
1063 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1065 Fix misc bugs and typos in app.js
1066 https://bugs.webkit.org/show_bug.cgi?id=138946
1068 Reviewed by Benjamin Poulain.
1071 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
1072 (App.ChartsController.init):
1073 (App.buildPopup): Renamed from App.BuildPopup.
1074 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
1075 remove() on the wrong object (an array as opposed to elements in the array).
1076 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
1077 _highlights is always an array and evalutes to true.
1079 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
1081 New perf dashboard should provide UI to create a new analysis task
1082 https://bugs.webkit.org/show_bug.cgi?id=138910
1084 Reviewed by Benjamin Poulain.
1086 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
1087 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
1089 With this patch, we can create a new analysis task by selection a range of points and opening
1090 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
1091 in the chart hyperlinked to the analysis task.
1093 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
1095 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
1096 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
1098 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
1099 and adds the associated bugs to each task in the array.
1102 * public/api/runs.php: Reverted changes made in r175006.
1103 (fetch_runs_for_config):
1106 * public/api/test-groups.php:
1107 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
1109 * public/include/db.php:
1110 (Database::select_first_or_last_row):
1111 (Database::select_rows): Extracted from select_first_or_last_row.
1113 * public/v2/analysis.js:
1114 (App.AnalysisTask): Added "bugs" property.
1115 (App.Bug): Added now that bugs are regular data store objects.
1118 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
1119 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
1120 platform that are associated with a specific range of runs.
1121 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
1122 (App.PaneController.actions.associateBug): Deleted.
1123 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
1124 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
1125 once we've created one.
1126 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
1127 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
1128 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
1129 (App.PaneController._updateBugs): Deleted.
1130 (App.PaneController._updateMarkedPoints): Deleted.
1131 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
1132 the name is missing or when at most one point is selected.
1134 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
1135 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
1136 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
1137 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
1138 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
1139 clickable bars for analysis tasks.
1140 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
1141 bar for analysis tasks to place them at the right location.
1142 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
1144 * public/v2/chart-pane.css:
1145 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
1146 (.chart .rangeBar): Added.
1148 * public/v2/data.js:
1149 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
1151 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
1152 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
1153 task bars in the interactive chart component.
1155 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
1157 Fix typos in r176203.
1160 (App.ChartsController.actions.addPaneByMetricAndPlatform):
1161 (App.AnalysisTaskRoute):
1163 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
1165 Unreviewed. Updated the install instruction.
1169 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
1171 App.Manifest shouldn't use App.__container__.lookup
1172 https://bugs.webkit.org/show_bug.cgi?id=138768
1174 Reviewed by Andreas Kling.
1176 Removed the hack to find the store object via App.__container__.lookup.
1177 Pass around the store object instead.
1180 (App.DashboardRow._createPane): Add "store" property to the pane.
1181 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
1182 (App.IndexController.gridChanged): Ditto.
1183 (App.IndexController.actions.addRow): Ditto.
1184 (App.IndexController.init): Ditto.
1185 (App.Pane._fetch): Ditto.
1186 (App.ChartsController._parsePaneList): Ditto.
1187 (App.ChartsController._updateQueryString): Ditto.
1188 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
1189 (App.BuildPopup): Ditto.
1190 (App.AnalysisTaskRoute.model): Ditto.
1191 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
1193 * public/v2/manifest.js:
1194 (App.Manifest.fetch): Removed the code to find the store object.
1196 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
1198 Fix Ember.js warnings the new perf dashboard
1199 https://bugs.webkit.org/show_bug.cgi?id=138531
1201 Reviewed by Darin Adler.
1203 Fixed various warnings.
1206 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
1207 * public/v2/data.js:
1208 (PrivilegedAPI._post): Removed the superfluous console.log.
1209 (CommitLogs.fetchForTimeRange): Ditto.
1210 * public/v2/index.html: Added tbody as required by the HTML specification.
1212 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1214 Fix typos in r175768.
1217 (App.AnalysisTaskViewModel.roots):
1219 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
1221 Introduce the concept of analysis task to perf dashboard
1222 https://bugs.webkit.org/show_bug.cgi?id=138517
1224 Reviewed by Andreas Kling.
1226 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
1227 a single platform and used to bisect regressions in the range.
1229 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
1231 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
1232 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
1233 test runs. Analysis tasks not associated with test runs are used for try new patches.
1234 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
1235 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
1236 build_requests - A build request represents a single pending build for A/B testing.
1238 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
1242 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
1243 the specified analysis task group as well as build requests associated with them.
1245 (fetch_test_groups_for_task):
1246 (fetch_build_requests_for_task):
1247 (fetch_build_requests_for_group):
1248 (format_test_group):
1249 (format_build_request):
1251 * public/include/json-header.php:
1252 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
1255 * public/privileged-api/associate-bug.php:
1256 (main): Fixed a typo.
1258 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
1261 (ensure_config_from_runs):
1263 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
1265 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
1267 (App.AnalysisTask.create):
1269 (App.TestGroupAdapter):
1270 (App.AnalysisTaskSerializer):
1271 (App.TestGroupSerializer):
1274 * public/v2/app.css: Added style rules for the analysis page.
1277 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
1279 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
1280 exactly one selected point as we can still create an analysis task.
1281 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
1282 grammatical and also alert'ed the error message when there is one.
1283 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
1284 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
1285 once XHR request has completed.
1286 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
1287 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
1288 is selected in the details pane.
1290 (App.AnalysisRoute): Added.
1291 (App.AnalysisTaskRoute): Added.
1292 (App.AnalysisTaskViewModel): Added.
1293 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
1294 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
1295 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
1296 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
1297 the user selects an option for all roots in A or B configuration.
1298 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
1300 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
1302 * public/v2/data.js:
1303 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
1304 point so that we can use it in App.AnalysisTaskViewModel.roots.
1305 (TimeSeries.prototype.findPointByMeasurementId): Added.
1306 (TimeSeries.prototype.seriesBetweenPoints): Added.
1308 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
1309 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
1310 when multiple points are selected. Finally, added a new template for the analysis task page.
1312 * public/v2/manifest.js:
1313 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
1314 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
1315 App.AnalysisTaskViewModel._taskUpdated.
1317 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
1319 Remove App.PaneController.bugsChangeCount in the new perf dashboard
1320 https://bugs.webkit.org/show_bug.cgi?id=138111
1322 Reviewed by Darin Adler.
1325 (App.PaneController.bugsChangeCount): Removed.
1326 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
1327 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
1328 Finds the list of current run's points that are associated with bugs.
1329 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
1330 * public/v2/chart-pane.css:
1331 (.chart .marked): Renamed from .hasBugs.
1332 * public/v2/index.html: Specify chartPointRadius and markedPoints.
1334 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
1336 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
1337 https://bugs.webkit.org/show_bug.cgi?id=138099
1339 Reviewed by Benjamin Poulain.
1341 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
1342 _showDetails inverting the order of the current and old measurements.
1345 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
1346 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
1347 current (latest) measurement and the first point is the oldest measurement.
1348 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
1350 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
1352 Perf dashboard should provide a way to associate bugs with a test run
1353 https://bugs.webkit.org/show_bug.cgi?id=137857
1355 Reviewed by Andreas Kling.
1357 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
1358 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
1359 the Apache configuration.
1362 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
1363 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
1364 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
1365 via the cookie and returns a token computed from those two values as well as the remote username.
1367 The font end code then POST's the request along with the returned token. The server side code verifies
1368 that the specified token can be generated from the salt and the expiration time set in the cookie, and
1369 the token hasn't expired.
1372 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
1373 have zero or exactly one bug associated with a test run.
1375 * public/admin/bug-trackers.php: Added the support for editing bug_url.
1376 * public/api/runs.php:
1377 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
1378 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
1379 an associated bug if there is one.
1380 (format_run): Calls parse_bugs_array.
1382 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
1383 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
1384 have a valid JSON payload.
1385 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
1386 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
1387 the expiration time stored in the cookie.
1388 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
1390 * public/include/manifest.php:
1391 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
1392 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
1394 * public/index.html:
1395 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
1397 * public/privileged-api/associate-bug.php: Added.
1398 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
1399 attack via ensure_privileged_api_data_and_token, which calls verify_token.
1401 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
1403 * public/v2/app.css:
1404 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
1405 selected in a chart.
1408 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
1409 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
1410 they would overlap on each other if both of them are shown.
1411 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
1412 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
1413 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
1414 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
1415 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
1416 showing the search pane.
1417 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
1418 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
1419 bugs in the selected range.
1421 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
1422 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
1423 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
1424 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
1425 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
1426 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
1427 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
1428 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
1430 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
1431 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
1432 to selectionChanged action instead of just finding the first and the last points.
1434 * public/v2/chart-pane.css: Updated the style.
1436 * public/v2/data.js:
1437 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
1438 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
1439 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
1440 we haven't already obtained a CSRF token or if the token has already been expired.
1441 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
1443 (Measurement.prototype.bugs): Added.
1444 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
1445 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
1447 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
1450 * public/v2/manifest.js:
1451 (App.BugTracker.bugUrl):
1452 (App.BugTracker.newBugUrl): Added.
1453 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
1454 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
1455 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
1456 (App.Manifest.bugTrackers): Added.
1457 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
1458 their respective ids to make the ordering stable.
1460 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
1462 Remove unused jobs table
1463 https://bugs.webkit.org/show_bug.cgi?id=137724
1465 Reviewed by Daniel Bates.
1467 Removed jobs table in the database as well as related code.
1469 * init-database.sql:
1470 * public/admin/jobs.php: Removed.
1471 * public/admin/tests.php:
1472 * public/include/admin-header.php:
1474 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1476 New perf dashboard should have an ability to search commits by a keyword
1477 https://bugs.webkit.org/show_bug.cgi?id=137675
1479 Reviewed by Geoffrey Garen.
1481 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
1482 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
1483 This API change allows fetch_commits_between to generate results without processing Postgres query results.
1485 In the front end side, we've added a search pane in pane controller, and the interactive chart component
1486 now has a concept of highlighted items which is used to indicate commits found by the search pane.
1488 * public/api/commits.php:
1489 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
1490 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
1491 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
1492 (format_commit): Renamed from format_commits. Now only formats one commit.
1494 * public/include/db.php:
1495 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
1497 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
1500 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
1501 which is a hash table that contains highlighted items' measurements' ids as keys.
1502 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
1503 the default commit repository.
1504 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
1505 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
1506 Added the code to initialize this._highlights.
1507 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
1508 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
1509 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
1510 the existing lines for the old highlighted items.
1511 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
1512 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
1514 * public/v2/chart-pane.css: Added style for the search pane and the search button.
1516 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
1517 (CommitLogs): Added.
1518 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
1519 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
1520 (CommitLogs._cacheConsecutiveCommits): Ditto.
1521 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
1522 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
1523 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
1525 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
1526 for showingDetails since this property is no longer used.
1528 * public/v2/manifest.js:
1529 (App.Manifest.repositories): Added.
1530 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
1531 the default repository to search.
1532 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
1534 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
1536 Unreviewed build fix after r174555.
1538 * public/include/manifest.php:
1539 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
1540 * tests/admin-regenerate-manifest.js: Fixed the test case.
1542 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
1544 New perf dashboard UI tries to fetch commits all the time
1545 https://bugs.webkit.org/show_bug.cgi?id=137592
1547 Reviewed by Andreas Kling.
1549 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
1550 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
1551 no reported commits as they are all going to fail.
1553 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
1554 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
1555 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
1556 of commits sorted chronologically by time.
1558 * public/include/manifest.php:
1561 (App.CommitsViewerComponent.commitsChanged):
1563 * public/v2/data.js:
1564 (FetchCommitsForTimeRange):
1565 (FetchCommitsForTimeRange._cachedCommitsByRepository):
1567 * public/v2/manifest.js:
1570 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1572 Another unreviewed build fix after r174477.
1574 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
1576 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
1578 * public/include/report-processor.php:
1580 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1582 Unreviewed build fix after r174477.
1584 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
1585 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
1587 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
1588 This is necessary for baseline and target values manually added via admin pages.
1590 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1592 Add v2 UI for the perf dashboard
1593 https://bugs.webkit.org/show_bug.cgi?id=137537
1595 Rubber-stamped by Andreas Kling.
1598 * public/v2/app.css: Added.
1599 * public/v2/app.js: Added.
1600 * public/v2/chart-pane.css: Added.
1601 * public/v2/data.js: Added.
1602 * public/v2/index.html: Added.
1603 * public/v2/js: Added.
1604 * public/v2/js/d3: Added.
1605 * public/v2/js/d3/LICENSE: Added.
1606 * public/v2/js/d3/d3.js: Added.
1607 * public/v2/js/d3/d3.min.js: Added.
1608 * public/v2/js/ember-data.js: Added.
1609 * public/v2/js/ember.js: Added.
1610 * public/v2/js/handlebars.js: Added.
1611 * public/v2/js/jquery.min.js: Added.
1612 * public/v2/js/statistics.js: Added.
1613 * public/v2/manifest.js: Added.
1614 * public/v2/popup.js: Added.
1616 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1618 Remove superfluously duplicated code in public/api/report-commits.php.
1620 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
1622 Perf dashboard should store commit logs
1623 https://bugs.webkit.org/show_bug.cgi?id=137510
1625 Reviewed by Darin Adler.
1627 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
1629 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
1630 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
1631 a subversion directory. The git version of this script will be added in a follow up patch.
1634 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
1635 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
1636 relationship via "build_commits" relations.
1638 In order to migrate an existing instance of this application, run the following SQL commands:
1642 INSERT INTO commits (commit_repository, commit_revision, commit_time)
1643 (SELECT DISTINCT ON (revision_repository, revision_value)
1644 revision_repository, revision_value, revision_time FROM build_revisions);
1646 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
1647 FROM commits, build_revisions
1648 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
1650 DROP TABLE build_revisions;
1655 The helper script to submit commit logs can be used as follows:
1657 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
1658 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
1660 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
1661 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
1662 "feeder-slave-password" as the builder name and the builder password respectively.
1664 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
1665 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
1668 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
1670 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
1671 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
1673 - Not specified - It returns every single commit for a given repository.
1674 - Matches "oldest" - It returns the commit with the oldest timestamp.
1675 - Matches "latest" - It returns the commit with the latest timestamp.
1676 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
1677 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
1678 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
1679 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
1680 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
1681 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
1683 (commit_from_revision):
1684 (fetch_commits_between):
1687 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
1688 See tests/api-report-commits.js for examples on how to use this API.
1690 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
1691 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
1692 to optimize this and other JSON APIs.
1694 * public/include/db.php:
1695 (Database::select_or_insert_row):
1696 (Database::update_or_insert_row): Added.
1697 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
1698 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
1700 (Database::select_first_row):
1701 (Database::select_last_row): Added.
1702 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
1703 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
1705 * public/include/report-processor.php:
1706 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
1707 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
1708 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
1711 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
1713 * tests/api-report-commits.js: Added.
1714 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
1717 * tools/pull-svn.py: Added. See above for how to use this script.
1719 (determine_first_revision_to_fetch):
1720 (fetch_revision_from_dasbhoard):
1721 (fetch_commit_and_resolve_author):
1724 (resolve_author_name_from_email):
1727 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
1729 Update Install.md for Mavericks and fix typos
1730 https://bugs.webkit.org/show_bug.cgi?id=137276
1732 Reviewed by Benjamin Poulain.
1734 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
1736 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
1738 Finally, init-database.sql is no longer located inside database directory.
1742 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1744 Report run id's in api/runs.php for the new dashboard UI
1745 https://bugs.webkit.org/show_bug.cgi?id=135813
1747 Reviewed by Andreas Kling.
1749 Include run_id in the generated JSON.
1751 * public/api/runs.php:
1752 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
1755 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
1757 Merging platforms mixes baselines and targets into reported data
1758 https://bugs.webkit.org/show_bug.cgi?id=135260
1760 Reviewed by Andreas Kling.
1762 When merging two platforms, move test configurations of a different type (baseline, target)
1763 as well as of different metric (Time, Runs).
1765 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
1766 It's sufficient to detect one such test_runs object.
1768 * public/admin/platforms.php:
1771 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
1773 Merging platforms mixes baselines and targets into reported data
1774 https://bugs.webkit.org/show_bug.cgi?id=135260
1776 Reviewed by Geoffrey Garen.
1778 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
1779 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
1781 * public/admin/platforms.php:
1783 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
1785 Build fix after r171361.
1787 * public/js/helper-classes.js:
1788 (.this.formattedBuildTime):
1790 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
1792 Perf dashboard spends 2s processing JSON data during the page loads
1793 https://bugs.webkit.org/show_bug.cgi?id=135152
1795 Reviewed by Andreas Kling.
1797 In the Apple internal dashboard, we were spending as much as 2 seconds
1798 converting raw JSON data into proper JS objects while loading the dashboard.
1800 This caused the apparent unresponsiveness of the dashboard despite of the fact
1801 charts themselves updated almost instantaneously.
1803 * public/index.html:
1804 * public/js/helper-classes.js:
1805 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
1806 lazily as creating new Date objects and running string replace is expensive.
1807 (TestBuild.formattedTime):
1808 (TestBuild.formattedBuildTime):
1809 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
1810 (PerfTestRuns.addResult): Deleted.
1812 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
1814 Perf dashboard shouldn't show the full git hash
1815 https://bugs.webkit.org/show_bug.cgi?id=135083
1817 Reviewed by Benjamin Poulain.
1819 Detect Git/Mercurial hash by checking the length.
1821 If it's a hash, use the first 8 characters in the label
1822 while retaining the full length to be used in hyperlinks.
1824 * public/js/helper-classes.js:
1825 (.this.formattedRevisions):
1828 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
1830 Add an instruction on how to backup the database.
1831 https://bugs.webkit.org/show_bug.cgi?id=133391
1833 Rubber-stamped by Andreas Kling.
1837 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1839 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
1841 * public/js/helper-classes.js:
1842 (PerfTestRuns.smallerIsBetter):
1844 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
1848 * public/common.css:
1850 * public/index.html:
1854 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1856 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
1857 https://bugs.webkit.org/show_bug.cgi?id=131157
1859 Reviewed by Andreas Kling.
1861 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
1862 This allows, for example, adding all metrics such as Arithmetic and Geometric for
1863 a given test suite without also adding its subtests.
1865 * public/index.html:
1869 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1871 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
1872 https://bugs.webkit.org/show_bug.cgi?id=131155
1874 Reviewed by Andreas Kling.
1876 The bug was caused by Chart.attach binding event listeners on plot container on each call.
1877 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
1878 click when attach() has been called even number of times, keeping the tooltip invisible.
1880 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
1881 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
1882 is called for the first time.
1884 * public/index.html:
1886 (Chart..bindPlotEventHandlers):
1888 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1890 WebKitPerfMonitor: Tooltips can be cut off at the top
1891 https://bugs.webkit.org/show_bug.cgi?id=130960
1893 Reviewed by Andreas Kling.
1895 * public/common.css:
1896 (#title): Removed the gradients, box shadows, and border from the header.
1897 (#title h1): Reduce the font size.
1898 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
1899 * public/index.html:
1900 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
1901 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
1902 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
1903 * public/js/helper-classes.js:
1904 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
1905 tooltip extending above y=0.
1907 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
1909 WebKitPerfMonitor: Y-axis adjustment is too aggressive
1910 https://bugs.webkit.org/show_bug.cgi?id=130937
1912 Reviewed by Andreas Kling.
1914 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
1915 results. This had two major problems:
1916 1. Two standard deviations can be too small to show the confidence interval for results.
1917 2. Sometimes baseline and target can be more than two standards deviations away.
1919 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
1920 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
1921 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
1922 the margin on each side separately to reduce the empty space on either side.
1924 A more rigorous approach would involve computing least squared value of results with respect to intervals
1925 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
1927 * public/index.html:
1928 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
1929 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
1930 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
1931 We wouldn't see the difference between measured values versus baseline and target values otherwise.
1932 * public/js/helper-classes.js:
1933 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
1934 interval delta cannot be computed.
1935 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
1936 within the given interval.
1937 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
1938 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
1939 (PerfTestRuns..unscaledMeansForAllResults):
1940 (PerfTestRuns.min): Take the confidence interval delta into account.
1941 (PerfTestRuns.max): Ditto.
1942 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
1943 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
1945 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
1947 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
1949 Some CSS tweaks after r166477 and r166479,
1951 * public/index.html:
1953 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1955 WebKitPerfMonitor: Sometimes text inside panes overlap
1956 https://bugs.webkit.org/show_bug.cgi?id=130956
1958 Reviewed by Gyuyoung Kim.
1960 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
1961 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
1962 reduces the total height of the pane and fits more information per screen capita on the dashboard.
1964 * public/index.html: Updated and added a bunch of CSS rules for the new look.
1965 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
1966 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
1967 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
1968 of the build info shown in a chart pane and a tooltip.
1969 (Chart): Made .status a table.
1970 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
1971 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
1972 now that status.text no longer contains it.
1973 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
1975 * public/js/helper-classes.js:
1976 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
1977 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
1978 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
1979 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
1980 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
1981 capital letter; e.g. "MB" instead of "M B".
1983 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1985 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1986 https://bugs.webkit.org/show_bug.cgi?id=130957
1988 Reviewed by Gyuyoung Kim.
1990 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1991 This reclaims 50px × width of the screen real estate.
1993 * public/common.css:
1994 (#title): Reduced the space below the header from 20px to 10px.
1995 * public/index.html:
1996 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1997 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1998 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1999 real estate between the header and the platform names.
2001 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
2003 Update the install guidelines for perf.webkit.org
2004 https://bugs.webkit.org/show_bug.cgi?id=129895
2006 Reviewed by Ryosuke Niwa.
2008 The current install guideline for perf.webkit.org discourages the use of the installed
2009 Server application. I've actualized the documentation for Mavericks, and modified the
2010 guideline to include the instructions for Server.app also.
2014 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
2016 Update perf.webkit.org json example
2017 https://bugs.webkit.org/show_bug.cgi?id=129907
2019 Reviewed by Andreas Kling.
2021 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
2025 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
2027 Merge database-common.js and utility.js into run-tests.js.
2029 Reviewed by Matthew Hanson.
2031 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
2032 Also moved init-database.sql out of the database directory and removed the directory entirely.
2034 * database: Removed.
2035 * database/database-common.js: Removed.
2036 * database/utility.js: Removed.
2037 * init-database.sql: Moved from database/init-database.sql.
2039 (connect): Moved from database-common.js.
2040 (pathToDatabseSQL): Extracted from pathToLocalScript.
2041 (pathToTests): Moved from database-common.js.
2044 (SerializedTaskQueue): Ditto.
2046 (initializeDatabase):
2047 (TestEnvironment.it):
2048 (TestEnvironment.queryAndFetchAll):
2051 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2053 Remove the dependency on node.js from the production code.
2055 Reviewed by Ricky Mondello.
2057 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
2059 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
2060 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
2061 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
2062 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
2063 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
2065 Also removed the js files that are no longer used.
2067 * config.json: Moved from database/config.json.
2068 * database/aggregate.js: Removed. No longer used.
2069 * database/database-common.js: Removed unused functions, and updated the path to config.json.
2070 * database/process-jobs.js: Removed. No longer used.
2071 * database/sample-data.sql: Removed. We have a much better corpus of data now.
2072 * database/schema.graffle: Removed. It's completely obsolete.
2073 * public/include/db.php: Updated the path to config.json.
2074 * public/include/evaluator.js: Removed.
2076 * public/include/report-processor.php:
2077 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
2078 storing values into $expressions and calling evaluate_expressions_by_node.
2079 (TestRunsGenerator::aggregate_values): Added.
2080 (TestRunsGenerator::compute_caches): Directly compute the caches.
2082 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2084 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
2086 * public/admin/platforms.php:
2087 * public/include/db.php:
2089 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2091 Zoomed y-axis view is ununsable when the last result is an outlier.
2093 Reviewed by Stephanie Lewis.
2095 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
2096 the last result so that the graph looks sane if the last result was an outlier. However, always show
2097 the last result's mean even if it was an outlier.
2099 * public/index.html:
2100 * public/js/helper-classes.js:
2101 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
2102 Also added the ability to cache the unscaled means to avoid recomputation.
2103 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
2104 (PerfTestRuns.max): Ditto.
2105 (PerfTestRuns.sampleStandardDeviation): Ditto.
2106 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
2108 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
2112 * public/admin/tests.php:
2113 * public/js/helper-classes.js:
2115 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
2117 Use two standard deviations instead as I mentioned in the mailing list.
2119 * public/index.html:
2121 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2123 The performance dashboard erroneously shows upward arrow for combined metrics.
2125 A single outlier can ruin the zoomed y-axis view.
2127 Rubber-stamped by Antti Koivisto.
2129 * public/index.html:
2130 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
2131 from the latest results' mean.
2132 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
2133 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
2134 (Chart.toggleYAxis):
2135 * public/js/helper-classes.js:
2136 (PerfTestRuns.sampleStandardDeviation): Added.
2137 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
2139 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
2141 Don't include the confidence interval when computing the y-axis.
2143 Rubber-stamped by Simon Fraser.
2145 * public/js/helper-classes.js:
2149 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2151 Tiny CSS tweak for tooltips.
2153 * public/index.html:
2155 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
2157 Remove the erroneously repeated code.
2159 * public/admin/test-configurations.php:
2161 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2163 <rdar://problem/15704893> perf dashboard should show baseline numbers
2165 Reviewed by Stephanie Lewis.
2167 * public/admin/bug-trackers.php:
2168 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
2171 * public/admin/platforms.php:
2172 (merge_list): Ditto.
2174 * public/admin/test-configurations.php: Added.
2175 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
2176 build_revisions as they're not meaningful for baseline / target numbers.
2177 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
2178 one test run so that we don't accidentally delete a reported test run.
2179 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
2180 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
2181 and delete existing ones.
2183 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
2184 on each platform; there could be configurations of distinct types such as "current" and "baseline".
2185 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
2187 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
2188 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
2189 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
2190 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
2191 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
2193 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
2195 * public/include/admin-header.php:
2196 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
2197 have id and type sub columns, and each custom column could generate multiple rows.
2199 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
2200 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
2201 We then proceed to generate the second header row with sub column names.
2203 When generating the actual content, we first generate all custom columns as they may have multiple rows in
2204 which case regular columns need rowspan set to the maximum number of rows.
2206 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
2209 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
2210 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
2211 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
2212 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
2213 expanded to occupy all sub columns.
2215 * public/include/manifest.php:
2216 (ManifestGenerator::platforms): Don't add the metric more than once.
2218 * public/include/test-name-resolver.php:
2219 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
2220 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
2221 full metric name later.
2222 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
2223 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
2224 (TestNameResolver::full_name_for_test): Added.
2225 (TestNameResolver::full_name_for_metric): Added.
2226 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
2228 * public/js/helper-classes.js:
2229 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
2230 test runs created to set baseline and target points.
2232 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2234 Build fix after r57928. Removed a superfluous close parenthesis.
2236 * public/api/runs.php:
2238 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2240 Unreviewed build & typo fixes.
2242 * public/admin/platforms.php:
2243 * tests/admin-platforms.js:
2245 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
2247 <rdar://problem/15704893> perf dashboard should show baseline numbers
2249 Rubber-stamped by Antti Koivisto.
2251 Organize some code into functions in runs.php.
2253 Also added back $paths that was erroneously removed in r57925 from json-header.php.
2255 * public/api/runs.php:
2256 (fetch_runs_for_config): Extracted.
2257 (format_run): Ditto.
2259 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2261 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
2263 * database/config.json:
2264 * public/admin/reprocess-report.php:
2265 * public/api/report.php:
2266 * public/api/runs.php:
2267 * public/include/json-header.php:
2269 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2271 Commit yet another forgotten change.
2273 Something went horribly wrong with my merge :(
2275 * database/init-database.sql:
2277 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2279 Commit one more forgotten change. Sorry for making a mess here.
2281 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2283 Commit the forgotten files.
2285 * public/admin/platforms.php: Added.
2286 * tests/admin-platforms.js: Added.
2288 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
2290 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
2292 Reviewed by Stephanie Lewis.
2294 Added /admin/platforms/ page to hide and merge platforms.
2296 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
2297 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
2298 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
2299 each test configuration a distinct "test run" for each build.
2301 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
2302 their test configurations into platform B.
2304 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
2305 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
2306 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
2307 in platform B, in which case R should relate to T_B instead.
2309 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
2310 new platform. We then migrate the test configurations of the remaining test runs.
2312 * database/init-database.sql: Added platform_hidden.
2314 * public/admin/platforms.php: Added.
2315 (merge_platforms): Added. Implements the algorithm described above.
2316 (merge_list): Added.
2318 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
2319 is hidden since it doesn't do anything.
2321 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
2322 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
2323 missing it since unchecked checkbox doesn't set the value in $_POST.
2324 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
2325 switch statement instead of repeated if's.
2326 (AdministrativePage::render_table): Emit "update-column" for update_field.
2328 * public/include/db.php: Disable warnings when we're not in the debug mode.
2330 * public/include/manifest.php:
2331 (ManifestGenerator::platforms): Skip platforms that have been hidden.
2334 (TestEnvironment.postJSON):
2335 (TestEnvironment.httpGet):
2336 (TestEnvironment.httpPost): Added.
2337 (sendHttpRequest): Set the content type if specified.
2339 * tests/admin-platforms.js: Added tests.
2341 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
2343 Extract the code to compute full test names from tests.php.
2345 Reviewed by Stephanie Lewis.
2347 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
2348 and paves our way to re-use the code in other pages.
2350 * public/admin/tests.php:
2352 * public/include/db.php:
2353 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
2354 tests.php and test-name-resolver.php.
2356 * public/include/test-name-resolver.php: Added.
2357 (TestNameResolver::__construct):
2358 (TestNameResolver::compute_full_name): Moved from tests.php.
2359 (TestNameResolver::map_metrics_to_tests): Ditto.
2360 (TestNameResolver::sort_tests_by_full_name): Ditto.
2361 (TestNameResolver::tests): Added.
2362 (TestNameResolver::test_id_for_full_name): Ditto.
2363 (TestNameResolver::metrics_for_test_id): Ditto.
2364 (TestNameResolver::child_metrics_for_test_id): Ditto.
2365 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
2367 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2369 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2371 Reviewed by Stephanie Lewis.
2373 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
2375 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
2376 but that's sufficient to correct the wrongfully processed reports for now.
2378 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
2379 We should eventually add a nice UI to find and reprocess reports.
2381 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
2383 * public/include/db.php: Added the forgotten call to prefixed_column_names.
2385 * public/include/report-processor.php: Copied from public/api/report.php.
2386 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
2387 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
2388 create a new report or authenticate the builder password (the password is never stored in the report).
2389 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
2390 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
2391 (ReportProcessor::store_report): Ditto.
2393 * tests/admin-reprocess-report.js: Added.
2395 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
2397 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
2399 Reviewed by Ricky Mondello.
2401 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
2402 for the same build number as a single build by ignoring build time. This was necessary to associate
2403 multiple reports by a single build - e.g. for different performance test suites - because the scripts
2404 we use to submit results computed its own "build time" when they're called.
2406 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
2407 last week; new reports were wrongfully associated with old build numbers.
2409 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
2410 to the same build. Instead, we create a new build object for those reports. Since the longest set of
2411 tests we have only take a couple of hours to run, 24 hours should be more than enough.
2413 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
2414 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
2415 (builder, build number, build time).
2417 * public/api/report.php:
2418 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
2419 when no such build exists. This prevents a report from being associated with a very old build of the same
2422 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
2423 a similar bug in the future sooner.
2425 * tests/api-report.js: Added three test cases.
2427 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2429 Merged the upstream changes to db.php
2430 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
2432 * public/include/db.php:
2434 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2436 Update other scripts and tests per previous patch.
2438 * public/include/manifest.php:
2439 * tests/admin-regenerate-manifest.js:
2441 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
2443 Remove metrics_unit.
2445 Reviewed by Ricky Mondello.
2447 This column is no longer used by the front-end code since r48360.
2449 * database/init-database.sql:
2450 * public/admin/tests.php:
2452 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
2454 Unreviewed build fix.
2456 * public/api/report.php:
2458 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
2460 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
2462 Reviewed by Ricky Mondello.
2464 Support a new alternative format for aggregated results where we have raw values as well as
2465 the list aggregators so that instead of
2466 "metrics": {"Time": ["Arithmetic"]}
2468 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
2470 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
2471 dashboard and the generated results page, which doesn't know how to aggregate values.
2473 We need to keep the support for the old format because all other existing performance tests
2474 all rely on the old format. Even if we updated the tests, we need the dashboard to support
2475 the old format during the transition.
2477 * public/api/report.php:
2478 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
2479 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
2481 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
2483 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2485 Unreviewed; Tweak the CSS so that chart panes align vertically.
2487 * public/index.html:
2489 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
2491 SafariPerfMonitor should support Combined metric.
2493 * public/js/helper-classes.js:
2494 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
2495 value as well but assume it to be greater-is-better for now.
2497 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2499 Commit the forgotten init-database change to add iteration_relative_time.
2501 * database/init-database.sql:
2503 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
2505 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
2507 Reviewed by Ricky Mondello.
2509 Add the support for each value to have a relative time. This is necessary for frame rate history
2510 since a frame rate needs to be associated with a time it was sampled.
2512 * database/init-database.sql: Added iteration_relative_time to run_iterations.
2514 * public/api/report.php:
2515 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
2516 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
2517 with relative time since taking the average of two frame rates for two subtests taken at two
2518 different times doesn't make any sense.
2519 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
2520 etc..., use the second element since we assume values are of the form (relative time, frame rate).
2521 Also exit early with an error if the number of elements in the array is not a pair.
2522 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
2524 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
2525 iteration_relative_time.
2527 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
2529 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
2531 Reviewed by Ricky Mondello.
2533 Support that. It's one line change.
2535 * public/api/report.php:
2536 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
2537 to match the convention assumed elsewhere.
2538 * tests/api-report.js: Added a test case.
2540 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2542 SafariPerfMonitor shows popups for points outside of the visible region.
2544 Rubber-stamped by Simon Fraser.
2546 * public/index.html:
2547 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
2548 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
2549 may return an item underneath y-axis labels.
2551 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2553 Tweak the CSS a little to avoid the test name overlapping with the summary table.
2555 * public/index.html:
2557 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2559 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
2561 * public/index.html:
2563 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
2565 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
2566 <rdar://problem/13992271> Should scale Y axis to include error ranges
2568 Reviewed by Ricky Mondello.
2570 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
2571 the main graph doesn't go outside the graph even when the y-axis is adjusted.
2573 * database/config.json:
2574 * public/index.html:
2575 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
2576 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
2577 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
2579 * public/js/helper-classes.js:
2580 (PerfTestResult.confidenceIntervalDelta):
2581 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
2582 (PerfTestRuns.min): Take confidence interval delta into account.
2583 (PerfTestRuns.max): Ditto.
2584 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
2586 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2588 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
2590 * public/api/report.php:
2591 (ReportProcessor::recursively_ensure_tests):
2592 * tests/api-report.js: Added a test.
2594 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2596 Unreviewed build fixes.
2598 * public/api/report.php:
2599 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
2600 Also, tolerate reports without any revision information.
2602 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
2605 * tests/api-report.js: Added few test cases.
2607 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
2609 Commit another change that was supposed to be committed in r50331.
2612 (TestEnvironment.this.postJSON):
2613 (TestEnvironment.this.httpGet):
2616 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
2618 Commit the remaining files.
2620 * public/admin/regenerate-manifest.php:
2621 * public/include/admin-header.php:
2622 * public/include/json-header.php:
2623 * public/include/manifest.php:
2625 (TestEnvironment.this.postJSON):
2626 (TestEnvironment.this.httpGet):
2629 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
2631 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
2633 Reviewed by Ricky Mondello.
2635 Added some tests for admin/regenerate-manifest.
2637 * public/admin/regenerate-manifest.php: Use require_once instead of require.
2638 * public/include/admin-header.php: Ditto.
2639 * public/include/json-header.php: Ditto.
2641 * public/include/manifest.php:
2642 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
2643 When there are no builders, simply return an empty array.
2646 (TestEnvironment.postJSON):
2647 (TestEnvironment.httpGet): Added.
2648 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
2650 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
2652 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
2654 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
2655 and run_iterations. Also fixed a typo in report.php found by new tests.
2657 * public/api/report.php:
2658 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
2659 * tests/api-report.js: Added more test cases.
2661 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
2663 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
2665 Reviewed by Ricky Mondello.
2667 Add a test runner script and some simple test cases.
2669 * database/config.json: Added the configuration for "testServer".
2670 * database/database-common.js:
2671 (pathToTests): Added.
2672 * run-tests.js: Added.
2675 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
2676 and if there are, asks the user if it’s okay to delete all of the data contained therein.
2677 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
2679 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
2680 in the current database using PostgreSQL's information_schema.
2681 (askYesOrNoQuestion):
2683 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
2685 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
2686 (TestEnvironment.assert): Exposes assert to tests.
2687 (TestEnvironment.console): Exposes console to tests.
2688 (TestEnvironment.describe): Adds a description.
2689 (TestEnvironment.it): Adds a test case.
2690 (TestEnvironment.postJSON):
2691 (TestEnvironment.queryAndFetchAll):
2692 (TestEnvironment.sha256):
2693 (TestEnvironment.notifyDone): Ends the current test case.
2697 (TestContext): An object created for each test case. Conceptually, this object is always on
2698 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
2699 this object via currentTestContext.
2700 (TestContext.description):
2702 (TestContext.logError):
2705 * tests/api-report.js: Added some basic tests for /api/report.php.
2707 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2709 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
2711 The problem was that we were detecting whether we're updating dashboard or not by checking
2712 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
2713 all configurations. Use separate 'dashboard' action to execute the code even when
2714 metric_configurations is empty.
2716 * public/admin/tests.php:
2718 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2720 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
2722 Reviewed by Ricky Mondello.
2724 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
2725 from ReportProcessor as a preparation to replace deprecated aggregate.js.
2727 * public/api/report.php:
2728 (ReportProcessor::exit_with_error): Moved.
2729 (ReportProcessor::process): Use the extracted TestRunsGenerator.
2730 (TestRunsGenerator): Added.
2731 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
2732 (TestRunsGenerator::add_aggregated_metric): Moved.
2733 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
2734 (TestRunsGenerator::aggregate): Moved. Made public.
2735 (TestRunsGenerator::aggregate_current_test_level): Moved.
2736 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
2737 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
2738 (TestRunsGenerator::compute_caches): Moved. Made public.
2739 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
2740 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
2741 (TestRunsGenerator::rollback_with_error): Moved.
2743 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2745 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
2747 Reviewed by Remy Demarest.
2749 Regenerate the manifest file when updating fields or adding new items that are included in
2752 * public/admin/bug-trackers.php:
2753 * public/admin/builders.php:
2754 * public/admin/regenerate-manifest.php:
2755 * public/admin/repositories.php:
2756 * public/admin/tests.php:
2757 * public/include/admin-header.php:
2758 (regenerate_manifest): Extracted from regenerate-manifest.php.
2760 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
2762 Unreviewed build fix for memory test results.
2764 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
2765 aggregating at each level.
2767 * public/api/report.php:
2768 (ReportProcessor::recursively_ensure_tests):
2769 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
2770 (ReportProcessor::add_values_for_aggregation):
2771 (ReportProcessor::aggregate):
2772 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
2774 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
2776 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
2777 not the number of iteration groups. Also, don't set group number when the entire run belongs
2778 a single iteration group.
2780 * public/api/report.php:
2781 (ReportProcessor::commit):
2783 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2785 SafariPerfMonitor: Introduce iteration groups
2787 Reviewed by Remy Demarest.
2789 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
2790 the runtime environment variances to get more stable results. And it's desirable to keep track of
2791 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
2793 This patch introduces "iteration groups" to keep track of this extra information.
2795 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
2796 the outer array denotes iteration groups and each inner array contains iteration values for each group.
2799 * database/init-database.sql: Add iteration_group column.
2800 * public/api/report.php:
2801 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
2803 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
2804 contains the list of values indexed by the iteration order and group sizes. Store the group size so
2805 that we can restore the iteration groups before passing it to node.js and restore them later.
2807 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
2808 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
2810 Also check that each iteration group in each subtest are consistent with one another. To see why we need
2811 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
2812 that each iteration group in T1 and T2 have the same size:
2813 T1 = [[1, 2], [3, 4, 5]]
2814 T2 = [[6, 7], [8, 9, 10]]
2816 so that the aggregated result (the sum in this case) can have the same groups as in:
2817 T = [[7, 9], [11, 13, 15]]
2819 If some iteration groups in T1 and T2 had a different size as in:
2820 T1 = [[1, 2, 3], [4, 5]]
2821 T2 = [[6, 7], [8, 9, 10]]
2823 Then iteration groups of the aggregated T is ambiguous.
2825 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
2826 (ReportProcessor::commit): Store iteration_group values.
2828 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2830 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
2831 migrated to perf.webkit.org.
2833 * database/perf-webkit-migrator.js: Removed.
2835 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2837 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
2839 * public/index.html:
2842 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
2844 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
2846 Reviewed by Ricky Mondello.
2848 It is often desirable to see charts of a given test for all platforms, or to be able to see
2849 charts of all subtests on a given platform when trying to triage perf. regressions.
2851 Support this use case by adding the ability to do so on the charts page.
2853 Also, we used to disable items on the test list based on the platform chosen. This turned out
2854 to be a bad UI because in many situations you want to be able to compare results of the same test
2855 on multiple platforms.
2857 In this new UI, we have three select elements, each of which selects the following:
2858 1. Top-level test - Test suite such as Dromaeo
2859 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
2860 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
2861 3. Platform - Mountain Lion, Qt, etc...
2863 A user can select "all" for metric and platform but we disallow doing both at once since adding
2864 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
2865 think of a use case where you want to look at that many charts at once. We can support this later
2866 if valid use cases come up.
2868 * public/index.html:
2869 (.showCharts.addOption): Extracted.
2870 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
2871 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
2872 metricList has onchange handler that enables/disables items on platformList.
2874 (init): Sort tests and test metrics here instead of doing that in showCharts.
2876 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
2878 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
2880 Reviewed by Remy Demarest and Ricky Mondello.
2882 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
2883 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
2884 templates to the manifest file instead. Each build now only contains the builder id.
2886 * public/api/runs.php: Removed the part of the query that joined builders table. This
2887 speeds up the query quite a bit.
2889 * public/include/manifest.php:
2890 (ManifestGenerator::generate): Generate builders field.
2891 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
2892 associative array that contains name and its build URL template.
2894 * public/index.html:
2895 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
2896 instead of a revision since this function is used for revisions and build page URLs now.
2897 (.buildLabelWithLinks): Include the linkified build number.
2899 * public/js/helper-classes.js:
2900 (TestBuild.builder): Added.
2901 (TestBuild.buildNumber): Added.
2902 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
2903 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
2905 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
2907 Tooltips interfere with user interactions
2909 Rubber-stamped by Simon Fraser.
2911 Disable tooltip on the dashboard page since graphs are too small to be useful there.
2912 Also, show graphs for only 10 days by default as opposed to 20.
2913 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
2915 * public/index.html:
2916 * public/js/helper-classes.js:
2918 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
2920 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
2921 to be compatible with webkit-perf.appspot.com.
2923 * public/admin/builders.php:
2924 * public/api/report.php:
2926 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
2930 Add a missing constraint on builds table. For a given builder, there should be exactly
2931 one build for a given build number.
2933 Also add report_committed_at to reports table to record the time at which a given report
2934 was processed and test_runs and run_iterations rows were committed into the database.
2936 * database/config.json:
2937 * public/api/report.php:
2939 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
2941 Unreviewed. Add more checks for empty SQL query results.
2943 * public/include/manifest.php:
2945 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2947 More build fixes on perf.webkit.org.
2949 * public/api/runs.php: Make PostgreSQL happier.
2950 * public/include/manifest.php: Don't assume we always have bug trackers.
2952 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2954 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
2955 and fix other miscellaneous UI bugs.
2957 Rubber-stamped by Simon Fraser.
2959 Removed the code to determine whether smaller value is better or not for a given test in index.html
2960 in the favor of using that of PerfTestRuns.
2962 * public/include/manifest.php: Fixed a typo.
2963 * public/index.html:
2965 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
2967 * public/js/helper-classes.js:
2968 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
2970 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
2971 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
2972 at roughly 2,000 units to avoid this.
2974 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
2975 The only thing we can avoid is innerHTML.
2977 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2979 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
2981 * public/include/evaluator.js:
2983 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2985 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2987 Reviewed by Remy Demarest.
2989 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2990 admin/bug-trackers.php and can be associated with multiple repositories.
2992 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2993 to determine the set of bug trackers to show for a given set of blame lists.
2994 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2995 a place to file bugs against the regression.
2997 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2998 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
3000 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
3001 bug trackers, namely associated repositories.
3003 * public/include/admin-header.php: Added a link to bug-trackers.php
3004 * public/include/manifest.php:
3005 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
3006 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
3008 (ManifestGenerator::repositories):
3010 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
3011 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
3012 'repositories' where the latter contains the list of associated repository names.
3014 * public/index.html:
3015 (Chart): Takes bugTrackers as as argument.
3016 (Chart.showTooltipWithResults): Removed the hard-coded list.
3018 (init.addPlatformsToDashboard):
3019 (init.showCharts.createChartFromListPair):
3020 (init): Stores the list of bug trackers in the manifest to a local variable.
3022 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3024 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
3026 * public/include/evaluator.js:
3028 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
3030 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
3032 Reviewed by Remy Demarest.
3034 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
3035 new row into the database.
3037 * public/admin/aggregators.php: Use AdministrativePage.
3038 * public/admin/builders.php: Ditto.
3039 * public/admin/repositories.php: Ditto.
3040 * public/include/admin-header.php:
3041 (AdministrativePage): Added.
3042 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
3043 to an associative array that describes the column.
3044 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
3045 - label: Human readable name of the column.
3046 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
3047 column exists only before we create password_hash column at the insertion time.
3049 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
3050 titlecase (e.g. new_bug is converted to New Bug).
3051 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
3052 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
3053 textarea for a given editing mode ('text', 'url', or 'string').
3054 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
3055 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
3057 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
3059 Build fix. Some systems don't support r+. Use proc_open instead.
3061 * public/api/report.php:
3063 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3065 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
3066 when computing the y-axis of data points to show tooltips at.
3068 * public/index.html:
3070 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
3072 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
3075 * public/.htaccess: Removed.
3077 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
3081 * public/include/manifest.php: Build fix. db is on this.
3082 * public/js/statistics.js:
3083 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
3085 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
3087 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
3089 Reviewed by Anders Carlsson.
3091 Rewrote and merged populate-from-report.js into report.php.
3093 * database/config.json: Added a path to node.js.
3095 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
3096 Once we land this patch and update the administrative pages, we can remove this column.
3098 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
3099 that table is going away once we remove the node.js backend.
3101 * database/populate-from-report.js: Removed.
3102 * public/api/report.php: Added.
3104 (ReportProcessor.__construct):
3105 (ReportProcessor.process):
3107 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
3108 verified to be submitted by a known builder.
3110 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
3111 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
3112 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
3113 inside a transaction because there could be multiple reports for a single build, each containing results for
3116 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
3117 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
3118 add_values_to_commit, and add_values_for_aggregation.
3120 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
3121 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
3122 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
3125 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
3126 to be aggregated in ReportProcessor.aggregate.
3128 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
3130 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
3131 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
3132 given for each row (child metrics of M). This function extracts each column (iteration) via
3133 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
3134 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
3136 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
3137 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
3138 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
3140 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
3141 (ReportProcessor.evaluate_expressions_by_node): See above.
3143 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
3144 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
3145 results also need the said caches.
3147 (ReportProcessor.add_values_to_commit):
3149 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
3150 the transaction as needed if anything goes wrong.
3152 (ReportProcessor.rollback_with_error)
3154 * public/include/db.php:
3155 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
3156 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
3157 contiguously in a SQL statement.
3159 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
3160 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
3161 a column value of the choice.
3163 (Database.begin_transaction): Added.
3164 (Database.commit_transaction): Added.
3165 (Database.rollback_transaction): Added.
3167 * public/include/evaluator.js: Added.
3168 * public/include/json-header.php:
3169 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
3170 context under which the request failed.
3171 (successful_exit): Merge "additional details".
3172 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
3173 (merge_additional_details):
3175 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
3177 SafariPerfMonitor: Add more helper functions to db.php
3179 Reviewed by Remy Demarest.
3181 Added Database::insert_row and array_get to make common database operations easier.
3183 * public/admin/aggregators.php: Use Database::insert_row instead of
3184 execute_query_and_expect_one_row_to_be_affected.
3186 * public/admin/builders.php: Ditto.
3188 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
3189 inserting a row. With insert_row, we don't need that.
3191 * public/include/admin-header.php: Ditto.
3193 * public/include/db.php:
3194 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
3195 return the default value (defaults to NULL) if the key doesn't exist.
3197 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
3200 (Database::prepare_params): Added. Takes an associative array of column names and their values,
3201 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
3202 column names all in the same order.
3204 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
3205 the given prefix. Values are given in a form of an associative array where keys are unprefixed
3206 column names and values are corresponding values. When the row is successfully inserted, it returns
3207 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
3208 indicating the success of the insertion.
3210 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3212 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
3214 Reviewed by Conrad Shultz.
3216 Rewrote the manifest generator in PHP.
3218 * database/generate-manifest.js: Removed.
3219 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
3220 * public/include/db.php:
3221 (array_ensure_item_has_array): Added.
3222 * public/include/evaluator.js: Added.
3223 * public/include/json-header.php:
3224 * public/include/manifest.php: Added.
3226 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
3228 Dates on overflow plot are overlapping
3230 Rubber-stamped by Simon Fraser.
3232 Don't show more than 5 days.
3234 * public/index.html:
3235 * public/js/helper-classes.js:
3236 (TestBuild.UTCtoPST):
3239 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3241 Show build time as well as commit time on the dashboard and tooltips.
3243 Rubber-stamped by Simon Fraser.
3245 Include both the maximum commit time and build time in buildLabelWithLinks.
3246 Also use ISO format to save the screen real estate.
3248 * public/index.html:
3249 (buildLabelWithLinks):
3250 * public/js/helper-classes.js:
3252 (TestBuild.buildTime):
3253 (TestBuild.formattedBuildTime):
3255 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
3257 Unreviewed; Convert metric.name to metric.unit in the front end.
3259 * public/js/helper-classes.js:
3261 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
3263 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
3265 Rubber-stamped by Simon Fraser.
3267 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
3268 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
3269 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
3271 * public/index.html:
3272 (.buildLabelWithLinks): Extracted from TestBuild.label.
3273 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
3274 on Radar and WebKit Bugzilla.
3275 * public/js/helper-classes.js:
3276 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
3277 (PerfTestResult.isBetterThan): Added.
3278 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
3279 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
3280 to indicate progressions or regressions.
3281 (PerfTestResult.label):
3282 (TestBuild.formattedTime): Added.
3283 (TestBuild.platform): Added.
3284 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
3285 (TestBuild.smallerIsBetter): Added.
3286 (Tooltip.show): Take a raw markup instead of two results.
3288 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
3290 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
3292 Rubber-stamped by Tim Horton.
3294 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
3295 since each platform may have a different number of tests to be shown on the dashboard.
3297 * public/index.html:
3299 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3301 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
3303 * public/js/helper-classes.js:
3306 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3308 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
3310 Rubber-stamped by Tim Horton.
3312 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
3314 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
3315 the revision r1234 was the revision used in the previous build.
3317 * public/api/runs.php:
3318 (parse_revisions_array): Trim double quotations around repository names and revisions.
3319 * public/js/helper-classes.js:
3322 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
3324 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
3326 Rubber-stamped by Tim Horton.
3328 * public/index.html:
3329 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
3330 on the dashboard page as it's way too noisy.
3332 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
3334 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
3335 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
3336 so that the tooltip for hover can be reused further.
3338 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
3339 and find the first point that lies on the right of the cursor position. We then compute the midpoint
3340 between this and the previous point and pick the closer of the two. It returns an item-like object
3341 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
3343 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
3345 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
3346 the first or "current" data points (as opposed to target or baseline data points).
3348 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
3349 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
3350 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
3352 * public/js/helper-classes.js:
3353 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
3354 work to the client via bindClick.
3356 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
3358 (Tooltip.bindClick): Added.
3360 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3362 Yet another build fix. metricId*s*.
3364 * public/admin/tests.php:
3366 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3368 Another build fix. Use the new payload format for the aggregate job.
3370 * public/admin/tests.php:
3372 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
3376 * database/aggregate.js: Use variables that actually exist.
3377 * database/database-common.js:
3378 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
3379 function calls will find this configuration.
3381 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3383 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
3385 Reviewed by Ricky Mondello.
3387 Turned InstallManual into a proper markdown document and added ReadMe.md.
3389 * InstallManual: Removed.
3390 * InstallManual.md: Moved from InstallManual.
3393 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
3395 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
3397 Reviewed by Ricky Mondello.
3399 This patch prepares the front end code to process baseline and target results properly.
3401 * public/index.html:
3402 (fetchTest.createRunAndResults): Extracted.
3403 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
3404 Deleted the comment about how sorting will be unnecessary once we start results in the server side
3405 since sorting by the maximum revision commit time turned out to be non-trivial in php.
3407 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3409 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
3411 Reviewed by Tim Horton.
3413 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
3414 These files are "dynamically linked" to our app.
3416 * public/index.html:
3417 * public/js/jquery-1.8.2.min.js: Removed.
3418 * public/js/jquery.colorhelpers.js: Added.
3419 * public/js/jquery.flot.categories.js: Added.
3420 * public/js/jquery.flot.crosshair.js: Added.
3421 * public/js/jquery.flot.errorbars.js: Added.
3422 * public/js/jquery.flot.fillbetween.js: Added.
3423 * public/js/jquery.flot.js: Added.
3424 * public/js/jquery.flot.min.js: Removed.
3425 * public/js/jquery.flot.navigate.js: Added.
3426 * public/js/jquery.flot.resize.js: Added.
3427 * public/js/jquery.flot.selection.js: Added.
3428 * public/js/jquery.flot.stack.js: Added.
3429 * public/js/jquery.flot.symbol.js: Added.
3430 * public/js/jquery.flot.threshold.js: Added.
3431 * public/js/jquery.flot.time.js: Added.
3432 * public/js/jquery.js: Added.
3434 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
3436 Return NaN instead of throwing when there aren't enough samples.
3438 Reviewed by Sam Weinig.
3440 It's better to return NaN when we don't have enough samples so that we can treat it
3441 as if we don't have any confidence interval.
3443 * public/js/statistics.js:
3446 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3448 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
3450 * public/js/helper-classes.js:
3451 (URLState.parseIfNeeded):
3453 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
3455 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
3457 Reviewed by Ricky Mondello.
3459 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
3461 * public/admin/aggregators.php: Use heredoc.
3462 * public/admin/builders.php:
3463 * public/admin/jobs.php:
3464 * public/admin/repositories.php:
3465 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
3466 This allows us to use update_field when updating test's url and metric's unit. Changed the action
3467 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
3468 Also removed a stray code to update unit and url simultaneously since it's never used.
3469 * public/include/admin-header.php:
3470 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
3471 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
3472 (update_field): Moved from repositories.php.
3474 * public/include/db.php:
3475 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
3477 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
3479 Build fixes. Treat mean, sum, and square sum as float, not int.
3481 Also use 95% confidence interval instead of 90% confidence interval.
3483 * public/api/runs.php:
3484 * public/js/helper-classes.js:
3485 (.this.confidenceIntervalDelta):
3487 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
3489 Add an administrative page to edit repository information.
3491 Reviewed by Ricky Mondello.
3493 * public/admin/repositories.php: Added.
3494 * public/include/admin-header.php:
3496 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
3498 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
3500 Reviewed by Ricky Mondello.
3502 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
3503 to aggregate results for those matrix in populate-from-report.js.
3505 * database/generate-manifest.js:
3506 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
3507 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
3508 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
3509 * database/populate-from-report.js:
3511 (getReport): No change even though the diff looks as if it moved.
3512 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
3513 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
3514 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
3515 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
3516 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
3518 (ensureMetricId): Take an aggregator id as an argument.
3519 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
3520 for all builds when the build id is not specified.
3521 * public/admin/tests.php:
3522 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
3523 of the same name with different aggregators.
3525 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
3527 Build fix. Don't pass in arguments to in the wrong order.
3529 * database/aggregate.js:
3531 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3533 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
3535 Reviewed by Ricky Mondello.
3537 Since the version of flot we use doesn't support showing graphs in the current locate or
3538 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
3539 treat them as in UTC). We don't want to use the current locate because other websites on
3540 webkit.org assume PST.
3542 Also append this information to build's label.
3544 * public/js/helper-classes.js:
3548 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3550 Store test URLs reported by builders.
3552 Reviewed by Ricky Mondello.
3554 * database/populate-from-report.js:
3555 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
3556 (ensureTestId): Store the URL.
3558 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
3560 Yet another build fix; don't blow up even if we didn't have any test configurations.
3562 * public/admin/tests.php:
3564 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
3566 Build fix; don't instantiate Date when a timestamp wasn't provided.
3568 * database/populate-from-report.js:
3570 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
3572 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
3574 Reviewed by Tim Horton.
3576 Added an install manual.
3578 * InstallManual: Added.
3580 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
3582 Minor build fix. Don't unset builderPassword when it's not set.
3584 * public/api/report.php:
3586 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3588 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
3590 Reviewed by Ricky Mondello.
3592 * public/admin/admin.css: Make a very large payload scrollable.
3593 * public/admin/jobs.php: Format JSONs.
3595 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
3597 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
3599 Reviewed by Ricky Mondello.
3601 Add report.php and populate-from-report.js that process JSON files submitted by builders.
3603 * database/populate-from-report.js: Added.
3605 (getReport): Obtains the payload (the actual report) from "jobs" table.
3606 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
3607 and their results. This function recursively traverses tests and metrics and ensure their ids.
3609 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
3610 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
3611 is a "function" in mathematical sense).
3613 (ensureRepositoryIdsForAllRevisions):
3614 (getIdOrCreateBuildWithRevisions):
3615 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
3616 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
3617 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
3619 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
3620 test results all in a single transaction. This allows us to keep the database consistent in that either
3621 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
3622 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
3623 other parts of the application are concerned.
3624 (scheduleQueriesToInsertRun):
3625 * database/process-jobs.js: Add a call to populate-from-report.js.
3626 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
3627 * public/include/db.php: Support parameterized query.
3628 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
3629 a test result could confirm that the submission indeed succeeded.
3631 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3633 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
3635 * database/aggregate.js:
3636 * database/database-common.js:
3637 (selectColumnCreatingRowIfNeeded):
3638 (ensureRepositoryId):
3639 (ensureConfigurationIdFromList):
3640 * database/perf-webkit-migrator.js:
3643 (getOrCreateBuildId):
3645 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3647 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
3649 Reviewed by Ricky Mondello.
3651 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
3652 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
3654 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
3657 (saveAggregatedResults):
3658 * database/database-common.js:
3659 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
3660 (getIdOrCreateRepository): Ditto.
3661 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
3662 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
3663 * database/perf-webkit-migrator.js:
3664 * database/utility.js: Added.
3665 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
3666 from being executed.
3667 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
3668 call the callback passed into start().
3669 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
3670 (TaskQueue.addTask):
3672 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
3673 (SerializedTaskQueue.executeNextTask):
3674 (SerializedTaskQueue.addTask):
3675 (SerializedTaskQueue.start):
3677 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3679 Revert erroneously committed changes.
3681 * database/config.json:
3683 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
3685 aggregator.js should be able to accept multiple metric ids and a single build id.
3687 Reviewed by Ricky Mondello.
3689 Make aggregator.js accept multiple ids and generate results for single build when bots are
3690 reporting new results.
3692 * database/aggregate.js:
3693 (parseArgv): Added. Returns an object containing the parsed representation of argv,
3694 which currently contains metricIDs and buildIds.
3695 (main): Use parseArgv and processConfigurations
3696 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
3697 (processPlatform.processConfigurations): Extracted.
3699 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
3701 Add an administrative page for builders.
3703 Reviewed by Ricky Mondello.
3705 We need an administrative page to add and edit builder information.
3706 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.