1 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
3 Another unreviewed build fix after r174477.
5 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
7 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
9 * public/include/report-processor.php:
11 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
13 Unreviewed build fix after r174477.
15 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
16 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
18 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
19 This is necessary for baseline and target values manually added via admin pages.
21 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
23 Add v2 UI for the perf dashboard
24 https://bugs.webkit.org/show_bug.cgi?id=137537
26 Rubber-stamped by Andreas Kling.
29 * public/v2/app.css: Added.
30 * public/v2/app.js: Added.
31 * public/v2/chart-pane.css: Added.
32 * public/v2/data.js: Added.
33 * public/v2/index.html: Added.
34 * public/v2/js: Added.
35 * public/v2/js/d3: Added.
36 * public/v2/js/d3/LICENSE: Added.
37 * public/v2/js/d3/d3.js: Added.
38 * public/v2/js/d3/d3.min.js: Added.
39 * public/v2/js/ember-data.js: Added.
40 * public/v2/js/ember.js: Added.
41 * public/v2/js/handlebars.js: Added.
42 * public/v2/js/jquery.min.js: Added.
43 * public/v2/js/statistics.js: Added.
44 * public/v2/manifest.js: Added.
45 * public/v2/popup.js: Added.
47 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
49 Remove superfluously duplicated code in public/api/report-commits.php.
51 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
53 Perf dashboard should store commit logs
54 https://bugs.webkit.org/show_bug.cgi?id=137510
56 Reviewed by Darin Adler.
58 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
60 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
61 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
62 a subversion directory. The git version of this script will be added in a follow up patch.
65 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
66 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
67 relationship via "build_commits" relations.
69 In order to migrate an existing instance of this application, run the following SQL commands:
73 INSERT INTO commits (commit_repository, commit_revision, commit_time)
74 (SELECT DISTINCT ON (revision_repository, revision_value)
75 revision_repository, revision_value, revision_time FROM build_revisions);
77 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
78 FROM commits, build_revisions
79 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
81 DROP TABLE build_revisions;
86 The helper script to submit commit logs can be used as follows:
88 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
89 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
91 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
92 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
93 "feeder-slave-password" as the builder name and the builder password respectively.
95 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
96 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
99 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
101 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
102 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
104 - Not specified - It returns every single commit for a given repository.
105 - Matches "oldest" - It returns the commit with the oldest timestamp.
106 - Matches "latest" - It returns the commit with the latest timestamp.
107 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
108 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
109 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
110 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
111 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
112 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
114 (commit_from_revision):
115 (fetch_commits_between):
118 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
119 See tests/api-report-commits.js for examples on how to use this API.
121 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
122 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
123 to optimize this and other JSON APIs.
125 * public/include/db.php:
126 (Database::select_or_insert_row):
127 (Database::update_or_insert_row): Added.
128 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
129 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
131 (Database::select_first_row):
132 (Database::select_last_row): Added.
133 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
134 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
136 * public/include/report-processor.php:
137 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
138 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
139 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
142 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
144 * tests/api-report-commits.js: Added.
145 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
148 * tools/pull-svn.py: Added. See above for how to use this script.
150 (determine_first_revision_to_fetch):
151 (fetch_revision_from_dasbhoard):
152 (fetch_commit_and_resolve_author):
155 (resolve_author_name_from_email):
158 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
160 Update Install.md for Mavericks and fix typos
161 https://bugs.webkit.org/show_bug.cgi?id=137276
163 Reviewed by Benjamin Poulain.
165 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
167 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
169 Finally, init-database.sql is no longer located inside database directory.
173 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
175 Report run id's in api/runs.php for the new dashboard UI
176 https://bugs.webkit.org/show_bug.cgi?id=135813
178 Reviewed by Andreas Kling.
180 Include run_id in the generated JSON.
182 * public/api/runs.php:
183 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
186 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
188 Merging platforms mixes baselines and targets into reported data
189 https://bugs.webkit.org/show_bug.cgi?id=135260
191 Reviewed by Andreas Kling.
193 When merging two platforms, move test configurations of a different type (baseline, target)
194 as well as of different metric (Time, Runs).
196 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
197 It's sufficient to detect one such test_runs object.
199 * public/admin/platforms.php:
202 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
204 Merging platforms mixes baselines and targets into reported data
205 https://bugs.webkit.org/show_bug.cgi?id=135260
207 Reviewed by Geoffrey Garen.
209 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
210 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
212 * public/admin/platforms.php:
214 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
216 Build fix after r171361.
218 * public/js/helper-classes.js:
219 (.this.formattedBuildTime):
221 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
223 Perf dashboard spends 2s processing JSON data during the page loads
224 https://bugs.webkit.org/show_bug.cgi?id=135152
226 Reviewed by Andreas Kling.
228 In the Apple internal dashboard, we were spending as much as 2 seconds
229 converting raw JSON data into proper JS objects while loading the dashboard.
231 This caused the apparent unresponsiveness of the dashboard despite of the fact
232 charts themselves updated almost instantaneously.
235 * public/js/helper-classes.js:
236 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
237 lazily as creating new Date objects and running string replace is expensive.
238 (TestBuild.formattedTime):
239 (TestBuild.formattedBuildTime):
240 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
241 (PerfTestRuns.addResult): Deleted.
243 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
245 Perf dashboard shouldn't show the full git hash
246 https://bugs.webkit.org/show_bug.cgi?id=135083
248 Reviewed by Benjamin Poulain.
250 Detect Git/Mercurial hash by checking the length.
252 If it's a hash, use the first 8 characters in the label
253 while retaining the full length to be used in hyperlinks.
255 * public/js/helper-classes.js:
256 (.this.formattedRevisions):
259 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
261 Add an instruction on how to backup the database.
262 https://bugs.webkit.org/show_bug.cgi?id=133391
264 Rubber-stamped by Andreas Kling.
268 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
270 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
272 * public/js/helper-classes.js:
273 (PerfTestRuns.smallerIsBetter):
275 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
285 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
287 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
288 https://bugs.webkit.org/show_bug.cgi?id=131157
290 Reviewed by Andreas Kling.
292 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
293 This allows, for example, adding all metrics such as Arithmetic and Geometric for
294 a given test suite without also adding its subtests.
300 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
302 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
303 https://bugs.webkit.org/show_bug.cgi?id=131155
305 Reviewed by Andreas Kling.
307 The bug was caused by Chart.attach binding event listeners on plot container on each call.
308 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
309 click when attach() has been called even number of times, keeping the tooltip invisible.
311 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
312 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
313 is called for the first time.
317 (Chart..bindPlotEventHandlers):
319 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
321 WebKitPerfMonitor: Tooltips can be cut off at the top
322 https://bugs.webkit.org/show_bug.cgi?id=130960
324 Reviewed by Andreas Kling.
327 (#title): Removed the gradients, box shadows, and border from the header.
328 (#title h1): Reduce the font size.
329 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
331 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
332 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
333 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
334 * public/js/helper-classes.js:
335 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
336 tooltip extending above y=0.
338 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
340 WebKitPerfMonitor: Y-axis adjustment is too aggressive
341 https://bugs.webkit.org/show_bug.cgi?id=130937
343 Reviewed by Andreas Kling.
345 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
346 results. This had two major problems:
347 1. Two standard deviations can be too small to show the confidence interval for results.
348 2. Sometimes baseline and target can be more than two standards deviations away.
350 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
351 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
352 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
353 the margin on each side separately to reduce the empty space on either side.
355 A more rigorous approach would involve computing least squared value of results with respect to intervals
356 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
359 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
360 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
361 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
362 We wouldn't see the difference between measured values versus baseline and target values otherwise.
363 * public/js/helper-classes.js:
364 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
365 interval delta cannot be computed.
366 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
367 within the given interval.
368 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
369 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
370 (PerfTestRuns..unscaledMeansForAllResults):
371 (PerfTestRuns.min): Take the confidence interval delta into account.
372 (PerfTestRuns.max): Ditto.
373 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
374 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
376 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
378 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
380 Some CSS tweaks after r166477 and r166479,
384 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
386 WebKitPerfMonitor: Sometimes text inside panes overlap
387 https://bugs.webkit.org/show_bug.cgi?id=130956
389 Reviewed by Gyuyoung Kim.
391 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
392 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
393 reduces the total height of the pane and fits more information per screen capita on the dashboard.
395 * public/index.html: Updated and added a bunch of CSS rules for the new look.
396 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
397 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
398 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
399 of the build info shown in a chart pane and a tooltip.
400 (Chart): Made .status a table.
401 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
402 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
403 now that status.text no longer contains it.
404 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
406 * public/js/helper-classes.js:
407 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
408 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
409 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
410 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
411 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
412 capital letter; e.g. "MB" instead of "M B".
414 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
416 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
417 https://bugs.webkit.org/show_bug.cgi?id=130957
419 Reviewed by Gyuyoung Kim.
421 Moved the slider into the header. Also reduced the spacing between the header and platform names.
422 This reclaims 50px × width of the screen real estate.
425 (#title): Reduced the space below the header from 20px to 10px.
427 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
428 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
429 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
430 real estate between the header and the platform names.
432 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
434 Update the install guidelines for perf.webkit.org
435 https://bugs.webkit.org/show_bug.cgi?id=129895
437 Reviewed by Ryosuke Niwa.
439 The current install guideline for perf.webkit.org discourages the use of the installed
440 Server application. I've actualized the documentation for Mavericks, and modified the
441 guideline to include the instructions for Server.app also.
445 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
447 Update perf.webkit.org json example
448 https://bugs.webkit.org/show_bug.cgi?id=129907
450 Reviewed by Andreas Kling.
452 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
456 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
458 Merge database-common.js and utility.js into run-tests.js.
460 Reviewed by Matthew Hanson.
462 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
463 Also moved init-database.sql out of the database directory and removed the directory entirely.
466 * database/database-common.js: Removed.
467 * database/utility.js: Removed.
468 * init-database.sql: Moved from database/init-database.sql.
470 (connect): Moved from database-common.js.
471 (pathToDatabseSQL): Extracted from pathToLocalScript.
472 (pathToTests): Moved from database-common.js.
475 (SerializedTaskQueue): Ditto.
477 (initializeDatabase):
478 (TestEnvironment.it):
479 (TestEnvironment.queryAndFetchAll):
482 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
484 Remove the dependency on node.js from the production code.
486 Reviewed by Ricky Mondello.
488 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
490 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
491 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
492 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
493 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
494 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
496 Also removed the js files that are no longer used.
498 * config.json: Moved from database/config.json.
499 * database/aggregate.js: Removed. No longer used.
500 * database/database-common.js: Removed unused functions, and updated the path to config.json.
501 * database/process-jobs.js: Removed. No longer used.
502 * database/sample-data.sql: Removed. We have a much better corpus of data now.
503 * database/schema.graffle: Removed. It's completely obsolete.
504 * public/include/db.php: Updated the path to config.json.
505 * public/include/evaluator.js: Removed.
507 * public/include/report-processor.php:
508 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
509 storing values into $expressions and calling evaluate_expressions_by_node.
510 (TestRunsGenerator::aggregate_values): Added.
511 (TestRunsGenerator::compute_caches): Directly compute the caches.
513 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
515 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
517 * public/admin/platforms.php:
518 * public/include/db.php:
520 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
522 Zoomed y-axis view is ununsable when the last result is an outlier.
524 Reviewed by Stephanie Lewis.
526 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
527 the last result so that the graph looks sane if the last result was an outlier. However, always show
528 the last result's mean even if it was an outlier.
531 * public/js/helper-classes.js:
532 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
533 Also added the ability to cache the unscaled means to avoid recomputation.
534 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
535 (PerfTestRuns.max): Ditto.
536 (PerfTestRuns.sampleStandardDeviation): Ditto.
537 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
539 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
543 * public/admin/tests.php:
544 * public/js/helper-classes.js:
546 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
548 Use two standard deviations instead as I mentioned in the mailing list.
552 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
554 The performance dashboard erroneously shows upward arrow for combined metrics.
556 A single outlier can ruin the zoomed y-axis view.
558 Rubber-stamped by Antti Koivisto.
561 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
562 from the latest results' mean.
563 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
564 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
566 * public/js/helper-classes.js:
567 (PerfTestRuns.sampleStandardDeviation): Added.
568 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
570 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
572 Don't include the confidence interval when computing the y-axis.
574 Rubber-stamped by Simon Fraser.
576 * public/js/helper-classes.js:
580 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
582 Tiny CSS tweak for tooltips.
586 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
588 Remove the erroneously repeated code.
590 * public/admin/test-configurations.php:
592 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
594 <rdar://problem/15704893> perf dashboard should show baseline numbers
596 Reviewed by Stephanie Lewis.
598 * public/admin/bug-trackers.php:
599 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
602 * public/admin/platforms.php:
605 * public/admin/test-configurations.php: Added.
606 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
607 build_revisions as they're not meaningful for baseline / target numbers.
608 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
609 one test run so that we don't accidentally delete a reported test run.
610 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
611 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
612 and delete existing ones.
614 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
615 on each platform; there could be configurations of distinct types such as "current" and "baseline".
616 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
618 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
619 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
620 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
621 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
622 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
624 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
626 * public/include/admin-header.php:
627 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
628 have id and type sub columns, and each custom column could generate multiple rows.
630 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
631 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
632 We then proceed to generate the second header row with sub column names.
634 When generating the actual content, we first generate all custom columns as they may have multiple rows in
635 which case regular columns need rowspan set to the maximum number of rows.
637 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
640 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
641 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
642 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
643 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
644 expanded to occupy all sub columns.
646 * public/include/manifest.php:
647 (ManifestGenerator::platforms): Don't add the metric more than once.
649 * public/include/test-name-resolver.php:
650 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
651 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
652 full metric name later.
653 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
654 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
655 (TestNameResolver::full_name_for_test): Added.
656 (TestNameResolver::full_name_for_metric): Added.
657 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
659 * public/js/helper-classes.js:
660 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
661 test runs created to set baseline and target points.
663 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
665 Build fix after r57928. Removed a superfluous close parenthesis.
667 * public/api/runs.php:
669 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
671 Unreviewed build & typo fixes.
673 * public/admin/platforms.php:
674 * tests/admin-platforms.js:
676 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
678 <rdar://problem/15704893> perf dashboard should show baseline numbers
680 Rubber-stamped by Antti Koivisto.
682 Organize some code into functions in runs.php.
684 Also added back $paths that was erroneously removed in r57925 from json-header.php.
686 * public/api/runs.php:
687 (fetch_runs_for_config): Extracted.
690 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
692 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
694 * database/config.json:
695 * public/admin/reprocess-report.php:
696 * public/api/report.php:
697 * public/api/runs.php:
698 * public/include/json-header.php:
700 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
702 Commit yet another forgotten change.
704 Something went horribly wrong with my merge :(
706 * database/init-database.sql:
708 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
710 Commit one more forgotten change. Sorry for making a mess here.
712 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
714 Commit the forgotten files.
716 * public/admin/platforms.php: Added.
717 * tests/admin-platforms.js: Added.
719 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
721 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
723 Reviewed by Stephanie Lewis.
725 Added /admin/platforms/ page to hide and merge platforms.
727 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
728 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
729 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
730 each test configuration a distinct "test run" for each build.
732 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
733 their test configurations into platform B.
735 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
736 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
737 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
738 in platform B, in which case R should relate to T_B instead.
740 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
741 new platform. We then migrate the test configurations of the remaining test runs.
743 * database/init-database.sql: Added platform_hidden.
745 * public/admin/platforms.php: Added.
746 (merge_platforms): Added. Implements the algorithm described above.
749 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
750 is hidden since it doesn't do anything.
752 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
753 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
754 missing it since unchecked checkbox doesn't set the value in $_POST.
755 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
756 switch statement instead of repeated if's.
757 (AdministrativePage::render_table): Emit "update-column" for update_field.
759 * public/include/db.php: Disable warnings when we're not in the debug mode.
761 * public/include/manifest.php:
762 (ManifestGenerator::platforms): Skip platforms that have been hidden.
765 (TestEnvironment.postJSON):
766 (TestEnvironment.httpGet):
767 (TestEnvironment.httpPost): Added.
768 (sendHttpRequest): Set the content type if specified.
770 * tests/admin-platforms.js: Added tests.
772 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
774 Extract the code to compute full test names from tests.php.
776 Reviewed by Stephanie Lewis.
778 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
779 and paves our way to re-use the code in other pages.
781 * public/admin/tests.php:
783 * public/include/db.php:
784 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
785 tests.php and test-name-resolver.php.
787 * public/include/test-name-resolver.php: Added.
788 (TestNameResolver::__construct):
789 (TestNameResolver::compute_full_name): Moved from tests.php.
790 (TestNameResolver::map_metrics_to_tests): Ditto.
791 (TestNameResolver::sort_tests_by_full_name): Ditto.
792 (TestNameResolver::tests): Added.
793 (TestNameResolver::test_id_for_full_name): Ditto.
794 (TestNameResolver::metrics_for_test_id): Ditto.
795 (TestNameResolver::child_metrics_for_test_id): Ditto.
796 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
798 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
800 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
802 Reviewed by Stephanie Lewis.
804 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
806 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
807 but that's sufficient to correct the wrongfully processed reports for now.
809 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
810 We should eventually add a nice UI to find and reprocess reports.
812 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
814 * public/include/db.php: Added the forgotten call to prefixed_column_names.
816 * public/include/report-processor.php: Copied from public/api/report.php.
817 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
818 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
819 create a new report or authenticate the builder password (the password is never stored in the report).
820 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
821 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
822 (ReportProcessor::store_report): Ditto.
824 * tests/admin-reprocess-report.js: Added.
826 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
828 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
830 Reviewed by Ricky Mondello.
832 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
833 for the same build number as a single build by ignoring build time. This was necessary to associate
834 multiple reports by a single build - e.g. for different performance test suites - because the scripts
835 we use to submit results computed its own "build time" when they're called.
837 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
838 last week; new reports were wrongfully associated with old build numbers.
840 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
841 to the same build. Instead, we create a new build object for those reports. Since the longest set of
842 tests we have only take a couple of hours to run, 24 hours should be more than enough.
844 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
845 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
846 (builder, build number, build time).
848 * public/api/report.php:
849 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
850 when no such build exists. This prevents a report from being associated with a very old build of the same
853 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
854 a similar bug in the future sooner.
856 * tests/api-report.js: Added three test cases.
858 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
860 Merged the upstream changes to db.php
861 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
863 * public/include/db.php:
865 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
867 Update other scripts and tests per previous patch.
869 * public/include/manifest.php:
870 * tests/admin-regenerate-manifest.js:
872 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
876 Reviewed by Ricky Mondello.
878 This column is no longer used by the front-end code since r48360.
880 * database/init-database.sql:
881 * public/admin/tests.php:
883 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
885 Unreviewed build fix.
887 * public/api/report.php:
889 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
891 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
893 Reviewed by Ricky Mondello.
895 Support a new alternative format for aggregated results where we have raw values as well as
896 the list aggregators so that instead of
897 "metrics": {"Time": ["Arithmetic"]}
899 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
901 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
902 dashboard and the generated results page, which doesn't know how to aggregate values.
904 We need to keep the support for the old format because all other existing performance tests
905 all rely on the old format. Even if we updated the tests, we need the dashboard to support
906 the old format during the transition.
908 * public/api/report.php:
909 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
910 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
912 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
914 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
916 Unreviewed; Tweak the CSS so that chart panes align vertically.
920 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
922 SafariPerfMonitor should support Combined metric.
924 * public/js/helper-classes.js:
925 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
926 value as well but assume it to be greater-is-better for now.
928 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
930 Commit the forgotten init-database change to add iteration_relative_time.
932 * database/init-database.sql:
934 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
936 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
938 Reviewed by Ricky Mondello.
940 Add the support for each value to have a relative time. This is necessary for frame rate history
941 since a frame rate needs to be associated with a time it was sampled.
943 * database/init-database.sql: Added iteration_relative_time to run_iterations.
945 * public/api/report.php:
946 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
947 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
948 with relative time since taking the average of two frame rates for two subtests taken at two
949 different times doesn't make any sense.
950 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
951 etc..., use the second element since we assume values are of the form (relative time, frame rate).
952 Also exit early with an error if the number of elements in the array is not a pair.
953 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
955 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
956 iteration_relative_time.
958 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
960 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
962 Reviewed by Ricky Mondello.
964 Support that. It's one line change.
966 * public/api/report.php:
967 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
968 to match the convention assumed elsewhere.
969 * tests/api-report.js: Added a test case.
971 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
973 SafariPerfMonitor shows popups for points outside of the visible region.
975 Rubber-stamped by Simon Fraser.
978 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
979 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
980 may return an item underneath y-axis labels.
982 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
984 Tweak the CSS a little to avoid the test name overlapping with the summary table.
988 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
990 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
994 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
996 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
997 <rdar://problem/13992271> Should scale Y axis to include error ranges
999 Reviewed by Ricky Mondello.
1001 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
1002 the main graph doesn't go outside the graph even when the y-axis is adjusted.
1004 * database/config.json:
1005 * public/index.html:
1006 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
1007 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
1008 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
1010 * public/js/helper-classes.js:
1011 (PerfTestResult.confidenceIntervalDelta):
1012 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
1013 (PerfTestRuns.min): Take confidence interval delta into account.
1014 (PerfTestRuns.max): Ditto.
1015 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
1017 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1019 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
1021 * public/api/report.php:
1022 (ReportProcessor::recursively_ensure_tests):
1023 * tests/api-report.js: Added a test.
1025 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1027 Unreviewed build fixes.
1029 * public/api/report.php:
1030 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
1031 Also, tolerate reports without any revision information.
1033 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
1036 * tests/api-report.js: Added few test cases.
1038 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1040 Commit another change that was supposed to be committed in r50331.
1043 (TestEnvironment.this.postJSON):
1044 (TestEnvironment.this.httpGet):
1047 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
1049 Commit the remaining files.
1051 * public/admin/regenerate-manifest.php:
1052 * public/include/admin-header.php:
1053 * public/include/json-header.php:
1054 * public/include/manifest.php:
1056 (TestEnvironment.this.postJSON):
1057 (TestEnvironment.this.httpGet):
1060 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
1062 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
1064 Reviewed by Ricky Mondello.
1066 Added some tests for admin/regenerate-manifest.
1068 * public/admin/regenerate-manifest.php: Use require_once instead of require.
1069 * public/include/admin-header.php: Ditto.
1070 * public/include/json-header.php: Ditto.
1072 * public/include/manifest.php:
1073 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
1074 When there are no builders, simply return an empty array.
1077 (TestEnvironment.postJSON):
1078 (TestEnvironment.httpGet): Added.
1079 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
1081 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
1083 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
1085 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
1086 and run_iterations. Also fixed a typo in report.php found by new tests.
1088 * public/api/report.php:
1089 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
1090 * tests/api-report.js: Added more test cases.
1092 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
1094 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
1096 Reviewed by Ricky Mondello.
1098 Add a test runner script and some simple test cases.
1100 * database/config.json: Added the configuration for "testServer".
1101 * database/database-common.js:
1102 (pathToTests): Added.
1103 * run-tests.js: Added.
1106 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
1107 and if there are, asks the user if it’s okay to delete all of the data contained therein.
1108 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
1110 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
1111 in the current database using PostgreSQL's information_schema.
1112 (askYesOrNoQuestion):
1114 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
1116 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
1117 (TestEnvironment.assert): Exposes assert to tests.
1118 (TestEnvironment.console): Exposes console to tests.
1119 (TestEnvironment.describe): Adds a description.
1120 (TestEnvironment.it): Adds a test case.
1121 (TestEnvironment.postJSON):
1122 (TestEnvironment.queryAndFetchAll):
1123 (TestEnvironment.sha256):
1124 (TestEnvironment.notifyDone): Ends the current test case.
1128 (TestContext): An object created for each test case. Conceptually, this object is always on
1129 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
1130 this object via currentTestContext.
1131 (TestContext.description):
1133 (TestContext.logError):
1136 * tests/api-report.js: Added some basic tests for /api/report.php.
1138 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1140 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
1142 The problem was that we were detecting whether we're updating dashboard or not by checking
1143 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
1144 all configurations. Use separate 'dashboard' action to execute the code even when
1145 metric_configurations is empty.
1147 * public/admin/tests.php:
1149 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1151 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
1153 Reviewed by Ricky Mondello.
1155 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
1156 from ReportProcessor as a preparation to replace deprecated aggregate.js.
1158 * public/api/report.php:
1159 (ReportProcessor::exit_with_error): Moved.
1160 (ReportProcessor::process): Use the extracted TestRunsGenerator.
1161 (TestRunsGenerator): Added.
1162 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
1163 (TestRunsGenerator::add_aggregated_metric): Moved.
1164 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
1165 (TestRunsGenerator::aggregate): Moved. Made public.
1166 (TestRunsGenerator::aggregate_current_test_level): Moved.
1167 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
1168 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
1169 (TestRunsGenerator::compute_caches): Moved. Made public.
1170 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
1171 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1172 (TestRunsGenerator::rollback_with_error): Moved.
1174 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1176 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1178 Reviewed by Remy Demarest.
1180 Regenerate the manifest file when updating fields or adding new items that are included in
1183 * public/admin/bug-trackers.php:
1184 * public/admin/builders.php:
1185 * public/admin/regenerate-manifest.php:
1186 * public/admin/repositories.php:
1187 * public/admin/tests.php:
1188 * public/include/admin-header.php:
1189 (regenerate_manifest): Extracted from regenerate-manifest.php.
1191 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1193 Unreviewed build fix for memory test results.
1195 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1196 aggregating at each level.
1198 * public/api/report.php:
1199 (ReportProcessor::recursively_ensure_tests):
1200 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1201 (ReportProcessor::add_values_for_aggregation):
1202 (ReportProcessor::aggregate):
1203 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1205 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1207 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1208 not the number of iteration groups. Also, don't set group number when the entire run belongs
1209 a single iteration group.
1211 * public/api/report.php:
1212 (ReportProcessor::commit):
1214 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1216 SafariPerfMonitor: Introduce iteration groups
1218 Reviewed by Remy Demarest.
1220 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1221 the runtime environment variances to get more stable results. And it's desirable to keep track of
1222 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1224 This patch introduces "iteration groups" to keep track of this extra information.
1226 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1227 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1230 * database/init-database.sql: Add iteration_group column.
1231 * public/api/report.php:
1232 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1234 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1235 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1236 that we can restore the iteration groups before passing it to node.js and restore them later.
1238 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1239 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1241 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1242 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1243 that each iteration group in T1 and T2 have the same size:
1244 T1 = [[1, 2], [3, 4, 5]]
1245 T2 = [[6, 7], [8, 9, 10]]
1247 so that the aggregated result (the sum in this case) can have the same groups as in:
1248 T = [[7, 9], [11, 13, 15]]
1250 If some iteration groups in T1 and T2 had a different size as in:
1251 T1 = [[1, 2, 3], [4, 5]]
1252 T2 = [[6, 7], [8, 9, 10]]
1254 Then iteration groups of the aggregated T is ambiguous.
1256 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1257 (ReportProcessor::commit): Store iteration_group values.
1259 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1261 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1262 migrated to perf.webkit.org.
1264 * database/perf-webkit-migrator.js: Removed.
1266 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1268 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1270 * public/index.html:
1273 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1275 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1277 Reviewed by Ricky Mondello.
1279 It is often desirable to see charts of a given test for all platforms, or to be able to see
1280 charts of all subtests on a given platform when trying to triage perf. regressions.
1282 Support this use case by adding the ability to do so on the charts page.
1284 Also, we used to disable items on the test list based on the platform chosen. This turned out
1285 to be a bad UI because in many situations you want to be able to compare results of the same test
1286 on multiple platforms.
1288 In this new UI, we have three select elements, each of which selects the following:
1289 1. Top-level test - Test suite such as Dromaeo
1290 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1291 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1292 3. Platform - Mountain Lion, Qt, etc...
1294 A user can select "all" for metric and platform but we disallow doing both at once since adding
1295 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1296 think of a use case where you want to look at that many charts at once. We can support this later
1297 if valid use cases come up.
1299 * public/index.html:
1300 (.showCharts.addOption): Extracted.
1301 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1302 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1303 metricList has onchange handler that enables/disables items on platformList.
1305 (init): Sort tests and test metrics here instead of doing that in showCharts.
1307 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1309 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1311 Reviewed by Remy Demarest and Ricky Mondello.
1313 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1314 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1315 templates to the manifest file instead. Each build now only contains the builder id.
1317 * public/api/runs.php: Removed the part of the query that joined builders table. This
1318 speeds up the query quite a bit.
1320 * public/include/manifest.php:
1321 (ManifestGenerator::generate): Generate builders field.
1322 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1323 associative array that contains name and its build URL template.
1325 * public/index.html:
1326 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1327 instead of a revision since this function is used for revisions and build page URLs now.
1328 (.buildLabelWithLinks): Include the linkified build number.
1330 * public/js/helper-classes.js:
1331 (TestBuild.builder): Added.
1332 (TestBuild.buildNumber): Added.
1333 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1334 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1336 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1338 Tooltips interfere with user interactions
1340 Rubber-stamped by Simon Fraser.
1342 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1343 Also, show graphs for only 10 days by default as opposed to 20.
1344 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1346 * public/index.html:
1347 * public/js/helper-classes.js:
1349 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1351 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1352 to be compatible with webkit-perf.appspot.com.
1354 * public/admin/builders.php:
1355 * public/api/report.php:
1357 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1361 Add a missing constraint on builds table. For a given builder, there should be exactly
1362 one build for a given build number.
1364 Also add report_committed_at to reports table to record the time at which a given report
1365 was processed and test_runs and run_iterations rows were committed into the database.
1367 * database/config.json:
1368 * public/api/report.php:
1370 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1372 Unreviewed. Add more checks for empty SQL query results.
1374 * public/include/manifest.php:
1376 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1378 More build fixes on perf.webkit.org.
1380 * public/api/runs.php: Make PostgreSQL happier.
1381 * public/include/manifest.php: Don't assume we always have bug trackers.
1383 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1385 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1386 and fix other miscellaneous UI bugs.
1388 Rubber-stamped by Simon Fraser.
1390 Removed the code to determine whether smaller value is better or not for a given test in index.html
1391 in the favor of using that of PerfTestRuns.
1393 * public/include/manifest.php: Fixed a typo.
1394 * public/index.html:
1396 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1398 * public/js/helper-classes.js:
1399 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1401 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1402 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1403 at roughly 2,000 units to avoid this.
1405 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1406 The only thing we can avoid is innerHTML.
1408 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1410 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1412 * public/include/evaluator.js:
1414 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1416 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1418 Reviewed by Remy Demarest.
1420 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1421 admin/bug-trackers.php and can be associated with multiple repositories.
1423 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1424 to determine the set of bug trackers to show for a given set of blame lists.
1425 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1426 a place to file bugs against the regression.
1428 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1429 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1431 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1432 bug trackers, namely associated repositories.
1434 * public/include/admin-header.php: Added a link to bug-trackers.php
1435 * public/include/manifest.php:
1436 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1437 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1439 (ManifestGenerator::repositories):
1441 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1442 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1443 'repositories' where the latter contains the list of associated repository names.
1445 * public/index.html:
1446 (Chart): Takes bugTrackers as as argument.
1447 (Chart.showTooltipWithResults): Removed the hard-coded list.
1449 (init.addPlatformsToDashboard):
1450 (init.showCharts.createChartFromListPair):
1451 (init): Stores the list of bug trackers in the manifest to a local variable.
1453 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1455 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1457 * public/include/evaluator.js:
1459 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1461 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1463 Reviewed by Remy Demarest.
1465 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1466 new row into the database.
1468 * public/admin/aggregators.php: Use AdministrativePage.
1469 * public/admin/builders.php: Ditto.
1470 * public/admin/repositories.php: Ditto.
1471 * public/include/admin-header.php:
1472 (AdministrativePage): Added.
1473 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1474 to an associative array that describes the column.
1475 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1476 - label: Human readable name of the column.
1477 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1478 column exists only before we create password_hash column at the insertion time.
1480 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1481 titlecase (e.g. new_bug is converted to New Bug).
1482 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1483 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1484 textarea for a given editing mode ('text', 'url', or 'string').
1485 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1486 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1488 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1490 Build fix. Some systems don't support r+. Use proc_open instead.
1492 * public/api/report.php:
1494 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1496 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1497 when computing the y-axis of data points to show tooltips at.
1499 * public/index.html:
1501 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1503 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1506 * public/.htaccess: Removed.
1508 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1512 * public/include/manifest.php: Build fix. db is on this.
1513 * public/js/statistics.js:
1514 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1516 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1518 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1520 Reviewed by Anders Carlsson.
1522 Rewrote and merged populate-from-report.js into report.php.
1524 * database/config.json: Added a path to node.js.
1526 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1527 Once we land this patch and update the administrative pages, we can remove this column.
1529 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1530 that table is going away once we remove the node.js backend.
1532 * database/populate-from-report.js: Removed.
1533 * public/api/report.php: Added.
1535 (ReportProcessor.__construct):
1536 (ReportProcessor.process):
1538 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1539 verified to be submitted by a known builder.
1541 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1542 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1543 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1544 inside a transaction because there could be multiple reports for a single build, each containing results for
1547 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1548 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1549 add_values_to_commit, and add_values_for_aggregation.
1551 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1552 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1553 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1556 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1557 to be aggregated in ReportProcessor.aggregate.
1559 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1561 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1562 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1563 given for each row (child metrics of M). This function extracts each column (iteration) via
1564 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1565 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1567 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1568 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1569 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1571 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1572 (ReportProcessor.evaluate_expressions_by_node): See above.
1574 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1575 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1576 results also need the said caches.
1578 (ReportProcessor.add_values_to_commit):
1580 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1581 the transaction as needed if anything goes wrong.
1583 (ReportProcessor.rollback_with_error)
1585 * public/include/db.php:
1586 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1587 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1588 contiguously in a SQL statement.
1590 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1591 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1592 a column value of the choice.
1594 (Database.begin_transaction): Added.
1595 (Database.commit_transaction): Added.
1596 (Database.rollback_transaction): Added.
1598 * public/include/evaluator.js: Added.
1599 * public/include/json-header.php:
1600 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1601 context under which the request failed.
1602 (successful_exit): Merge "additional details".
1603 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1604 (merge_additional_details):
1606 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1608 SafariPerfMonitor: Add more helper functions to db.php
1610 Reviewed by Remy Demarest.
1612 Added Database::insert_row and array_get to make common database operations easier.
1614 * public/admin/aggregators.php: Use Database::insert_row instead of
1615 execute_query_and_expect_one_row_to_be_affected.
1617 * public/admin/builders.php: Ditto.
1619 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1620 inserting a row. With insert_row, we don't need that.
1622 * public/include/admin-header.php: Ditto.
1624 * public/include/db.php:
1625 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1626 return the default value (defaults to NULL) if the key doesn't exist.
1628 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1631 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1632 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1633 column names all in the same order.
1635 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1636 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1637 column names and values are corresponding values. When the row is successfully inserted, it returns
1638 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1639 indicating the success of the insertion.
1641 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1643 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
1645 Reviewed by Conrad Shultz.
1647 Rewrote the manifest generator in PHP.
1649 * database/generate-manifest.js: Removed.
1650 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
1651 * public/include/db.php:
1652 (array_ensure_item_has_array): Added.
1653 * public/include/evaluator.js: Added.
1654 * public/include/json-header.php:
1655 * public/include/manifest.php: Added.
1657 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1659 Dates on overflow plot are overlapping
1661 Rubber-stamped by Simon Fraser.
1663 Don't show more than 5 days.
1665 * public/index.html:
1666 * public/js/helper-classes.js:
1667 (TestBuild.UTCtoPST):
1670 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1672 Show build time as well as commit time on the dashboard and tooltips.
1674 Rubber-stamped by Simon Fraser.
1676 Include both the maximum commit time and build time in buildLabelWithLinks.
1677 Also use ISO format to save the screen real estate.
1679 * public/index.html:
1680 (buildLabelWithLinks):
1681 * public/js/helper-classes.js:
1683 (TestBuild.buildTime):
1684 (TestBuild.formattedBuildTime):
1686 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
1688 Unreviewed; Convert metric.name to metric.unit in the front end.
1690 * public/js/helper-classes.js:
1692 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1694 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
1696 Rubber-stamped by Simon Fraser.
1698 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
1699 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
1700 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
1702 * public/index.html:
1703 (.buildLabelWithLinks): Extracted from TestBuild.label.
1704 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
1705 on Radar and WebKit Bugzilla.
1706 * public/js/helper-classes.js:
1707 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
1708 (PerfTestResult.isBetterThan): Added.
1709 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
1710 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
1711 to indicate progressions or regressions.
1712 (PerfTestResult.label):
1713 (TestBuild.formattedTime): Added.
1714 (TestBuild.platform): Added.
1715 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
1716 (TestBuild.smallerIsBetter): Added.
1717 (Tooltip.show): Take a raw markup instead of two results.
1719 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
1721 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
1723 Rubber-stamped by Tim Horton.
1725 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
1726 since each platform may have a different number of tests to be shown on the dashboard.
1728 * public/index.html:
1730 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1732 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
1734 * public/js/helper-classes.js:
1737 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1739 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
1741 Rubber-stamped by Tim Horton.
1743 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
1745 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
1746 the revision r1234 was the revision used in the previous build.
1748 * public/api/runs.php:
1749 (parse_revisions_array): Trim double quotations around repository names and revisions.
1750 * public/js/helper-classes.js:
1753 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1755 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
1757 Rubber-stamped by Tim Horton.
1759 * public/index.html:
1760 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
1761 on the dashboard page as it's way too noisy.
1763 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
1765 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
1766 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
1767 so that the tooltip for hover can be reused further.
1769 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
1770 and find the first point that lies on the right of the cursor position. We then compute the midpoint
1771 between this and the previous point and pick the closer of the two. It returns an item-like object
1772 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
1774 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
1776 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
1777 the first or "current" data points (as opposed to target or baseline data points).
1779 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
1780 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
1781 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
1783 * public/js/helper-classes.js:
1784 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
1785 work to the client via bindClick.
1787 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
1789 (Tooltip.bindClick): Added.
1791 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1793 Yet another build fix. metricId*s*.
1795 * public/admin/tests.php:
1797 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1799 Another build fix. Use the new payload format for the aggregate job.
1801 * public/admin/tests.php:
1803 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1807 * database/aggregate.js: Use variables that actually exist.
1808 * database/database-common.js:
1809 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
1810 function calls will find this configuration.
1812 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1814 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
1816 Reviewed by Ricky Mondello.
1818 Turned InstallManual into a proper markdown document and added ReadMe.md.
1820 * InstallManual: Removed.
1821 * InstallManual.md: Moved from InstallManual.
1824 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1826 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
1828 Reviewed by Ricky Mondello.
1830 This patch prepares the front end code to process baseline and target results properly.
1832 * public/index.html:
1833 (fetchTest.createRunAndResults): Extracted.
1834 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
1835 Deleted the comment about how sorting will be unnecessary once we start results in the server side
1836 since sorting by the maximum revision commit time turned out to be non-trivial in php.
1838 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1840 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
1842 Reviewed by Tim Horton.
1844 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
1845 These files are "dynamically linked" to our app.
1847 * public/index.html:
1848 * public/js/jquery-1.8.2.min.js: Removed.
1849 * public/js/jquery.colorhelpers.js: Added.
1850 * public/js/jquery.flot.categories.js: Added.
1851 * public/js/jquery.flot.crosshair.js: Added.
1852 * public/js/jquery.flot.errorbars.js: Added.
1853 * public/js/jquery.flot.fillbetween.js: Added.
1854 * public/js/jquery.flot.js: Added.
1855 * public/js/jquery.flot.min.js: Removed.
1856 * public/js/jquery.flot.navigate.js: Added.
1857 * public/js/jquery.flot.resize.js: Added.
1858 * public/js/jquery.flot.selection.js: Added.
1859 * public/js/jquery.flot.stack.js: Added.
1860 * public/js/jquery.flot.symbol.js: Added.
1861 * public/js/jquery.flot.threshold.js: Added.
1862 * public/js/jquery.flot.time.js: Added.
1863 * public/js/jquery.js: Added.
1865 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1867 Return NaN instead of throwing when there aren't enough samples.
1869 Reviewed by Sam Weinig.
1871 It's better to return NaN when we don't have enough samples so that we can treat it
1872 as if we don't have any confidence interval.
1874 * public/js/statistics.js:
1877 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1879 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
1881 * public/js/helper-classes.js:
1882 (URLState.parseIfNeeded):
1884 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1886 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
1888 Reviewed by Ricky Mondello.
1890 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
1892 * public/admin/aggregators.php: Use heredoc.
1893 * public/admin/builders.php:
1894 * public/admin/jobs.php:
1895 * public/admin/repositories.php:
1896 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
1897 This allows us to use update_field when updating test's url and metric's unit. Changed the action
1898 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
1899 Also removed a stray code to update unit and url simultaneously since it's never used.
1900 * public/include/admin-header.php:
1901 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
1902 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
1903 (update_field): Moved from repositories.php.
1905 * public/include/db.php:
1906 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
1908 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
1910 Build fixes. Treat mean, sum, and square sum as float, not int.
1912 Also use 95% confidence interval instead of 90% confidence interval.
1914 * public/api/runs.php:
1915 * public/js/helper-classes.js:
1916 (.this.confidenceIntervalDelta):
1918 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
1920 Add an administrative page to edit repository information.
1922 Reviewed by Ricky Mondello.
1924 * public/admin/repositories.php: Added.
1925 * public/include/admin-header.php:
1927 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
1929 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
1931 Reviewed by Ricky Mondello.
1933 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
1934 to aggregate results for those matrix in populate-from-report.js.
1936 * database/generate-manifest.js:
1937 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
1938 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
1939 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
1940 * database/populate-from-report.js:
1942 (getReport): No change even though the diff looks as if it moved.
1943 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
1944 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
1945 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
1946 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
1947 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
1949 (ensureMetricId): Take an aggregator id as an argument.
1950 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
1951 for all builds when the build id is not specified.
1952 * public/admin/tests.php:
1953 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
1954 of the same name with different aggregators.
1956 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
1958 Build fix. Don't pass in arguments to in the wrong order.
1960 * database/aggregate.js:
1962 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1964 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
1966 Reviewed by Ricky Mondello.
1968 Since the version of flot we use doesn't support showing graphs in the current locate or
1969 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
1970 treat them as in UTC). We don't want to use the current locate because other websites on
1971 webkit.org assume PST.
1973 Also append this information to build's label.
1975 * public/js/helper-classes.js:
1979 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1981 Store test URLs reported by builders.
1983 Reviewed by Ricky Mondello.
1985 * database/populate-from-report.js:
1986 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
1987 (ensureTestId): Store the URL.
1989 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
1991 Yet another build fix; don't blow up even if we didn't have any test configurations.
1993 * public/admin/tests.php:
1995 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1997 Build fix; don't instantiate Date when a timestamp wasn't provided.
1999 * database/populate-from-report.js:
2001 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
2003 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
2005 Reviewed by Tim Horton.
2007 Added an install manual.
2009 * InstallManual: Added.
2011 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
2013 Minor build fix. Don't unset builderPassword when it's not set.
2015 * public/api/report.php:
2017 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2019 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
2021 Reviewed by Ricky Mondello.
2023 * public/admin/admin.css: Make a very large payload scrollable.
2024 * public/admin/jobs.php: Format JSONs.
2026 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
2028 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
2030 Reviewed by Ricky Mondello.
2032 Add report.php and populate-from-report.js that process JSON files submitted by builders.
2034 * database/populate-from-report.js: Added.
2036 (getReport): Obtains the payload (the actual report) from "jobs" table.
2037 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
2038 and their results. This function recursively traverses tests and metrics and ensure their ids.
2040 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
2041 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
2042 is a "function" in mathematical sense).
2044 (ensureRepositoryIdsForAllRevisions):
2045 (getIdOrCreateBuildWithRevisions):
2046 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
2047 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
2048 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
2050 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
2051 test results all in a single transaction. This allows us to keep the database consistent in that either
2052 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
2053 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
2054 other parts of the application are concerned.
2055 (scheduleQueriesToInsertRun):
2056 * database/process-jobs.js: Add a call to populate-from-report.js.
2057 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
2058 * public/include/db.php: Support parameterized query.
2059 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
2060 a test result could confirm that the submission indeed succeeded.
2062 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2064 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
2066 * database/aggregate.js:
2067 * database/database-common.js:
2068 (selectColumnCreatingRowIfNeeded):
2069 (ensureRepositoryId):
2070 (ensureConfigurationIdFromList):
2071 * database/perf-webkit-migrator.js:
2074 (getOrCreateBuildId):
2076 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2078 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
2080 Reviewed by Ricky Mondello.
2082 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
2083 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
2085 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
2088 (saveAggregatedResults):
2089 * database/database-common.js:
2090 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
2091 (getIdOrCreateRepository): Ditto.
2092 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
2093 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
2094 * database/perf-webkit-migrator.js:
2095 * database/utility.js: Added.
2096 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
2097 from being executed.
2098 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
2099 call the callback passed into start().
2100 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
2101 (TaskQueue.addTask):
2103 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
2104 (SerializedTaskQueue.executeNextTask):
2105 (SerializedTaskQueue.addTask):
2106 (SerializedTaskQueue.start):
2108 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2110 Revert erroneously committed changes.
2112 * database/config.json:
2114 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2116 aggregator.js should be able to accept multiple metric ids and a single build id.
2118 Reviewed by Ricky Mondello.
2120 Make aggregator.js accept multiple ids and generate results for single build when bots are
2121 reporting new results.
2123 * database/aggregate.js:
2124 (parseArgv): Added. Returns an object containing the parsed representation of argv,
2125 which currently contains metricIDs and buildIds.
2126 (main): Use parseArgv and processConfigurations
2127 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
2128 (processPlatform.processConfigurations): Extracted.
2130 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2132 Add an administrative page for builders.
2134 Reviewed by Ricky Mondello.
2136 We need an administrative page to add and edit builder information.
2137 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
2139 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
2140 since we don't have plans to use those columns in near future. Also make builder_name unique
2141 as required by the rest of the app.
2142 * public/admin/builders.php: Added.
2143 * public/api/runs.php: Updated per the table rename.
2144 * public/include/admin-header.php: Added a link to builders.php.
2146 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
2148 Build fixes for r46982.
2150 * database/aggregate.js:
2151 (fetchConfigurations): Bind i so that it's not always metricIds.length.
2152 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
2153 (processBuild): Don't print "." until we've committed transactions. It's misleading.
2155 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2157 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
2159 * public/admin/aggregators.php:
2160 * public/admin/footer.php: Removed.
2161 * public/admin/header.php: Removed.
2162 * public/admin/index.php:
2163 * public/admin/jobs.php:
2164 * public/admin/tests.php:
2165 * public/api/json-header.php: Removed.
2166 * public/api/runs.php:
2167 * public/db.php: Removed.
2168 * public/include: Added.
2169 * public/include/admin-footer.php: Copied from public/admin/footer.php.
2170 * public/include/admin-header.php: Copied from public/admin/header.php.
2171 * public/include/db.php: Copied from public/db.php.
2172 * public/include/json-header.php: Copied from public/api/json-header.php.
2174 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2176 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2178 Reviewed by Ricky Mondello.
2180 Added the initial implementation of value aggregation.
2181 Also added abilities to configure the dashboard page in tests.php.
2183 * database/aggregate.js: Added.
2184 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2185 (TaskQueue.addTask):
2187 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2188 (SerializedTaskQueue.addTask):
2189 (SerializedTaskQueue.start):
2192 (fetchConfigurations):
2193 (fetchBuildsForPlatform):
2195 (testsWithDifferentIterationCounts):
2196 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2197 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2198 (getOrInsertConfiguration):
2200 * database/database-common.js:
2201 (fetchTable): Log an error as an error.
2202 (getOrCreateId): Extracted from perf-webkit-migrator.
2203 (statistics): Added.
2204 * database/perf-webkit-migrator.js:
2205 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2206 runs JSON since runs JSONs are generated on demand now.
2208 (getOrCreatePlatformId):
2209 (getOrCreateTestId):
2210 (getOrCreateConfigurationId):
2211 (getOrCreateRevisionId):
2212 (getOrCreateRepositoryId):
2213 (getOrCreateBuildId):
2214 * database/process-jobs.js:
2215 (processJob): Handle 'aggregate' type.
2217 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2219 Fix the dashboard after adding test_metrics.
2221 Reviewed by Ricky Mondello.
2223 Rename test to metrics in various functions and sort tests on the charts page.
2224 Also representing whether a test appears or not by setting a flag on dashboard
2225 was bogus because test objects are shared by multiple platforms. Instead, store
2226 dashboard platform list as intended by the manifest JSON.
2228 * public/index.html:
2229 (PerfTestRuns): Renamed test to metric.
2231 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2232 (fullName): Moved so that it appears above where it's called.
2233 * public/js/helper-classes.js:
2235 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2237 Update tests.php to reflect recent changes in the database schema.
2239 Reviewed by Conrad Shultz.
2241 Made the following changes to tests.php:
2242 1. Disallow adding metrics to tests without subtests.
2243 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2244 3. Linkified tests with subtests instead of showing all them at once.
2246 * public/admin/admin.css:
2247 (.action-field, .notice):
2249 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2250 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2251 (add_job): Extracted.
2252 * public/admin/tests.php: See above.
2253 (array_item_set_default): Added.
2254 (array_item_or_default): Renamed from get_value_with_default.
2255 (compute_full_name): Extracted.
2256 (sort_tests): Ditto.
2257 (map_metrics_to_tests): Ditto.
2259 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2261 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2263 Reviewed by Simon Fraser.
2265 Linkify the headers using metric.test.url when it's provided.
2267 * public/index.html:
2269 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2271 Use parameterized pg_query_params in query_and_fetch_all
2273 Reviewed by Conrad Shultz.
2275 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2277 * public/api/runs.php:
2279 (ctype_alnum_underscore): Added.
2281 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2283 Update the migration tool to support test_metrics.
2285 Reviewed by Mark Rowe.
2287 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2288 Also import run_iteration rows as runs JSON files now include individual values.
2290 * database/database-common.js:
2291 (addJob): Extracted.
2292 * database/perf-webkit-migrator.js:
2293 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2294 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2295 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2298 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2300 Build fix. Suppress "Undefined index" warning.
2302 * public/admin/tests.php:
2304 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2306 Fix a commit error in r46756. api/ should obviously be added under public/
2309 * api/json-header.php: Removed.
2310 * api/runs.php: Removed.
2311 * public/api: Copied from api.
2313 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2315 SafariPerfMonitor: Linkify revisions and revisions range
2316 <rdar://problem/12801010>
2318 Reviewed by Mark Rowe.
2320 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2321 since it needs to know "url" and "blameUrl".
2323 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2325 * public/index.html:
2326 * public/js/helper-classes.js:
2328 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2329 (TestBuild.label): Add labels for all revisions.
2333 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2335 Make the generation of "runs" JSON dynamic and support test_metrics.
2337 Reviewed by Mark Rowe.
2339 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2341 Since there could be hundreds, if not thousands, of tests for each configuration and users
2342 aren't necessarily interested in looking at all test results, it's much more efficient to
2343 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2344 when bots report new results (i.e. pushing).
2346 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2349 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2350 (exit_with_error): Added.
2351 (successful_exit): Added.
2352 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2353 * database/generate-runs.js: Removed.
2354 * database/process-jobs.js: No longer supports "runs".
2355 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2356 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2358 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2360 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2362 Update tests.php and sample-data.sql per addition of test_metrics.
2364 Rubber-stamped by Timothy Hatcher.
2366 Remove a useless code from tests.php that used to update the unit and the url of a test
2367 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2369 Also update the sample data to reflect the addition of test_metrics.
2371 * database/sample-data.sql:
2372 * public/admin/tests.php:
2374 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2376 Share more code between admin pages.
2378 Reviewed by Timothy Hatcher.
2380 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2381 between admin pages.
2383 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2384 to check the nullity of global $db now.
2386 * public/admin/aggregators.php:
2387 * public/admin/header.php:
2389 (execute_query_and_expect_one_row_to_be_affected): Added.
2390 * public/admin/index.php:
2391 * public/admin/jobs.php:
2392 * public/admin/tests.php:
2394 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2396 SafariPerfMonitor: Add admin page to edit aggregators
2397 <rdar://problem/12782687>
2399 Reviewed by Mark Rowe.
2401 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2403 * public/admin/aggregators.php: Added.
2404 * public/admin/header.php:
2405 * public/admin/jobs.php: Removed an erroneous hidden input element.
2407 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2409 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2411 * database/init-database.sql:
2413 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2415 SafariPerfMonitor: Allow multiple metrics per test
2416 <rdar://problem/12773506>
2418 Rubber-stamped by Mark Rowe.
2420 Introduce a new table test_metrics. This table represents metrics each test can have
2421 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2424 Updated admin/tests.php and index.html accordingly.
2426 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2428 * database/generate-manifest.js:
2429 (buildPlatformMapIfPossible):
2430 * database/generate-runs.js:
2432 * database/init-database.sql:
2433 * database/schema.graffle:
2434 * public/admin/admin.css:
2437 * public/admin/tests.php:
2438 * public/index.html:
2440 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2442 SafariPerfMonitor: Improve the webkit-perf migration tool
2443 <rdar://problem/12760882>
2445 Reviewed by Mark Rowe.
2447 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
2448 and we don't want to pause the whole importation process until the user comes back to decide whether
2451 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
2452 down to make modifications.
2454 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2455 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2457 * database/init-database.sql:
2458 * database/perf-webkit-migrator.js:
2459 (migrateTestConfig):
2460 * database/schema.graffle:
2461 * public/admin/admin.css:
2463 * public/admin/tests.php:
2465 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2467 Create a new performance dashboard
2468 <rdar://problem/12625582>
2470 Rubber-stamped by Mark Rowe.
2472 Add the initial implementation of the perf dashboard.
2475 * database/config.json: Added.
2476 * database/database-common.js: Added.
2481 (pathToLocalScript):
2483 * database/generate-manifest.js: Added.
2486 (buildPlatformMapIfPossible):
2487 (generateFileIfPossible):
2488 * database/perf-webkit-migrator.js: Added.
2489 * database/process-jobs.js: Added.
2490 * database/sample-data.sql: Added.
2491 * database/schema.graffle: Added.
2493 * public/admin: Added.
2494 * public/admin/README: Added.
2495 * public/admin/admin.css: Added.
2496 * public/admin/footer.php: Added.
2497 * public/admin/header.php: Added.
2498 * public/admin/index.php: Added.
2499 * public/admin/jobs.php: Added.
2500 * public/admin/tests.php: Added.
2501 * public/common.css: Added.
2502 * public/data: Added.
2503 * public/db.php: Added.
2504 * public/index.html: Added.
2506 * public/js/helper-classes.js: Added.
2507 * public/js/jquery-1.8.2.min.js: Added.
2508 * public/js/jquery.flot.min.js: Added.
2509 * public/js/jquery.flot.plugins.js: Added.
2510 * public/js/shared.js: Added.
2511 (fileNameFromPlatformAndTest):
2512 * public/js/statistics.js: Added.