1 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
3 Some CSS tweaks after r166477 and r166479,
7 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
9 WebKitPerfMonitor: Sometimes text inside panes overlap
10 https://bugs.webkit.org/show_bug.cgi?id=130956
12 Reviewed by Gyuyoung Kim.
14 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
15 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
16 reduces the total height of the pane and fits more information per screen capita on the dashboard.
18 * public/index.html: Updated and added a bunch of CSS rules for the new look.
19 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
20 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
21 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
22 of the build info shown in a chart pane and a tooltip.
23 (Chart): Made .status a table.
24 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
25 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
26 now that status.text no longer contains it.
27 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
29 * public/js/helper-classes.js:
30 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
31 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
32 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
33 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
34 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
35 capital letter; e.g. "MB" instead of "M B".
37 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
39 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
40 https://bugs.webkit.org/show_bug.cgi?id=130957
42 Reviewed by Gyuyoung Kim.
44 Moved the slider into the header. Also reduced the spacing between the header and platform names.
45 This reclaims 50px × width of the screen real estate.
48 (#title): Reduced the space below the header from 20px to 10px.
50 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
51 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
52 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
53 real estate between the header and the platform names.
55 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
57 Update the install guidelines for perf.webkit.org
58 https://bugs.webkit.org/show_bug.cgi?id=129895
60 Reviewed by Ryosuke Niwa.
62 The current install guideline for perf.webkit.org discourages the use of the installed
63 Server application. I've actualized the documentation for Mavericks, and modified the
64 guideline to include the instructions for Server.app also.
68 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
70 Update perf.webkit.org json example
71 https://bugs.webkit.org/show_bug.cgi?id=129907
73 Reviewed by Andreas Kling.
75 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
79 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
81 Merge database-common.js and utility.js into run-tests.js.
83 Reviewed by Matthew Hanson.
85 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
86 Also moved init-database.sql out of the database directory and removed the directory entirely.
89 * database/database-common.js: Removed.
90 * database/utility.js: Removed.
91 * init-database.sql: Moved from database/init-database.sql.
93 (connect): Moved from database-common.js.
94 (pathToDatabseSQL): Extracted from pathToLocalScript.
95 (pathToTests): Moved from database-common.js.
98 (SerializedTaskQueue): Ditto.
100 (initializeDatabase):
101 (TestEnvironment.it):
102 (TestEnvironment.queryAndFetchAll):
105 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
107 Remove the dependency on node.js from the production code.
109 Reviewed by Ricky Mondello.
111 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
113 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
114 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
115 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
116 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
117 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
119 Also removed the js files that are no longer used.
121 * config.json: Moved from database/config.json.
122 * database/aggregate.js: Removed. No longer used.
123 * database/database-common.js: Removed unused functions, and updated the path to config.json.
124 * database/process-jobs.js: Removed. No longer used.
125 * database/sample-data.sql: Removed. We have a much better corpus of data now.
126 * database/schema.graffle: Removed. It's completely obsolete.
127 * public/include/db.php: Updated the path to config.json.
128 * public/include/evaluator.js: Removed.
130 * public/include/report-processor.php:
131 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
132 storing values into $expressions and calling evaluate_expressions_by_node.
133 (TestRunsGenerator::aggregate_values): Added.
134 (TestRunsGenerator::compute_caches): Directly compute the caches.
136 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
138 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
140 * public/admin/platforms.php:
141 * public/include/db.php:
143 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
145 Zoomed y-axis view is ununsable when the last result is an outlier.
147 Reviewed by Stephanie Lewis.
149 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
150 the last result so that the graph looks sane if the last result was an outlier. However, always show
151 the last result's mean even if it was an outlier.
154 * public/js/helper-classes.js:
155 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
156 Also added the ability to cache the unscaled means to avoid recomputation.
157 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
158 (PerfTestRuns.max): Ditto.
159 (PerfTestRuns.sampleStandardDeviation): Ditto.
160 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
162 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
166 * public/admin/tests.php:
167 * public/js/helper-classes.js:
169 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
171 Use two standard deviations instead as I mentioned in the mailing list.
175 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
177 The performance dashboard erroneously shows upward arrow for combined metrics.
179 A single outlier can ruin the zoomed y-axis view.
181 Rubber-stamped by Antti Koivisto.
184 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
185 from the latest results' mean.
186 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
187 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
189 * public/js/helper-classes.js:
190 (PerfTestRuns.sampleStandardDeviation): Added.
191 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
193 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
195 Don't include the confidence interval when computing the y-axis.
197 Rubber-stamped by Simon Fraser.
199 * public/js/helper-classes.js:
203 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
205 Tiny CSS tweak for tooltips.
209 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
211 Remove the erroneously repeated code.
213 * public/admin/test-configurations.php:
215 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
217 <rdar://problem/15704893> perf dashboard should show baseline numbers
219 Reviewed by Stephanie Lewis.
221 * public/admin/bug-trackers.php:
222 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
225 * public/admin/platforms.php:
228 * public/admin/test-configurations.php: Added.
229 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
230 build_revisions as they're not meaningful for baseline / target numbers.
231 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
232 one test run so that we don't accidentally delete a reported test run.
233 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
234 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
235 and delete existing ones.
237 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
238 on each platform; there could be configurations of distinct types such as "current" and "baseline".
239 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
241 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
242 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
243 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
244 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
245 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
247 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
249 * public/include/admin-header.php:
250 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
251 have id and type sub columns, and each custom column could generate multiple rows.
253 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
254 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
255 We then proceed to generate the second header row with sub column names.
257 When generating the actual content, we first generate all custom columns as they may have multiple rows in
258 which case regular columns need rowspan set to the maximum number of rows.
260 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
263 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
264 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
265 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
266 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
267 expanded to occupy all sub columns.
269 * public/include/manifest.php:
270 (ManifestGenerator::platforms): Don't add the metric more than once.
272 * public/include/test-name-resolver.php:
273 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
274 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
275 full metric name later.
276 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
277 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
278 (TestNameResolver::full_name_for_test): Added.
279 (TestNameResolver::full_name_for_metric): Added.
280 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
282 * public/js/helper-classes.js:
283 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
284 test runs created to set baseline and target points.
286 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
288 Build fix after r57928. Removed a superfluous close parenthesis.
290 * public/api/runs.php:
292 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
294 Unreviewed build & typo fixes.
296 * public/admin/platforms.php:
297 * tests/admin-platforms.js:
299 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
301 <rdar://problem/15704893> perf dashboard should show baseline numbers
303 Rubber-stamped by Antti Koivisto.
305 Organize some code into functions in runs.php.
307 Also added back $paths that was erroneously removed in r57925 from json-header.php.
309 * public/api/runs.php:
310 (fetch_runs_for_config): Extracted.
313 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
315 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
317 * database/config.json:
318 * public/admin/reprocess-report.php:
319 * public/api/report.php:
320 * public/api/runs.php:
321 * public/include/json-header.php:
323 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
325 Commit yet another forgotten change.
327 Something went horribly wrong with my merge :(
329 * database/init-database.sql:
331 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
333 Commit one more forgotten change. Sorry for making a mess here.
335 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
337 Commit the forgotten files.
339 * public/admin/platforms.php: Added.
340 * tests/admin-platforms.js: Added.
342 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
344 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
346 Reviewed by Stephanie Lewis.
348 Added /admin/platforms/ page to hide and merge platforms.
350 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
351 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
352 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
353 each test configuration a distinct "test run" for each build.
355 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
356 their test configurations into platform B.
358 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
359 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
360 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
361 in platform B, in which case R should relate to T_B instead.
363 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
364 new platform. We then migrate the test configurations of the remaining test runs.
366 * database/init-database.sql: Added platform_hidden.
368 * public/admin/platforms.php: Added.
369 (merge_platforms): Added. Implements the algorithm described above.
372 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
373 is hidden since it doesn't do anything.
375 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
376 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
377 missing it since unchecked checkbox doesn't set the value in $_POST.
378 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
379 switch statement instead of repeated if's.
380 (AdministrativePage::render_table): Emit "update-column" for update_field.
382 * public/include/db.php: Disable warnings when we're not in the debug mode.
384 * public/include/manifest.php:
385 (ManifestGenerator::platforms): Skip platforms that have been hidden.
388 (TestEnvironment.postJSON):
389 (TestEnvironment.httpGet):
390 (TestEnvironment.httpPost): Added.
391 (sendHttpRequest): Set the content type if specified.
393 * tests/admin-platforms.js: Added tests.
395 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
397 Extract the code to compute full test names from tests.php.
399 Reviewed by Stephanie Lewis.
401 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
402 and paves our way to re-use the code in other pages.
404 * public/admin/tests.php:
406 * public/include/db.php:
407 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
408 tests.php and test-name-resolver.php.
410 * public/include/test-name-resolver.php: Added.
411 (TestNameResolver::__construct):
412 (TestNameResolver::compute_full_name): Moved from tests.php.
413 (TestNameResolver::map_metrics_to_tests): Ditto.
414 (TestNameResolver::sort_tests_by_full_name): Ditto.
415 (TestNameResolver::tests): Added.
416 (TestNameResolver::test_id_for_full_name): Ditto.
417 (TestNameResolver::metrics_for_test_id): Ditto.
418 (TestNameResolver::child_metrics_for_test_id): Ditto.
419 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
421 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
423 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
425 Reviewed by Stephanie Lewis.
427 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
429 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
430 but that's sufficient to correct the wrongfully processed reports for now.
432 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
433 We should eventually add a nice UI to find and reprocess reports.
435 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
437 * public/include/db.php: Added the forgotten call to prefixed_column_names.
439 * public/include/report-processor.php: Copied from public/api/report.php.
440 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
441 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
442 create a new report or authenticate the builder password (the password is never stored in the report).
443 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
444 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
445 (ReportProcessor::store_report): Ditto.
447 * tests/admin-reprocess-report.js: Added.
449 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
451 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
453 Reviewed by Ricky Mondello.
455 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
456 for the same build number as a single build by ignoring build time. This was necessary to associate
457 multiple reports by a single build - e.g. for different performance test suites - because the scripts
458 we use to submit results computed its own "build time" when they're called.
460 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
461 last week; new reports were wrongfully associated with old build numbers.
463 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
464 to the same build. Instead, we create a new build object for those reports. Since the longest set of
465 tests we have only take a couple of hours to run, 24 hours should be more than enough.
467 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
468 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
469 (builder, build number, build time).
471 * public/api/report.php:
472 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
473 when no such build exists. This prevents a report from being associated with a very old build of the same
476 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
477 a similar bug in the future sooner.
479 * tests/api-report.js: Added three test cases.
481 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
483 Merged the upstream changes to db.php
484 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
486 * public/include/db.php:
488 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
490 Update other scripts and tests per previous patch.
492 * public/include/manifest.php:
493 * tests/admin-regenerate-manifest.js:
495 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
499 Reviewed by Ricky Mondello.
501 This column is no longer used by the front-end code since r48360.
503 * database/init-database.sql:
504 * public/admin/tests.php:
506 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
508 Unreviewed build fix.
510 * public/api/report.php:
512 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
514 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
516 Reviewed by Ricky Mondello.
518 Support a new alternative format for aggregated results where we have raw values as well as
519 the list aggregators so that instead of
520 "metrics": {"Time": ["Arithmetic"]}
522 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
524 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
525 dashboard and the generated results page, which doesn't know how to aggregate values.
527 We need to keep the support for the old format because all other existing performance tests
528 all rely on the old format. Even if we updated the tests, we need the dashboard to support
529 the old format during the transition.
531 * public/api/report.php:
532 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
533 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
535 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
537 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
539 Unreviewed; Tweak the CSS so that chart panes align vertically.
543 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
545 SafariPerfMonitor should support Combined metric.
547 * public/js/helper-classes.js:
548 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
549 value as well but assume it to be greater-is-better for now.
551 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
553 Commit the forgotten init-database change to add iteration_relative_time.
555 * database/init-database.sql:
557 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
559 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
561 Reviewed by Ricky Mondello.
563 Add the support for each value to have a relative time. This is necessary for frame rate history
564 since a frame rate needs to be associated with a time it was sampled.
566 * database/init-database.sql: Added iteration_relative_time to run_iterations.
568 * public/api/report.php:
569 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
570 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
571 with relative time since taking the average of two frame rates for two subtests taken at two
572 different times doesn't make any sense.
573 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
574 etc..., use the second element since we assume values are of the form (relative time, frame rate).
575 Also exit early with an error if the number of elements in the array is not a pair.
576 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
578 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
579 iteration_relative_time.
581 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
583 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
585 Reviewed by Ricky Mondello.
587 Support that. It's one line change.
589 * public/api/report.php:
590 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
591 to match the convention assumed elsewhere.
592 * tests/api-report.js: Added a test case.
594 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
596 SafariPerfMonitor shows popups for points outside of the visible region.
598 Rubber-stamped by Simon Fraser.
601 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
602 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
603 may return an item underneath y-axis labels.
605 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
607 Tweak the CSS a little to avoid the test name overlapping with the summary table.
611 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
613 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
617 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
619 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
620 <rdar://problem/13992271> Should scale Y axis to include error ranges
622 Reviewed by Ricky Mondello.
624 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
625 the main graph doesn't go outside the graph even when the y-axis is adjusted.
627 * database/config.json:
629 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
630 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
631 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
633 * public/js/helper-classes.js:
634 (PerfTestResult.confidenceIntervalDelta):
635 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
636 (PerfTestRuns.min): Take confidence interval delta into account.
637 (PerfTestRuns.max): Ditto.
638 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
640 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
642 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
644 * public/api/report.php:
645 (ReportProcessor::recursively_ensure_tests):
646 * tests/api-report.js: Added a test.
648 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
650 Unreviewed build fixes.
652 * public/api/report.php:
653 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
654 Also, tolerate reports without any revision information.
656 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
659 * tests/api-report.js: Added few test cases.
661 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
663 Commit another change that was supposed to be committed in r50331.
666 (TestEnvironment.this.postJSON):
667 (TestEnvironment.this.httpGet):
670 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
672 Commit the remaining files.
674 * public/admin/regenerate-manifest.php:
675 * public/include/admin-header.php:
676 * public/include/json-header.php:
677 * public/include/manifest.php:
679 (TestEnvironment.this.postJSON):
680 (TestEnvironment.this.httpGet):
683 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
685 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
687 Reviewed by Ricky Mondello.
689 Added some tests for admin/regenerate-manifest.
691 * public/admin/regenerate-manifest.php: Use require_once instead of require.
692 * public/include/admin-header.php: Ditto.
693 * public/include/json-header.php: Ditto.
695 * public/include/manifest.php:
696 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
697 When there are no builders, simply return an empty array.
700 (TestEnvironment.postJSON):
701 (TestEnvironment.httpGet): Added.
702 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
704 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
706 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
708 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
709 and run_iterations. Also fixed a typo in report.php found by new tests.
711 * public/api/report.php:
712 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
713 * tests/api-report.js: Added more test cases.
715 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
717 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
719 Reviewed by Ricky Mondello.
721 Add a test runner script and some simple test cases.
723 * database/config.json: Added the configuration for "testServer".
724 * database/database-common.js:
725 (pathToTests): Added.
726 * run-tests.js: Added.
729 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
730 and if there are, asks the user if it’s okay to delete all of the data contained therein.
731 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
733 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
734 in the current database using PostgreSQL's information_schema.
735 (askYesOrNoQuestion):
737 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
739 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
740 (TestEnvironment.assert): Exposes assert to tests.
741 (TestEnvironment.console): Exposes console to tests.
742 (TestEnvironment.describe): Adds a description.
743 (TestEnvironment.it): Adds a test case.
744 (TestEnvironment.postJSON):
745 (TestEnvironment.queryAndFetchAll):
746 (TestEnvironment.sha256):
747 (TestEnvironment.notifyDone): Ends the current test case.
751 (TestContext): An object created for each test case. Conceptually, this object is always on
752 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
753 this object via currentTestContext.
754 (TestContext.description):
756 (TestContext.logError):
759 * tests/api-report.js: Added some basic tests for /api/report.php.
761 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
763 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
765 The problem was that we were detecting whether we're updating dashboard or not by checking
766 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
767 all configurations. Use separate 'dashboard' action to execute the code even when
768 metric_configurations is empty.
770 * public/admin/tests.php:
772 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
774 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
776 Reviewed by Ricky Mondello.
778 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
779 from ReportProcessor as a preparation to replace deprecated aggregate.js.
781 * public/api/report.php:
782 (ReportProcessor::exit_with_error): Moved.
783 (ReportProcessor::process): Use the extracted TestRunsGenerator.
784 (TestRunsGenerator): Added.
785 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
786 (TestRunsGenerator::add_aggregated_metric): Moved.
787 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
788 (TestRunsGenerator::aggregate): Moved. Made public.
789 (TestRunsGenerator::aggregate_current_test_level): Moved.
790 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
791 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
792 (TestRunsGenerator::compute_caches): Moved. Made public.
793 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
794 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
795 (TestRunsGenerator::rollback_with_error): Moved.
797 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
799 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
801 Reviewed by Remy Demarest.
803 Regenerate the manifest file when updating fields or adding new items that are included in
806 * public/admin/bug-trackers.php:
807 * public/admin/builders.php:
808 * public/admin/regenerate-manifest.php:
809 * public/admin/repositories.php:
810 * public/admin/tests.php:
811 * public/include/admin-header.php:
812 (regenerate_manifest): Extracted from regenerate-manifest.php.
814 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
816 Unreviewed build fix for memory test results.
818 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
819 aggregating at each level.
821 * public/api/report.php:
822 (ReportProcessor::recursively_ensure_tests):
823 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
824 (ReportProcessor::add_values_for_aggregation):
825 (ReportProcessor::aggregate):
826 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
828 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
830 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
831 not the number of iteration groups. Also, don't set group number when the entire run belongs
832 a single iteration group.
834 * public/api/report.php:
835 (ReportProcessor::commit):
837 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
839 SafariPerfMonitor: Introduce iteration groups
841 Reviewed by Remy Demarest.
843 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
844 the runtime environment variances to get more stable results. And it's desirable to keep track of
845 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
847 This patch introduces "iteration groups" to keep track of this extra information.
849 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
850 the outer array denotes iteration groups and each inner array contains iteration values for each group.
853 * database/init-database.sql: Add iteration_group column.
854 * public/api/report.php:
855 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
857 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
858 contains the list of values indexed by the iteration order and group sizes. Store the group size so
859 that we can restore the iteration groups before passing it to node.js and restore them later.
861 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
862 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
864 Also check that each iteration group in each subtest are consistent with one another. To see why we need
865 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
866 that each iteration group in T1 and T2 have the same size:
867 T1 = [[1, 2], [3, 4, 5]]
868 T2 = [[6, 7], [8, 9, 10]]
870 so that the aggregated result (the sum in this case) can have the same groups as in:
871 T = [[7, 9], [11, 13, 15]]
873 If some iteration groups in T1 and T2 had a different size as in:
874 T1 = [[1, 2, 3], [4, 5]]
875 T2 = [[6, 7], [8, 9, 10]]
877 Then iteration groups of the aggregated T is ambiguous.
879 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
880 (ReportProcessor::commit): Store iteration_group values.
882 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
884 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
885 migrated to perf.webkit.org.
887 * database/perf-webkit-migrator.js: Removed.
889 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
891 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
896 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
898 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
900 Reviewed by Ricky Mondello.
902 It is often desirable to see charts of a given test for all platforms, or to be able to see
903 charts of all subtests on a given platform when trying to triage perf. regressions.
905 Support this use case by adding the ability to do so on the charts page.
907 Also, we used to disable items on the test list based on the platform chosen. This turned out
908 to be a bad UI because in many situations you want to be able to compare results of the same test
909 on multiple platforms.
911 In this new UI, we have three select elements, each of which selects the following:
912 1. Top-level test - Test suite such as Dromaeo
913 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
914 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
915 3. Platform - Mountain Lion, Qt, etc...
917 A user can select "all" for metric and platform but we disallow doing both at once since adding
918 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
919 think of a use case where you want to look at that many charts at once. We can support this later
920 if valid use cases come up.
923 (.showCharts.addOption): Extracted.
924 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
925 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
926 metricList has onchange handler that enables/disables items on platformList.
928 (init): Sort tests and test metrics here instead of doing that in showCharts.
930 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
932 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
934 Reviewed by Remy Demarest and Ricky Mondello.
936 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
937 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
938 templates to the manifest file instead. Each build now only contains the builder id.
940 * public/api/runs.php: Removed the part of the query that joined builders table. This
941 speeds up the query quite a bit.
943 * public/include/manifest.php:
944 (ManifestGenerator::generate): Generate builders field.
945 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
946 associative array that contains name and its build URL template.
949 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
950 instead of a revision since this function is used for revisions and build page URLs now.
951 (.buildLabelWithLinks): Include the linkified build number.
953 * public/js/helper-classes.js:
954 (TestBuild.builder): Added.
955 (TestBuild.buildNumber): Added.
956 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
957 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
959 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
961 Tooltips interfere with user interactions
963 Rubber-stamped by Simon Fraser.
965 Disable tooltip on the dashboard page since graphs are too small to be useful there.
966 Also, show graphs for only 10 days by default as opposed to 20.
967 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
970 * public/js/helper-classes.js:
972 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
974 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
975 to be compatible with webkit-perf.appspot.com.
977 * public/admin/builders.php:
978 * public/api/report.php:
980 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
984 Add a missing constraint on builds table. For a given builder, there should be exactly
985 one build for a given build number.
987 Also add report_committed_at to reports table to record the time at which a given report
988 was processed and test_runs and run_iterations rows were committed into the database.
990 * database/config.json:
991 * public/api/report.php:
993 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
995 Unreviewed. Add more checks for empty SQL query results.
997 * public/include/manifest.php:
999 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1001 More build fixes on perf.webkit.org.
1003 * public/api/runs.php: Make PostgreSQL happier.
1004 * public/include/manifest.php: Don't assume we always have bug trackers.
1006 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1008 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1009 and fix other miscellaneous UI bugs.
1011 Rubber-stamped by Simon Fraser.
1013 Removed the code to determine whether smaller value is better or not for a given test in index.html
1014 in the favor of using that of PerfTestRuns.
1016 * public/include/manifest.php: Fixed a typo.
1017 * public/index.html:
1019 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1021 * public/js/helper-classes.js:
1022 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1024 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1025 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1026 at roughly 2,000 units to avoid this.
1028 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1029 The only thing we can avoid is innerHTML.
1031 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1033 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1035 * public/include/evaluator.js:
1037 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1039 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
1041 Reviewed by Remy Demarest.
1043 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
1044 admin/bug-trackers.php and can be associated with multiple repositories.
1046 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
1047 to determine the set of bug trackers to show for a given set of blame lists.
1048 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
1049 a place to file bugs against the regression.
1051 * database/init-database.sql: Added bug_trackers and tracker_repositories.
1052 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
1054 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
1055 bug trackers, namely associated repositories.
1057 * public/include/admin-header.php: Added a link to bug-trackers.php
1058 * public/include/manifest.php:
1059 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
1060 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
1062 (ManifestGenerator::repositories):
1064 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
1065 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
1066 'repositories' where the latter contains the list of associated repository names.
1068 * public/index.html:
1069 (Chart): Takes bugTrackers as as argument.
1070 (Chart.showTooltipWithResults): Removed the hard-coded list.
1072 (init.addPlatformsToDashboard):
1073 (init.showCharts.createChartFromListPair):
1074 (init): Stores the list of bug trackers in the manifest to a local variable.
1076 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1078 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
1080 * public/include/evaluator.js:
1082 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1084 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
1086 Reviewed by Remy Demarest.
1088 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
1089 new row into the database.
1091 * public/admin/aggregators.php: Use AdministrativePage.
1092 * public/admin/builders.php: Ditto.
1093 * public/admin/repositories.php: Ditto.
1094 * public/include/admin-header.php:
1095 (AdministrativePage): Added.
1096 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
1097 to an associative array that describes the column.
1098 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
1099 - label: Human readable name of the column.
1100 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
1101 column exists only before we create password_hash column at the insertion time.
1103 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
1104 titlecase (e.g. new_bug is converted to New Bug).
1105 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
1106 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
1107 textarea for a given editing mode ('text', 'url', or 'string').
1108 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
1109 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
1111 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
1113 Build fix. Some systems don't support r+. Use proc_open instead.
1115 * public/api/report.php:
1117 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1119 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
1120 when computing the y-axis of data points to show tooltips at.
1122 * public/index.html:
1124 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
1126 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
1129 * public/.htaccess: Removed.
1131 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
1135 * public/include/manifest.php: Build fix. db is on this.
1136 * public/js/statistics.js:
1137 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
1139 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
1141 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
1143 Reviewed by Anders Carlsson.
1145 Rewrote and merged populate-from-report.js into report.php.
1147 * database/config.json: Added a path to node.js.
1149 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
1150 Once we land this patch and update the administrative pages, we can remove this column.
1152 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
1153 that table is going away once we remove the node.js backend.
1155 * database/populate-from-report.js: Removed.
1156 * public/api/report.php: Added.
1158 (ReportProcessor.__construct):
1159 (ReportProcessor.process):
1161 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
1162 verified to be submitted by a known builder.
1164 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
1165 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
1166 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
1167 inside a transaction because there could be multiple reports for a single build, each containing results for
1170 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
1171 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
1172 add_values_to_commit, and add_values_for_aggregation.
1174 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
1175 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
1176 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
1179 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
1180 to be aggregated in ReportProcessor.aggregate.
1182 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
1184 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
1185 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
1186 given for each row (child metrics of M). This function extracts each column (iteration) via
1187 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
1188 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
1190 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
1191 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
1192 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
1194 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
1195 (ReportProcessor.evaluate_expressions_by_node): See above.
1197 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
1198 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
1199 results also need the said caches.
1201 (ReportProcessor.add_values_to_commit):
1203 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
1204 the transaction as needed if anything goes wrong.
1206 (ReportProcessor.rollback_with_error)
1208 * public/include/db.php:
1209 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
1210 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
1211 contiguously in a SQL statement.
1213 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
1214 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
1215 a column value of the choice.
1217 (Database.begin_transaction): Added.
1218 (Database.commit_transaction): Added.
1219 (Database.rollback_transaction): Added.
1221 * public/include/evaluator.js: Added.
1222 * public/include/json-header.php:
1223 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
1224 context under which the request failed.
1225 (successful_exit): Merge "additional details".
1226 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
1227 (merge_additional_details):
1229 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
1231 SafariPerfMonitor: Add more helper functions to db.php
1233 Reviewed by Remy Demarest.
1235 Added Database::insert_row and array_get to make common database operations easier.
1237 * public/admin/aggregators.php: Use Database::insert_row instead of
1238 execute_query_and_expect_one_row_to_be_affected.
1240 * public/admin/builders.php: Ditto.
1242 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
1243 inserting a row. With insert_row, we don't need that.
1245 * public/include/admin-header.php: Ditto.
1247 * public/include/db.php:
1248 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
1249 return the default value (defaults to NULL) if the key doesn't exist.
1251 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
1254 (Database::prepare_params): Added. Takes an associative array of column names and their values,
1255 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
1256 column names all in the same order.
1258 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
1259 the given prefix. Values are given in a form of an associative array where keys are unprefixed
1260 column names and values are corresponding values. When the row is successfully inserted, it returns
1261 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
1262 indicating the success of the insertion.
1264 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1266 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
1268 Reviewed by Conrad Shultz.
1270 Rewrote the manifest generator in PHP.
1272 * database/generate-manifest.js: Removed.
1273 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
1274 * public/include/db.php:
1275 (array_ensure_item_has_array): Added.
1276 * public/include/evaluator.js: Added.
1277 * public/include/json-header.php:
1278 * public/include/manifest.php: Added.
1280 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
1282 Dates on overflow plot are overlapping
1284 Rubber-stamped by Simon Fraser.
1286 Don't show more than 5 days.
1288 * public/index.html:
1289 * public/js/helper-classes.js:
1290 (TestBuild.UTCtoPST):
1293 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1295 Show build time as well as commit time on the dashboard and tooltips.
1297 Rubber-stamped by Simon Fraser.
1299 Include both the maximum commit time and build time in buildLabelWithLinks.
1300 Also use ISO format to save the screen real estate.
1302 * public/index.html:
1303 (buildLabelWithLinks):
1304 * public/js/helper-classes.js:
1306 (TestBuild.buildTime):
1307 (TestBuild.formattedBuildTime):
1309 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
1311 Unreviewed; Convert metric.name to metric.unit in the front end.
1313 * public/js/helper-classes.js:
1315 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
1317 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
1319 Rubber-stamped by Simon Fraser.
1321 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
1322 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
1323 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
1325 * public/index.html:
1326 (.buildLabelWithLinks): Extracted from TestBuild.label.
1327 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
1328 on Radar and WebKit Bugzilla.
1329 * public/js/helper-classes.js:
1330 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
1331 (PerfTestResult.isBetterThan): Added.
1332 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
1333 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
1334 to indicate progressions or regressions.
1335 (PerfTestResult.label):
1336 (TestBuild.formattedTime): Added.
1337 (TestBuild.platform): Added.
1338 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
1339 (TestBuild.smallerIsBetter): Added.
1340 (Tooltip.show): Take a raw markup instead of two results.
1342 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
1344 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
1346 Rubber-stamped by Tim Horton.
1348 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
1349 since each platform may have a different number of tests to be shown on the dashboard.
1351 * public/index.html:
1353 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1355 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
1357 * public/js/helper-classes.js:
1360 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1362 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
1364 Rubber-stamped by Tim Horton.
1366 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
1368 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
1369 the revision r1234 was the revision used in the previous build.
1371 * public/api/runs.php:
1372 (parse_revisions_array): Trim double quotations around repository names and revisions.
1373 * public/js/helper-classes.js:
1376 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
1378 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
1380 Rubber-stamped by Tim Horton.
1382 * public/index.html:
1383 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
1384 on the dashboard page as it's way too noisy.
1386 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
1388 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
1389 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
1390 so that the tooltip for hover can be reused further.
1392 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
1393 and find the first point that lies on the right of the cursor position. We then compute the midpoint
1394 between this and the previous point and pick the closer of the two. It returns an item-like object
1395 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
1397 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
1399 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
1400 the first or "current" data points (as opposed to target or baseline data points).
1402 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
1403 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
1404 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
1406 * public/js/helper-classes.js:
1407 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
1408 work to the client via bindClick.
1410 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
1412 (Tooltip.bindClick): Added.
1414 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1416 Yet another build fix. metricId*s*.
1418 * public/admin/tests.php:
1420 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1422 Another build fix. Use the new payload format for the aggregate job.
1424 * public/admin/tests.php:
1426 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
1430 * database/aggregate.js: Use variables that actually exist.
1431 * database/database-common.js:
1432 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
1433 function calls will find this configuration.
1435 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1437 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
1439 Reviewed by Ricky Mondello.
1441 Turned InstallManual into a proper markdown document and added ReadMe.md.
1443 * InstallManual: Removed.
1444 * InstallManual.md: Moved from InstallManual.
1447 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
1449 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
1451 Reviewed by Ricky Mondello.
1453 This patch prepares the front end code to process baseline and target results properly.
1455 * public/index.html:
1456 (fetchTest.createRunAndResults): Extracted.
1457 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
1458 Deleted the comment about how sorting will be unnecessary once we start results in the server side
1459 since sorting by the maximum revision commit time turned out to be non-trivial in php.
1461 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1463 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
1465 Reviewed by Tim Horton.
1467 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
1468 These files are "dynamically linked" to our app.
1470 * public/index.html:
1471 * public/js/jquery-1.8.2.min.js: Removed.
1472 * public/js/jquery.colorhelpers.js: Added.
1473 * public/js/jquery.flot.categories.js: Added.
1474 * public/js/jquery.flot.crosshair.js: Added.
1475 * public/js/jquery.flot.errorbars.js: Added.
1476 * public/js/jquery.flot.fillbetween.js: Added.
1477 * public/js/jquery.flot.js: Added.
1478 * public/js/jquery.flot.min.js: Removed.
1479 * public/js/jquery.flot.navigate.js: Added.
1480 * public/js/jquery.flot.resize.js: Added.
1481 * public/js/jquery.flot.selection.js: Added.
1482 * public/js/jquery.flot.stack.js: Added.
1483 * public/js/jquery.flot.symbol.js: Added.
1484 * public/js/jquery.flot.threshold.js: Added.
1485 * public/js/jquery.flot.time.js: Added.
1486 * public/js/jquery.js: Added.
1488 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
1490 Return NaN instead of throwing when there aren't enough samples.
1492 Reviewed by Sam Weinig.
1494 It's better to return NaN when we don't have enough samples so that we can treat it
1495 as if we don't have any confidence interval.
1497 * public/js/statistics.js:
1500 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1502 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
1504 * public/js/helper-classes.js:
1505 (URLState.parseIfNeeded):
1507 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
1509 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
1511 Reviewed by Ricky Mondello.
1513 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
1515 * public/admin/aggregators.php: Use heredoc.
1516 * public/admin/builders.php:
1517 * public/admin/jobs.php:
1518 * public/admin/repositories.php:
1519 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
1520 This allows us to use update_field when updating test's url and metric's unit. Changed the action
1521 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
1522 Also removed a stray code to update unit and url simultaneously since it's never used.
1523 * public/include/admin-header.php:
1524 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
1525 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
1526 (update_field): Moved from repositories.php.
1528 * public/include/db.php:
1529 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
1531 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
1533 Build fixes. Treat mean, sum, and square sum as float, not int.
1535 Also use 95% confidence interval instead of 90% confidence interval.
1537 * public/api/runs.php:
1538 * public/js/helper-classes.js:
1539 (.this.confidenceIntervalDelta):
1541 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
1543 Add an administrative page to edit repository information.
1545 Reviewed by Ricky Mondello.
1547 * public/admin/repositories.php: Added.
1548 * public/include/admin-header.php:
1550 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
1552 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
1554 Reviewed by Ricky Mondello.
1556 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
1557 to aggregate results for those matrix in populate-from-report.js.
1559 * database/generate-manifest.js:
1560 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
1561 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
1562 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
1563 * database/populate-from-report.js:
1565 (getReport): No change even though the diff looks as if it moved.
1566 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
1567 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
1568 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
1569 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
1570 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
1572 (ensureMetricId): Take an aggregator id as an argument.
1573 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
1574 for all builds when the build id is not specified.
1575 * public/admin/tests.php:
1576 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
1577 of the same name with different aggregators.
1579 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
1581 Build fix. Don't pass in arguments to in the wrong order.
1583 * database/aggregate.js:
1585 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1587 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
1589 Reviewed by Ricky Mondello.
1591 Since the version of flot we use doesn't support showing graphs in the current locate or
1592 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
1593 treat them as in UTC). We don't want to use the current locate because other websites on
1594 webkit.org assume PST.
1596 Also append this information to build's label.
1598 * public/js/helper-classes.js:
1602 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1604 Store test URLs reported by builders.
1606 Reviewed by Ricky Mondello.
1608 * database/populate-from-report.js:
1609 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
1610 (ensureTestId): Store the URL.
1612 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
1614 Yet another build fix; don't blow up even if we didn't have any test configurations.
1616 * public/admin/tests.php:
1618 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
1620 Build fix; don't instantiate Date when a timestamp wasn't provided.
1622 * database/populate-from-report.js:
1624 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
1626 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
1628 Reviewed by Tim Horton.
1630 Added an install manual.
1632 * InstallManual: Added.
1634 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
1636 Minor build fix. Don't unset builderPassword when it's not set.
1638 * public/api/report.php:
1640 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1642 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
1644 Reviewed by Ricky Mondello.
1646 * public/admin/admin.css: Make a very large payload scrollable.
1647 * public/admin/jobs.php: Format JSONs.
1649 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
1651 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
1653 Reviewed by Ricky Mondello.
1655 Add report.php and populate-from-report.js that process JSON files submitted by builders.
1657 * database/populate-from-report.js: Added.
1659 (getReport): Obtains the payload (the actual report) from "jobs" table.
1660 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
1661 and their results. This function recursively traverses tests and metrics and ensure their ids.
1663 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
1664 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
1665 is a "function" in mathematical sense).
1667 (ensureRepositoryIdsForAllRevisions):
1668 (getIdOrCreateBuildWithRevisions):
1669 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
1670 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
1671 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
1673 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
1674 test results all in a single transaction. This allows us to keep the database consistent in that either
1675 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
1676 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
1677 other parts of the application are concerned.
1678 (scheduleQueriesToInsertRun):
1679 * database/process-jobs.js: Add a call to populate-from-report.js.
1680 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
1681 * public/include/db.php: Support parameterized query.
1682 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
1683 a test result could confirm that the submission indeed succeeded.
1685 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1687 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
1689 * database/aggregate.js:
1690 * database/database-common.js:
1691 (selectColumnCreatingRowIfNeeded):
1692 (ensureRepositoryId):
1693 (ensureConfigurationIdFromList):
1694 * database/perf-webkit-migrator.js:
1697 (getOrCreateBuildId):
1699 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1701 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
1703 Reviewed by Ricky Mondello.
1705 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
1706 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
1708 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
1711 (saveAggregatedResults):
1712 * database/database-common.js:
1713 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
1714 (getIdOrCreateRepository): Ditto.
1715 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
1716 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
1717 * database/perf-webkit-migrator.js:
1718 * database/utility.js: Added.
1719 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
1720 from being executed.
1721 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
1722 call the callback passed into start().
1723 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
1724 (TaskQueue.addTask):
1726 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
1727 (SerializedTaskQueue.executeNextTask):
1728 (SerializedTaskQueue.addTask):
1729 (SerializedTaskQueue.start):
1731 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1733 Revert erroneously committed changes.
1735 * database/config.json:
1737 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
1739 aggregator.js should be able to accept multiple metric ids and a single build id.
1741 Reviewed by Ricky Mondello.
1743 Make aggregator.js accept multiple ids and generate results for single build when bots are
1744 reporting new results.
1746 * database/aggregate.js:
1747 (parseArgv): Added. Returns an object containing the parsed representation of argv,
1748 which currently contains metricIDs and buildIds.
1749 (main): Use parseArgv and processConfigurations
1750 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
1751 (processPlatform.processConfigurations): Extracted.
1753 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
1755 Add an administrative page for builders.
1757 Reviewed by Ricky Mondello.
1759 We need an administrative page to add and edit builder information.
1760 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
1762 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
1763 since we don't have plans to use those columns in near future. Also make builder_name unique
1764 as required by the rest of the app.
1765 * public/admin/builders.php: Added.
1766 * public/api/runs.php: Updated per the table rename.
1767 * public/include/admin-header.php: Added a link to builders.php.
1769 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
1771 Build fixes for r46982.
1773 * database/aggregate.js:
1774 (fetchConfigurations): Bind i so that it's not always metricIds.length.
1775 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
1776 (processBuild): Don't print "." until we've committed transactions. It's misleading.
1778 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1780 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
1782 * public/admin/aggregators.php:
1783 * public/admin/footer.php: Removed.
1784 * public/admin/header.php: Removed.
1785 * public/admin/index.php:
1786 * public/admin/jobs.php:
1787 * public/admin/tests.php:
1788 * public/api/json-header.php: Removed.
1789 * public/api/runs.php:
1790 * public/db.php: Removed.
1791 * public/include: Added.
1792 * public/include/admin-footer.php: Copied from public/admin/footer.php.
1793 * public/include/admin-header.php: Copied from public/admin/header.php.
1794 * public/include/db.php: Copied from public/db.php.
1795 * public/include/json-header.php: Copied from public/api/json-header.php.
1797 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
1799 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
1801 Reviewed by Ricky Mondello.
1803 Added the initial implementation of value aggregation.
1804 Also added abilities to configure the dashboard page in tests.php.
1806 * database/aggregate.js: Added.
1807 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
1808 (TaskQueue.addTask):
1810 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
1811 (SerializedTaskQueue.addTask):
1812 (SerializedTaskQueue.start):
1815 (fetchConfigurations):
1816 (fetchBuildsForPlatform):
1818 (testsWithDifferentIterationCounts):
1819 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
1820 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
1821 (getOrInsertConfiguration):
1823 * database/database-common.js:
1824 (fetchTable): Log an error as an error.
1825 (getOrCreateId): Extracted from perf-webkit-migrator.
1826 (statistics): Added.
1827 * database/perf-webkit-migrator.js:
1828 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
1829 runs JSON since runs JSONs are generated on demand now.
1831 (getOrCreatePlatformId):
1832 (getOrCreateTestId):
1833 (getOrCreateConfigurationId):
1834 (getOrCreateRevisionId):
1835 (getOrCreateRepositoryId):
1836 (getOrCreateBuildId):
1837 * database/process-jobs.js:
1838 (processJob): Handle 'aggregate' type.
1840 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
1842 Fix the dashboard after adding test_metrics.
1844 Reviewed by Ricky Mondello.
1846 Rename test to metrics in various functions and sort tests on the charts page.
1847 Also representing whether a test appears or not by setting a flag on dashboard
1848 was bogus because test objects are shared by multiple platforms. Instead, store
1849 dashboard platform list as intended by the manifest JSON.
1851 * public/index.html:
1852 (PerfTestRuns): Renamed test to metric.
1854 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
1855 (fullName): Moved so that it appears above where it's called.
1856 * public/js/helper-classes.js:
1858 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
1860 Update tests.php to reflect recent changes in the database schema.
1862 Reviewed by Conrad Shultz.
1864 Made the following changes to tests.php:
1865 1. Disallow adding metrics to tests without subtests.
1866 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
1867 3. Linkified tests with subtests instead of showing all them at once.
1869 * public/admin/admin.css:
1870 (.action-field, .notice):
1872 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
1873 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
1874 (add_job): Extracted.
1875 * public/admin/tests.php: See above.
1876 (array_item_set_default): Added.
1877 (array_item_or_default): Renamed from get_value_with_default.
1878 (compute_full_name): Extracted.
1879 (sort_tests): Ditto.
1880 (map_metrics_to_tests): Ditto.
1882 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
1884 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
1886 Reviewed by Simon Fraser.
1888 Linkify the headers using metric.test.url when it's provided.
1890 * public/index.html:
1892 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1894 Use parameterized pg_query_params in query_and_fetch_all
1896 Reviewed by Conrad Shultz.
1898 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
1900 * public/api/runs.php:
1902 (ctype_alnum_underscore): Added.
1904 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
1906 Update the migration tool to support test_metrics.
1908 Reviewed by Mark Rowe.
1910 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
1911 Also import run_iteration rows as runs JSON files now include individual values.
1913 * database/database-common.js:
1914 (addJob): Extracted.
1915 * database/perf-webkit-migrator.js:
1916 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
1917 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
1918 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
1921 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1923 Build fix. Suppress "Undefined index" warning.
1925 * public/admin/tests.php:
1927 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1929 Fix a commit error in r46756. api/ should obviously be added under public/
1932 * api/json-header.php: Removed.
1933 * api/runs.php: Removed.
1934 * public/api: Copied from api.
1936 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1938 SafariPerfMonitor: Linkify revisions and revisions range
1939 <rdar://problem/12801010>
1941 Reviewed by Mark Rowe.
1943 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
1944 since it needs to know "url" and "blameUrl".
1946 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
1948 * public/index.html:
1949 * public/js/helper-classes.js:
1951 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
1952 (TestBuild.label): Add labels for all revisions.
1956 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1958 Make the generation of "runs" JSON dynamic and support test_metrics.
1960 Reviewed by Mark Rowe.
1962 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
1964 Since there could be hundreds, if not thousands, of tests for each configuration and users
1965 aren't necessarily interested in looking at all test results, it's much more efficient to
1966 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
1967 when bots report new results (i.e. pushing).
1969 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
1972 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
1973 (exit_with_error): Added.
1974 (successful_exit): Added.
1975 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
1976 * database/generate-runs.js: Removed.
1977 * database/process-jobs.js: No longer supports "runs".
1978 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
1979 * public/db.php: Print "Nothing to see here." when it's accessed directly.
1981 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
1983 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
1985 Update tests.php and sample-data.sql per addition of test_metrics.
1987 Rubber-stamped by Timothy Hatcher.
1989 Remove a useless code from tests.php that used to update the unit and the url of a test
1990 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
1992 Also update the sample data to reflect the addition of test_metrics.
1994 * database/sample-data.sql:
1995 * public/admin/tests.php:
1997 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
1999 Share more code between admin pages.
2001 Reviewed by Timothy Hatcher.
2003 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2004 between admin pages.
2006 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2007 to check the nullity of global $db now.
2009 * public/admin/aggregators.php:
2010 * public/admin/header.php:
2012 (execute_query_and_expect_one_row_to_be_affected): Added.
2013 * public/admin/index.php:
2014 * public/admin/jobs.php:
2015 * public/admin/tests.php:
2017 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2019 SafariPerfMonitor: Add admin page to edit aggregators
2020 <rdar://problem/12782687>
2022 Reviewed by Mark Rowe.
2024 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2026 * public/admin/aggregators.php: Added.
2027 * public/admin/header.php:
2028 * public/admin/jobs.php: Removed an erroneous hidden input element.
2030 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2032 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2034 * database/init-database.sql:
2036 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2038 SafariPerfMonitor: Allow multiple metrics per test
2039 <rdar://problem/12773506>
2041 Rubber-stamped by Mark Rowe.
2043 Introduce a new table test_metrics. This table represents metrics each test can have
2044 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
2047 Updated admin/tests.php and index.html accordingly.
2049 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
2051 * database/generate-manifest.js:
2052 (buildPlatformMapIfPossible):
2053 * database/generate-runs.js:
2055 * database/init-database.sql:
2056 * database/schema.graffle:
2057 * public/admin/admin.css:
2060 * public/admin/tests.php:
2061 * public/index.html:
2063 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
2065 SafariPerfMonitor: Improve the webkit-perf migration tool
2066 <rdar://problem/12760882>
2068 Reviewed by Mark Rowe.
2070 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
2071 and we don't want to pause the whole importation process until the user comes back to decide whether
2074 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
2075 down to make modifications.
2077 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
2078 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
2080 * database/init-database.sql:
2081 * database/perf-webkit-migrator.js:
2082 (migrateTestConfig):
2083 * database/schema.graffle:
2084 * public/admin/admin.css:
2086 * public/admin/tests.php:
2088 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
2090 Create a new performance dashboard
2091 <rdar://problem/12625582>
2093 Rubber-stamped by Mark Rowe.
2095 Add the initial implementation of the perf dashboard.
2098 * database/config.json: Added.
2099 * database/database-common.js: Added.
2104 (pathToLocalScript):
2106 * database/generate-manifest.js: Added.
2109 (buildPlatformMapIfPossible):
2110 (generateFileIfPossible):
2111 * database/perf-webkit-migrator.js: Added.
2112 * database/process-jobs.js: Added.
2113 * database/sample-data.sql: Added.
2114 * database/schema.graffle: Added.
2116 * public/admin: Added.
2117 * public/admin/README: Added.
2118 * public/admin/admin.css: Added.
2119 * public/admin/footer.php: Added.
2120 * public/admin/header.php: Added.
2121 * public/admin/index.php: Added.
2122 * public/admin/jobs.php: Added.
2123 * public/admin/tests.php: Added.
2124 * public/common.css: Added.
2125 * public/data: Added.
2126 * public/db.php: Added.
2127 * public/index.html: Added.
2129 * public/js/helper-classes.js: Added.
2130 * public/js/jquery-1.8.2.min.js: Added.
2131 * public/js/jquery.flot.min.js: Added.
2132 * public/js/jquery.flot.plugins.js: Added.
2133 * public/js/shared.js: Added.
2134 (fileNameFromPlatformAndTest):
2135 * public/js/statistics.js: Added.