1 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
3 The dashboard on new perf monitor should be configurable
4 https://bugs.webkit.org/show_bug.cgi?id=138994
6 Reviewed by Benjamin Poulain.
8 For now, make it configurable via config.json. We should eventually make it configurable via
9 an administrative page but this will do for now.
11 * config.json: Added the empty dashboard configuration.
13 * public/include/manifest.php: Include the dashboard configuration in the manifest file.
16 (App.IndexController): Removed defaultTable since this is now dynamically obtained via App.Manifest.
17 (App.IndexController.gridChanged): Use App.Dashboard to parse the dashboard configuration.
18 Also obtain the default configuration from App.Manifest.
19 (App.IndexController._normalizeTable): Moved to App.Dashboard.
21 * public/v2/manifest.js:
22 (App.Repository.urlForRevision): Fixed the position of the open curly bracket.
23 (App.Repository.urlForRevisionRange): Ditto.
24 (App.Dashboard): Added.
25 (App.Dashboard.table): Extracted from App.IndexController.gridChanged.
26 (App.Dashboard.rows): Ditto.
27 (App.Dashboard.headerColumns): Ditto.
28 (App.Dashboard._normalizeTable): Moved from App.IndexController._normalizeTable.
29 (App.MetricSerializer.normalizePayload): Synthesize a dashboard record from the configuration.
30 Since there is exactly one dashboard object per app, it's okay to hard code an id here.
31 (App.Manifest._fetchedManifest): Set defaultDashboard to the one and only one dashboard we have.
33 2014-11-21 Ryosuke Niwa <rniwa@webkit.org>
35 There should be a way to associate bugs with analysis tasks
36 https://bugs.webkit.org/show_bug.cgi?id=138977
38 Reviewed by Benjamin Poulain.
40 Updated associate-bug.php to match the new database schema.
42 * public/include/json-header.php:
43 (require_format): Removed the call to camel_case_words_separated_by_underscore since the name is
44 already camel-cased in require_existence_of. This makes the function usable elsewhere.
46 * public/privileged-api/associate-bug.php:
47 (main): Changed the API to take run, bugTracker, and number to match the new database schema.
48 Also verify that those values are integers using require_format.
50 * public/v2/analysis.js:
51 (App.AnalysisTask.label): Added. Concatenates the task's name with the bug numbers.
52 (App.Bug.label): Added.
53 (App.BugAdapter): Added.
54 (App.BugAdapter.createRecord): Use PrivilegedAPI instead of the builtin ajax call.
55 (App.BuildRequest): Inherit from newly added App.Model, which is set to DS.Model right now.
57 * public/v2/app.css: Renamed .test-groups to .analysis-group. Also added new rules for the table
58 containing the bug information.
61 (App.InteractiveChartComponent._rangesChanged): Added label to range bar objects.
62 (App.AnalysisTaskRoute):
63 (App.AnalysisTaskController): Replaced the functionality of App.AnalysisTaskViewModel.
64 (App.AnalysisTaskController._fetchedManifest): Added.
65 (App.AnalysisTaskController.actions.associateBug): Added.
67 * public/v2/chart-pane.css: Renamed .bugs-pane to .analysis-pane.
70 (Measurement.prototype.associateBug): Deleted.
72 * public/v2/index.html: Renamed .bugs-pane to .analysis-pane and .test-groups to .analysis-group.
73 Added a table show the bug information. Also hide the chart until chartData is available.
75 * public/v2/manifest.js:
78 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
80 Fix misc bugs and typos in app.js
81 https://bugs.webkit.org/show_bug.cgi?id=138946
83 Reviewed by Benjamin Poulain.
86 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
87 (App.ChartsController.init):
88 (App.buildPopup): Renamed from App.BuildPopup.
89 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
90 remove() on the wrong object (an array as opposed to elements in the array).
91 (App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
92 _highlights is always an array and evalutes to true.
94 2014-11-20 Ryosuke Niwa <rniwa@webkit.org>
96 New perf dashboard should provide UI to create a new analysis task
97 https://bugs.webkit.org/show_bug.cgi?id=138910
99 Reviewed by Benjamin Poulain.
101 This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
102 I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.
104 With this patch, we can create a new analysis task by selection a range of points and opening
105 "analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
106 in the chart hyperlinked to the analysis task.
108 * init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.
110 * public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric
111 on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
113 (fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
114 and adds the associated bugs to each task in the array.
117 * public/api/runs.php: Reverted changes made in r175006.
118 (fetch_runs_for_config):
121 * public/api/test-groups.php:
122 (fetch_test_groups_for_task): Use the newly added Database::select_rows.
124 * public/include/db.php:
125 (Database::select_first_or_last_row):
126 (Database::select_rows): Extracted from select_first_or_last_row.
128 * public/v2/analysis.js:
129 (App.AnalysisTask): Added "bugs" property.
130 (App.Bug): Added now that bugs are regular data store objects.
133 (App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
134 (App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
135 platform that are associated with a specific range of runs.
136 (App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
137 (App.PaneController.actions.associateBug): Deleted.
138 (App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
139 this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
140 once we've created one.
141 (App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
142 (App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
143 (App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
144 (App.PaneController._updateBugs): Deleted.
145 (App.PaneController._updateMarkedPoints): Deleted.
146 (App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
147 the name is missing or when at most one point is selected.
149 (App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
150 (App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
151 (App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
152 on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
153 (App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
154 clickable bars for analysis tasks.
155 (App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
156 bar for analysis tasks to place them at the right location.
157 (App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.
159 * public/v2/chart-pane.css:
160 (.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
161 (.chart .rangeBar): Added.
164 (TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.
166 * public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.
167 This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
168 task bars in the interactive chart component.
170 2014-11-19 Ryosuke Niwa <rniwa@webkit.org>
172 Fix typos in r176203.
175 (App.ChartsController.actions.addPaneByMetricAndPlatform):
176 (App.AnalysisTaskRoute):
178 2014-11-18 Ryosuke Niwa <rniwa@webkit.org>
180 Unreviewed. Updated the install instruction.
184 2014-11-17 Ryosuke Niwa <rniwa@webkit.org>
186 App.Manifest shouldn't use App.__container__.lookup
187 https://bugs.webkit.org/show_bug.cgi?id=138768
189 Reviewed by Andreas Kling.
191 Removed the hack to find the store object via App.__container__.lookup.
192 Pass around the store object instead.
195 (App.DashboardRow._createPane): Add "store" property to the pane.
196 (App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
197 (App.IndexController.gridChanged): Ditto.
198 (App.IndexController.actions.addRow): Ditto.
199 (App.IndexController.init): Ditto.
200 (App.Pane._fetch): Ditto.
201 (App.ChartsController._parsePaneList): Ditto.
202 (App.ChartsController._updateQueryString): Ditto.
203 (App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
204 (App.BuildPopup): Ditto.
205 (App.AnalysisTaskRoute.model): Ditto.
206 (App.AnalysisTaskViewModel._taskUpdated): Ditto.
208 * public/v2/manifest.js:
209 (App.Manifest.fetch): Removed the code to find the store object.
211 2014-11-08 Ryosuke Niwa <rniwa@webkit.org>
213 Fix Ember.js warnings the new perf dashboard
214 https://bugs.webkit.org/show_bug.cgi?id=138531
216 Reviewed by Darin Adler.
218 Fixed various warnings.
221 (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
223 (PrivilegedAPI._post): Removed the superfluous console.log.
224 (CommitLogs.fetchForTimeRange): Ditto.
225 * public/v2/index.html: Added tbody as required by the HTML specification.
227 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
229 Fix typos in r175768.
232 (App.AnalysisTaskViewModel.roots):
234 2014-11-07 Ryosuke Niwa <rniwa@webkit.org>
236 Introduce the concept of analysis task to perf dashboard
237 https://bugs.webkit.org/show_bug.cgi?id=138517
239 Reviewed by Andreas Kling.
241 Introduced the concept of an analysis task, which is created for a range of measurements for a given metric on
242 a single platform and used to bisect regressions in the range.
244 Added a new page to see the list of active analysis tasks and a page to view the contents of an analysis task.
246 * init-database.sql: Added a bunch of tables to store information about analysis tasks.
247 analysis_tasks - Represents each analysis task. Associated with a platform and a metric and possibly with two
248 test runs. Analysis tasks not associated with test runs are used for try new patches.
249 analysis_test_groups - A test group in an analysis task represents a bunch of related A/B testing results.
250 root_sets - A root set represents a set of roots (or packages) installed in each A/B testing.
251 build_requests - A build request represents a single pending build for A/B testing.
253 * public/api/analysis-tasks.php: Added. Returns the specified analysis task or all analysis tasks in an array.
257 * public/api/test-groups.php: Added. Returns analysis task groups for the specified analysis task or returns
258 the specified analysis task group as well as build requests associated with them.
260 (fetch_test_groups_for_task):
261 (fetch_build_requests_for_task):
262 (fetch_build_requests_for_group):
264 (format_build_request):
266 * public/include/json-header.php:
267 (remote_user_name): Extracted from compute_token so that we can use it in create-analysis-task.php.
270 * public/privileged-api/associate-bug.php:
271 (main): Fixed a typo.
273 * public/privileged-api/create-analysis-task.php: Added. Creates a new analysis task for a given test run range.
276 (ensure_config_from_runs):
278 * public/privileged-api/generate-csrf-token.php: Use remote_user_name.
280 * public/v2/analysis.js: Added. Various Ember data store models to represent analysis tasks and related objects.
282 (App.AnalysisTask.create):
284 (App.TestGroupAdapter):
285 (App.AnalysisTaskSerializer):
286 (App.TestGroupSerializer):
289 * public/v2/app.css: Added style rules for the analysis page.
292 (App.Pane._fetch): Use fetchRunsWithPlatformAndMetric, which has been refactored into App.Manifest.
294 (App.PaneController.actions.toggleBugsPane): Show bugs pane even when there are no bug trackers or there is not
295 exactly one selected point as we can still create an analysis task.
296 (App.PaneController.actions.associateBug): Renamed singlySelectedPoint to selectedSinglePoint to be more
297 grammatical and also alert'ed the error message when there is one.
298 (App.PaneController.actions.createAnalysisTask): Added. Creates a new analysis task and opens it in a new tab.
299 Since window.open only works during the click, we open the new "window" preemptively and navigates or closes it
300 once XHR request has completed.
301 (App.PaneController._detailsChanged): Changes due to singlySelectedPoint to selectedSinglePoint rename.
302 (App.PaneController._updateBugs): Fixed a bug that we were showing bugs in the previous point when a single point
303 is selected in the details pane.
305 (App.AnalysisRoute): Added.
306 (App.AnalysisTaskRoute): Added.
307 (App.AnalysisTaskViewModel): Added.
308 (App.AnalysisTaskViewModel._taskUpdated): Fetch runs for the associated platform and metric.
309 (App.AnalysisTaskViewModel._fetchedRuns): Setup the chart data to show.
310 (App.AnalysisTaskViewModel.testSets): The computed property used to update roots for all repositories/projects.
311 (App.AnalysisTaskViewModel._rootChangedForTestSet): Updates root selections for all repositories/projects when
312 the user selects an option for all roots in A or B configuration.
313 (App.AnalysisTaskViewModel.roots): The computed property used to show root choices for each repository/project.
315 * public/v2/chart-pane.css: Added style rules for details view in the analysis task page.
318 (Measurement.prototype._formatRevisionRange): Don't prefix a revision number with "At " when there is no previous
319 point so that we can use it in App.AnalysisTaskViewModel.roots.
320 (TimeSeries.prototype.findPointByMeasurementId): Added.
321 (TimeSeries.prototype.seriesBetweenPoints): Added.
323 * public/v2/index.html: Use Metric.fullName since the same value is needed in the analysis task page. Also added
324 a button to create an analysis task, and made bugs pane button always enabled since we can an analysis task even
325 when multiple points are selected. Finally, added a new template for the analysis task page.
327 * public/v2/manifest.js:
328 (App.Metric.fullName): Added to share code between the charts page and the analysis task page.
329 (App.Manifest.fetchRunsWithPlatformAndMetric): Extracted from App.Pane._fetch to be reused in
330 App.AnalysisTaskViewModel._taskUpdated.
332 2014-10-28 Ryosuke Niwa <rniwa@webkit.org>
334 Remove App.PaneController.bugsChangeCount in the new perf dashboard
335 https://bugs.webkit.org/show_bug.cgi?id=138111
337 Reviewed by Darin Adler.
340 (App.PaneController.bugsChangeCount): Removed.
341 (App.PaneController.actions.associateBug): Call _updateMarkedPoints instead of incrementing bugsChangeCount.
342 (App.PaneController._updateMarkedPoints): Extracted from App.InteractiveChartComponent._updateDotsWithBugs.
343 Finds the list of current run's points that are associated with bugs.
344 (App.InteractiveChartComponent._updateMarkedDots): Renamed from _updateDotsWithBugs.
345 * public/v2/chart-pane.css:
346 (.chart .marked): Renamed from .hasBugs.
347 * public/v2/index.html: Specify chartPointRadius and markedPoints.
349 2014-10-27 Ryosuke Niwa <rniwa@webkit.org>
351 REGRESSION: commit logs are not shown sometimes on the new dashboard UI
352 https://bugs.webkit.org/show_bug.cgi?id=138099
354 Reviewed by Benjamin Poulain.
356 The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
357 _showDetails inverting the order of the current and old measurements.
360 (App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
361 (App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
362 current (latest) measurement and the first point is the oldest measurement.
363 (App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
365 2014-10-18 Ryosuke Niwa <rniwa@webkit.org>
367 Perf dashboard should provide a way to associate bugs with a test run
368 https://bugs.webkit.org/show_bug.cgi?id=137857
370 Reviewed by Andreas Kling.
372 Added a "privileged" API, /privileged-api/associate-bug, to associate a bug with a test run.
373 /privileged-api/ is to be protected by an authentication mechanism such as DigestAuth over https by
374 the Apache configuration.
377 The Cross Site Request (CSRF) Forgery prevention for privileged APIs work as follows. When a user is
378 about to make a privileged API access, the front end code obtains a CSRF token generated by POST'ing
379 to privileged-api/generate-csrf-token; the page sets a randomly generated salt and an expiration time
380 via the cookie and returns a token computed from those two values as well as the remote username.
382 The font end code then POST's the request along with the returned token. The server side code verifies
383 that the specified token can be generated from the salt and the expiration time set in the cookie, and
384 the token hasn't expired.
387 * init-database.sql: Added bug_url to bug_trackers table, and added bugs table. Each bug tracker will
388 have zero or exactly one bug associated with a test run.
390 * public/admin/bug-trackers.php: Added the support for editing bug_url.
391 * public/api/runs.php:
392 (fetch_runs_for_config): Modified the query to fetch bugs associated with test_runs.
393 (parse_bugs_array): Added. Parses the aggregated bugs and creates a dictionary that maps a tracker id to
394 an associated bug if there is one.
395 (format_run): Calls parse_bugs_array.
397 * public/include/json-header.php: Added helper functions to deal for CSRF prevention.
398 (ensure_privileged_api_data): Added. Dies immediately if the request's method is not POST or doesn't
399 have a valid JSON payload.
400 (ensure_privileged_api_data_and_token): Ditto. Also checks that the CSRF prevention token is valid.
401 (compute_token): Computes a CSRF token using the REMOTE_USER (e.g. set via BasicAuth), the salt, and
402 the expiration time stored in the cookie.
403 (verify_token): Returns true iff the specified token matches what compute_token returns from the cookie.
405 * public/include/manifest.php:
406 (ManifestGenerator::bug_trackers): Include bug_url as bugUrl in the manifest. Also use tracker_id instead
407 of tracker_name as the key in the manifest. This requires changes to both v1 and v2 front end.
410 (Chart..showTooltipWithResults): Updated for the manifest format changed mentioned above.
412 * public/privileged-api/associate-bug.php: Added.
413 (main): Added. Associates or dissociates a bug with a test run inside a transaction. It prevent a CSRF
414 attack via ensure_privileged_api_data_and_token, which calls verify_token.
416 * public/privileged-api/generate-csrf-token.php: Added. Generates a CSRF token valid for one hour.
419 (.disabled .icon-button:hover g): Used by the "bugs" icon when a range of points or no points are
423 (App.PaneController.actions.toggleBugsPane): Added. Toggles the visibility of the bugs pane when exactly
424 one point is selected in the chart. Also hides the search pane when making the bugs pane visible since
425 they would overlap on each other if both of them are shown.
426 (App.PaneController.actions.associateBug): Makes a privileged API request to associate the specified bug
427 with the currently selected point (test run). Updates the bug information in "details" and colors of dots
428 in the charts to reflect new states. Because chart data objects aren't real Ember objects for performance
429 reasons, we have to use a dirty hack of modifying a dummy counter bugsChangeCount.
430 (App.PaneController.actions.toggleSearchPane): Renamed from toggleSearch. Also hides the bugs pane when
431 showing the search pane.
432 (App.PaneController.actions.rangeChanged): Takes all selected points as the second argument instead of
433 taking start and end points as the second and the third arguments so that _showDetails can enumerate all
434 bugs in the selected range.
436 (App.PaneController._detailsChanged): Added. Hide the bugs pane whenever a new point is selected.
437 Also update singlySelectedPoint, which is used by toggleBugsPane and associateBug.
438 (App.PaneController._currentItemChanged): Updated for the _showDetails change.
439 (App.PaneController._showDetails): Takes an array of selected points in place of old arguments.
440 Simplified the code to compute the revision information. Calls _updateBugs to format the associated bugs.
441 (App.PaneController._updateBugs): Sets details.bugTrackers to a dictionary that maps a bug tracker id to
442 a bug tracker proxy with an array of (bugNumber, bugUrl) pairs and also editedBugNumber, which is used by
443 the bugs pane to associate or dissociate a bug number, if exactly one point is selected.
445 (App.InteractiveChartComponent._updateDotsWithBugs): Added. Sets hasBugs class on dots as needed.
446 (App.InteractiveChartComponent._setCurrentSelection): Finds and passes all points in the selected range
447 to selectionChanged action instead of just finding the first and the last points.
449 * public/v2/chart-pane.css: Updated the style.
452 (PrivilegedAPI): Added. A wrapper for privileged APIs' CSRF tokens.
453 (PrivilegedAPI.sendRequest): Makes a privileged API call. Fetches a new CSRF token if needed.
454 (PrivilegedAPI._generateTokenInServerIfNeeded): Makes a request to privileged-api/generate-csrf-token if
455 we haven't already obtained a CSRF token or if the token has already been expired.
456 (PrivilegedAPI._post): Makes a single POST request to /privileged-api/* with a JSON payload.
458 (Measurement.prototype.bugs): Added.
459 (Measurement.prototype.hasBugs): Returns true iff bugs has more than one bug number.
460 (Measurement.prototype.associateBug): Associates a bug with a test run via privileged-api/associate-bug.
462 * public/v2/index.html: Added the bugs pane. Also added a list of bugs associated with the current run in
465 * public/v2/manifest.js:
466 (App.BugTracker.bugUrl):
467 (App.BugTracker.newBugUrl): Added.
468 (App.BugTracker.repositories): Added. This was a missing back reference to repositories.
469 (App.MetricSerializer.normalizePayload): Now parses/loads the list of bug trackers from the manifest.
470 (App.Manifest.repositoriesWithReportedCommits): Now initialized to an empty array instead of null.
471 (App.Manifest.bugTrackers): Added.
472 (App.Manifest._fetchedManifest): Sets App.Manifest.bugTrackers. Also sorts the list of repositories by
473 their respective ids to make the ordering stable.
475 2014-10-14 Ryosuke Niwa <rniwa@webkit.org>
477 Remove unused jobs table
478 https://bugs.webkit.org/show_bug.cgi?id=137724
480 Reviewed by Daniel Bates.
482 Removed jobs table in the database as well as related code.
485 * public/admin/jobs.php: Removed.
486 * public/admin/tests.php:
487 * public/include/admin-header.php:
489 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
491 New perf dashboard should have an ability to search commits by a keyword
492 https://bugs.webkit.org/show_bug.cgi?id=137675
494 Reviewed by Geoffrey Garen.
496 /api/commits/ now accepts query parameters to search a commit by a keyword. Its output format changed to
497 include "authorEmail" and "authorName" directly as columns instead of including an "author" object.
498 This API change allows fetch_commits_between to generate results without processing Postgres query results.
500 In the front end side, we've added a search pane in pane controller, and the interactive chart component
501 now has a concept of highlighted items which is used to indicate commits found by the search pane.
503 * public/api/commits.php:
504 (main): Extract query parameters: keyword, from, and to and use that to fetch appropriate commits.
505 (fetch_commits_between): Moved some code from main. Now takes a search term as the third argument.
506 We look for a commit if its author name or email contains the keyword or if its revision matches the keyword.
507 (format_commit): Renamed from format_commits. Now only formats one commit.
509 * public/include/db.php:
510 (Database::query_and_fetch_all): Now returns array() when the query results is empty (instead of false).
512 * public/v2/app.css: Renamed .close-button to .icon-button since it's used by a search button as well.
515 (App.Pane.searchCommit): Added. Finds the commits by a search term and assigns 'highlightedItems',
516 which is a hash table that contains highlighted items' measurements' ids as keys.
517 (App.PaneController.actions.toggleSearch): Toggles the visibility of the search pane. Also sets
518 the default commit repository.
519 (App.PaneController.actions.searchCommit): Delegates the work to App.Pane.searchCommit.
520 (App.InteractiveChartComponent._constructGraphIfPossible): Fixed a bug that we weren't removing old this._dots.
521 Added the code to initialize this._highlights.
522 (App.InteractiveChartComponent._updateDimensionsIfNeeded): Updates dimensions of highlight lines.
523 (App.InteractiveChartComponent._updateHighlightPositions): Added. Ditto.
524 (App.InteractiveChartComponent._highlightedItemsChanged): Adds vertical lines for highlighted items and deletes
525 the existing lines for the old highlighted items.
526 (App.CommitsViewerComponent.commitsChanged): Updated the code per JSON API change mentioned above.
527 Also fixed a bug that the code tries to update the commits viewer even if the viewer had already been destroyed.
529 * public/v2/chart-pane.css: Added style for the search pane and the search button.
531 * public/v2/data.js: Turned FetchCommitsForTimeRange into a class: CommitLogs.
533 (CommitLogs.fetchForTimeRange): Renamed from FetchCommitsForTimeRange. Takes a search term as an argument.
534 (CommitLogs._cachedCommitsBetween): Extracted from FetchCommitsForTimeRange.
535 (CommitLogs._cacheConsecutiveCommits): Ditto.
536 (FetchCommitsForTimeRange._cachedCommitsByRepository): Deleted.
537 (Measurement.prototype.commitTimeForRepository): Extracted from formattedRevisions.
538 (Measurement.prototype.formattedRevisions): Uses formattedRevisions. Deleted the unused code for commitTime.
540 * public/v2/index.html: Added the search pane and the search button. Also removed the unused attribute binding
541 for showingDetails since this property is no longer used.
543 * public/v2/manifest.js:
544 (App.Manifest.repositories): Added.
545 (App.Manifest.repositoriesWithReportedCommits): Ditto. Used by App.PaneController.actions.toggleSearch to find
546 the default repository to search.
547 (App.Manifest._fetchedManifest): Populates repositories and repositoriesWithReportedCommits.
549 2014-10-13 Ryosuke Niwa <rniwa@webkit.org>
551 Unreviewed build fix after r174555.
553 * public/include/manifest.php:
554 (ManifestGenerator::generate): Assign an empty array to $repositories_with_commit when there are no commits.
555 * tests/admin-regenerate-manifest.js: Fixed the test case.
557 2014-10-09 Ryosuke Niwa <rniwa@webkit.org>
559 New perf dashboard UI tries to fetch commits all the time
560 https://bugs.webkit.org/show_bug.cgi?id=137592
562 Reviewed by Andreas Kling.
564 Added hasReportedCommits boolean to repository meta data in manifest.json, and used that in
565 the front end to avoid issuing HTTP requests to fetch commit logs for repositories with
566 no reported commits as they are all going to fail.
568 Also added an internal cache to FetchCommitsForTimeRange in the front end to avoid fetching
569 the same commit logs repeatedly. There are two data structures we cache: commitsByRevision
570 which maps a given commit revision/hash to a commit object; and commitsByTime which is an array
571 of commits sorted chronologically by time.
573 * public/include/manifest.php:
576 (App.CommitsViewerComponent.commitsChanged):
579 (FetchCommitsForTimeRange):
580 (FetchCommitsForTimeRange._cachedCommitsByRepository):
582 * public/v2/manifest.js:
585 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
587 Another unreviewed build fix after r174477.
589 Don't try to insert a duplicated row into build_commits as it results in a database constraint error.
591 This has been caught by a test in /api/report. I don't know why I thought all tests were passing.
593 * public/include/report-processor.php:
595 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
597 Unreviewed build fix after r174477.
599 * init-database.sql: Removed build_commits_index since it's redundant with build_commit's primary key.
600 Also fixed a syntax error that we were missing "," after line that declared build_commit column.
602 * public/api/runs.php: Fixed the query so that test_runs without commits data will be retrieved.
603 This is necessary for baseline and target values manually added via admin pages.
605 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
607 Add v2 UI for the perf dashboard
608 https://bugs.webkit.org/show_bug.cgi?id=137537
610 Rubber-stamped by Andreas Kling.
613 * public/v2/app.css: Added.
614 * public/v2/app.js: Added.
615 * public/v2/chart-pane.css: Added.
616 * public/v2/data.js: Added.
617 * public/v2/index.html: Added.
618 * public/v2/js: Added.
619 * public/v2/js/d3: Added.
620 * public/v2/js/d3/LICENSE: Added.
621 * public/v2/js/d3/d3.js: Added.
622 * public/v2/js/d3/d3.min.js: Added.
623 * public/v2/js/ember-data.js: Added.
624 * public/v2/js/ember.js: Added.
625 * public/v2/js/handlebars.js: Added.
626 * public/v2/js/jquery.min.js: Added.
627 * public/v2/js/statistics.js: Added.
628 * public/v2/manifest.js: Added.
629 * public/v2/popup.js: Added.
631 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
633 Remove superfluously duplicated code in public/api/report-commits.php.
635 2014-10-08 Ryosuke Niwa <rniwa@webkit.org>
637 Perf dashboard should store commit logs
638 https://bugs.webkit.org/show_bug.cgi?id=137510
640 Reviewed by Darin Adler.
642 For the v2 version of the perf dashboard, we would like to be able to see commit logs in the dashboard itself.
644 This patch replaces "build_revisions" table with "commits" and "build_commits" relations to store commit logs,
645 and add JSON APIs to report and retrieve them. It also adds a tools/pull-svn.py to pull commit logs from
646 a subversion directory. The git version of this script will be added in a follow up patch.
649 In the new database schema, each revision in each repository is represented by exactly one row in "commits"
650 instead of one row for each build in "build_revisions". "commits" and "builds" now have a proper many-to-many
651 relationship via "build_commits" relations.
653 In order to migrate an existing instance of this application, run the following SQL commands:
657 INSERT INTO commits (commit_repository, commit_revision, commit_time)
658 (SELECT DISTINCT ON (revision_repository, revision_value)
659 revision_repository, revision_value, revision_time FROM build_revisions);
661 INSERT INTO build_commits (commit_build, build_commit) SELECT revision_build, commit_id
662 FROM commits, build_revisions
663 WHERE commit_repository = revision_repository AND commit_revision = revision_value;
665 DROP TABLE build_revisions;
670 The helper script to submit commit logs can be used as follows:
672 python ./tools/pull-svn.py "WebKit" https://svn.webkit.org/repository/webkit/ https://perf.webkit.org
673 feeder-slave feeder-slave-password 60 "webkit-patch find-users"
675 The above command will pull the subversion server at https://svn.webkit.org/repository/webkit/ every 60 seconds
676 to retrieve at most 10 commits, and submits the results to https://perf.webkit.org using "feeder-slave" and
677 "feeder-slave-password" as the builder name and the builder password respectively.
679 The last, optional, argument is the shell command to convert a subversion account to the corresponding username.
680 e.g. "webkit-patch find-users rniwa@webkit.org" yields "Ryosuke Niwa" <rniwa@webkit.org> in the stdout.
683 * init-database.sql: Replaced "build_revisions" relation with "commits" and "build_commits" relations.
685 * public/api/commits.php: Added. Retrieves a list of commits based on arguments in its path of the form
686 /api/commits/<repository-name>/<filter>. The behavior of this API depends on <filter> as follows:
688 - Not specified - It returns every single commit for a given repository.
689 - Matches "oldest" - It returns the commit with the oldest timestamp.
690 - Matches "latest" - It returns the commit with the latest timestamp.
691 - Matches "last-reported" - It returns the commit with the latest timestamp added via report-commits.php.
692 - Is entirely alphanumeric - It returns the commit whose revision matches the filter.
693 - Is of the form <alphanumeric>:<alphanumeric> or <alphanumeric>-<alphanumeric> - It retrieves the list
694 of commits added via report-commits.php between two timestamps retrieved from commits whose revisions
695 match the two alphanumeric values specified. Because it retrieves commits based on their timestamps,
696 the list may contain commits that do not appear as neither hash's ancestor in git/mercurial.
698 (commit_from_revision):
699 (fetch_commits_between):
702 * public/api/report-commits.php: Added. A JSON API to report new subversion, git, or mercurial commits.
703 See tests/api-report-commits.js for examples on how to use this API.
705 * public/api/runs.php: Updated the query to use "commit_builds" and "commits" relations instead of
706 "build_revisions". Regrettably, the new query is 20% slower but I'm going to wait until the new UI is ready
707 to optimize this and other JSON APIs.
709 * public/include/db.php:
710 (Database::select_or_insert_row):
711 (Database::update_or_insert_row): Added.
712 (Database::_select_update_or_insert_row): Extracted from select_or_insert_row. Try to update first and then
713 insert if the update fails for update_or_insert_row. Preserves the old behavior when $should_update is false.
715 (Database::select_first_row):
716 (Database::select_last_row): Added.
717 (Database::select_first_or_last_row): Extracted from select_first_row. Fixed a bug that we were asserting
718 $order_by to be not alphanumeric/underscore. Retrieve the last row instead of the first if $descending_order.
720 * public/include/report-processor.php:
721 (ReportProcessor::resolve_build_id): Store commits instead of build_revisions. We don't worry about the race
722 condition for adding "build_commits" rows since we shouldn't have a single tester submitting the same result
723 concurrently. Even if it happened, it will only result in a PHP error and the database will stay consistent.
726 (pathToTests): Don't call path.resolve with "undefined" testName; It throws an exception in the latest node.js.
728 * tests/api-report-commits.js: Added.
729 * tests/api-report.js: Fixed a test per build_revisions to build_commits/commits replacement.
732 * tools/pull-svn.py: Added. See above for how to use this script.
734 (determine_first_revision_to_fetch):
735 (fetch_revision_from_dasbhoard):
736 (fetch_commit_and_resolve_author):
739 (resolve_author_name_from_email):
742 2014-09-30 Ryosuke Niwa <rniwa@webkit.org>
744 Update Install.md for Mavericks and fix typos
745 https://bugs.webkit.org/show_bug.cgi?id=137276
747 Reviewed by Benjamin Poulain.
749 Add the instruction to copy php.ini to enable the Postgres extension in PHP.
751 Also use perf.webkit.org as the directory name instead of WebKitPerfMonitor.
753 Finally, init-database.sql is no longer located inside database directory.
757 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
759 Report run id's in api/runs.php for the new dashboard UI
760 https://bugs.webkit.org/show_bug.cgi?id=135813
762 Reviewed by Andreas Kling.
764 Include run_id in the generated JSON.
766 * public/api/runs.php:
767 (fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
770 2014-08-11 Ryosuke Niwa <rniwa@webkit.org>
772 Merging platforms mixes baselines and targets into reported data
773 https://bugs.webkit.org/show_bug.cgi?id=135260
775 Reviewed by Andreas Kling.
777 When merging two platforms, move test configurations of a different type (baseline, target)
778 as well as of different metric (Time, Runs).
780 Also avoid fetching the entire table of runs just to see if there are no remaining runs.
781 It's sufficient to detect one such test_runs object.
783 * public/admin/platforms.php:
786 2014-07-30 Ryosuke Niwa <rniwa@webkit.org>
788 Merging platforms mixes baselines and targets into reported data
789 https://bugs.webkit.org/show_bug.cgi?id=135260
791 Reviewed by Geoffrey Garen.
793 Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
794 Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).
796 * public/admin/platforms.php:
798 2014-07-23 Ryosuke Niwa <rniwa@webkit.org>
800 Build fix after r171361.
802 * public/js/helper-classes.js:
803 (.this.formattedBuildTime):
805 2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
807 Perf dashboard spends 2s processing JSON data during the page loads
808 https://bugs.webkit.org/show_bug.cgi?id=135152
810 Reviewed by Andreas Kling.
812 In the Apple internal dashboard, we were spending as much as 2 seconds
813 converting raw JSON data into proper JS objects while loading the dashboard.
815 This caused the apparent unresponsiveness of the dashboard despite of the fact
816 charts themselves updated almost instantaneously.
819 * public/js/helper-classes.js:
820 (TestBuild): Compute the return values of formattedTime and formattedBuildTime
821 lazily as creating new Date objects and running string replace is expensive.
822 (TestBuild.formattedTime):
823 (TestBuild.formattedBuildTime):
824 (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
825 (PerfTestRuns.addResult): Deleted.
827 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
829 Perf dashboard shouldn't show the full git hash
830 https://bugs.webkit.org/show_bug.cgi?id=135083
832 Reviewed by Benjamin Poulain.
834 Detect Git/Mercurial hash by checking the length.
836 If it's a hash, use the first 8 characters in the label
837 while retaining the full length to be used in hyperlinks.
839 * public/js/helper-classes.js:
840 (.this.formattedRevisions):
843 2014-05-29 Ryosuke Niwa <rniwa@webkit.org>
845 Add an instruction on how to backup the database.
846 https://bugs.webkit.org/show_bug.cgi?id=133391
848 Rubber-stamped by Andreas Kling.
852 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
854 Build fix after r166479. 'bytes' is now abbreviated as 'B'.
856 * public/js/helper-classes.js:
857 (PerfTestRuns.smallerIsBetter):
859 2014-04-08 Ryosuke Niwa <rniwa@webkit.org>
869 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
871 WebKitPerfMonitor: There should be a way to add all metrics of a suite without also adding subtests
872 https://bugs.webkit.org/show_bug.cgi?id=131157
874 Reviewed by Andreas Kling.
876 Split "all metrics" into all metrics of a test suite and all subtests of the suite.
877 This allows, for example, adding all metrics such as Arithmetic and Geometric for
878 a given test suite without also adding its subtests.
884 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
886 WebKitPerfMonitor: Tooltips cannot be pinned after using browser's back button
887 https://bugs.webkit.org/show_bug.cgi?id=131155
889 Reviewed by Andreas Kling.
891 The bug was caused by Chart.attach binding event listeners on plot container on each call.
892 This resulted in the click event handler toggling the visiblity of the tooltip twice upon
893 click when attach() has been called even number of times, keeping the tooltip invisible.
895 Fixed the bug by extracting the code to bind event listeners outside of Chart.attach as
896 a separate function, bindPlotEventHandlers, and calling it exactly once when Chart.attach
897 is called for the first time.
901 (Chart..bindPlotEventHandlers):
903 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
905 WebKitPerfMonitor: Tooltips can be cut off at the top
906 https://bugs.webkit.org/show_bug.cgi?id=130960
908 Reviewed by Andreas Kling.
911 (#title): Removed the gradients, box shadows, and border from the header.
912 (#title h1): Reduce the font size.
913 (#title ul): Use line-height to vertically align the navigation bar instead of specifying a padding atop.
915 (.tooltop:before): Added. Identical to .tooltop:after except it's upside down (arrow facing up).
916 (.tooltip.inverted:before): Show the arrow facing up when .inverted is set.
917 (.tooltip.inverted:before): Hide the arrow facing down when .inverted is set.
918 * public/js/helper-classes.js:
919 (Tooltip.show): Show the tooltip below the point if placing it above the point results in the top of the
920 tooltip extending above y=0.
922 2014-04-03 Ryosuke Niwa <rniwa@webkit.org>
924 WebKitPerfMonitor: Y-axis adjustment is too aggressive
925 https://bugs.webkit.org/show_bug.cgi?id=130937
927 Reviewed by Andreas Kling.
929 Previously, adjusted min. and max. were defined as the two standards deviations away from EWMA of measured
930 results. This had two major problems:
931 1. Two standard deviations can be too small to show the confidence interval for results.
932 2. Sometimes baseline and target can be more than two standards deviations away.
934 Fixed the bug by completely rewriting the algorithm to compute the interval. Instead of blindly using two
935 standard deviations as margins, we keep adding quarter the standard deviation on each side until more than 90%
936 of points lie in the interval or we've expanded 4 standard deviations. Once this condition is met, we reduce
937 the margin on each side separately to reduce the empty space on either side.
939 A more rigorous approach would involve computing least squared value of results with respect to intervals
940 but that seems like an overkill for a simple UI problem; it's also computationally expensive.
943 (Chart..adjustedIntervalForRun): Extracted from computeYAxisBoundsToFitLines.
944 (Chart..computeYAxisBoundsToFitLines): Compute the min. and max. adjusted intervals out of adjusted intervals
945 for each runs (current, baseline, and target) so that at least one point from each set of results is shown.
946 We wouldn't see the difference between measured values versus baseline and target values otherwise.
947 * public/js/helper-classes.js:
948 (PerfTestResult.unscaledConfidenceIntervalDelta): Returns the default value if the confidence
949 interval delta cannot be computed.
950 (PerfTestResult.isInUnscaledInterval): Added. Returns true iff the confidence intervals lies
951 within the given interval.
952 (PerfTestRuns..filteredResults): Extracted from unscaledMeansForAllResults now that PerfTestRuns.min and
953 PerfTestRuns.max need to use both mean and confidence interval delta for each result.
954 (PerfTestRuns..unscaledMeansForAllResults):
955 (PerfTestRuns.min): Take the confidence interval delta into account.
956 (PerfTestRuns.max): Ditto.
957 (PerfTestRuns.countResults): Returns the number of results in the given time frame (> minTime).
958 (PerfTestRuns.countResultsInInterval): Returns the number of results whose confidence interval lie within the
960 (PerfTestRuns.exponentialMovingArithmeticMean): Fixed the typo so that it actually computes the EWMA.
962 2014-03-31 Ryosuke Niwa <rniwa@webkit.org>
964 Some CSS tweaks after r166477 and r166479,
968 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
970 WebKitPerfMonitor: Sometimes text inside panes overlap
971 https://bugs.webkit.org/show_bug.cgi?id=130956
973 Reviewed by Gyuyoung Kim.
975 Revamped the pane UI. Now build info uses table element instead of plane text with BRs. The computed status of
976 the latest result against baseline/target such as "3% until target" is now shown above the current value. This
977 reduces the total height of the pane and fits more information per screen capita on the dashboard.
979 * public/index.html: Updated and added a bunch of CSS rules for the new look.
980 (.computeStatus): Don't append the build info here. The build info is constructed as a separate table now.
981 (.createSummaryRowMarkup): Use th instead of td for "Current", "Baseline", and "Target" in the summary table.
982 (.buildLabelWithLinks): Construct table rows instead of br separated lines of text. This streamlines the look
983 of the build info shown in a chart pane and a tooltip.
984 (Chart): Made .status a table.
985 (Chart.populate): Prepend status.text, which contains text such as "3% until target", into the summary rows
986 right above "Current" value, and populate .status with buildLabelWithLinks manually instead of status.text
987 now that status.text no longer contains it.
988 (Chart..showTooltipWithResults): Wrap buildLabelWithLinks with a table element.
990 * public/js/helper-classes.js:
991 (TestBuild.formattedRevisions): Don't include repository names in labels since repository names are now added
992 by buildLabelWithLinks inside th elements. Also place spaces around '-' between two different OS X versions.
993 e.g. "OS X 10.8 - OS X 10.9" instead of "OS X 10.8-OS X 10.9".
994 (PerfTestRuns): Use "/s" for "runs/s" and "B" for "bytes" to make text shorter in .status and .summaryTable.
995 (PerfTestRuns..computeScalingFactorIfNeeded): Avoid placing a space between 'M' and a unit starting with a
996 capital letter; e.g. "MB" instead of "M B".
998 2014-03-30 Ryosuke Niwa <rniwa@webkit.org>
1000 WebKitPerfMonitor: Header and number-of-days slider takes up too much space
1001 https://bugs.webkit.org/show_bug.cgi?id=130957
1003 Reviewed by Gyuyoung Kim.
1005 Moved the slider into the header. Also reduced the spacing between the header and platform names.
1006 This reclaims 50px × width of the screen real estate.
1008 * public/common.css:
1009 (#title): Reduced the space below the header from 20px to 10px.
1010 * public/index.html:
1011 (#numberOfDaysPicker): Removed the rounded border around the number-of-days slider.
1012 (#dashboard > tbody > tr > td): Added a 1.5em padding at the bottom.
1013 (#dashboard > thead th): That allows us to remove the padding at the top here. This reduces the wasted screen
1014 real estate between the header and the platform names.
1016 2014-03-10 Zoltan Horvath <zoltan@webkit.org>
1018 Update the install guidelines for perf.webkit.org
1019 https://bugs.webkit.org/show_bug.cgi?id=129895
1021 Reviewed by Ryosuke Niwa.
1023 The current install guideline for perf.webkit.org discourages the use of the installed
1024 Server application. I've actualized the documentation for Mavericks, and modified the
1025 guideline to include the instructions for Server.app also.
1029 2014-03-08 Zoltan Horvath <zoltan@webkit.org>
1031 Update perf.webkit.org json example
1032 https://bugs.webkit.org/show_bug.cgi?id=129907
1034 Reviewed by Andreas Kling.
1036 The current example is not valid json syntax. I fixed the syntax errors and indented the code properly.
1040 2014-01-31 Ryosuke Niwa <rniwa@webkit.org>
1042 Merge database-common.js and utility.js into run-tests.js.
1044 Reviewed by Matthew Hanson.
1046 Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
1047 Also moved init-database.sql out of the database directory and removed the directory entirely.
1049 * database: Removed.
1050 * database/database-common.js: Removed.
1051 * database/utility.js: Removed.
1052 * init-database.sql: Moved from database/init-database.sql.
1054 (connect): Moved from database-common.js.
1055 (pathToDatabseSQL): Extracted from pathToLocalScript.
1056 (pathToTests): Moved from database-common.js.
1059 (SerializedTaskQueue): Ditto.
1061 (initializeDatabase):
1062 (TestEnvironment.it):
1063 (TestEnvironment.queryAndFetchAll):
1066 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1068 Remove the dependency on node.js from the production code.
1070 Reviewed by Ricky Mondello.
1072 Work towards <rdar://problem/15955053> Upstream SafariPerfMonitor.
1074 Removed node.js dependency from TestRunsGenerator. It was really a design mistake to invoke node.js from php.
1075 It added so much complexity with only theoretical extensibility of adding aggregators. It turns out that
1076 many aggregators we'd like to add are a lot more complicated than ones that could be written under the current
1077 infrastructure, and we need to make the other aspects (e.g. the level of aggregations) a lot more extensible.
1078 Removing and simplifying TestRunsGenerator allows us to implement such extensions in the future.
1080 Also removed the js files that are no longer used.
1082 * config.json: Moved from database/config.json.
1083 * database/aggregate.js: Removed. No longer used.
1084 * database/database-common.js: Removed unused functions, and updated the path to config.json.
1085 * database/process-jobs.js: Removed. No longer used.
1086 * database/sample-data.sql: Removed. We have a much better corpus of data now.
1087 * database/schema.graffle: Removed. It's completely obsolete.
1088 * public/include/db.php: Updated the path to config.json.
1089 * public/include/evaluator.js: Removed.
1091 * public/include/report-processor.php:
1092 (TestRunsGenerator::aggregate): Directly aggregate values via newly added aggregate_values method instead of
1093 storing values into $expressions and calling evaluate_expressions_by_node.
1094 (TestRunsGenerator::aggregate_values): Added.
1095 (TestRunsGenerator::compute_caches): Directly compute the caches.
1097 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1099 Build fix. Don't fail the platform merges even if there are no test configurations to be moved to the new platform.
1101 * public/admin/platforms.php:
1102 * public/include/db.php:
1104 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1106 Zoomed y-axis view is ununsable when the last result is an outlier.
1108 Reviewed by Stephanie Lewis.
1110 Show two standard deviations from the exponential moving average with alpha = 0.3 instead of the mean of
1111 the last result so that the graph looks sane if the last result was an outlier. However, always show
1112 the last result's mean even if it was an outlier.
1114 * public/index.html:
1115 * public/js/helper-classes.js:
1116 (unscaledMeansForAllResults): Extracted from min/max/sampleStandardDeviation.
1117 Also added the ability to cache the unscaled means to avoid recomputation.
1118 (PerfTestRuns.min): Refactored to use unscaledMeansForAllResults.
1119 (PerfTestRuns.max): Ditto.
1120 (PerfTestRuns.sampleStandardDeviation): Ditto.
1121 (PerfTestRuns.exponentialMovingArithmeticMean): Added.
1123 2014-01-30 Ryosuke Niwa <rniwa@webkit.org>
1127 * public/admin/tests.php:
1128 * public/js/helper-classes.js:
1130 2014-01-29 Ryosuke Niwa <rniwa@webkit.org>
1132 Use two standard deviations instead as I mentioned in the mailing list.
1134 * public/index.html:
1136 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1138 The performance dashboard erroneously shows upward arrow for combined metrics.
1140 A single outlier can ruin the zoomed y-axis view.
1142 Rubber-stamped by Antti Koivisto.
1144 * public/index.html:
1145 (computeYAxisBoundsToFitLines): Added adjustedMax and adjustedMin, which are pegged at 4 standard deviations
1146 from the latest results' mean.
1147 (Chart): Renamed shouldStartYAxisAtZero to shouldShowEntireYAxis.
1148 (Chart.attachMainPlot): Use the adjusted max and min when we're not showing the entire y-axis.
1149 (Chart.toggleYAxis):
1150 * public/js/helper-classes.js:
1151 (PerfTestRuns.sampleStandardDeviation): Added.
1152 (PerfTestRuns.smallerIsBetter): 'Combined' is a smaller is better metric.
1154 2014-01-28 Ryosuke Niwa <rniwa@webkit.org>
1156 Don't include the confidence interval when computing the y-axis.
1158 Rubber-stamped by Simon Fraser.
1160 * public/js/helper-classes.js:
1164 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1166 Tiny CSS tweak for tooltips.
1168 * public/index.html:
1170 2014-01-25 Ryosuke Niwa <rniwa@webkit.org>
1172 Remove the erroneously repeated code.
1174 * public/admin/test-configurations.php:
1176 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1178 <rdar://problem/15704893> perf dashboard should show baseline numbers
1180 Reviewed by Stephanie Lewis.
1182 * public/admin/bug-trackers.php:
1183 (associated_repositories): Return an array of HTMLs instead of echo'ing as expected by AdministrativePage.
1186 * public/admin/platforms.php:
1187 (merge_list): Ditto.
1189 * public/admin/test-configurations.php: Added.
1190 (add_run): Adds a "synthetic" test run and a corresponding build. It doesn't create run_iterations and
1191 build_revisions as they're not meaningful for baseline / target numbers.
1192 (delete_run): Deletes a synthetic test run and its build. It verifies that the specified build has exactly
1193 one test run so that we don't accidentally delete a reported test run.
1194 (generate_rows_for_configurations): Generates rows of configuration IDs and types.
1195 (generate_rows_for_test_runs): Ditto for test runs. It also emits the form to add new "synthetic" test runs
1196 and delete existing ones.
1198 * public/admin/tests.php: We wrongfully assumed there is exactly one test configuration for each metric
1199 on each platform; there could be configurations of distinct types such as "current" and "baseline".
1200 Thus, update all test configurations for a given metric when updating config_is_in_dashboard.
1202 * public/api/runs.php: Remove the NotImplemented when we have multiple test configurations.
1203 (fetch_runs_for_config): "Synthetic" test runs created on test-configurations page are missing revision
1204 data so we need to left-outer-join (instead of inner-join) build_revisions. To avoid making the query
1205 unreadable, don't join revision_repository here. Instead, fetch the list of repositories upfront and
1206 resolve names in parse_revisions_array. This actually reduces the query time by ~10%.
1208 (parse_revisions_array): Skip an empty array created for "synthetic" test runs.
1210 * public/include/admin-header.php:
1211 (AdministrativePage::render_table): Now custom columns support sub columns. e.g. a configuration column may
1212 have id and type sub columns, and each custom column could generate multiple rows.
1214 Any table with sub columns now generates two rows for thead. We generate td's in in the first row without
1215 sub columns with rowspan of 2, and generate ones with sub columns with colspan set to the sub column count.
1216 We then proceed to generate the second header row with sub column names.
1218 When generating the actual content, we first generate all custom columns as they may have multiple rows in
1219 which case regular columns need rowspan set to the maximum number of rows.
1221 Once we've generated the first row, we proceed to generate subsequent rows for those custom columns that
1224 (AdministrativePage::render_custom_cells): Added. This function is responsible for generating table cells
1225 for a given row in a given custom column. It generates an empty td when the custom column doesn't have
1226 enough rows. It also generates empty an td when it doesn't have enough columns in some rows except when
1227 the entire row consists of exactly one cell for a custom column with sub columns, in which case the cell is
1228 expanded to occupy all sub columns.
1230 * public/include/manifest.php:
1231 (ManifestGenerator::platforms): Don't add the metric more than once.
1233 * public/include/test-name-resolver.php:
1234 (TestNameResolver::__construct): We had wrongfully assumed that we have exactly one test configuration on
1235 each platform for each metric like tests.php. Fixed that. Also fetch the list of aggregators to compute the
1236 full metric name later.
1237 (TestNameResolver::map_metrics_to_tests): Populate $this->id_to_metric.
1238 (TestNameResolver::test_id_for_full_name): Simplified the code using array_get.
1239 (TestNameResolver::full_name_for_test): Added.
1240 (TestNameResolver::full_name_for_metric): Added.
1241 (TestNameResolver::configurations_for_metric_and_platform): Renamed as it returns multiple configurations.
1243 * public/js/helper-classes.js:
1244 (TestBuild): Use the build time as the maximum time when revision information is missing for "synthetic"
1245 test runs created to set baseline and target points.
1247 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1249 Build fix after r57928. Removed a superfluous close parenthesis.
1251 * public/api/runs.php:
1253 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1255 Unreviewed build & typo fixes.
1257 * public/admin/platforms.php:
1258 * tests/admin-platforms.js:
1260 2014-01-24 Ryosuke Niwa <rniwa@webkit.org>
1262 <rdar://problem/15704893> perf dashboard should show baseline numbers
1264 Rubber-stamped by Antti Koivisto.
1266 Organize some code into functions in runs.php.
1268 Also added back $paths that was erroneously removed in r57925 from json-header.php.
1270 * public/api/runs.php:
1271 (fetch_runs_for_config): Extracted.
1272 (format_run): Ditto.
1274 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1276 Merge the upstream json-shared.php as of https://trac.webkit.org/r162693.
1278 * database/config.json:
1279 * public/admin/reprocess-report.php:
1280 * public/api/report.php:
1281 * public/api/runs.php:
1282 * public/include/json-header.php:
1284 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1286 Commit yet another forgotten change.
1288 Something went horribly wrong with my merge :(
1290 * database/init-database.sql:
1292 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1294 Commit one more forgotten change. Sorry for making a mess here.
1296 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1298 Commit the forgotten files.
1300 * public/admin/platforms.php: Added.
1301 * tests/admin-platforms.js: Added.
1303 2014-01-23 Ryosuke Niwa <rniwa@webkit.org>
1305 <rdar://problem/15889905> SafariPerfMonitor: there should be a way to merge and hide platforms
1307 Reviewed by Stephanie Lewis.
1309 Added /admin/platforms/ page to hide and merge platforms.
1311 Merging two platforms is tricky because we need to migrate test runs as well as some test configurations.
1312 Recall that each test (e.g. Dromaeo) can have many "test metrics" (e.g. MaxAllocations, EndAllocations),
1313 and they have a distinct "test configuration" for each platform (e.g. MaxAllocation on Mountain Lion), and
1314 each test configuration a distinct "test run" for each build.
1316 In order to merge platform A into platform B, we must migrate all test runs that belong to platform A via
1317 their test configurations into platform B.
1319 Suppose we're migrating a test run R for test configuration T_A in platform A for metric M. Since M exists
1320 independent of platforms, R should continue to relate to M through some test configuration. Unfortunately,
1321 we can't simply move T_A into platform B since we may already have a test configuration T_B for metric M
1322 in platform B, in which case R should relate to T_B instead.
1324 Thus, we first migrate all test runs for which we already have corresponding test configurations in the
1325 new platform. We then migrate the test configurations of the remaining test runs.
1327 * database/init-database.sql: Added platform_hidden.
1329 * public/admin/platforms.php: Added.
1330 (merge_platforms): Added. Implements the algorithm described above.
1331 (merge_list): Added.
1333 * public/admin/tests.php: Disable the checkbox to show a test configuration on the dashboard if its platform
1334 is hidden since it doesn't do anything.
1336 * public/include/admin-header.php: Added the hyperlink to /admin/platforms.
1337 (update_field): Don't bail out if the newly added "update-column" is set to the field name even if $_POST is
1338 missing it since unchecked checkbox doesn't set the value in $_POST.
1339 (AdministrativePage::render_form_control_for_column): Added the support for boolean edit mode. Also used
1340 switch statement instead of repeated if's.
1341 (AdministrativePage::render_table): Emit "update-column" for update_field.
1343 * public/include/db.php: Disable warnings when we're not in the debug mode.
1345 * public/include/manifest.php:
1346 (ManifestGenerator::platforms): Skip platforms that have been hidden.
1349 (TestEnvironment.postJSON):
1350 (TestEnvironment.httpGet):
1351 (TestEnvironment.httpPost): Added.
1352 (sendHttpRequest): Set the content type if specified.
1354 * tests/admin-platforms.js: Added tests.
1356 2014-01-22 Ryosuke Niwa <rniwa@webkit.org>
1358 Extract the code to compute full test names from tests.php.
1360 Reviewed by Stephanie Lewis.
1362 Extracted TestNameResolver out of tests.php. This reduces the number of global variables in tests.php
1363 and paves our way to re-use the code in other pages.
1365 * public/admin/tests.php:
1367 * public/include/db.php:
1368 (array_set_default): Renamed from array_item_set_default and moved from tests.php as it's used in both
1369 tests.php and test-name-resolver.php.
1371 * public/include/test-name-resolver.php: Added.
1372 (TestNameResolver::__construct):
1373 (TestNameResolver::compute_full_name): Moved from tests.php.
1374 (TestNameResolver::map_metrics_to_tests): Ditto.
1375 (TestNameResolver::sort_tests_by_full_name): Ditto.
1376 (TestNameResolver::tests): Added.
1377 (TestNameResolver::test_id_for_full_name): Ditto.
1378 (TestNameResolver::metrics_for_test_id): Ditto.
1379 (TestNameResolver::child_metrics_for_test_id): Ditto.
1380 (TestNameResolver::configuration_for_metric_and_platform): Ditto.
1382 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1384 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1386 Reviewed by Stephanie Lewis.
1388 Add the ability to reprocess reports so that I can re-associate wrongfully associated reports.
1390 Added public/admin/reprocess-report.php. It doesn't have any nice UI to find reports and it returns JSON
1391 but that's sufficient to correct the wrongfully processed reports for now.
1393 * public/admin/reprocess-report.php: Added. Takes a report id in $_GET or $_POST and process the report.
1394 We should eventually add a nice UI to find and reprocess reports.
1396 * public/api/report.php: ReportProcessor and TestRunsGenerator have been removed.
1398 * public/include/db.php: Added the forgotten call to prefixed_column_names.
1400 * public/include/report-processor.php: Copied from public/api/report.php.
1401 (ReportProcessor::__construct): Fetch the list of aggregators here for simplicity.
1402 (ReportProcessor::process): Optionally takes $existing_report_id. When this value is specified, we don't
1403 create a new report or authenticate the builder password (the password is never stored in the report).
1404 Also use select_first_row instead of query_and_fetch_all to find the builder for simplicity.
1405 (ReportProcessor::construct_build_data): Extracted from store_report_and_get_build_data.
1406 (ReportProcessor::store_report): Ditto.
1408 * tests/admin-reprocess-report.js: Added.
1410 2014-01-21 Ryosuke Niwa <rniwa@webkit.org>
1412 <rdar://problem/15867325> Perf dashboard is erroneously associating reported results with old revisions
1414 Reviewed by Ricky Mondello.
1416 The bug was caused by a build fix r57645. It attempted to treat multiple reports from the same builder
1417 for the same build number as a single build by ignoring build time. This was necessary to associate
1418 multiple reports by a single build - e.g. for different performance test suites - because the scripts
1419 we use to submit results computed its own "build time" when they're called.
1421 An unintended consequence of this change was revealed when we moved a buildbot master to the new machine
1422 last week; new reports were wrongfully associated with old build numbers.
1424 Fixed the bug by not allowing reports made more than 1 day after the initial build time to be assigned
1425 to the same build. Instead, we create a new build object for those reports. Since the longest set of
1426 tests we have only take a couple of hours to run, 24 hours should be more than enough.
1428 * database/init-database.sql: We can no longer constrain that each build number is unique to a builder
1429 or that build number and build time pair is unique. Instead, constrain the uniqueness of the tuple
1430 (builder, build number, build time).
1432 * public/api/report.php:
1433 (ReportProcessor::resolve_build_id): Look for any builds made within the past one day. Create a new build
1434 when no such build exists. This prevents a report from being associated with a very old build of the same
1437 Also check that revision numbers or hashes match when we're adding revision info. This will let us catch
1438 a similar bug in the future sooner.
1440 * tests/api-report.js: Added three test cases.
1442 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1444 Merged the upstream changes to db.php
1445 See http://trac.webkit.org/browser/trunk/Websites/test-results/public/include/db.php
1447 * public/include/db.php:
1449 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1451 Update other scripts and tests per previous patch.
1453 * public/include/manifest.php:
1454 * tests/admin-regenerate-manifest.js:
1456 2014-01-20 Ryosuke Niwa <rniwa@webkit.org>
1458 Remove metrics_unit.
1460 Reviewed by Ricky Mondello.
1462 This column is no longer used by the front-end code since r48360.
1464 * database/init-database.sql:
1465 * public/admin/tests.php:
1467 2014-01-16 Ryosuke Niwa <rniwa@webkit.org>
1469 Unreviewed build fix.
1471 * public/api/report.php:
1473 2014-01-15 Ryosuke Niwa <rniwa@webkit.org>
1475 <rdar://problem/15832456> Automate DoYouEvenBench (124497)
1477 Reviewed by Ricky Mondello.
1479 Support a new alternative format for aggregated results where we have raw values as well as
1480 the list aggregators so that instead of
1481 "metrics": {"Time": ["Arithmetic"]}
1483 "metrics": {"Time": { "aggregators" : ["Arithmetic"], "current": [300, 310, 320, 330] }}
1485 This allows single JSON generated by run-perf-tests in WebKit to be shared between the perf
1486 dashboard and the generated results page, which doesn't know how to aggregate values.
1488 We need to keep the support for the old format because all other existing performance tests
1489 all rely on the old format. Even if we updated the tests, we need the dashboard to support
1490 the old format during the transition.
1492 * public/api/report.php:
1493 (ReportProcessor::recursively_ensure_tests): Support the new format in addition to the old one.
1494 (ReportProcessor::aggregator_list_if_exists): Replaced is_list_of_aggregators.
1496 * tests/api-report.js: Updated one of aggregator test cases to test the new format.
1498 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1500 Unreviewed; Tweak the CSS so that chart panes align vertically.
1502 * public/index.html:
1504 2013-05-31 Ryosuke Niwa <rniwa@webkit.org>
1506 SafariPerfMonitor should support Combined metric.
1508 * public/js/helper-classes.js:
1509 (PerfTestRuns): Added 'Combined' metric. In general, it could be used for smaller-is-better
1510 value as well but assume it to be greater-is-better for now.
1512 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1514 Commit the forgotten init-database change to add iteration_relative_time.
1516 * database/init-database.sql:
1518 2013-05-30 Ryosuke Niwa <rniwa@webkit.org>
1520 <rdar://problem/13993069> SafariPerfMonitor: Support accepting (relative time, value) pairs
1522 Reviewed by Ricky Mondello.
1524 Add the support for each value to have a relative time. This is necessary for frame rate history
1525 since a frame rate needs to be associated with a time it was sampled.
1527 * database/init-database.sql: Added iteration_relative_time to run_iterations.
1529 * public/api/report.php:
1530 (TestRunsGenerator::test_value_list_to_values_by_iterations): Reject any non-numeral values here.
1531 This code is used to aggregate values but it doesn't make sense to aggregate iteration values
1532 with relative time since taking the average of two frame rates for two subtests taken at two
1533 different times doesn't make any sense.
1534 (TestRunsGenerator::compute_caches): When we encounter an array value while computing sum, mean,
1535 etc..., use the second element since we assume values are of the form (relative time, frame rate).
1536 Also exit early with an error if the number of elements in the array is not a pair.
1537 (TestRunsGenerator::commit): Store the relative time and the frame rate as needed.
1539 * tests/api-report.js: Added a test case. Also modified existing test cases to account for
1540 iteration_relative_time.
1542 2013-05-27 Ryosuke Niwa <rniwa@webkit.org>
1544 <rdar://problem/13654488> SafariPerfMonitor: Support accepting single-value results
1546 Reviewed by Ricky Mondello.
1548 Support that. It's one line change.
1550 * public/api/report.php:
1551 (ReportProcessor.recursively_ensure_tests): When there is exactly one value, wrap it inside an array
1552 to match the convention assumed elsewhere.
1553 * tests/api-report.js: Added a test case.
1555 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1557 SafariPerfMonitor shows popups for points outside of the visible region.
1559 Rubber-stamped by Simon Fraser.
1561 * public/index.html:
1562 (Chart.closestItemForPageXRespectingPlotOffset): renamed from closestItemForPageX.
1563 (Chart.attach): Always use closestItemForPageXRespectingPlotOffset to work around the fact flot
1564 may return an item underneath y-axis labels.
1566 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1568 Tweak the CSS a little to avoid the test name overlapping with the summary table.
1570 * public/index.html:
1572 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1574 Unreviewed. Fix the typo. The anchor element should wrap the svg element, not the other way around.
1576 * public/index.html:
1578 2013-05-26 Ryosuke Niwa <rniwa@webkit.org>
1580 <rdar://problem/13992266> Should be a toggle to show entire Y-axis range
1581 <rdar://problem/13992271> Should scale Y axis to include error ranges
1583 Reviewed by Ricky Mondello.
1585 Add the feature. Also made adjust y-axis respect confidence interval delta so that the gray shade behind
1586 the main graph doesn't go outside the graph even when the y-axis is adjusted.
1588 * database/config.json:
1589 * public/index.html:
1590 (Chart): Add a SVG arrow to toggle y-axis mode, and bind click on the arrow to toggleYAxis().
1591 (Chart.attachMainPlot): Respect shouldStartYAxisAtZero.
1592 (Chart.toggleYAxis): Toggle the y-axis mode of this chart by toggling shouldStartYAxisAtZero and calling
1594 * public/js/helper-classes.js:
1595 (PerfTestResult.confidenceIntervalDelta):
1596 (PerfTestResult.unscaledConfidenceIntervalDelta): Extracted.
1597 (PerfTestRuns.min): Take confidence interval delta into account.
1598 (PerfTestRuns.max): Ditto.
1599 (PerfTestRuns.hasConfidenceInterval): Not sure why this function was checking the typeof. Just use isNaN.
1601 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1603 A build fix of the previous. Don't look for a test with NULL parent because NULL != NULL in our beloved SQL.
1605 * public/api/report.php:
1606 (ReportProcessor::recursively_ensure_tests):
1607 * tests/api-report.js: Added a test.
1609 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1611 Unreviewed build fixes.
1613 * public/api/report.php:
1614 (ReportProcessor::process): Explicitly exit with error when builder name or build time is missing.
1615 Also, tolerate reports without any revision information.
1617 (ReportProcessor::recursively_ensure_tests): When looking for a test, don't forget to compare its
1620 * tests/api-report.js: Added few test cases.
1622 2013-04-26 Ryosuke Niwa <rniwa@webkit.org>
1624 Commit another change that was supposed to be committed in r50331.
1627 (TestEnvironment.this.postJSON):
1628 (TestEnvironment.this.httpGet):
1631 2013-04-09 Ryosuke Niwa <rniwa@webkit.org>
1633 Commit the remaining files.
1635 * public/admin/regenerate-manifest.php:
1636 * public/include/admin-header.php:
1637 * public/include/json-header.php:
1638 * public/include/manifest.php:
1640 (TestEnvironment.this.postJSON):
1641 (TestEnvironment.this.httpGet):
1644 2013-03-15 Ryosuke Niwa <rniwa@webkit.org>
1646 SafariPerfMonitor: Add some tests for admin/regenerate-manifest.
1648 Reviewed by Ricky Mondello.
1650 Added some tests for admin/regenerate-manifest.
1652 * public/admin/regenerate-manifest.php: Use require_once instead of require.
1653 * public/include/admin-header.php: Ditto.
1654 * public/include/json-header.php: Ditto.
1656 * public/include/manifest.php:
1657 (ManifestGenerator::builders): Removed a reference to a non-existent variable.
1658 When there are no builders, simply return an empty array.
1661 (TestEnvironment.postJSON):
1662 (TestEnvironment.httpGet): Added.
1663 (sendHttpRequest): Renamed from postHttpRequest as it now takes method as an argument.
1665 * tests/admin-regenerate-manifest.js: Added with a bunch of test cases.
1667 2013-03-14 Ryosuke Niwa <rniwa@webkit.org>
1669 Unreviewed. Added more tests for api/report to ensure it creates tests, metrics, test_runs,
1670 and run_iterations. Also fixed a typo in report.php found by new tests.
1672 * public/api/report.php:
1673 (main): Fix a bug in the regular expression to wrap numbers with double quotations.
1674 * tests/api-report.js: Added more test cases.
1676 2013-03-12 Ryosuke Niwa <rniwa@webkit.org>
1678 <rdar://problem/13399038> SafariPerfMonitor: Need integration tests
1680 Reviewed by Ricky Mondello.
1682 Add a test runner script and some simple test cases.
1684 * database/config.json: Added the configuration for "testServer".
1685 * database/database-common.js:
1686 (pathToTests): Added.
1687 * run-tests.js: Added.
1690 (confirmUserWantsDatabaseToBeInitializedIfNeeded): Checks whether there are any non-empty tables,
1691 and if there are, asks the user if it’s okay to delete all of the data contained therein.
1692 (confirmUserWantsDatabaseToBeInitializedIfNeeded.findNonEmptyTable): Find a table with non-zero
1694 (confirmUserWantsDatabaseToBeInitializedIfNeeded.fetchTableNames): Fetch the list of all tables
1695 in the current database using PostgreSQL's information_schema.
1696 (askYesOrNoQuestion):
1698 (initializeDatabase): Executes init-database.sql. It drops all tables and creates them again.
1700 (TestEnvironment): The global object exposed in tests. Provides various utility functions.
1701 (TestEnvironment.assert): Exposes assert to tests.
1702 (TestEnvironment.console): Exposes console to tests.
1703 (TestEnvironment.describe): Adds a description.
1704 (TestEnvironment.it): Adds a test case.
1705 (TestEnvironment.postJSON):
1706 (TestEnvironment.queryAndFetchAll):
1707 (TestEnvironment.sha256):
1708 (TestEnvironment.notifyDone): Ends the current test case.
1712 (TestContext): An object created for each test case. Conceptually, this object is always on
1713 "stack" when a test case is running. TestEnvironment and an uncaughtException handler accesses
1714 this object via currentTestContext.
1715 (TestContext.description):
1717 (TestContext.logError):
1720 * tests/api-report.js: Added some basic tests for /api/report.php.
1722 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1724 Unreviewed administrative page fix. Make it possible to remove all configuration from dashboard.
1726 The problem was that we were detecting whether we're updating dashboard or not by checking
1727 the existence of metric_configurations in $_POST but this key doesn't exist when we're removing
1728 all configurations. Use separate 'dashboard' action to execute the code even when
1729 metric_configurations is empty.
1731 * public/admin/tests.php:
1733 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1735 SafariPerfMonitor: Extract a class to aggregate and store values from ReportProcessor.
1737 Reviewed by Ricky Mondello.
1739 This patch extracts TestRunsGenerator, which aggregates and compute caches of values,
1740 from ReportProcessor as a preparation to replace deprecated aggregate.js.
1742 * public/api/report.php:
1743 (ReportProcessor::exit_with_error): Moved.
1744 (ReportProcessor::process): Use the extracted TestRunsGenerator.
1745 (TestRunsGenerator): Added.
1746 (TestRunsGenerator::exit_with_error): Copied from ReportProcessor.
1747 (TestRunsGenerator::add_aggregated_metric): Moved.
1748 (TestRunsGenerator::add_values_for_aggregation): Moved. Made public.
1749 (TestRunsGenerator::aggregate): Moved. Made public.
1750 (TestRunsGenerator::aggregate_current_test_level): Moved.
1751 (TestRunsGenerator::test_value_list_to_values_by_iterations): Moved.
1752 (TestRunsGenerator::evaluate_expressions_by_node): Moved.
1753 (TestRunsGenerator::compute_caches): Moved. Made public.
1754 (TestRunsGenerator::add_values_to_commit): Moved. Made public.
1755 (TestRunsGenerator::commit): Moved. Made public. Also takes build_id and platform_id.
1756 (TestRunsGenerator::rollback_with_error): Moved.
1758 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1760 SafariPerfMonitor: Administrative pages should update manifest JSON as needed.
1762 Reviewed by Remy Demarest.
1764 Regenerate the manifest file when updating fields or adding new items that are included in
1767 * public/admin/bug-trackers.php:
1768 * public/admin/builders.php:
1769 * public/admin/regenerate-manifest.php:
1770 * public/admin/repositories.php:
1771 * public/admin/tests.php:
1772 * public/include/admin-header.php:
1773 (regenerate_manifest): Extracted from regenerate-manifest.php.
1775 2013-03-08 Ryosuke Niwa <rniwa@webkit.org>
1777 Unreviewed build fix for memory test results.
1779 Make aggregation work in the nested cases. We start from the "leaf" tests and move our ways up,
1780 aggregating at each level.
1782 * public/api/report.php:
1783 (ReportProcessor::recursively_ensure_tests):
1784 (ReportProcessor::add_aggregated_metric): Renamed from ensure_aggregated_metric.
1785 (ReportProcessor::add_values_for_aggregation):
1786 (ReportProcessor::aggregate):
1787 (ReportProcessor::aggregate_current_test_level): Extracted from aggregate.
1789 2013-03-02 Ryosuke Niwa <rniwa@webkit.org>
1791 Build fixes. iteration_count_cache should be the total number of values in all iteration group,
1792 not the number of iteration groups. Also, don't set group number when the entire run belongs
1793 a single iteration group.
1795 * public/api/report.php:
1796 (ReportProcessor::commit):
1798 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1800 SafariPerfMonitor: Introduce iteration groups
1802 Reviewed by Remy Demarest.
1804 In WebKit land, we're going to use multiple instances of DumpRenderTree or WebKitTestRunner to amortize
1805 the runtime environment variances to get more stable results. And it's desirable to keep track of
1806 the instance of DumpRenderTree or WebKitTestRunner used to generate each iteration value.
1808 This patch introduces "iteration groups" to keep track of this extra information.
1810 Instead of receiving a flat array of iteration values, we can now receive a two dimensional array where
1811 the outer array denotes iteration groups and each inner array contains iteration values for each group.
1814 * database/init-database.sql: Add iteration_group column.
1815 * public/api/report.php:
1816 (ReportProcessor::recursively_ensure_tests): Always use the two dimensional array internally.
1818 (ReportProcessor::aggregate): test_value_list_to_values_by_iterations now returns an associative array
1819 contains the list of values indexed by the iteration order and group sizes. Store the group size so
1820 that we can restore the iteration groups before passing it to node.js and restore them later.
1822 (ReportProcessor::test_value_list_to_values_by_iterations): Flatten iteration groups into an array
1823 of values and construct group_size array to restore the groups later in ReportProcessor::aggregate.
1825 Also check that each iteration group in each subtest are consistent with one another. To see why we need
1826 to do this, suppose we're aggregating two tests T1 and T2 with the following values. Then it's important
1827 that each iteration group in T1 and T2 have the same size:
1828 T1 = [[1, 2], [3, 4, 5]]
1829 T2 = [[6, 7], [8, 9, 10]]
1831 so that the aggregated result (the sum in this case) can have the same groups as in:
1832 T = [[7, 9], [11, 13, 15]]
1834 If some iteration groups in T1 and T2 had a different size as in:
1835 T1 = [[1, 2, 3], [4, 5]]
1836 T2 = [[6, 7], [8, 9, 10]]
1838 Then iteration groups of the aggregated T is ambiguous.
1840 (ReportProcessor::compute_caches): Flatten iteration groups to compute caches (e.g. mean, stdev, etc...)
1841 (ReportProcessor::commit): Store iteration_group values.
1843 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1845 Unreviewed. Delete the migration tool for webkit-perf.appspot.com now that we have successfully
1846 migrated to perf.webkit.org.
1848 * database/perf-webkit-migrator.js: Removed.
1850 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1852 Build fix. Don't forget to add metrics of the top level tests e.g. Dromaeo:Time:Arithmetic.
1854 * public/index.html:
1857 2013-03-01 Ryosuke Niwa <rniwa@webkit.org>
1859 SafariPerfMonitor: Make it possible to add charts for all subtests or all platforms.
1861 Reviewed by Ricky Mondello.
1863 It is often desirable to see charts of a given test for all platforms, or to be able to see
1864 charts of all subtests on a given platform when trying to triage perf. regressions.
1866 Support this use case by adding the ability to do so on the charts page.
1868 Also, we used to disable items on the test list based on the platform chosen. This turned out
1869 to be a bad UI because in many situations you want to be able to compare results of the same test
1870 on multiple platforms.
1872 In this new UI, we have three select elements, each of which selects the following:
1873 1. Top-level test - Test suite such as Dromaeo
1874 2. Metric - Pages and subtests under the suite such as www.webkit.org for dom-modify:Runs
1875 (where dom-modify is the name of the subtest and Runs is a metric in that subtest) for Dromaeo.
1876 3. Platform - Mountain Lion, Qt, etc...
1878 A user can select "all" for metric and platform but we disallow doing both at once since adding
1879 all metrics on all platforms tends to add way too many charts and hang the browser. I also can't
1880 think of a use case where you want to look at that many charts at once. We can support this later
1881 if valid use cases come up.
1883 * public/index.html:
1884 (.showCharts.addOption): Extracted.
1885 (.showCharts): Added "metricList" that shows the list of test and metrics (in the form of
1886 relative metrics paths such as "DOMWalk:Time") for each top-level test selected in testList.
1887 metricList has onchange handler that enables/disables items on platformList.
1889 (init): Sort tests and test metrics here instead of doing that in showCharts.
1891 2013-02-28 Ryosuke Niwa <rniwa@webkit.org>
1893 <rdar://problem/13316756> SafariPerfMonitor: tooltip should include a link to build URLs
1895 Reviewed by Remy Demarest and Ricky Mondello.
1897 Added a hyperlink to build page in tooltips. Repeating the entire build URL in each build
1898 was a bad idea because it bloats the resultant JSON file too much. So move the build URL
1899 templates to the manifest file instead. Each build now only contains the builder id.
1901 * public/api/runs.php: Removed the part of the query that joined builders table. This
1902 speeds up the query quite a bit.
1904 * public/include/manifest.php:
1905 (ManifestGenerator::generate): Generate builders field.
1906 (ManifestGenerator::builders): Added. Returns an associative array of builder ids to an
1907 associative array that contains name and its build URL template.
1909 * public/index.html:
1910 (.buildLabelWithLinks.linkifyIfNotNull): Renamed from linkifiedLabel. Take a label and url
1911 instead of a revision since this function is used for revisions and build page URLs now.
1912 (.buildLabelWithLinks): Include the linkified build number.
1914 * public/js/helper-classes.js:
1915 (TestBuild.builder): Added.
1916 (TestBuild.buildNumber): Added.
1917 (TestBuild.buildUrl): Returns the build URL. The variable name in the URL template has been
1918 changed from %s to $buildNumber to be more descriptive and consistent with other URL templates.
1920 2013-02-27 Ryosuke Niwa <rniwa@webkit.org>
1922 Tooltips interfere with user interactions
1924 Rubber-stamped by Simon Fraser.
1926 Disable tooltip on the dashboard page since graphs are too small to be useful there.
1927 Also, show graphs for only 10 days by default as opposed to 20.
1928 Finally, dismiss the hovering tooltip when mouse enters a "pinned" tooltip.
1930 * public/index.html:
1931 * public/js/helper-classes.js:
1933 2013-02-24 Ryosuke Niwa <rniwa@webkit.org>
1935 Fix some serious typo. We're supposed to be using SHA-256, not SHA-1 to hash our passwords,
1936 to be compatible with webkit-perf.appspot.com.
1938 * public/admin/builders.php:
1939 * public/api/report.php:
1941 2013-02-23 Ryosuke Niwa <rniwa@webkit.org>
1945 Add a missing constraint on builds table. For a given builder, there should be exactly
1946 one build for a given build number.
1948 Also add report_committed_at to reports table to record the time at which a given report
1949 was processed and test_runs and run_iterations rows were committed into the database.
1951 * database/config.json:
1952 * public/api/report.php:
1954 2013-02-22 Ryosuke Niwa <rniwa@webkit.org>
1956 Unreviewed. Add more checks for empty SQL query results.
1958 * public/include/manifest.php:
1960 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1962 More build fixes on perf.webkit.org.
1964 * public/api/runs.php: Make PostgreSQL happier.
1965 * public/include/manifest.php: Don't assume we always have bug trackers.
1967 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1969 SafariPerfMonitor: index.html duplicates the code in PerfTestRuns to determine smallerIsBetter
1970 and fix other miscellaneous UI bugs.
1972 Rubber-stamped by Simon Fraser.
1974 Removed the code to determine whether smaller value is better or not for a given test in index.html
1975 in the favor of using that of PerfTestRuns.
1977 * public/include/manifest.php: Fixed a typo.
1978 * public/index.html:
1980 (Chart.attachMainPlot): Fixed a bug to access previousPoint.left even when previousPoint is null.
1982 * public/js/helper-classes.js:
1983 (PerfTestRuns): Added EndAllocations, MaxAllocations, and MeanAllocations.
1985 (PerfTestRuns.computeScalingFactorIfNeeded): When the mean is almost 10,000 units, we may end up
1986 using 5 digits instead of 4, resulting in the use of scientific notations. Go up to the next unit
1987 at roughly 2,000 units to avoid this.
1989 (Tooltip.show): Show the tooltip even when the new content is identical to the previous content.
1990 The only thing we can avoid is innerHTML.
1992 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
1994 Another build fix. The path to node is /usr/local/bin/node, not /usr/bin/local/node
1996 * public/include/evaluator.js:
1998 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2000 <rdar://problem/13267898> SafariPerfMonitor: Bug trackers should be configurable
2002 Reviewed by Remy Demarest.
2004 Made the list of bug trackers configurable. Namely, each bug tracker can be added in
2005 admin/bug-trackers.php and can be associated with multiple repositories.
2007 The association between bug trackers and repositories (such as WebKit, Safari, etc...) are used
2008 to determine the set of bug trackers to show for a given set of blame lists.
2009 e.g. if a test regressed due to a change in Safari, then we don't want to show WebKit Bugzilla as
2010 a place to file bugs against the regression.
2012 * database/init-database.sql: Added bug_trackers and tracker_repositories.
2013 Also drop those tables before creating them (note "DROP TABLE reports" was missing).
2015 * public/admin/bug-trackers.php: Added. The administrative interface for adding and managing
2016 bug trackers, namely associated repositories.
2018 * public/include/admin-header.php: Added a link to bug-trackers.php
2019 * public/include/manifest.php:
2020 (ManifestGenerator::generate): Include the list of bug trackers in the manifest.
2021 Also moved the code to fetch repositories table here from ManifestGenerator::repositories.
2023 (ManifestGenerator::repositories):
2025 (ManifestGenerator::bug_trackers): Added. Generates an associative array of bug trackers where
2026 keys are names of bug trackers and values are associative arrays with keys 'new_bug_url' and
2027 'repositories' where the latter contains the list of associated repository names.
2029 * public/index.html:
2030 (Chart): Takes bugTrackers as as argument.
2031 (Chart.showTooltipWithResults): Removed the hard-coded list.
2033 (init.addPlatformsToDashboard):
2034 (init.showCharts.createChartFromListPair):
2035 (init): Stores the list of bug trackers in the manifest to a local variable.
2037 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2039 A follow up on the previous build fix. When using proc_open, we need to make evalulator.js executable.
2041 * public/include/evaluator.js:
2043 2013-02-21 Ryosuke Niwa <rniwa@webkit.org>
2045 SafariPerfMonitor: Extract the code to generate tabular view in administrative pages
2047 Reviewed by Remy Demarest.
2049 Extracted AdministrativePage to share the code to generate a tabular view of data and a form to insert
2050 new row into the database.
2052 * public/admin/aggregators.php: Use AdministrativePage.
2053 * public/admin/builders.php: Ditto.
2054 * public/admin/repositories.php: Ditto.
2055 * public/include/admin-header.php:
2056 (AdministrativePage): Added.
2057 (AdministrativePage::__construct): column_info is an associative array that maps a SQL column name
2058 to an associative array that describes the column.
2059 - editing_mode: Specifies the type of form ('text', 'url', or 'string') to show for this column.
2060 - label: Human readable name of the column.
2061 - pre_insertion: Signifies that this column exists only before the row is inserted. e.g. password
2062 column exists only before we create password_hash column at the insertion time.
2064 (AdministrativePage::name_to_titlecase): Converts an underscored lowercase name to a human readable
2065 titlecase (e.g. new_bug is converted to New Bug).
2066 (AdministrativePage::column_label): Obtains the label specified in column_info or titlecased column name.
2067 (AdministrativePage::render_form_control_for_column): "Renders" a text form control such as input and
2068 textarea for a given editing mode ('text', 'url', or 'string').
2069 (AdministrativePage::render_table): Renders a whole SQL table after sorting rows by the specified column.
2070 (AdministrativePage::render_form_to_add): Renders a form to insert new row.
2072 2013-02-20 Ryosuke Niwa <rniwa@webkit.org>
2074 Build fix. Some systems don't support r+. Use proc_open instead.
2076 * public/api/report.php:
2078 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2080 Build fix. Use the mean data series as supposed to upper or lower confidence bounds
2081 when computing the y-axis of data points to show tooltips at.
2083 * public/index.html:
2085 2013-02-15 Ryosuke Niwa <rniwa@webkit.org>
2087 Unreviewed. Removed .htaccess in favor of directly putting directives in httpd.conf.
2090 * public/.htaccess: Removed.
2092 2013-02-14 Ryosuke Niwa <rniwa@webkit.org>
2096 * public/include/manifest.php: Build fix. db is on this.
2097 * public/js/statistics.js:
2098 (Statistics.confidenceInterval): Added. An utility function for debugging purposes.
2100 2013-02-13 Ryosuke Niwa <rniwa@webkit.org>
2102 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 2)
2104 Reviewed by Anders Carlsson.
2106 Rewrote and merged populate-from-report.js into report.php.
2108 * database/config.json: Added a path to node.js.
2110 * database/init-database.sql: Don't require unit to be always present since it's no longer used by the front end.
2111 Once we land this patch and update the administrative pages, we can remove this column.
2113 Also add a new reports table to store JSON reported by builders. We used to store everything in jobs table but
2114 that table is going away once we remove the node.js backend.
2116 * database/populate-from-report.js: Removed.
2117 * public/api/report.php: Added.
2119 (ReportProcessor.__construct):
2120 (ReportProcessor.process):
2122 (ReportProcessor.store_report_and_get_build_data): We store the report into the database as soon as it has been
2123 verified to be submitted by a known builder.
2125 (ReportProcessor.exit_with_error): Store the error message and details in the database if the report had been
2126 stored. If not, then notify that to the client via 'failureStored' in the JSON response.
2127 (ReportProcessor.resolve_build_id): Insert build and build_revisions rows if needed. We don't do this atomically
2128 inside a transaction because there could be multiple reports for a single build, each containing results for
2131 (ReportProcessor.recursively_ensure_tests): Parse a tree of tests and insert tests and test_metrics rows as
2132 needed. It also computes the metrics to aggregate and prepares values to commit via ensure_aggregated_metric,
2133 add_values_to_commit, and add_values_for_aggregation.
2135 (ReportProcessor.is_list_of_aggregators): When a metric is an aggregation, it contains an array of aggregator
2136 names, e.g. ["Arithmetic", "Geometric"], instead of a dictionary of configuration types to their values,
2137 e.g. {Time: {current: [1, 2, 3,]}}. This function detects the former. (Note that dictionary and list are both
2140 (ReportProcessor.ensure_aggregated_metric): Create a metric with aggregator to add it to the list of metrics
2141 to be aggregated in ReportProcessor.aggregate.
2143 (ReportProcessor.add_values_for_aggregation): Called by test metrics with aggregated parent test metrics.
2145 (ReportProcessor.aggregate): Compute results for aggregated metrics. Consider a matrix with rows representing
2146 child tests and columns representing "iterations" for a given aggregated metrics M. Initially, we have values
2147 given for each row (child metrics of M). This function extracts each column (iteration) via
2148 test_value_list_to_values_by_iterations, and feeds it into evaluate_expressions_by_node to get aggregated values
2149 for each column (iteration of M). Finally, it registers those aggregated values to be committed.
2151 Note that we don't want to start a new node.js process for each aggregation, so we accumulate all values to be
2152 aggregated in node.js in $expressions. Each entry in $expressions is a JSON string that contains code and
2153 values to be aggregated. node.js gives us back a list of JSON strings that contain aggregated values.
2155 (ReportProcessor.test_value_list_to_values_by_iterations): See above.
2156 (ReportProcessor.evaluate_expressions_by_node): See above.
2158 (ReportProcessor.compute_caches): Compute cached mean, sum, and square sums for each run we're about to add
2159 using evaluate_expressions_by_node. We can't do this before computing aggregated results since those aggregated
2160 results also need the said caches.
2162 (ReportProcessor.add_values_to_commit):
2164 (ReportProcessor.commit): Add test_runs and run_iterations atomically inside a transaction, rolling back
2165 the transaction as needed if anything goes wrong.
2167 (ReportProcessor.rollback_with_error)
2169 * public/include/db.php:
2170 (Database.prepare_params): Use $values (instead of $placeholders) to compute the current index since
2171 placeholders ($1, $2, etc...) may be split up into multiple arrays given they may not necessarily show up
2172 contiguously in a SQL statement.
2174 (Database.select_or_insert_row): Added. Selects a row if the attempt to insert the same row fails. It
2175 automatically creates a query string from a dictionary of unprefixed column names and table. It returns
2176 a column value of the choice.
2178 (Database.begin_transaction): Added.
2179 (Database.commit_transaction): Added.
2180 (Database.rollback_transaction): Added.
2182 * public/include/evaluator.js: Added.
2183 * public/include/json-header.php:
2184 (exit_with_error): Take error details and merge it with "additional details". This allows report.php to provide
2185 context under which the request failed.
2186 (successful_exit): Merge "additional details".
2187 (set_exit_detail): Added. Sets "additional details" to the JSON returned by exit_with_error or successful_exit.
2188 (merge_additional_details):
2190 2013-02-12 Ryosuke Niwa <rniwa@webkit.org>
2192 SafariPerfMonitor: Add more helper functions to db.php
2194 Reviewed by Remy Demarest.
2196 Added Database::insert_row and array_get to make common database operations easier.
2198 * public/admin/aggregators.php: Use Database::insert_row instead of
2199 execute_query_and_expect_one_row_to_be_affected.
2201 * public/admin/builders.php: Ditto.
2203 * public/admin/tests.php: Ditto; We used to run a separate SELECT query just to get the id after
2204 inserting a row. With insert_row, we don't need that.
2206 * public/include/admin-header.php: Ditto.
2208 * public/include/db.php:
2209 (array_get): Added. It returns the value of an array given a key if the key exists; otherwise
2210 return the default value (defaults to NULL) if the key doesn't exist.
2212 (Database::column_names): Added. Prefixes an array of column names and creates a comma separated
2215 (Database::prepare_params): Added. Takes an associative array of column names and their values,
2216 and builds up arrays for placeholder (e.g. $1, $2, etc...) and values, then returns an array of
2217 column names all in the same order.
2219 (Database::insert_row): Added. Inserts a new row into the specified table where column names have
2220 the given prefix. Values are given in a form of an associative array where keys are unprefixed
2221 column names and values are corresponding values. When the row is successfully inserted, it returns
2222 the specified column's value (defaults to prefix_id). If NULL is specified, it returns a boolean
2223 indicating the success of the insertion.
2225 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2227 <rdar://problem/13165667> SafariPerfMonitor doesn't work on perf.webkit.org (Part 1)
2229 Reviewed by Conrad Shultz.
2231 Rewrote the manifest generator in PHP.
2233 * database/generate-manifest.js: Removed.
2234 * public/admin/regenerate-manifest.php: Added. Use ManifestGenerator to generate and store the manifest.
2235 * public/include/db.php:
2236 (array_ensure_item_has_array): Added.
2237 * public/include/evaluator.js: Added.
2238 * public/include/json-header.php:
2239 * public/include/manifest.php: Added.
2241 2013-02-11 Ryosuke Niwa <rniwa@webkit.org>
2243 Dates on overflow plot are overlapping
2245 Rubber-stamped by Simon Fraser.
2247 Don't show more than 5 days.
2249 * public/index.html:
2250 * public/js/helper-classes.js:
2251 (TestBuild.UTCtoPST):
2254 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2256 Show build time as well as commit time on the dashboard and tooltips.
2258 Rubber-stamped by Simon Fraser.
2260 Include both the maximum commit time and build time in buildLabelWithLinks.
2261 Also use ISO format to save the screen real estate.
2263 * public/index.html:
2264 (buildLabelWithLinks):
2265 * public/js/helper-classes.js:
2267 (TestBuild.buildTime):
2268 (TestBuild.formattedBuildTime):
2270 2013-02-08 Ryosuke Niwa <rniwa@webkit.org>
2272 Unreviewed; Convert metric.name to metric.unit in the front end.
2274 * public/js/helper-classes.js:
2276 2013-02-07 Ryosuke Niwa <rniwa@webkit.org>
2278 <rdar://problem/13166276> SafariPerfMonitor: Need hyperlinks to file bugs
2280 Rubber-stamped by Simon Fraser.
2282 This patch adds hyperlinks to file new bugs on Radar and WebKit Bugzilla. Because we want to include information
2283 such as the degree of progression or regression and the regression ranges when filing new bugs, broke various
2284 label() functions into smaller pieces to be used in both generating tooltips and the hyperlinks.
2286 * public/index.html:
2287 (.buildLabelWithLinks): Extracted from TestBuild.label.
2288 (.showTooltipWithResults): Extracted from Tooltip.show. Also added the code to generate hyperlinks to file new bugs
2289 on Radar and WebKit Bugzilla.
2290 * public/js/helper-classes.js:
2291 (PerfTestResult.metric): Replaced test() as runs.test() no longer exists.
2292 (PerfTestResult.isBetterThan): Added.
2293 (PerfTestResult.formattedRelativeDifference): Extracted from PerfTestResult.label.
2294 (PerfTestResult.formattedProgressionOrRegression): Ditto. Also use "better" and "worse" instead of arrow symbols
2295 to indicate progressions or regressions.
2296 (PerfTestResult.label):
2297 (TestBuild.formattedTime): Added.
2298 (TestBuild.platform): Added.
2299 (TestBuild.formattedRevisions): Extracted from TestBuild.label. Merged a part of linkifyLabel.
2300 (TestBuild.smallerIsBetter): Added.
2301 (Tooltip.show): Take a raw markup instead of two results.
2303 2013-02-06 Ryosuke Niwa <rniwa@webkit.org>
2305 <rdar://problem/13151520> SafariPerfMonitor: Dashboard can cause excessive horizontal scrolling when there are many platforms
2307 Rubber-stamped by Tim Horton.
2309 Stack platforms when there are more than 3 of them since making the layout adaptive is tricky
2310 since each platform may have a different number of tests to be shown on the dashboard.
2312 * public/index.html:
2314 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2316 Build fix. Don't prefix a SVn revision with 'r' when constructing a changeset / blame URL.
2318 * public/js/helper-classes.js:
2321 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2323 SafariPerfMonitor: repository names or revisions are double-quoted when they contain a space
2325 Rubber-stamped by Tim Horton.
2327 The bug was in the PHP code that parsed Postgres array. Trim double quotations as needed.
2329 Also fixed a bug in TestBuild where we used to show the revision range as r1234-1250 when
2330 the revision r1234 was the revision used in the previous build.
2332 * public/api/runs.php:
2333 (parse_revisions_array): Trim double quotations around repository names and revisions.
2334 * public/js/helper-classes.js:
2337 2013-02-05 Ryosuke Niwa <rniwa@webkit.org>
2339 <rdar://problem/13151558> SafariPerfMonitor: Tooltip is unusable
2341 Rubber-stamped by Tim Horton.
2343 * public/index.html:
2344 (Chart.attachMainPlot): Disable auto highlighting (circle around a data point that shows up on hover)
2345 on the dashboard page as it's way too noisy.
2347 (Chart.hideTooltip): Added. Hides the tooltip that shows up on hover.
2349 (.toggleClickTooltip): Extracted from the code for "mouseout" bind (now replaced by "mouseleave").
2350 Pins or unpins a tooltip. When pinning a tooltip, we create a tooltip behind the scene and show that
2351 so that the tooltip for hover can be reused further.
2353 (.closestItemForPageX): Find the closest item given pageX. We iterate data points from left to right,
2354 and find the first point that lies on the right of the cursor position. We then compute the midpoint
2355 between this and the previous point and pick the closer of the two. It returns an item-like object
2356 that has all properties we need since flot doesn't provide an API to retrieve the real item object.
2358 (Chart): Call toggleClickTooltip when a (hover) tooltip is clicked.
2360 (Chart.attach): In "plothover" bind, call closestItemForPageX when item is not provided by flot on
2361 the first or "current" data points (as opposed to target or baseline data points).
2363 Also bind the code to clear crosshair and hide tooltips to "mouseleave" instead of "mouseout", and
2364 avoid triggering this code when the cursor is still within the plot's rectangle (e.g. when a cursor
2365 moves onto a tooltip) to avoid the premature dismissal of a tooltip.
2367 * public/js/helper-classes.js:
2368 (Tooltip.ensureContainer): Don't automatically close then the user clicks on tooltip. Delegate this
2369 work to the client via bindClick.
2371 (Tooltip.show): Move tooltip up by 5px. Also added a FIXME to move this offset computation to the client.
2373 (Tooltip.bindClick): Added.
2375 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2377 Yet another build fix. metricId*s*.
2379 * public/admin/tests.php:
2381 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2383 Another build fix. Use the new payload format for the aggregate job.
2385 * public/admin/tests.php:
2387 2013-02-03 Ryosuke Niwa <rniwa@webkit.org>
2391 * database/aggregate.js: Use variables that actually exist.
2392 * database/database-common.js:
2393 (ensureConfigurationIdFromList): Add the newly added configuration to the list so that subsequent
2394 function calls will find this configuration.
2396 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2398 <rdar://problem/13130139> SafariPerfMonitor: Add ReadMe
2400 Reviewed by Ricky Mondello.
2402 Turned InstallManual into a proper markdown document and added ReadMe.md.
2404 * InstallManual: Removed.
2405 * InstallManual.md: Moved from InstallManual.
2408 2013-01-31 Ryosuke Niwa <rniwa@webkit.org>
2410 <rdar://problem/13109335> SafariPerfMonitor: Add baseline and target lines
2412 Reviewed by Ricky Mondello.
2414 This patch prepares the front end code to process baseline and target results properly.
2416 * public/index.html:
2417 (fetchTest.createRunAndResults): Extracted.
2418 (fetchTest): Call createRunAndResults on current, baseline, and target values of the JSON.
2419 Deleted the comment about how sorting will be unnecessary once we start results in the server side
2420 since sorting by the maximum revision commit time turned out to be non-trivial in php.
2422 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2424 <rdar://problem/13057071> SafariPerfMonitor: Use newer version of flot that supports timezone properly
2426 Reviewed by Tim Horton.
2428 Use flot at https://github.com/flot/flot/commit/ec168da2cb8619ebf59c7e721d12c44a7960ff41.
2429 These files are "dynamically linked" to our app.
2431 * public/index.html:
2432 * public/js/jquery-1.8.2.min.js: Removed.
2433 * public/js/jquery.colorhelpers.js: Added.
2434 * public/js/jquery.flot.categories.js: Added.
2435 * public/js/jquery.flot.crosshair.js: Added.
2436 * public/js/jquery.flot.errorbars.js: Added.
2437 * public/js/jquery.flot.fillbetween.js: Added.
2438 * public/js/jquery.flot.js: Added.
2439 * public/js/jquery.flot.min.js: Removed.
2440 * public/js/jquery.flot.navigate.js: Added.
2441 * public/js/jquery.flot.resize.js: Added.
2442 * public/js/jquery.flot.selection.js: Added.
2443 * public/js/jquery.flot.stack.js: Added.
2444 * public/js/jquery.flot.symbol.js: Added.
2445 * public/js/jquery.flot.threshold.js: Added.
2446 * public/js/jquery.flot.time.js: Added.
2447 * public/js/jquery.js: Added.
2449 2013-01-29 Ryosuke Niwa <rniwa@webkit.org>
2451 Return NaN instead of throwing when there aren't enough samples.
2453 Reviewed by Sam Weinig.
2455 It's better to return NaN when we don't have enough samples so that we can treat it
2456 as if we don't have any confidence interval.
2458 * public/js/statistics.js:
2461 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2463 Build fix. Apparently Safari sometimes appends / at the end of hash location. Remove that.
2465 * public/js/helper-classes.js:
2466 (URLState.parseIfNeeded):
2468 2013-01-28 Ryosuke Niwa <rniwa@webkit.org>
2470 <rdar://problem/13081582> SafariPerfMonitor: Always use parameterized SQL functions in php code
2472 Reviewed by Ricky Mondello.
2474 Parameterized execute_query_and_expect_one_row_to_be_affected and updated the code accordingly.
2476 * public/admin/aggregators.php: Use heredoc.
2477 * public/admin/builders.php:
2478 * public/admin/jobs.php:
2479 * public/admin/repositories.php:
2480 * public/admin/tests.php: Updated the forms to use unprefixed field names to match other pages.
2481 This allows us to use update_field when updating test's url and metric's unit. Changed the action
2482 to regenerate aggregated matrix from "update" to "add" to simplify the dependencies in if-else.
2483 Also removed a stray code to update unit and url simultaneously since it's never used.
2484 * public/include/admin-header.php:
2485 (execute_query_and_expect_one_row_to_be_affected): Added $params. Also automatically convert
2486 empty strings to NULL as it was previously done via $db->quote_string_or_null_if_empty in callers.
2487 (update_field): Moved from repositories.php.
2489 * public/include/db.php:
2490 (quote_string_or_null_if_empty): Removed now that nobody uses this function.
2492 2013-01-25 Ryosuke Niwa <rniwa@webkit.org>
2494 Build fixes. Treat mean, sum, and square sum as float, not int.
2496 Also use 95% confidence interval instead of 90% confidence interval.
2498 * public/api/runs.php:
2499 * public/js/helper-classes.js:
2500 (.this.confidenceIntervalDelta):
2502 2013-01-24 Ryosuke Niwa <rniwa@webkit.org>
2504 Add an administrative page to edit repository information.
2506 Reviewed by Ricky Mondello.
2508 * public/admin/repositories.php: Added.
2509 * public/include/admin-header.php:
2511 2013-01-23 Ryosuke Niwa <rniwa@webkit.org>
2513 <rdar://problem/13067539> SafariPerfMonitor: Automatically create aggregated metrics from builder reports
2515 Reviewed by Ricky Mondello.
2517 Auto-create aggregated matrix such as arithmetic means and geometric means as requested and add a job
2518 to aggregate results for those matrix in populate-from-report.js.
2520 * database/generate-manifest.js:
2521 (.): Include aggregator names such as Arithmetic and Geometric in the list of metrics.
2522 * database/init-database.sql: Remove an erroneous unique constraint. There could be multiple matrix that share
2523 the same test and name (e.g. Dromaeo, Time) with different aggregators (e.g. Arithmetic and Geometric).
2524 * database/populate-from-report.js:
2526 (getReport): No change even though the diff looks as if it moved.
2527 (processReport): Extracted from main. Fetch the list of aggregators, pass that to recursivelyEnsureTestsIdsAndMetricsIds
2528 to obtain the list of aggregated metrics (such as arithmetic means) that need to be passed to aggregate.js
2529 (scheduleJobs): Extracted from processReport. Add a job to aggregate results.
2530 (recursivelyEnsureTestsIdsAndMetricsIds): When a metric is a list of names, assume them as aggregator names,
2531 and add corresponding metrics for them. Note we convert those names to ids using the dictionary we obtained
2533 (ensureMetricId): Take an aggregator id as an argument.
2534 * database/process-jobs.js: Support multiple metric ids and build id. Note that aggregate.js aggregates results
2535 for all builds when the build id is not specified.
2536 * public/admin/tests.php:
2537 * public/index.html: Include the aggregator name in the full name since there could be multiple metrics
2538 of the same name with different aggregators.
2540 2013-01-22 Ryosuke Niwa <rniwa@webkit.org>
2542 Build fix. Don't pass in arguments to in the wrong order.
2544 * database/aggregate.js:
2546 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2548 <rdar://problem/13057110> SafariPerfMonitor: x-axis is messed up
2550 Reviewed by Ricky Mondello.
2552 Since the version of flot we use doesn't support showing graphs in the current locate or
2553 in a specific timezone, convert all timestamps to PST manually (Date's constructor will still
2554 treat them as in UTC). We don't want to use the current locate because other websites on
2555 webkit.org assume PST.
2557 Also append this information to build's label.
2559 * public/js/helper-classes.js:
2563 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2565 Store test URLs reported by builders.
2567 Reviewed by Ricky Mondello.
2569 * database/populate-from-report.js:
2570 (recursivelyEnsureTestsIdsAndMetricsIds): Pass in the test url.
2571 (ensureTestId): Store the URL.
2573 2013-01-20 Ryosuke Niwa <rniwa@webkit.org>
2575 Yet another build fix; don't blow up even if we didn't have any test configurations.
2577 * public/admin/tests.php:
2579 2013-01-21 Ryosuke Niwa <rniwa@webkit.org>
2581 Build fix; don't instantiate Date when a timestamp wasn't provided.
2583 * database/populate-from-report.js:
2585 2013-01-18 Ryosuke Niwa <rniwa@webkit.org>
2587 Rename SafariPerfDashboard to SafariPerfMonitor and add a install manual.
2589 Reviewed by Tim Horton.
2591 Added an install manual.
2593 * InstallManual: Added.
2595 2012-12-21 Ryosuke Niwa <rniwa@webkit.org>
2597 Minor build fix. Don't unset builderPassword when it's not set.
2599 * public/api/report.php:
2601 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2603 Prettify JSON payloads and make very large payloads not explode the table in jobs.php.
2605 Reviewed by Ricky Mondello.
2607 * public/admin/admin.css: Make a very large payload scrollable.
2608 * public/admin/jobs.php: Format JSONs.
2610 2012-12-19 Ryosuke Niwa <rniwa@webkit.org>
2612 <rdar://problem/12897424> SafariPerfMonitor: Add ability to report results from bots
2614 Reviewed by Ricky Mondello.
2616 Add report.php and populate-from-report.js that process JSON files submitted by builders.
2618 * database/populate-from-report.js: Added.
2620 (getReport): Obtains the payload (the actual report) from "jobs" table.
2621 (recursivelyEnsureTestsIdsAndMetricsIds): "reports.tests" contain a tree of tests, test metrics,
2622 and their results. This function recursively traverses tests and metrics and ensure their ids.
2624 (metricToUnit): Maps a metric name to a unit. This should really be done in the client side since
2625 there is no point in storing unit given that every metric maps to exactly one unit (i.e. the mapping
2626 is a "function" in mathematical sense).
2628 (ensureRepositoryIdsForAllRevisions):
2629 (getIdOrCreateBuildWithRevisions):
2630 (ensureBuildIdAndRevisions): Obtains a build id given a builder name, a build number, and a build time
2631 if one already exists. If not, then inserts a new build and corresponding revisions information (e.g.
2632 build 123 may contain WebKit revision r456789). We don't retrieve rows for revisions since we don't use
2634 (insertRun): Insert new rows into "test_runs" and "run_iterations" tables, thereby recording the new
2635 test results all in a single transaction. This allows us to keep the database consistent in that either
2636 a build has been reported or not at least in "test_runs" and "run_iterations" tables. It'll be ideal if
2637 we could do the same for "builds" and "build_revisions" but that's not a hard requirement as far as
2638 other parts of the application are concerned.
2639 (scheduleQueriesToInsertRun):
2640 * database/process-jobs.js: Add a call to populate-from-report.js.
2641 * public/api/report.php: Added. Adds a new job named "report" to be processed by populate-from-report.js.
2642 * public/include/db.php: Support parameterized query.
2643 * public/include/json-header.php: Always include 'status' in the response so that builder submitting
2644 a test result could confirm that the submission indeed succeeded.
2646 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2648 Rename get(Id)OrCreate*(Id) to ensure*Id as suggested by Ricky on one of his code reviews.
2650 * database/aggregate.js:
2651 * database/database-common.js:
2652 (selectColumnCreatingRowIfNeeded):
2653 (ensureRepositoryId):
2654 (ensureConfigurationIdFromList):
2655 * database/perf-webkit-migrator.js:
2658 (getOrCreateBuildId):
2660 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2662 Extract commonly-used functions from aggregate.js and perf-webkit-migrator.js.
2664 Reviewed by Ricky Mondello.
2666 As a preparation to add report.js that processes a JSON file submitted by bots, extract various functions
2667 and classes from aggregate.js and perf-webkit-migrator.js to be shared.
2669 * database/aggregate.js: Extracted TaskQueue and SerializedTaskQueue into utility.js.
2672 (saveAggregatedResults):
2673 * database/database-common.js:
2674 (getIdOrCreatePlatform): Extracted from webkit-perf-migrator.js.
2675 (getIdOrCreateRepository): Ditto.
2676 (getConfigurationsForPlatformAndMetrics): Renamed from fetchConfigurations. Extracted from aggregator.js.
2677 (getIdFromListOrInsertConfiguration): Renamed from getOrInsertConfiguration. Extracted from aggregator.js.
2678 * database/perf-webkit-migrator.js:
2679 * database/utility.js: Added.
2680 (TaskQueue): Extracted from aggregator.js. Fixed a bug that prevented tasks added after start() is called
2681 from being executed.
2682 (TaskQueue.startTasksInQueue): Execute remaining tasks without serializing them. If the queue is empty,
2683 call the callback passed into start().
2684 (TaskQueue.taskCallback): The function each task calls back. Decrement the counter and call statTasksInQueue.
2685 (TaskQueue.addTask):
2687 (SerializedTaskQueue): Unlike TaskQueue, this class executes each task sequentially.
2688 (SerializedTaskQueue.executeNextTask):
2689 (SerializedTaskQueue.addTask):
2690 (SerializedTaskQueue.start):
2692 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2694 Revert erroneously committed changes.
2696 * database/config.json:
2698 2012-12-18 Ryosuke Niwa <rniwa@webkit.org>
2700 aggregator.js should be able to accept multiple metric ids and a single build id.
2702 Reviewed by Ricky Mondello.
2704 Make aggregator.js accept multiple ids and generate results for single build when bots are
2705 reporting new results.
2707 * database/aggregate.js:
2708 (parseArgv): Added. Returns an object containing the parsed representation of argv,
2709 which currently contains metricIDs and buildIds.
2710 (main): Use parseArgv and processConfigurations
2711 (processPlatform): Use build ids passed in or obtain all builds for the given platform.
2712 (processPlatform.processConfigurations): Extracted.
2714 2012-12-17 Ryosuke Niwa <rniwa@webkit.org>
2716 Add an administrative page for builders.
2718 Reviewed by Ricky Mondello.
2720 We need an administrative page to add and edit builder information.
2721 Also renamed "slaves" to "builders" in order to reduce the amount of technical jargon we use.
2723 * database/init-database.sql: Renamed slaves table to builders. Drop slave_os and slave_spec
2724 since we don't have plans to use those columns in near future. Also make builder_name unique
2725 as required by the rest of the app.
2726 * public/admin/builders.php: Added.
2727 * public/api/runs.php: Updated per the table rename.
2728 * public/include/admin-header.php: Added a link to builders.php.
2730 2012-12-14 Ryosuke Niwa <rniwa@webkit.org>
2732 Build fixes for r46982.
2734 * database/aggregate.js:
2735 (fetchConfigurations): Bind i so that it's not always metricIds.length.
2736 (fetchBuildsForPlatform): Return run_build as build_id since that's what caller expects.
2737 (processBuild): Don't print "." until we've committed transactions. It's misleading.
2739 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2741 Unreviewed. Move some php files to public/include as suggested by Mark on a code review.
2743 * public/admin/aggregators.php:
2744 * public/admin/footer.php: Removed.
2745 * public/admin/header.php: Removed.
2746 * public/admin/index.php:
2747 * public/admin/jobs.php:
2748 * public/admin/tests.php:
2749 * public/api/json-header.php: Removed.
2750 * public/api/runs.php:
2751 * public/db.php: Removed.
2752 * public/include: Added.
2753 * public/include/admin-footer.php: Copied from public/admin/footer.php.
2754 * public/include/admin-header.php: Copied from public/admin/header.php.
2755 * public/include/db.php: Copied from public/db.php.
2756 * public/include/json-header.php: Copied from public/api/json-header.php.
2758 2012-12-13 Ryosuke Niwa <rniwa@webkit.org>
2760 <rdar://problem/12822613> SafariPerfMonitor: implement naive value aggregation mechanism
2762 Reviewed by Ricky Mondello.
2764 Added the initial implementation of value aggregation.
2765 Also added abilities to configure the dashboard page in tests.php.
2767 * database/aggregate.js: Added.
2768 (TaskQueue): Added. Execute all tasks at once and waits for those tasks to complete.
2769 (TaskQueue.addTask):
2771 (SerializedTaskQueue): Added. Execute tasks sequentially after one another until all of them are completed.
2772 (SerializedTaskQueue.addTask):
2773 (SerializedTaskQueue.start):
2776 (fetchConfigurations):
2777 (fetchBuildsForPlatform):
2779 (testsWithDifferentIterationCounts):
2780 (aggregateIterationsForMetric): Retrieve run_iterations and aggregate results in memory.
2781 (saveAggregatedResults): Insert into test_runs and test_config in transactions.
2782 (getOrInsertConfiguration):
2784 * database/database-common.js:
2785 (fetchTable): Log an error as an error.
2786 (getOrCreateId): Extracted from perf-webkit-migrator.
2787 (statistics): Added.
2788 * database/perf-webkit-migrator.js:
2789 (migrateTestConfig): Converted units to respective metric names. Also removed the code to add jobs to update
2790 runs JSON since runs JSONs are generated on demand now.
2792 (getOrCreatePlatformId):
2793 (getOrCreateTestId):
2794 (getOrCreateConfigurationId):
2795 (getOrCreateRevisionId):
2796 (getOrCreateRepositoryId):
2797 (getOrCreateBuildId):
2798 * database/process-jobs.js:
2799 (processJob): Handle 'aggregate' type.
2801 2012-12-11 Ryosuke Niwa <rniwa@webkit.org>
2803 Fix the dashboard after adding test_metrics.
2805 Reviewed by Ricky Mondello.
2807 Rename test to metrics in various functions and sort tests on the charts page.
2808 Also representing whether a test appears or not by setting a flag on dashboard
2809 was bogus because test objects are shared by multiple platforms. Instead, store
2810 dashboard platform list as intended by the manifest JSON.
2812 * public/index.html:
2813 (PerfTestRuns): Renamed test to metric.
2815 (showCharts): Ditto; also sort metrics' full names before adding them to the select element.
2816 (fullName): Moved so that it appears above where it's called.
2817 * public/js/helper-classes.js:
2819 2012-12-10 Ryosuke Niwa <rniwa@webkit.org>
2821 Update tests.php to reflect recent changes in the database schema.
2823 Reviewed by Conrad Shultz.
2825 Made the following changes to tests.php:
2826 1. Disallow adding metrics to tests without subtests.
2827 2. Made dashboard configurable by adding checkboxes for each platform on each metric.
2828 3. Linkified tests with subtests instead of showing all them at once.
2830 * public/admin/admin.css:
2831 (.action-field, .notice):
2833 * public/admin/header.php: Specify paths by absolute paths so that tests.php can use PATH_INFO.
2834 (execute_query_and_expect_one_row_to_be_affected): Return a boolean. Used in tests.php while adding test_metrics.
2835 (add_job): Extracted.
2836 * public/admin/tests.php: See above.
2837 (array_item_set_default): Added.
2838 (array_item_or_default): Renamed from get_value_with_default.
2839 (compute_full_name): Extracted.
2840 (sort_tests): Ditto.
2841 (map_metrics_to_tests): Ditto.
2843 2012-12-06 Ryosuke Niwa <rniwa@webkit.org>
2845 <rdar://problem/12832324> SafariPerfMonitor: Linkify test names
2847 Reviewed by Simon Fraser.
2849 Linkify the headers using metric.test.url when it's provided.
2851 * public/index.html:
2853 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2855 Use parameterized pg_query_params in query_and_fetch_all
2857 Reviewed by Conrad Shultz.
2859 Address a review comment by Mark by using pg_query_params instead of pg_query in query_and_fetch_all.
2861 * public/api/runs.php:
2863 (ctype_alnum_underscore): Added.
2865 2012-12-04 Ryosuke Niwa <rniwa@webkit.org>
2867 Update the migration tool to support test_metrics.
2869 Reviewed by Mark Rowe.
2871 Updated the migration tool from webkit-perf.appspot.com to support test_metrics.
2872 Also import run_iteration rows as runs JSON files now include individual values.
2874 * database/database-common.js:
2875 (addJob): Extracted.
2876 * database/perf-webkit-migrator.js:
2877 (migrateTestConfig): Interchange the order in which we fetch runs and add configurations
2878 so that we can pass in the metric name and unit to getOrCreateConfigurationId.
2879 (getOrCreateConfigurationId): Updated to add both test configuration and test metric.
2882 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2884 Build fix. Suppress "Undefined index" warning.
2886 * public/admin/tests.php:
2888 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2890 Fix a commit error in r46756. api/ should obviously be added under public/
2893 * api/json-header.php: Removed.
2894 * api/runs.php: Removed.
2895 * public/api: Copied from api.
2897 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2899 SafariPerfMonitor: Linkify revisions and revisions range
2900 <rdar://problem/12801010>
2902 Reviewed by Mark Rowe.
2904 Linkify revisions in TestBuild.label. Pass in manifest.repositories to TestBuild's constructor
2905 since it needs to know "url" and "blameUrl".
2907 Also tweaked the appearance of graphs on charts page to better align graphs when unit names are long.
2909 * public/index.html:
2910 * public/js/helper-classes.js:
2912 (TestBuild.revision): Renamed from webkitRevision. Now returns an arbitrary revision number.
2913 (TestBuild.label): Add labels for all revisions.
2917 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2919 Make the generation of "runs" JSON dynamic and support test_metrics.
2921 Reviewed by Mark Rowe.
2923 It turned out that we can fetch all runs for a given configuration in roughly 100-200ms.
2925 Since there could be hundreds, if not thousands, of tests for each configuration and users
2926 aren't necessarily interested in looking at all test results, it's much more efficient to
2927 generate runs JSON dynamically (i.e. polling) upon a request instead of generating all of them
2928 when bots report new results (i.e. pushing).
2930 Rewrote the script to generate runs JSON in php and also supported test_metrics table.
2933 * api/json-header.php: Added. Sets Content-Type and cache policies (10 minutes by default).
2934 (exit_with_error): Added.
2935 (successful_exit): Added.
2936 * api/runs.php: Added. Ported database/database-common.js. It's much shorter in php!
2937 * database/generate-runs.js: Removed.
2938 * database/process-jobs.js: No longer supports "runs".
2939 * public/.htaccess: Added. Always add MultiView so that api/runs can receive a path info.
2940 * public/db.php: Print "Nothing to see here." when it's accessed directly.
2942 * public/index.html: Fetch runs JSONs from /api/runs/ instead of data/.
2944 2012-12-03 Ryosuke Niwa <rniwa@webkit.org>
2946 Update tests.php and sample-data.sql per addition of test_metrics.
2948 Rubber-stamped by Timothy Hatcher.
2950 Remove a useless code from tests.php that used to update the unit and the url of a test
2951 since it's no longer used, and add the UI and the ability to add a new aggregator to a test.
2953 Also update the sample data to reflect the addition of test_metrics.
2955 * database/sample-data.sql:
2956 * public/admin/tests.php:
2958 2012-11-30 Ryosuke Niwa <rniwa@webkit.org>
2960 Share more code between admin pages.
2962 Reviewed by Timothy Hatcher.
2964 Added notice and execute_query_and_expect_one_row_to_be_affected helper functions to share more code
2965 between admin pages.
2967 Also moved the code to connect to the database into header.php to be shared. Admin pages just need
2968 to check the nullity of global $db now.
2970 * public/admin/aggregators.php:
2971 * public/admin/header.php:
2973 (execute_query_and_expect_one_row_to_be_affected): Added.
2974 * public/admin/index.php:
2975 * public/admin/jobs.php:
2976 * public/admin/tests.php:
2978 2012-11-29 Ryosuke Niwa <rniwa@webkit.org>
2980 SafariPerfMonitor: Add admin page to edit aggregators
2981 <rdar://problem/12782687>
2983 Reviewed by Mark Rowe.
2985 Add aggregators.php. It's very simple. We should probably share more code between various admin pages.
2987 * public/admin/aggregators.php: Added.
2988 * public/admin/header.php:
2989 * public/admin/jobs.php: Removed an erroneous hidden input element.
2991 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2993 Fix a syntax error in init-database.sql and add the missing drop table at the beginning.
2995 * database/init-database.sql:
2997 2012-11-28 Ryosuke Niwa <rniwa@webkit.org>
2999 SafariPerfMonitor: Allow multiple metrics per test
3000 <rdar://problem/12773506>
3002 Rubber-stamped by Mark Rowe.
3004 Introduce a new table test_metrics. This table represents metrics each test can have
3005 such as time, memory allocation, frame rate as well as aggregation such as arithmetic mean
3008 Updated admin/tests.php and index.html accordingly.
3010 Also create few indexes based on postgres' "explain analysis" as suggested by Mark.
3012 * database/generate-manifest.js:
3013 (buildPlatformMapIfPossible):
3014 * database/generate-runs.js:
3016 * database/init-database.sql:
3017 * database/schema.graffle:
3018 * public/admin/admin.css:
3021 * public/admin/tests.php:
3022 * public/index.html:
3024 2012-11-27 Ryosuke Niwa <rniwa@webkit.org>
3026 SafariPerfMonitor: Improve the webkit-perf migration tool
3027 <rdar://problem/12760882>
3029 Reviewed by Mark Rowe.
3031 Make the migrator tool skip runs when fetching runs failed since webkit-perf.appspot.com is unreliable
3032 and we don't want to pause the whole importation process until the user comes back to decide whether
3035 Also place form controls next to each test in tests.php so that users don't have to scroll all the way
3036 down to make modifications.
3038 Finally, add unique constraint to (run_config, run_build) in test_runs table in order to optimize a query
3039 of the form: "SELECT run_id FROM test_runs WHERE run_config = $1 AND run_build = $2",
3041 * database/init-database.sql:
3042 * database/perf-webkit-migrator.js:
3043 (migrateTestConfig):
3044 * database/schema.graffle:
3045 * public/admin/admin.css:
3047 * public/admin/tests.php:
3049 2012-11-16 Ryosuke Niwa <rniwa@webkit.org>
3051 Create a new performance dashboard
3052 <rdar://problem/12625582>
3054 Rubber-stamped by Mark Rowe.
3056 Add the initial implementation of the perf dashboard.
3059 * database/config.json: Added.
3060 * database/database-common.js: Added.
3065 (pathToLocalScript):
3067 * database/generate-manifest.js: Added.
3070 (buildPlatformMapIfPossible):
3071 (generateFileIfPossible):
3072 * database/perf-webkit-migrator.js: Added.
3073 * database/process-jobs.js: Added.
3074 * database/sample-data.sql: Added.
3075 * database/schema.graffle: Added.
3077 * public/admin: Added.
3078 * public/admin/README: Added.
3079 * public/admin/admin.css: Added.
3080 * public/admin/footer.php: Added.
3081 * public/admin/header.php: Added.
3082 * public/admin/index.php: Added.
3083 * public/admin/jobs.php: Added.
3084 * public/admin/tests.php: Added.
3085 * public/common.css: Added.
3086 * public/data: Added.
3087 * public/db.php: Added.
3088 * public/index.html: Added.
3090 * public/js/helper-classes.js: Added.
3091 * public/js/jquery-1.8.2.min.js: Added.
3092 * public/js/jquery.flot.min.js: Added.
3093 * public/js/jquery.flot.plugins.js: Added.
3094 * public/js/shared.js: Added.
3095 (fileNameFromPlatformAndTest):
3096 * public/js/statistics.js: Added.